67455 Commits

This Branch

This Branch

All Branches

Author	SHA1	Message	Date
Givikap120	f286693273	drastically improved algorithm	2024-06-13 14:09:20 +03:00
Givikap120	16c3137920	fixed loli map abuse	2024-06-11 23:17:37 +03:00
Bartłomiej Dach	fb99daea2a	Merge pull request #28443 from ColdVolcano/shorten-accuracy ... Fix Argon accuracy counter layout when under 10% and wireframe off	2024-06-11 14:57:59 +02:00
ColdVolcano	4048a4bdfb	fix accuracy counter separating whole and fraction parts with wireframes off	2024-06-11 02:20:14 -06:00
Dean Herbert	cd3b455341	Merge pull request #28420 from bdach/mutually-exclusive-save-related-actions ... Disallow running save-related operations concurrently	2024-06-11 01:03:47 +09:00
Bartłomiej Dach	acf4dbb62c	Merge branch 'master' into mutually-exclusive-save-related-actions	2024-06-10 10:30:35 +02:00
Bartłomiej Dach	1d6b7e9c9b	Refactor further to address code quality complaints	2024-06-10 10:30:30 +02:00
Dean Herbert	a8a2e543d5	Merge pull request #28436 from omkelderman/fix-auto-pick-map-on-zero-ban-round ... Fix auto picking maps on zero ban rounds	2024-06-10 13:51:41 +09:00
Olle Kelderman	642095b07b	On the mappool screen the auto-pick map logic on map change still assumed 1 ban per team. Now it listens to the BanCount value from the round	2024-06-09 21:42:37 +02:00
Dean Herbert	be48377c4c	Merge pull request #28185 from frenzibyte/footer-v2-become-global ... Move new screen footer to `OsuGame` and add temporary `SongSelectV2` screen	2024-06-09 19:06:38 +09:00
Salman Ahmed	6201220994	Merge branch 'master' into footer-v2-become-global	2024-06-08 14:13:05 +03:00
Dean Herbert	daf85c320a	Merge pull request #22237 from mk56-spn/LeaderBoardScore_clean ... New leaderboard score card design implementation	2024-06-08 20:06:17 +09:00
Dean Herbert	7fc6ad5340	Merge pull request #28184 from frenzibyte/footer-v2-transitions ... Add basic animation to new footer and buttons	2024-06-08 19:43:23 +09:00
Salman Ahmed	5f8f6caedd	Use OsuGame.SHEAR	2024-06-07 22:45:22 +03:00
Salman Ahmed	6f729be573	Merge branch 'master' into LeaderBoardScore_clean	2024-06-07 22:42:49 +03:00
Salman Ahmed	f59d94bba4	Move transitions inside ScreenFooterButton and re-use Content from base implementation instead ... The point is to apply the transitions against a container that's inside of `ScreenFooterButton`, because the `ScreenFooterButton` drawable's position is being controlled by the flow container it's contained within, and we cannot apply the transitions on it directly.	2024-06-07 22:07:39 +03:00
Dean Herbert	1045742321	Merge pull request #28421 from bdach/mania-editor-flip-controls ... Implement flip operations in mania editor	2024-06-08 00:10:16 +09:00
Dean Herbert	030acb153a	Merge pull request #24475 from nanashi-1/add-rank-display ... Add skinnable rank display	2024-06-07 18:33:27 +09:00
Dean Herbert	9c6e707f00	Adjust transitions	2024-06-07 17:04:16 +08:00
Dean Herbert	366ef64a2c	Apply NRT to UpdateableRank	2024-06-07 16:54:12 +08:00
Bartłomiej Dach	72890bb9ac	Add stable-like animation legacy rank display ... Just substituting the sprite felt pretty terrible.	2024-06-07 09:56:10 +02:00
Bartłomiej Dach	199d31c0f4	Fix test not compiling ... A little ugly but maybe it'll do...	2024-06-07 09:54:00 +02:00
Bartłomiej Dach	4cd1ccc4d4	Merge branch 'master' into add-rank-display	2024-06-07 09:33:03 +02:00
Bartłomiej Dach	f787a29f49	Add test coverage	2024-06-07 09:19:17 +02:00
Bartłomiej Dach	629e7652c0	Implement flip operations in mania editor	2024-06-07 09:01:41 +02:00
Bartłomiej Dach	e13e9abda9	Disallow running save-related operations concurrently ... Closes https://github.com/ppy/osu/issues/25426. Different approach to prior ones, this just disables the relevant actions when something related to save/export is going on. Still ends up being convoluted because many things you wouldn't expect to touch save do touch save, so it's not just a concern between export and save specifically.	2024-06-07 08:13:51 +02:00
Bartłomiej Dach	a6d0cd56b0	Merge pull request #28399 from matheus-cesquim/total-playlist-duration-not-considering-altered-song-durations-from-speed-changing-mods-#28398 ... Fix playlist total time not considering rate adjust mods	2024-06-07 07:24:55 +02:00
Dean Herbert	7cbe93efc3	Refactor latest changes to avoid unnecessary call when mods not present	2024-06-07 10:37:27 +08:00
Xesquim	6e3bea938e	Instancing a Ruleset only when it's necessary to	2024-06-06 13:26:52 -03:00
Dean Herbert	dd3f4bcdab	Fix code quality and null handling	2024-06-07 00:01:50 +08:00
Xesquim	860afb8123	Creating method in ModUtils to calculate the rate for the song	2024-06-06 10:06:07 -03:00
Xesquim	7dd18a84f6	Fixing the GetTotalDuration in PlaylistExtesions	2024-06-05 12:25:33 -03:00
Dean Herbert	318598730b	Merge pull request #26309 from OliBomby/grids-1 ... Add ability to change position, spacing, and rotation of the positional snap grid in the editor	2024-06-05 23:36:45 +09:00
Dean Herbert	212be6b9a7	Merge branch 'master' into grids-1	2024-06-05 15:20:04 +09:00
Dean Herbert	058d7aa7c1	Merge pull request #28388 from bdach/disable-primary-constructors ... Disable primary constructor related inspections	2024-06-05 01:13:49 +09:00
Bartłomiej Dach	442b61da84	Disable primary constructor related inspections ... I'm not actually sure whether the editorconfig incantation does anything but it's the one official sources give: https://learn.microsoft.com/en-us/dotnet/fundamentals/code-analysis/style-rules/ide0290	2024-06-04 15:14:56 +02:00
Dean Herbert	9f6ff48833	Merge pull request #28387 from bdach/taiko-selection-handler-is-slow ... Fix performance overhead from ternary state bindable callbacks when selection is changing	2024-06-04 18:51:10 +09:00
Bartłomiej Dach	ecfcf7a2c0	Add xmldoc mention about performance overhead of PerformOnSelection()	2024-06-04 10:36:30 +02:00
Bartłomiej Dach	f13ca28d5e	Fix performance overhead from ternary state bindable callbacks when selection is changing ... Closes https://github.com/ppy/osu/issues/28369. The reporter of the issue was incorrect; it's not the beat snap grid that is causing the problem, it's something far stupider than that. When the current selection changes, `EditorSelectionHandler.UpdateTernaryStates()` is supposed to update the state of ternary bindables to reflect the reality of the current selection. This in turn will fire bindable change callbacks for said ternary toggles, which heavily use `EditorBeatmap.PerformOnSelection()`. The thing about that method is that it will attempt to check whether any changes were actually made to avoid producing empty undo states, *but* to do this, it must *serialise out the entire beatmap to a stream* and then *binary equality check that* to determine whether any changes were actually made: 7b14c77e43/osu.Game/Screens/Edit/EditorChangeHandler.cs (L65-L69) As goes without saying, this is very expensive and unnecessary, which leads to stuff like keeping a selection box active while a taiko beatmap is playing under it dog slow. So to attempt to mitigate that, add precondition checks to every single ternary callback of this sort to avoid this serialisation overhead. And yes, those precondition checks use linq, and that is *still* faster than not having them.	2024-06-04 10:32:12 +02:00
Bartłomiej Dach	4fcb902341	Merge branch 'master' into grids-1	2024-06-03 12:33:51 +02:00
Bartłomiej Dach	7b14c77e43	Merge pull request #28383 from peppy/fix-main-menu-test-fail ... Fix occasional test failures on new menu content tests	2024-06-03 10:29:18 +02:00
Dean Herbert	96514132c1	Fix occasional test failures on new menu content tests ... Scheduled data transfer could still overwrite test data.	2024-06-03 12:24:56 +09:00
Dan Balasescu	8296e6318a	Merge pull request #28380 from peppy/ruleset-store-unavailable-but-why ... Fix `AssemblyRulesetStore` not marking rulesets as available	2024-06-02 20:28:28 +09:00
Dean Herbert	091104764e	Fix AssemblyRulesetStore not marking rulesets as available	2024-06-02 17:33:06 +09:00
Dean Herbert	f1689d542e	Merge pull request #28371 from smoogipoo/fix-collections-menu-drag ... Fix unable to drag-scroll on collections right-click menu	2024-06-01 19:16:14 +09:00
Dan Balasescu	e3205fce47	Fix unable to drag-scroll on collections right-click menu	2024-06-01 14:29:23 +09:00
Dean Herbert	4162d0babe	Merge pull request #28297 from Hecatia-Lapislazuli/near-straight-slider-crash-fix ... Fix for nearly straight sliders causing a crash	2024-05-31 20:00:47 +09:00
Bartłomiej Dach	b76ec9654d	Merge pull request #28363 from peppy/external-link-open-trusted ... Bypass external link dialog for links on the trusted osu! domain	2024-05-31 09:11:49 +02:00
Bartłomiej Dach	69990c35cb	Add commentary on presence of IsPresent override	2024-05-31 08:47:19 +02:00
Dean Herbert	c6a7082034	Fix incorrect prefix check	2024-05-31 15:38:26 +09:00