1
0
mirror of https://github.com/ppy/osu.git synced 2024-11-18 08:52:54 +08:00
Commit Graph

59646 Commits

Author SHA1 Message Date
Bartłomiej Dach
bfbb5ab96b
Merge branch 'master' into fix-fail-progression-to-results 2023-03-30 21:40:49 +02:00
Dean Herbert
796cd9c916 Rewrite comment explaining early return on checkScoreCompleted given new usages 2023-03-31 02:36:17 +09:00
Dean Herbert
b25a59fd14 Rename scoreCompleted -> checkScoreCompleted to reflect the fact it doesn't always succeed 2023-03-31 02:30:04 +09:00
Bartłomiej Dach
ea7bf3586d
Merge pull request #23049 from peppy/fix-newlines-in-notification
Fix localisation for audio device error containing incorrect newline escaping
2023-03-29 22:30:01 +02:00
Dean Herbert
836c884aae Fix circle-size based scale being applied twice to caught fruit
Closes #22968.
2023-03-29 18:03:22 +09:00
Dean Herbert
72c5c9848f Always use LocalisableString fallbacks when deploying debug and viewing english
This allows changes to `xxxStrings.cs` files to immediately reflect in
the UI, which is (at least for me) an expectation.
2023-03-29 14:44:43 +09:00
Dean Herbert
c7003434b2 Fix localisation for audio device error containing incorrect newline escaping 2023-03-29 14:33:10 +09:00
Dean Herbert
4dd0c2c7a5 Add assert ensuring we don't ever get to the results screen with an F rank
Intentionally an assertion as I want tests to fail, but I don't want
this to cause crashes for an end user if it does happen to occur.
2023-03-29 14:11:58 +09:00
Dean Herbert
a8bb2e33ac Ensure all preconditions are checked before progressing to results screen after storyboard ends 2023-03-29 14:00:11 +09:00
Dean Herbert
9b45591c2f Add failing test coverage of saving failed replay causing progression to results 2023-03-29 14:00:11 +09:00
Dean Herbert
aad540629f Remove duplicate load rule from ShaderPrecompiler 2023-03-29 12:36:56 +09:00
Bartłomiej Dach
c0e60a0699
Merge pull request #23037 from peppy/no-spinner-fade-extension
Fix spinners being selectable for too long after they fade in the editor
2023-03-28 22:56:22 +02:00
Bartłomiej Dach
22bc5dff4e
Merge pull request #23036 from peppy/fix-account-reg-warning-bypass
Fix web account registration not bypassing the URL warning
2023-03-28 22:14:58 +02:00
Dean Herbert
45e3e3623b Fix spinners being selectable for too long after they fade in the editor
The actual visual extension is only applied to `HitCircle`s (which does include slider
start / end), and should not be applied to spinners in the first place.

Addresses https://github.com/ppy/osu/discussions/22949.
2023-03-28 18:49:59 +09:00
Dean Herbert
8c1df3c8d9 Fix web account registration not bypassing the URL warning 2023-03-28 15:38:19 +09:00
Dean Herbert
5c82d1f777
Merge pull request #22995 from Joehuu/fix-select-beatmap-keyboard-highlight
Fix select beatmap button not highlighting when creating a multiplayer room using keyboard
2023-03-28 15:34:47 +09:00
Dean Herbert
e9fd17461b
Merge pull request #23024 from bdach/mania-argon-explosion-upscroll
Fix hit lighting misalignment on argon skin with upscroll
2023-03-28 15:05:15 +09:00
Dean Herbert
0d77ec013a Fix ruleset-local shader manager not correctly falling back to existing cached shaders 2023-03-28 15:00:49 +09:00
Dean Herbert
5dfac02b11 Preload triangle shader on startup 2023-03-28 14:15:38 +09:00
Dean Herbert
c742b3f0a8 Update DrawableRulesetDependencies xmldoc to read more correctly 2023-03-28 14:15:19 +09:00
Bartłomiej Dach
8fc1fbc145
Merge branch 'master' into mania-argon-explosion-upscroll 2023-03-28 06:22:09 +02:00
Bartłomiej Dach
2b525b626c
Revert to previous conditional style 2023-03-28 06:22:00 +02:00
Dean Herbert
c50f457b13
Merge pull request #23018 from VoltrexKeyva/actions-tweaks
github: update workflows and make tweaks
2023-03-28 12:53:08 +09:00
Bartłomiej Dach
c54934cb45
Fix hit lighting misalignment on argon skin with upscroll 2023-03-27 18:15:01 +02:00
Bartłomiej Dach
f31e77dce5
Add direction switching to TestSceneManiaPlayer
To test upscroll easier, and with all parts in conjunction.
`ManiaSkinnableTestScene`s already had the capability to switch
directions, but they did not show all parts together, which meant
regressions were missed.
2023-03-27 18:08:14 +02:00
rrex971
9426633a05 Allow AR and CS values below 1.0 for Catch the Beat Difficulty Adjustment mod 2023-03-27 20:39:13 +05:30
Mohammed Keyvanzadeh
433f9e5367
fixup! revert formatting changes 2023-03-27 18:37:01 +03:30
Mohammed Keyvanzadeh
3d032d0024
github: update workflows and make tweaks
- Update the GitHub Actions workflows to their latest versions.
- Replace the usage of the deprecated `set-output` command with the
new recommended way to set the output.
- Format the YAML files.
2023-03-27 18:10:32 +03:30
Joseph Madamba
3e0bbb2432
Fix select beatmap button not highlighting when creating a multiplayer room using keyboard 2023-03-26 16:03:21 -07:00
Dean Herbert
6924dc5c50 Update framework 2023-03-27 02:16:33 +09:00
Dean Herbert
47188de9db
Merge pull request #22961 from peppy/dont-show-vulkan
Hide vulkan renderer option for now
2023-03-27 02:13:20 +09:00
Dean Herbert
898717231b Hide vulkan renderer option for now
We'll bring it back when it's more stable.
2023-03-27 02:00:10 +09:00
Bartłomiej Dach
6751f78304
Merge pull request #22924 from peppy/add-renderer-selection
Add ability to select renderer
2023-03-26 15:33:05 +02:00
Bartłomiej Dach
292486c25a
Use more resilient restore method 2023-03-26 14:35:00 +02:00
Bartłomiej Dach
f3c174a7f2
Fix test errors due to missing dependencies 2023-03-26 13:52:26 +02:00
Dean Herbert
bab93bed17 Fix string interpolation and use GetDescription on renderer value 2023-03-26 20:43:28 +09:00
Dean Herbert
ba078e8357 Show "automatic" resolved renderer inline in dropdown instead 2023-03-26 20:29:30 +09:00
Dean Herbert
764361b3d3 Add special case to hide definitely non-working renderers on android 2023-03-26 20:14:33 +09:00
Dean Herbert
e346b02ebf Add display of current renderer 2023-03-26 20:09:35 +09:00
Dean Herbert
91da546ba2 Merge branch 'master' into add-renderer-selection 2023-03-26 19:33:15 +09:00
Dean Herbert
8ad62c243d
Merge pull request #22880 from frenzibyte/fix-ubo-not-bound
Update UBO usages inline with framework changes
2023-03-26 19:31:29 +09:00
Dean Herbert
816eff1a87 Update iOS startup code 2023-03-26 16:27:44 +09:00
Dean Herbert
27de3314fd Remove iOS mouse handler code 2023-03-26 16:23:25 +09:00
Dean Herbert
c803eb8e04 Update framework 2023-03-26 16:14:15 +09:00
Dean Herbert
d31b37e87e Merge branch 'master' into fix-ubo-not-bound 2023-03-26 16:14:11 +09:00
Dean Herbert
b6f8078690
Merge pull request #22948 from Joehuu/2x-banner-api
Use `image@2x` from tournament banner api
2023-03-26 12:41:30 +09:00
Joseph Madamba
e1906a90eb
Use image@2x from tournament banner api 2023-03-25 13:08:46 -07:00
Joseph Madamba
450c5cef07
Add comment explaining loading container padding 2023-03-24 18:42:34 -07:00
Bartłomiej Dach
aa0677630f
Merge pull request #22939 from peppy/fix-tournament-round-edit-save-button
Fix tournament interface save button not usable after changing match progression/round
2023-03-23 22:15:27 +01:00
Terochi
e6f1ec57a9 Bring back and make use of clearPreviousSamples() 2023-03-23 18:46:48 +01:00