github: update workflows and make tweaks

- Update the GitHub Actions workflows to their latest versions. - Replace the usage of the deprecated `set-output` command with the new recommended way to set the output. - Format the YAML files.
2024-09-21 16:07:24 +08:00 · 2023-03-27 18:10:32 +03:30 · 2023-03-27 18:10:32 +03:30 · 3d032d0024
commit 3d032d0024
parent 6924dc5c50
6 changed files with 104 additions and 105 deletions
--- a/.github/ISSUE_TEMPLATE/config.yml
+++ b/.github/ISSUE_TEMPLATE/config.yml
@ -1,12 +1,11 @@
 blank_issues_enabled: false
 contact_links:
-    - name: Help
-      url: https://github.com/ppy/osu/discussions/categories/q-a
-      about: osu! not working as you'd expect? Not sure it's a bug? Check the Q&A section!
-    - name: Suggestions or feature request
-      url: https://github.com/ppy/osu/discussions/categories/ideas
-      about: Got something you think should change or be added? Search for or start a new discussion!
-    - name: osu!stable issues
-      url: https://github.com/ppy/osu-stable-issues
-      about: For osu!(stable) - ie. the current "live" game version, check out the dedicated repository. Note that this is for serious bug reports only, not tech support.
-
+  - name: Help
+    url: https://github.com/ppy/osu/discussions/categories/q-a
+    about: osu! not working as you'd expect? Not sure it's a bug? Check the Q&A section!
+  - name: Suggestions or feature request
+    url: https://github.com/ppy/osu/discussions/categories/ideas
+    about: Got something you think should change or be added? Search for or start a new discussion!
+  - name: osu!stable issues
+    url: https://github.com/ppy/osu-stable-issues
+    about: For osu!(stable) - ie. the current "live" game version, check out the dedicated repository. Note that this is for serious bug reports only, not tech support.
--- a/.github/dependabot.yml
+++ b/.github/dependabot.yml
@ -1,46 +1,46 @@
 version: 2
 updates:
- package-ecosystem: nuget
-  directory: "/"
-  schedule:
-    interval: monthly
-    time: "17:00"
-  open-pull-requests-limit: 0 # disabled until https://github.com/dependabot/dependabot-core/issues/369 is resolved.
-  ignore:
-  - dependency-name: Microsoft.EntityFrameworkCore.Design
-    versions:
-    - "> 2.2.6"
-  - dependency-name: Microsoft.EntityFrameworkCore.Sqlite
-    versions:
-    - "> 2.2.6"
-  - dependency-name: Microsoft.EntityFrameworkCore.Sqlite.Core
-    versions:
-    - "> 2.2.6"
-  - dependency-name: Microsoft.Extensions.DependencyInjection
-    versions:
-    - ">= 5.a, < 6"
-  - dependency-name: NUnit3TestAdapter
-    versions:
-    - ">= 3.16.a, < 3.17"
-  - dependency-name: Microsoft.NET.Test.Sdk
-    versions:
-    - 16.9.1
-  - dependency-name: Microsoft.Extensions.DependencyInjection
-    versions:
-    - 3.1.11
-    - 3.1.12
-  - dependency-name: Microsoft.AspNetCore.SignalR.Protocols.NewtonsoftJson
-    versions:
-    - 3.1.11
-  - dependency-name: Microsoft.NETCore.Targets
-    versions:
-    - 5.0.0
-  - dependency-name: Microsoft.AspNetCore.SignalR.Protocols.MessagePack
-    versions:
-    - 5.0.2
-  - dependency-name: NUnit
-    versions:
-    - 3.13.1
-  - dependency-name: Microsoft.AspNetCore.SignalR.Client
-    versions:
-    - 3.1.11
+  - package-ecosystem: nuget
+    directory: "/"
+    schedule:
+      interval: monthly
+      time: "17:00"
+    open-pull-requests-limit: 0 # disabled until https://github.com/dependabot/dependabot-core/issues/369 is resolved.
+    ignore:
+      - dependency-name: Microsoft.EntityFrameworkCore.Design
+        versions:
+          - "> 2.2.6"
+      - dependency-name: Microsoft.EntityFrameworkCore.Sqlite
+        versions:
+          - "> 2.2.6"
+      - dependency-name: Microsoft.EntityFrameworkCore.Sqlite.Core
+        versions:
+          - "> 2.2.6"
+      - dependency-name: Microsoft.Extensions.DependencyInjection
+        versions:
+          - ">= 5.a, < 6"
+      - dependency-name: NUnit3TestAdapter
+        versions:
+          - ">= 3.16.a, < 3.17"
+      - dependency-name: Microsoft.NET.Test.Sdk
+        versions:
+          - 16.9.1
+      - dependency-name: Microsoft.Extensions.DependencyInjection
+        versions:
+          - 3.1.11
+          - 3.1.12
+      - dependency-name: Microsoft.AspNetCore.SignalR.Protocols.NewtonsoftJson
+        versions:
+          - 3.1.11
+      - dependency-name: Microsoft.NETCore.Targets
+        versions:
+          - 5.0.0
+      - dependency-name: Microsoft.AspNetCore.SignalR.Protocols.MessagePack
+        versions:
+          - 5.0.2
+      - dependency-name: NUnit
+        versions:
+          - 3.13.1
+      - dependency-name: Microsoft.AspNetCore.SignalR.Client
+        versions:
+          - 3.1.11
--- a/.github/workflows/ci.yml
+++ b/.github/workflows/ci.yml
@ -13,17 +13,17 @@ jobs:
    runs-on: ubuntu-latest
    steps:
      - name: Checkout
-        uses: actions/checkout@v2
+        uses: actions/checkout@v3

      # FIXME: Tools won't run in .NET 6.0 unless you install 3.1.x LTS side by side.
      # https://itnext.io/how-to-support-multiple-net-sdks-in-github-actions-workflows-b988daa884e
      - name: Install .NET 3.1.x LTS
-        uses: actions/setup-dotnet@v1
+        uses: actions/setup-dotnet@v3
        with:
          dotnet-version: "3.1.x"

      - name: Install .NET 6.0.x
-        uses: actions/setup-dotnet@v1
+        uses: actions/setup-dotnet@v3
        with:
          dotnet-version: "6.0.x"

@ -59,28 +59,28 @@ jobs:
        run: dotnet jb inspectcode $(pwd)/osu.Desktop.slnf --no-build --output="inspectcodereport.xml" --caches-home="inspectcode" --verbosity=WARN

      - name: NVika
-        run: dotnet nvika parsereport "${{github.workspace}}/inspectcodereport.xml" --treatwarningsaserrors
+        run: dotnet nvika parsereport "${{ github.workspace }}/inspectcodereport.xml" --treatwarningsaserrors

  test:
    name: Test
-    runs-on: ${{matrix.os.fullname}}
+    runs-on: ${{ matrix.os.fullname }}
    env:
-      OSU_EXECUTION_MODE: ${{matrix.threadingMode}}
+      OSU_EXECUTION_MODE: ${{ matrix.threadingMode }}
    strategy:
-       fail-fast: false
-       matrix:
-          os:
-            - { prettyname: Windows, fullname: windows-latest }
-            - { prettyname: macOS, fullname: macos-latest }
-            - { prettyname: Linux, fullname: ubuntu-latest }
-          threadingMode: ['SingleThread', 'MultiThreaded']
+      fail-fast: false
+      matrix:
+        os:
+          - { prettyname: Windows, fullname: windows-latest }
+          - { prettyname: macOS, fullname: macos-latest }
+          - { prettyname: Linux, fullname: ubuntu-latest }
+        threadingMode: ["SingleThread", "MultiThreaded"]
    timeout-minutes: 60
    steps:
      - name: Checkout
-        uses: actions/checkout@v2
+        uses: actions/checkout@v3

      - name: Install .NET 6.0.x
-        uses: actions/setup-dotnet@v1
+        uses: actions/setup-dotnet@v3
        with:
          dotnet-version: "6.0.x"

@ -88,17 +88,17 @@ jobs:
        run: dotnet build -c Debug -warnaserror osu.Desktop.slnf

      - name: Test
-        run: dotnet test $pwd/**/*.Tests/bin/Debug/*/*.Tests.dll --logger "trx;LogFileName=TestResults-${{matrix.os.prettyname}}-${{matrix.threadingMode}}.trx" -- NUnit.ConsoleOut=0
+        run: dotnet test $pwd/**/*.Tests/bin/Debug/*/*.Tests.dll --logger "trx;LogFileName=TestResults-${{ matrix.os.prettyname }}-${{ matrix.threadingMode }}.trx" -- NUnit.ConsoleOut=0
        shell: pwsh

      # Attempt to upload results even if test fails.
      # https://docs.github.com/en/actions/reference/context-and-expression-syntax-for-github-actions#always
      - name: Upload Test Results
-        uses: actions/upload-artifact@v2
+        uses: actions/upload-artifact@v3
        if: ${{ always() }}
        with:
-          name: osu-test-results-${{matrix.os.prettyname}}-${{matrix.threadingMode}}
-          path: ${{github.workspace}}/TestResults/TestResults-${{matrix.os.prettyname}}-${{matrix.threadingMode}}.trx
+          name: osu-test-results-${{ matrix.os.prettyname }}-${{ matrix.threadingMode }}
+          path: ${{ github.workspace }}/TestResults/TestResults-${{ matrix.os.prettyname }}-${{ matrix.threadingMode }}.trx

  build-only-android:
    name: Build only (Android)
@ -106,10 +106,10 @@ jobs:
    timeout-minutes: 60
    steps:
      - name: Checkout
-        uses: actions/checkout@v2
+        uses: actions/checkout@v3

      - name: Install .NET 6.0.x
-        uses: actions/setup-dotnet@v1
+        uses: actions/setup-dotnet@v3
        with:
          dotnet-version: "6.0.x"

@ -125,10 +125,10 @@ jobs:
    timeout-minutes: 60
    steps:
      - name: Checkout
-        uses: actions/checkout@v2
+        uses: actions/checkout@v3

      - name: Install .NET 6.0.x
-        uses: actions/setup-dotnet@v1
+        uses: actions/setup-dotnet@v3
        with:
          dotnet-version: "6.0.x"

--- a/.github/workflows/diffcalc.yml
+++ b/.github/workflows/diffcalc.yml
@ -2,12 +2,11 @@
 # Usage:
 #   !pp check 0        | Runs only the osu! ruleset.
 #   !pp check 0 2      | Runs only the osu! and catch rulesets.
-#

 name: Difficulty Calculation
 on:
  issue_comment:
-    types: [ created ]
+    types: [created]

 env:
  CONCURRENCY: 4
@ -48,8 +47,8 @@ jobs:
            CONTINUE="no"
          fi

-          echo "::set-output name=continue::${CONTINUE}"
-          echo "::set-output name=matrix::${MATRIX_JSON}"
+          echo "continue=${CONTINUE}" >> $GITHUB_OUTPUT
+          echo "matrix=${MATRIX_JSON}" >> $GITHUB_OUTPUT
  diffcalc:
    name: Run
    runs-on: self-hosted
@ -80,34 +79,34 @@ jobs:
        env:
          GITHUB_TOKEN: ${{ secrets.GITHUB_TOKEN }}
        run: |
-          echo "::set-output name=branchname::$(curl -H "Authorization: token ${GITHUB_TOKEN}" ${{ github.event.issue.pull_request.url }} | jq '.head.ref' | sed 's/\"//g')"
-          echo "::set-output name=repo::$(curl -H "Authorization: token ${GITHUB_TOKEN}" ${{ github.event.issue.pull_request.url }} | jq '.head.repo.full_name' | sed 's/\"//g')"
+          echo "branchname=$(curl -H "Authorization: token ${GITHUB_TOKEN}" ${{ github.event.issue.pull_request.url }} | jq '.head.ref' | sed 's/\"//g')" >> $GITHUB_OUTPUT
+          echo "repo=$(curl -H "Authorization: token ${GITHUB_TOKEN}" ${{ github.event.issue.pull_request.url }} | jq '.head.repo.full_name' | sed 's/\"//g')" >> $GITHUB_OUTPUT

      # Checkout osu
      - name: Checkout osu (master)
-        uses: actions/checkout@v2
+        uses: actions/checkout@v3
        with:
-          path: 'master/osu'
+          path: "master/osu"
      - name: Checkout osu (pr)
-        uses: actions/checkout@v2
+        uses: actions/checkout@v3
        with:
-          path: 'pr/osu'
+          path: "pr/osu"
          repository: ${{ steps.upstreambranch.outputs.repo }}
          ref: ${{ steps.upstreambranch.outputs.branchname }}

      - name: Checkout osu-difficulty-calculator (master)
-        uses: actions/checkout@v2
+        uses: actions/checkout@v3
        with:
          repository: ppy/osu-difficulty-calculator
-          path: 'master/osu-difficulty-calculator'
+          path: "master/osu-difficulty-calculator"
      - name: Checkout osu-difficulty-calculator (pr)
-        uses: actions/checkout@v2
+        uses: actions/checkout@v3
        with:
          repository: ppy/osu-difficulty-calculator
-          path: 'pr/osu-difficulty-calculator'
+          path: "pr/osu-difficulty-calculator"

      - name: Install .NET 5.0.x
-        uses: actions/setup-dotnet@v1
+        uses: actions/setup-dotnet@v3
        with:
          dotnet-version: "5.0.x"

--- a/.github/workflows/report-nunit.yml
+++ b/.github/workflows/report-nunit.yml
@ -2,6 +2,7 @@
 # See:
 #   * https://github.com/dorny/test-reporter#recommended-setup-for-public-repositories
 #   * https://docs.github.com/en/actions/reference/authentication-in-a-workflow#permissions-for-the-github_token
+
 name: Annotate CI run with test results
 on:
  workflow_run:
@ -18,21 +19,21 @@ jobs:
    runs-on: ubuntu-latest
    if: ${{ github.event.workflow_run.conclusion != 'cancelled' }}
    strategy:
-       fail-fast: false
-       matrix:
-          os:
-            - { prettyname: Windows }
-            - { prettyname: macOS }
-            - { prettyname: Linux }
-          threadingMode: ['SingleThread', 'MultiThreaded']
+      fail-fast: false
+      matrix:
+        os:
+          - { prettyname: Windows }
+          - { prettyname: macOS }
+          - { prettyname: Linux }
+        threadingMode: ["SingleThread", "MultiThreaded"]
    timeout-minutes: 5
    steps:
      - name: Annotate CI run with test results
        uses: dorny/test-reporter@v1.6.0
        with:
-          artifact: osu-test-results-${{matrix.os.prettyname}}-${{matrix.threadingMode}}
-          name: Test Results (${{matrix.os.prettyname}}, ${{matrix.threadingMode}})
+          artifact: osu-test-results-${{ matrix.os.prettyname }}-${{ matrix.threadingMode }}
+          name: Test Results (${{ matrix.os.prettyname }}, ${{ matrix.threadingMode }})
          path: "*.trx"
          reporter: dotnet-trx
-          list-suites: 'failed'
-          list-tests: 'failed'
+          list-suites: "failed"
+          list-tests: "failed"
--- a/.github/workflows/sentry-release.yml
+++ b/.github/workflows/sentry-release.yml
@ -3,7 +3,7 @@ name: Add Release to Sentry
 on:
  push:
    tags:
-      - '*'
+      - "*"

 permissions:
  contents: read # to fetch code (actions/checkout)
@ -13,7 +13,7 @@ jobs:
    runs-on: ubuntu-latest
    steps:
      - name: Checkout
-        uses: actions/checkout@v2
+        uses: actions/checkout@v3
        with:
          fetch-depth: 0