70692 Commits

This Branch

This Branch

All Branches

• Handle non-legacy types

  Also used in some tests (e.g. beatmaps containing `HitCircle`s).

  Dan Balasescu · 2024-12-06 17:47:49 +09:00
  ec8b320e21
• Populate default LegacyType value on convert hitobjects

  Normally not an issue, but some tests create their own hitobjects
  deriving from `ConvertHitObject`.

  Dan Balasescu · 2024-12-06 17:47:14 +09:00
  8dda5aada8
• NRT refactorings + rename generators to match usage

  In particular, "EndTimeObject" is no longer correct - it's strictly used
  for spinners and not holds.

  Dan Balasescu · 2024-12-06 17:16:04 +09:00
  e703d9e814
• Add some explanatory comments

  In particular, the spinner one is the most relevant to this batch of
  changes.

  Dan Balasescu · 2024-12-06 16:40:29 +09:00
  1bbf32d567
• Rename LegacyPatternGenerator to stop naming conflicts
  Dan Balasescu · 2024-12-06 16:40:29 +09:00
  e8728abc00
• Simplify implementation
  Dan Balasescu · 2024-12-06 16:40:29 +09:00
  e65f8ba7a0
• Split out + rename PassThroughPatternGenerator

  Better symbolises the intent of this generator which is to convert
  hitobjects in their most simple forms - anything with an end time
  converts to a hold or otherwise converts to a normal note.

  Dan Balasescu · 2024-12-06 16:40:29 +09:00
  8e1bd98386
• Always convert mania spinners

  A big part of these changes is refactoring, which is somewhat necessary
  because it was previously implemented as two separate pathways which
  in-fact need to be joined at the hip when handling spinners.
  
  I've chosen to use `IHasLegacyHitObjectType` here because there's no
  other flag that allows us to tell `ConvertHold` apart from
  `ConvertSpinner`.

  Dan Balasescu · 2024-12-06 16:40:28 +09:00
  8b456e1379
• Add failing test
  Dan Balasescu · 2024-12-06 16:40:25 +09:00
  62ea4e0970
• Merge pull request #30910 from nekodex/improve-menu-sample-playback

  Improve menu/context-menu sample playback

  Dean Herbert · 2024-12-05 20:50:14 -08:00
  7592813e56
• Remove unnecessary null checks
  Dean Herbert · 2024-12-06 12:48:06 +09:00
  69014550b5
• Update resources
  Dean Herbert · 2024-12-05 21:07:13 +09:00
  49f4b0e6ef
• Update framework
  Dean Herbert · 2024-12-05 21:07:08 +09:00
  84a85000af
• Merge branch 'master' into improve-menu-sample-playback
  Dean Herbert · 2024-12-05 21:07:03 +09:00
  8d0e1f9d18
• Merge pull request #30976 from frenzibyte/hide-some-settings

  Hide debug settings in release builds

  Dean Herbert · 2024-12-05 00:24:26 -08:00
  2024.1205.0 3d6e766b32
• Clean up code slightly
  Salman Alshamrani · 2024-12-05 02:48:51 -05:00
  1b1e7b63e9
• Merge pull request #30937 from frenzibyte/fix-quick-restart-not-saving-score

  Fix score no longer being saved when quick-restarting after pass

  Dean Herbert · 2024-12-04 23:48:18 -08:00
  791416c8f1
• Remove unnecessary localisations
  Salman Alshamrani · 2024-12-05 02:45:43 -05:00
  7c1be5eca2
• Make debug section only visible on debug builds
  Salman Alshamrani · 2024-12-05 02:42:08 -05:00
  7ab16a55e5
• Move latency certifier and import files button outside debug section
  Salman Alshamrani · 2024-12-05 02:42:08 -05:00
  f83ec721fb
• Merge pull request #30965 from Susko3/use-GetLocalisedString

  Use `LocalisationManager.GetLocalisedString()` instead of bindable hack

  Dean Herbert · 2024-12-04 23:34:32 -08:00
  72aa65206d
• Merge pull request #30970 from peppy/results-screen-quick-retry-transition

  Fix quick retry transition from results screen

  Salman Alshamrani · 2024-12-04 07:12:38 -05:00
  aa0ee5cf3a
• Merge branch 'master' into results-screen-quick-retry-transition
  Salman Alshamrani · 2024-12-04 06:31:14 -05:00
  a7586c52d0
• Move non-current handling to PerformExit

  Co-authored-by: Dean Herbert <pe@ppy.sh>

  Salman Alshamrani · 2024-12-04 04:55:55 -05:00
  fa87df6c6a
• Merge pull request #30971 from smoogipoo/improve-multi-search

  Improve multiplayer listing search by making it fuzzy

  Dean Herbert · 2024-12-04 00:11:32 -08:00
  e555131b39
• Improve multiplayer listing search by making it fuzzy
  Dan Balasescu · 2024-12-04 16:26:36 +09:00
  ad4df82593
• Merge pull request #30969 from peppy/buttons-search-term

  Add "buttons" as a search term for key bindings

  Dan Balasescu · 2024-12-04 15:52:12 +09:00
  a8963cf317
• Fix quick retry transition from results screen
  Dean Herbert · 2024-12-04 14:31:39 +09:00
  a4d58648e2
• Add "buttons" as a search term for key bindings
  Dean Herbert · 2024-12-04 14:30:59 +09:00
  296fa69edd
• Use LocalisationManager.GetLocalisedString() instead of bindable hack

  Made possible by https://github.com/ppy/osu-framework/pull/6377.

  Susko3 · 2024-12-03 23:29:39 +00:00
  837744b0aa
• Merge pull request #30953 from peppy/notification-while-chedcking-for-updates

  Show an ongoing operation when checking for updates

  Dan Balasescu · 2024-12-03 17:27:10 +09:00
  f09d8f097a
• Merge pull request #30929 from timschumi/rate-change-ready

  Account for rate changing mods when disabling the "Ready" button

  Dan Balasescu · 2024-12-03 16:30:16 +09:00
  be05f2a1c2
• Add tests
  Dan Balasescu · 2024-12-03 15:45:58 +09:00
  6ff1dec7b2
• Refactor check-update flow to better handle unobserved exceptions
  Dean Herbert · 2024-12-03 14:23:10 +09:00
  457957d3b8
• Show an ongoing operation when checking for updates

  Addresses https://github.com/ppy/osu/discussions/30950.

  Dean Herbert · 2024-12-03 13:43:20 +09:00
  2ceb3f6f85
• Merge pull request #30917 from bdach/fix-incorrect-taiko-legacy-combo

  Fix strong drum rolls being counted for double the combo in legacy scoring attributes

  Dean Herbert · 2024-12-02 20:08:49 -08:00
  ce4aac4184
• Move rate-changing TODO to a common place in CalculateRateWithMods
  Tim Schumacher · 2024-12-02 23:49:51 +01:00
  e920cfa187
• Merge pull request #30947 from bdach/undesirable-deselect-on-control-click

  Do not deselect objects when control-clicking without hitting anything

  Dean Herbert · 2024-12-02 07:17:27 -08:00
  ce8e4120b7
• Do not deselect objects when control-clicking without hitting anything

  As per feedback in
  https://discord.com/channels/90072389919997952/1259818301517725707/1310270647187935284.

  Bartłomiej Dach · 2024-12-02 13:51:43 +01:00
  b505ecc7ba
• Add failing test case
  Bartłomiej Dach · 2024-12-02 13:51:41 +01:00
  b14dde937d
• Merge pull request #30863 from frenzibyte/improve-back-button-display

  Delay back button appearance when performing a quick restart

  Bartłomiej Dach · 2024-12-02 11:49:45 +01:00
  6c0ccc5ebe
• Merge pull request #30749 from Sheppsu/multi-spectator-settings-sidebar

  Add player settings to multi spectator screen

  Bartłomiej Dach · 2024-12-02 11:34:57 +01:00
  52b8753a12
• Merge pull request #28473 from bdach/beatmap-info-purge

  Move unnecessary properties from `BeatmapInfo` / realm to `IBeatmap`

  Dean Herbert · 2024-12-02 16:19:12 +09:00
  5b2558cec2
• Use local instead of field for local only usage
  Dean Herbert · 2024-12-01 19:53:57 +09:00
  23522b02d8
• Fix settings showing up during gameplay
  Dean Herbert · 2024-12-01 18:44:26 +09:00
  6afe083ec9
• Merge branch 'master' into multi-spectator-settings-sidebar
  Dean Herbert · 2024-12-01 18:33:46 +09:00
  ddac71628d
• Fix restarting no longer working from results screen

  Thanks to tests for pointing that out :blobsweat:

  Salman Alshamrani · 2024-12-01 02:13:20 -05:00
  53dce83b56
• Fix score no longer being saved when quick-restarting after pass
  Salman Alshamrani · 2024-11-30 23:36:02 -05:00
  9140893249
• Document ready button enable state with some comments
  Tim Schumacher · 2024-11-30 23:02:22 +01:00
  164b809c89
• Merge pull request #30928 from peppy/stop-logging-backwards-seek

  Stop loudly logging backwards seek bug to sentry

  Salman Alshamrani · 2024-11-30 16:35:35 -05:00
  1d610a0f1b