osu-lazer

Ensure skin default component layouts only apply to global layout for now

Dean Herbert · 2023-02-17 18:24:05 +09:00

ffb99364b9

Always return a non-null container for SkinComponentsContainerLookups

Dean Herbert · 2023-02-17 14:19:19 +09:00

9685fb2114

Standardise all local SkinComponentsContainerLookup variables to containerLookup

Dean Herbert · 2023-02-16 15:33:56 +09:00

76f7accd13

Rename SkinnableTargetContainer to SkinComponentsContainer

Also use full `SkinComponentsContainerLookup` instead of the sub-type.
This will potentially be useful once we bring in per-ruleset targets.

Dean Herbert · 2023-02-15 18:37:41 +09:00

a92e42bb84

Simplify and rename SkinnableTargetComponentsContainer

Dean Herbert · 2023-02-15 17:30:21 +09:00

8bbd00822c

Add parsing support for mania NoteBodyStyle

Dean Herbert · 2023-02-10 19:46:59 +09:00

bfbffc4a68

Add correct lookup for WidthForNoteHeightScale

Dean Herbert · 2023-02-10 19:18:41 +09:00

635e225d19

Fix the MOTHERLOAD of undetected issues that are now visible thanks to net6.0

Dean Herbert · 2022-12-16 18:16:26 +09:00

27c497145f

Fix SkinnableSprite lookups broken in lazer-first skins

Regressed with removal of local `GetTexture` calls in https://github.com/ppy/osu/commit/e19ba65f9186afab21aec536a636d7d152636dde

Dean Herbert · 2022-11-13 12:46:21 +09:00

eae8530722

Add "Component" prefix to lookup naming

Dean Herbert · 2022-11-09 17:46:43 +09:00

1aa0e40f2f

Rename SkinnableTarget to GlobalSkinLookup

Dean Herbert · 2022-11-09 17:46:43 +09:00

e75c3b3f94

Rename ISkinComponent to ISkinLookup

Dean Herbert · 2022-11-09 17:46:43 +09:00

c908969d9b

Apply nullability to skinning support classes

Dean Herbert · 2022-11-09 13:59:13 +09:00

bf26dbffc2

Don't throw if LegacySkin doesn't have a transformer encapsulating it

This allows for more flexibility in lookups.

Dean Herbert · 2022-10-12 17:29:17 +09:00

fd20515a6d

Standardise column index naming and xmldoc

Dean Herbert · 2022-10-07 15:24:36 +09:00

eea3d5adb8

Fix regression in legacy dual stage handling logic

Dean Herbert · 2022-10-07 15:24:36 +09:00

3947011baf

Apply IRenderer changes

Dan Balasescu · 2022-08-02 19:50:57 +09:00

b4e55f7309

Remove unused combo DI retrieval

Dean Herbert · 2022-07-27 13:50:03 +09:00

b803ec543f

remove unused using

Nitrous · 2022-07-27 09:41:58 +08:00

842ab3c5c1

replace SongProgress with LegacySongProgress

Nitrous · 2022-07-27 08:52:27 +08:00

a2320aeb27

Automated #nullable processing

Dan Balasescu · 2022-06-17 16:37:17 +09:00

f8830c6850

Change skin.ini boolean parsing to match osu!stable

Closes https://github.com/ppy/osu/issues/18579.

Dean Herbert · 2022-06-06 19:43:09 +09:00

3862681d94

Handle all skin component types explicitly

Salman Ahmed · 2022-04-23 03:34:05 +03:00

61078910a6

Remove legacy skin component fallback lookup

Has always been a source of hiding actual issues like in https://github.com/ppy/osu/issues/17745 (`sliderfollowcircle` looked up from fallback because there's no transformer), and https://github.com/ppy/osu/issues/17934 (because there's a texture `ok` and that matches the component name `HitResult.Ok`).

Salman Ahmed · 2022-04-23 01:06:36 +03:00

69e2e30971

Fix legacy skin hit animation lookup falling back to LookupName

Salman Ahmed · 2022-04-23 00:35:45 +03:00

56358ef19e

Fix skin texture lookups not handling paths with extensions

Salman Ahmed · 2022-04-07 15:07:30 +03:00

fb9fe4213d

Fix filename lookups on LegacySkins going awry when extension is specified

Due to the logic present to handle `@2x` fallback, the extension was
potentially being added at the wrong point in the filename. This change
ensures that the lookup filenames are always correct.

Closes https://github.com/ppy/osu/issues/17690.

Dean Herbert · 2022-04-07 14:16:19 +09:00

205edb65a2

Apply notnull constraint

Dan Balasescu · 2022-03-25 15:54:01 +09:00

23c4f9910e

Merge branch 'master' into skin-nullable

Dan Balasescu · 2022-03-25 15:36:21 +09:00

2d8d177807

Fix incorrect HUD component fallback

Legacy skins should now always show the legacy hud components. The
conditional here is no longer valid as fallback lookups happen at a
*skin*-fallback level rather than internal *source*-fallback.

Put another way, `LegacyDefaultSkin` (with user customisations) should
still display the classic HUD components even if a font is not provided,
as that font will be available via the skin lookup hierarchy.

The TODO removed in this commit has been already resolved so this code
is no longer required.

Dean Herbert · 2022-03-24 12:36:20 +09:00

a4d17a915f

Convert LegacySkin to use nullable

Dean Herbert · 2022-03-24 00:23:55 +09:00

194bf4fb05

Make "skin.ini" the default skin filename and remove redundant parameters

Dean Herbert · 2022-03-23 15:05:01 +09:00

078288a616

Change parameter order of LegacySkin to put IStorageResourceProvider first

The optional resource store should not be before the (basically)
required resource provider.

Dean Herbert · 2022-03-23 15:02:04 +09:00

7a1909bf97

Remove skin configuration stream logic as it is no longer required