627 Commits

• Use more generic wording for future-proofing
  Bartłomiej Dach · 2023-02-19 15:06:40 +01:00
  d9ca7102f0
• Combine config and time checks into one

  Functionally equivalent right now, but the combined variant is more
  localised to what it actually needs to do, and less error-prone if
  any new code gets appended to the method.

  Bartłomiej Dach · 2023-02-19 13:14:51 +01:00
  aac32a2c9f
• change bindable seekToHitObject to private
  Maximilian Kruse · 2023-02-19 10:18:02 +01:00
  f3522c4162
• Add setting to disable automatic seeking after object placement
  Maximilian Kruse · 2023-02-18 19:43:45 +01:00
  ddd37bb319
• Use equals instead and update other usage
  Joseph Madamba · 2023-02-04 19:58:48 -08:00
  191259c050
• Merge pull request #22281 from cdwcgt/editor-check-previewtime

  Add preview time setting check

  Dean Herbert · 2023-02-02 15:10:06 +09:00
  b792dc3af0
• Fix typo in missing-preview-point message
  Dean Herbert · 2023-02-02 14:34:59 +09:00
  5b3d7a8f26
• Fix message not reading well
  Dean Herbert · 2023-02-02 14:33:41 +09:00
  c2cde8361a
• Remove multiple cases of excess braces
  Dean Herbert · 2023-02-02 14:28:21 +09:00
  3a861fd943
• Consistent with BeatmapsetVerifier
  cdwcgt · 2023-02-01 11:52:14 +08:00
  76296eb35a
• Clean up xmldocs
  Bartłomiej Dach · 2023-01-23 21:22:18 +01:00
  1f40b2daf6
• change IssueTemplatePreviewTimeConflict's text
  cdwcgt · 2023-01-23 15:26:28 +09:00
  5afb733fb2
• Refactor how additional points are provided to avoid confusion
  Dean Herbert · 2023-01-23 14:13:46 +09:00
  73f083a316
• change property name
  Wleter · 2023-01-18 22:00:39 +01:00
  f8d8a627b8
• add collection of selection points.
  Wleter · 2023-01-18 21:34:23 +01:00
  ab78dd0436
• add check for preview time setting
  cdwcgt · 2023-01-19 01:08:37 +09:00
  e5eab72aeb
• add ScreenSpaceEndPoint field
  Wleter · 2023-01-10 21:20:09 +01:00
  e5863fbaf1
• Update IBeatSnapProvider documentation to mention the pre-divided BeatSnap
  Dean Herbert · 2022-12-02 17:57:15 +09:00
  ba99f1288c
• Expose Ruleset from HitObjectComposer instead
  Derrick Timmermans · 2022-11-30 12:17:58 +01:00
  6a61e70766
• Merge branch 'master' into Editor-DrawableRuleset-Dependencies
  Dean Herbert · 2022-11-30 17:42:46 +09:00
  4215f4f5d7
• Fix code style
  Derrick Timmermans · 2022-11-27 21:48:44 +01:00
  93ba84e5ff
• Provide ruleset dependencies only to Compose Placement Blueprints
  Derrick Timmermans · 2022-11-27 21:43:33 +01:00
  70c320b2e8
• Merge branch 'master' into update-framework
  Bartłomiej Dach · 2022-11-26 16:19:36 +01:00
  894ef15e79
• Partial everything
  Dan Balasescu · 2022-11-27 00:00:27 +09:00
  7bc8908ca9
• Fix triangles showing on ExpandableButtons when in contracted state
  Dean Herbert · 2022-11-25 20:18:35 +09:00
  76e9382e0b
• Dispose DrawableRulesetDependencies in HitObjectComposer
  Derrick Timmermans · 2022-11-25 08:27:22 +01:00
  65e5c9a3ae
• Provide DrawableRulesetDependencies from HitObjectComposer
  Derrick Timmermans · 2022-11-24 13:13:45 +01:00
  7b620392fe
• Add the ability to toggle off hit marker displays in the editor
  Dean Herbert · 2022-11-08 18:07:06 +09:00
  ada039151b
• Merge pull request #21017 from andy840119/remove-nullable-disable-in-the-checks

  Remove nullable disable in the checks.

  Dean Herbert · 2022-11-06 18:39:03 +09:00
  e02c477008
• Remove incorrect double multiplication and add missing test coverage
  Dean Herbert · 2022-11-01 17:17:54 +09:00
  29bc653d24
• Fix time snap of sliders not matching when SV is not 1.0x

  This regressed with https://github.com/ppy/osu/pull/20850 because the
  function was used in other places which expect it to factor slider
  velocity into the equation.
  
  Rather than reverting, I've added a new argument, as based on the method
  naming alone it was hard to discern whether SV should actually be
  considered.
  
  The reason for the change in #20850 was to avoid the SV coming in from a
  reference object which may not have a correct SV in the first place. In
  such cases, passing `false` to the function will give the expected
  behaviour.

  Dean Herbert · 2022-11-01 15:12:58 +09:00
  2a88409dfe
• Use empty string instead of null because issue template not accept null.
  andy840119 · 2022-10-30 16:31:07 +08:00
  a1a9238bd1
• File name should be nullable.
  andy840119 · 2022-10-30 16:29:54 +08:00
  505ec800da
• Remove nullable disable annotation in some checks class.
  andy840119 · 2022-10-30 16:28:49 +08:00
  db48a57fa7
• Remove nullable disable annotation in the issue and issue template-related class.
  andy840119 · 2022-10-30 16:25:15 +08:00
  24c27e62f6
• Enable distance snapping when DS value is changed via user interaction
  Dean Herbert · 2022-10-26 13:37:01 +09:00
  6b53ea3400
• Merge branch 'grid-momentary-shortcuts' into read-current-distance-snap
  Dean Herbert · 2022-10-26 13:28:04 +09:00
  7d59bc6e2f
• Move distance snap toggle button implementation to DistancedHitObjectComposer
  Dean Herbert · 2022-10-26 13:27:23 +09:00
  54ae16badc
• Fix typos in xmldoc

  Co-authored-by: Bartłomiej Dach <dach.bartlomiej@gmail.com>

  Dean Herbert · 2022-10-26 13:14:12 +09:00
  8d9a85e9e5
• Merge branch 'master' into grid-momentary-shortcuts
  Bartłomiej Dach · 2022-10-25 22:17:08 +02:00
  48057412f5
• Merge branch 'allow-distance-grid-snap' into grid-momentary-shortcuts
  Dean Herbert · 2022-10-25 14:10:45 +09:00
  2b850694fa
• Stop HitObjectComposer from handling Shift+Number keys
  Dean Herbert · 2022-10-24 15:19:36 +09:00
  d0e6bda9ef
• Improve UI a bit
  Dean Herbert · 2022-10-21 23:35:53 +09:00
  f516e32949
• Fix incorrect current DS value when inside a slider
  Dean Herbert · 2022-10-21 23:35:47 +09:00
  bb921ff9a7
• Combine display and button into one control
  Dean Herbert · 2022-10-21 23:21:07 +09:00
  f6de366766
• Display current distance snap and add button to update to use it
  Dean Herbert · 2022-10-21 22:58:36 +09:00
  645a84b1d6
• Change distance snap to never account for slider velocity

  This is a nuanced detail that was implemented incorrectly from the
  outset. When mapping, generally a mapper chooses the distance spacing
  with no regard to the SV. It has always been common to have a lower
  or higher distance spacing than SV, but with the way the lazer editor
  has worked, the SV was multiplied into the distance snap grid display,
  incorectly changing its spacing depending on the "reference object"
  (which is usually the previous hitobject chronologically).

  Dean Herbert · 2022-10-21 21:51:24 +09:00
  7dc03097ff
• Always enable distance spacing when adusting distance space multiplier
  Dean Herbert · 2022-10-21 16:10:55 +09:00
  6cdfddea62
• Adjust paddings to feel better now that backgrounds are visible of toolboxes
  Dean Herbert · 2022-10-18 14:38:45 +09:00
  860214c22a
• Fix osu! editor padding being applied to toolboxes

  The result of https://github.com/ppy/osu/pull/20739 and https://github.com/ppy/osu/pull/20738 having unintended side effects when applied together.

  Dean Herbert · 2022-10-18 14:32:00 +09:00
  6a7f6c76ff