Dean Herbert
c013974790
Merge branch 'master' into detached-beatmap-cache
2024-08-29 22:49:11 +09:00
Dan Balasescu
fec8fa46fa
Merge pull request #29533 from bdach/fix-sample-bank-stuff-again
...
Fix incorrect bank set / sample addition logic
2024-08-29 21:36:26 +09:00
Dan Balasescu
fde790c014
Rework played filter to a boolean value
2024-08-29 20:59:48 +09:00
Dan Balasescu
97adac2e0a
Add test + adjust existing ones with new semantics
2024-08-29 20:59:27 +09:00
Dean Herbert
d1d2591b67
Fix realm changes being applied before detach finishes
2024-08-29 18:42:43 +09:00
Dean Herbert
def1abaeca
Fix some tests not always waiting long enough for beatmap loading
...
These used to work because there was a huge blocking load operation,
which is now more asynchronous.
Note that the change made in `SongSelect` is not required, but defensive
(feels it should have been doing this the whole time).
2024-08-29 18:42:43 +09:00
Dan Balasescu
a077acc599
Merge pull request #29637 from Joehuu/collapse-pinned-comment-replies
...
Hide pinned comment replies initially to match web
2024-08-29 16:21:19 +09:00
Joseph Madamba
ef443b0b5d
Hide pinned comment replies initially to match web
2024-08-28 23:05:15 -07:00
Joseph Madamba
f0b2176c30
Add failing pinned comment replies state test
2024-08-28 22:58:57 -07:00
Dean Herbert
1776d38809
Remove loadedTestBeatmaps flag
2024-08-28 23:28:44 +09:00
Dean Herbert
e04b5bb3f2
Tidy up test beatmap loading
2024-08-28 23:28:44 +09:00
Dean Herbert
853023dfba
Reduce test filter count expectation by one due to initial filter being implicit
2024-08-28 23:28:44 +09:00
Dean Herbert
9123d2cb7f
Fix multiple test failures
2024-08-28 23:28:43 +09:00
Bartłomiej Dach
d49cd717d6
Merge pull request #29576 from peppy/allow-seek-in-more-places
...
Allow seeking via music controller overlay on more screens
2024-08-28 12:23:09 +02:00
Dean Herbert
dd4a1104e4
Always debounce external Filter requests (except for tests)
...
The only exception to the rule here was "when screen isn't active apply
without debounce" but I'm not sure we want this. It would cause a
stutter on returning to song select and I'm not even sure this is a
common scenario.
I'd rather remove it and see if someone finds an actual case where this
is an issue.
2024-08-28 19:13:50 +09:00
Dean Herbert
336abadbd1
Allow running initial filter criteria asynchronously
...
This reverts a portion of https://github.com/ppy/osu/pull/9539 .
The rearrangement in `SongSelect` is required to get the initial filter
into `BeatmapCarousel` (and avoid the `FilterChanged` event firing,
causing a delayed/scheduled filter application).
2024-08-28 19:13:50 +09:00
Dean Herbert
5ed0c6e91a
Remove song select preloading
...
Really unnecessary now.
2024-08-28 19:13:49 +09:00
Dean Herbert
c2c1dccf2d
Detach beatmap sets asynchronously
2024-08-28 19:13:49 +09:00
Dean Herbert
b1f653899c
Fix enumeration over modified collection
2024-08-28 19:13:49 +09:00
Dean Herbert
81b36d897d
Fix null reference in change handling code
2024-08-28 19:13:49 +09:00
Dean Herbert
081c9eb21b
Fix incorrect cancellation / disposal handling of DetachedBeatmapStore
2024-08-28 17:21:19 +09:00
Fabep
6adaf6a41f
Changed ModCustomisationPanelState names
2024-08-28 10:09:47 +02:00
OliBomby
cadbb0f27a
change sample seek keybind to ctrl shift
2024-08-28 09:57:13 +02:00
Fabep
be0e2efda2
Removed on click event for expanding the Mod Customisation Header.
2024-08-28 09:51:17 +02:00
Dean Herbert
4d42274771
Use bindable list implementation
2024-08-28 16:03:37 +09:00
Dean Herbert
466ed5de78
Add basic detached beatmap store
2024-08-28 16:03:37 +09:00
Dean Herbert
eb70a1b72d
Change middle text to only animate initially
2024-08-28 15:57:42 +09:00
Dean Herbert
47a52d10eb
Revert "Add slight parallax to centre content"
...
This reverts commit 90d06d4496
2024-08-28 15:32:59 +09:00
OliBomby
b5b4f915a9
Automatic seek to sample point on right-click
2024-08-27 19:40:33 +02:00
OliBomby
1117fd56a1
change default seek hotkeys
2024-08-27 19:40:18 +02:00
OliBomby
daad476593
Add float comparison leniency just in case
2024-08-27 19:04:16 +02:00
OliBomby
71044a0766
fix difference in sample time calculation
2024-08-27 19:02:40 +02:00
Bartłomiej Dach
a3b0ff4808
Merge branch 'master' into break-overlay-animation
2024-08-27 11:17:56 +02:00
Bartłomiej Dach
321e509f11
Merge pull request #29615 from peppy/break-overlay-improvements
...
Add shadow around break overlay middle content to make sure it remains visible
2024-08-27 11:16:08 +02:00
Bartłomiej Dach
334b25fb12
Merge pull request #29612 from peppy/fix-hold-note-default-node-samples
...
Fix osu!mania hold notes playing a sound at their tail in the editor
2024-08-27 11:15:47 +02:00
Bartłomiej Dach
7c0550d251
Merge pull request #29500 from frenzibyte/fix-pausing-for-the-millionth-time
...
Fix oversight in osu! pause input handling
2024-08-27 10:04:47 +02:00
Bartłomiej Dach
e59689f31a
Fix test and NRT failure
2024-08-27 09:49:49 +02:00
Dean Herbert
90d06d4496
Add slight parallax to centre content
2024-08-27 16:37:27 +09:00
Bartłomiej Dach
8d7053d367
Merge pull request #29560 from peppy/fix-daily-challenge-intro-mod-display
...
Fix mod icons potentially showing incorrectly at daily challenge intro
2024-08-27 09:37:11 +02:00
Dean Herbert
6f1664f0a6
Add beat-synced animation to break overlay
...
I've been meaning to make the progress bar synchronise with the beat
rather than a continuous countdown, just to give the overlay a bit more
of a rhythmic feel.
Not completely happy with how this feels but I think it's a start?
I had to refactor how the break overlay works in the process. It no
longer creates transforms for all breaks ahead-of-time, which could be
argued as a better way of doing things. It's more dynamically able to
handle breaks now (maybe useful for the future, who knows).
2024-08-27 16:34:37 +09:00
Dean Herbert
98faa07590
Apply NRT to BreakOverlay
2024-08-27 15:01:51 +09:00
Dean Herbert
797b020747
Add shadow around break overlay middle content to make sure it remains visible
2024-08-27 15:01:50 +09:00
Dean Herbert
abdbe510b8
Move break overlay (and cursor) further forward in depth
...
I didn't really want to move the cursor in front of the HUD, but we face
a bit of an impossible scenario otherwise (it should definitely be in
front of the break overlay for visibility).
So I'll deal with it for now.
2024-08-27 14:52:11 +09:00
Dean Herbert
c2c83fe73d
Fix TestSceneBreakTracker not removing old drawables
...
Also adds a bright background for testing overlay display.
2024-08-27 14:33:36 +09:00
Dean Herbert
dce32a7983
Ban Vortice.* imports
...
They have colours and boxes and other classes that conflict with our
naming. We never use them.
2024-08-27 14:30:07 +09:00
Dean Herbert
75f2ad1e51
Merge pull request #25953 from OliBomby/free-sliders
...
Add ability to change slider length by dragging slider tail
2024-08-27 14:12:02 +09:00
Dean Herbert
9840a07eaf
Fix osu!mania hold notes playing a sound at their tail in the editor
...
Closes #29584 .
2024-08-27 14:06:02 +09:00
Dean Herbert
1b26e1c126
Merge branch 'master' into free-sliders
2024-08-27 13:32:24 +09:00
Dean Herbert
50a8348bf9
Apply NRT to remaining classes in slider blueprint namespace
2024-08-27 13:18:55 +09:00
Dean Herbert
4fc96ebfde
Tidy some thing up
2024-08-27 13:13:22 +09:00
