53861 Commits

This Branch

This Branch

All Branches

• Move initial show to base implementation and add transition for legacy version
  Dean Herbert · 2022-07-28 18:29:49 +09:00
  ea027eda46
• Remove pointless null check
  Dean Herbert · 2022-07-28 18:28:03 +09:00
  bfa026879c
• Fix DefaultSongProgress graph not resetting if time is in intro
  Dean Herbert · 2022-07-28 18:25:24 +09:00
  d5e5761892
• Tidy up various things everywhere
  Dean Herbert · 2022-07-28 18:25:14 +09:00
  7108553883
• apply code quality fixes
  Nitrous · 2022-07-28 15:30:45 +08:00
  0d36907cad
• set FirstHitTime and LastHitTime once
  Nitrous · 2022-07-28 15:25:12 +08:00
  bca3994d91
• simplify helper methods
  Nitrous · 2022-07-28 15:19:35 +08:00
  70ed347b06
• apply suggestions

  - refactor `SongProgress`
  - make`UpdateProgress` more readable
  - enable NRT on new classes
  - refactor `TestSceneSongProgress` to use `GameplayClockContainer`

  Nitrous · 2022-07-28 15:15:41 +08:00
  db62d4be3a
• Split out tests and fix variable conflict
  Dean Herbert · 2022-07-28 13:24:14 +09:00
  0913cf013c
• account for gameplay start time
  Nitrous · 2022-07-28 08:01:38 +08:00
  45c11f2b7b
• remove unused using
  Nitrous · 2022-07-27 16:01:35 +08:00
  a222278710
• refactor song progress test scene
  Nitrous · 2022-07-27 15:57:47 +08:00
  6af6f03e29
• move song progress graph to its own test scene
  Nitrous · 2022-07-27 15:57:23 +08:00
  1e013bd4e9
• make SongProgress abstract

  - move unrelated logic to `DefaultSongProgress`
  - make `LegacySongProgress` inherit `SongProgress`

  Nitrous · 2022-07-27 15:19:21 +08:00
  37e642b0bd
• scale down graph from bleeding through border
  Nitrous · 2022-07-27 14:35:18 +08:00
  a12676c25d
• Fix broken tests due to badly reimplemented copy-pasted code
  Dean Herbert · 2022-07-27 13:58:01 +09:00
  d8e605d8aa
• Transfer TODO comment across to copy-pasted implmentation
  Dean Herbert · 2022-07-27 13:53:27 +09:00
  62ca3aada6
• Remove unused combo DI retrieval
  Dean Herbert · 2022-07-27 13:50:03 +09:00
  b803ec543f
• remove unused using
  Nitrous · 2022-07-27 09:41:58 +08:00
  842ab3c5c1
• Merge branch 'master' into pie-chart-progress
  Nitrous · 2022-07-27 08:53:23 +08:00
  3abf44da91
• replace SongProgress with LegacySongProgress
  Nitrous · 2022-07-27 08:52:27 +08:00
  a2320aeb27
• implement LegacySongProgress
  Nitrous · 2022-07-27 08:51:55 +08:00
  6b0f3674c3
• Merge pull request #19375 from novialriptide/contextmenu-external-beatmap

  Add ContextMenu to beatmap external link

  Dean Herbert · 2022-07-26 19:06:10 +09:00
  c30e8047ab
• Merge pull request #19400 from peppy/button-select-allow-more

  Always allow selecting the top-most button using the select binding

  Dan Balasescu · 2022-07-26 18:49:42 +09:00
  b47f674ddb
• Merge pull request #19402 from peppy/debugger-attached-audio-warning-disable

  Don't show audio playback issue notification if debugger is attached

  Dan Balasescu · 2022-07-26 18:49:33 +09:00
  bc60552694
• Merge pull request #19378 from peppy/beatmap-update-test

  Add separate beatmap update flow to handle edge cases better

  Dan Balasescu · 2022-07-26 18:49:20 +09:00
  8f7dff5c2c
• Don't show audio playback issue notification if debugger is attached

  I've hit this countless times recently when debugging during the startup
  procedure.

  Dean Herbert · 2022-07-26 18:20:46 +09:00
  e782590b3c
• Fix new update pathway not actually being used
  Dean Herbert · 2022-07-26 17:58:09 +09:00
  9173271900
• Always allow selecting the top-most button using the select binding
  Dean Herbert · 2022-07-26 17:46:23 +09:00
  1539fa704b
• Merge pull request #19399 from frenzibyte/carousel-order-stability

  Maintain sort stability by using carousel item ID as a fallback

  Dean Herbert · 2022-07-26 17:33:30 +09:00
  6ff44ed2c6
• Merge branch 'master' into beatmap-update-test
  Dean Herbert · 2022-07-26 17:27:36 +09:00
  7f75184a01
• Add test coverage of no online ID scenario
  Dean Herbert · 2022-07-26 17:27:23 +09:00
  ee694c1257
• Rearrange sizeaxes
  Andrew Hong · 2022-07-26 04:27:22 -04:00
  003aec86ae
• Add comprehensive test coverage of update scenarios
  Dean Herbert · 2022-07-26 17:22:52 +09:00
  1221cb1a42
• Remove notification upon copy
  Andrew Hong · 2022-07-26 04:19:54 -04:00
  aaf6ec05bb
• Merge pull request #19249 from andy840119/remove-nullable-disable-in-the-mods-for-catch-ruleset

  Remove nullable disable annotation in mods for catch ruleset.

  Salman Ahmed · 2022-07-26 11:10:41 +03:00
  f90604d873
• Fix incorrect handling if an update is processed with no changes
  Dean Herbert · 2022-07-26 17:00:28 +09:00
  4c22b55ce3
• Merge branch 'master' into remove-nullable-disable-in-the-mods-for-catch-ruleset
  andy · 2022-07-26 15:37:30 +08:00
  88db835e76
• Merge pull request #19392 from peppy/fix-test-leftovers

  Avoid leaving left-over files after test run completes

  Dan Balasescu · 2022-07-26 16:33:14 +09:00
  28e81b7c32
• Refactor new tests to not suck as much as the old importer tests
  Dean Herbert · 2022-07-26 16:33:00 +09:00
  846291d203
• Merge pull request #19393 from peppy/fix-statistics-panel

  Avoid potential realm fetch after disposal in `StatisticsPanel`

  Dan Balasescu · 2022-07-26 16:32:59 +09:00
  412d42b907
• Improve existing test coverage to cover order changes from other sort modes
  Salman Ahmed · 2022-07-26 10:24:51 +03:00
  91ffa7007f
• Make item ID comparer static
  Salman Ahmed · 2022-07-26 09:55:37 +03:00
  a4f6f2b9eb
• Revert one more missed change
  Dean Herbert · 2022-07-26 15:54:10 +09:00
  9939866f7d
• Add ImportAsUpdate method to IModelImporter to avoid otehr changes
  Dean Herbert · 2022-07-26 15:49:04 +09:00
  8370ca9765
• Remove remaining uses of "child" terminology in non-drawable components
  Salman Ahmed · 2022-07-26 09:43:47 +03:00
  693ac8750c
• Maintain sort stability by using carousel item ID as fallback
  Salman Ahmed · 2022-07-26 09:40:41 +03:00
  d7ef4170be
• Merge pull request #19377 from frenzibyte/fix-timeline-tests

  Fix intermittent timeline zoom test failures

  Dean Herbert · 2022-07-26 15:18:35 +09:00
  4efe09e7c2
• Merge pull request #19389 from peppy/cursor-with-touch

  Add ability to make cursor show even during touch input

  Dan Balasescu · 2022-07-26 15:13:55 +09:00
  5345e431cc
• Avoid potential realm fetch after disposal in StatisticsPanel

  As seen at https://github.com/ppy/osu/runs/7513799859?check_suite_focus=true.

  Dean Herbert · 2022-07-26 15:12:23 +09:00
  99bdf41717