65305 Commits

This Branch

This Branch

All Branches

• Merge pull request #26631 from frenzibyte/refactor-taiko-playfield-layout

  Rewrite osu!taiko playfield adjustment container to keep playfield height constant

  Dean Herbert · 2024-01-26 17:17:49 +09:00
  e78f0bc89b
• Merge pull request #26711 from EVAST9919/hud-linq-remove

  Remove LINQ cast in `HUDOverlay`

  Dean Herbert · 2024-01-26 16:13:21 +09:00
  86027268a8
• Move cast to local function and make direct cast
  Dean Herbert · 2024-01-26 12:55:36 +09:00
  6e3eb674f6
• Remove LINQ cast in HUDOverlay
  Andrei Zavatski · 2024-01-26 01:03:22 +03:00
  542f571dee
• Fix taiko playfield test scene
  Salman Ahmed · 2024-01-25 16:33:34 +03:00
  c35df0313f
• Simplify TaikoLegacyHitTarget container hierarchy
  Dean Herbert · 2024-01-25 21:02:22 +09:00
  5aa4235c3d
• Merge pull request #26689 from myQwil/divisor_cycle

  Prevent custom divisor ranges from halting divisor preset cycling

  Dean Herbert · 2024-01-25 20:46:16 +09:00
  baaf33d995
• Change name and description of force parameter in SetArbitraryDivisor
  Mike Will · 2024-01-25 05:12:54 -05:00
  a264ac9f38
• Merge pull request #26699 from peppy/fix-log-save-failure

  Add retry loop to avoid log export failing occasionally on windows

  Bartłomiej Dach · 2024-01-25 09:51:14 +01:00
  088397b0c3
• Merge pull request #26700 from peppy/accuracy-circle-crash

  Fix crash at results screen when hidden is enabled and S rank becomes A due to miss

  Bartłomiej Dach · 2024-01-25 09:32:47 +01:00
  3e13fb87f2
• Merge pull request #26697 from LeNitrous/add/scaled-screenshot

  Crop screenshots to scaling container

  Dean Herbert · 2024-01-25 15:03:56 +09:00
  45b4edcd23
• Fix crash at results screen when hidden is enabled and S rank becomes A due to miss

  Closes https://github.com/ppy/osu/issues/26692.

  Dean Herbert · 2024-01-25 15:02:44 +09:00
  37e370e654
• Add test coverage of hidden scores on accuracy circle
  Dean Herbert · 2024-01-25 15:02:44 +09:00
  f22bfa350a
• Refactor crop logic slightly
  Dean Herbert · 2024-01-25 14:30:26 +09:00
  69e822f3c5
• Move configuration retrieval to non-bindable inline for readability
  Dean Herbert · 2024-01-25 14:22:27 +09:00
  85927e0682
• Apply NRT to ScreenshotManager
  Dean Herbert · 2024-01-25 14:18:20 +09:00
  0cbba7e011
• Merge pull request #26695 from EVAST9919/rolling-counter-alloc

  Reduce localisation overhead in `ScoreCounter`

  Dean Herbert · 2024-01-25 14:13:35 +09:00
  254dcfcebc
• Add retry loop to avoid log export failing occasionally on windows

  Closes https://github.com/ppy/osu/issues/26693.

  Dean Herbert · 2024-01-25 13:53:36 +09:00
  d2990170d0
• offset crop rectangle to scaling container
  Nitrous · 2024-01-25 10:35:41 +08:00
  b20051fd55
• Crop screenshot image to scaling container.
  Nitrous · 2024-01-25 09:27:10 +08:00
  30e335233d
• Fix ArgonScoreCounter is still using localisation
  Andrei Zavatski · 2024-01-25 03:28:02 +03:00
  7811968582
• Prevent custom divisor ranges from halting preset cycling

  A custom divisor like 24 or 32 will result in a range containing
  many divisors that are already in the `Common` and `Triplets` presets.
  When this happens, it can become impossible to cycle between presets,
  because the preset can only be changed if the new divisor isn't already
  contained within the current preset's range.

  Mike Will · 2024-01-24 18:31:39 -05:00
  9e1c242713
• Reduce allocation overhead in ScoreCounter
  Andrei Zavatski · 2024-01-24 23:45:07 +03:00
  67010fcd03
• Merge pull request #26630 from peppy/s-rank-change

  Change S rank to require no miss

  Dean Herbert · 2024-01-24 13:27:40 +09:00
  2024.124.0 b272d34960
• Merge pull request #26674 from peppy/use-better-enumerator

  Reduce enumerator overhead in `GameplayLeaderboard`

  Bartłomiej Dach · 2024-01-23 16:31:17 +01:00
  871683a3dc
• Merge pull request #26680 from peppy/fix-now-playing-centering

  Fix now playing beatmap backgrounds not being correctly centred

  Bartłomiej Dach · 2024-01-23 16:17:34 +01:00
  0486c77a74
• Do not reprocess ranks for custom rulesets

  Chances are that because we've broken rank API, it would utterly fail
  for all custom rulesets anyhow.

  Bartłomiej Dach · 2024-01-23 12:59:36 +01:00
  6c169e3156
• Remove outdated test

  Non-legacy scores *are* subject to upgrades again - albeit it is *rank*
  upgrades that they are subject to.

  Bartłomiej Dach · 2024-01-23 12:53:16 +01:00
  0b5be3c40c
• Move transferal of LegacyTotalScore back to original spot

  This subtle detail was messing with server-side score import flows.
  Server-side, legacy total score will *already* be in `LegacyTotalScore`
  from the start, and `TotalScore` will be zero until recomputed via
  `StandardisedScoreMigrationTools.UpdateFromLegacy()` - so in that
  context, attempting to move it across is incorrect.

  Bartłomiej Dach · 2024-01-23 12:42:57 +01:00
  cb87d6ce50
• Apply more correct visual offset adjustment

  Co-authored-by: Walavouchey <36758269+Walavouchey@users.noreply.github.com>

  Dean Herbert · 2024-01-23 19:16:55 +09:00
  0cf90677e6
• Merge pull request #26677 from EVAST9919/triangles-better-clamp

  Implement per-axis clamping in `Triangles` backgrounds

  Dean Herbert · 2024-01-23 18:28:03 +09:00
  413c34ce06
• Fix now playing beatmap backgrounds not being correctly centred

  https://github.com/ppy/osu/discussions/26679

  Dean Herbert · 2024-01-23 17:30:00 +09:00
  c8cd7ebe6c
• Implement per-axis triangles clamping
  Andrei Zavatski · 2024-01-23 04:54:27 +03:00
  da992ccc55
• Remove redundant assertion

  It does look pretty dumb to be checking if something is `null` *after
  calling an instance method on it*...

  Bartłomiej Dach · 2024-01-22 22:01:03 +01:00
  4d253ebf3c
• Fix rank background processing not working (and not bumping score version)
  Bartłomiej Dach · 2024-01-22 21:34:28 +01:00
  fdd499a485
• Avoid using .Children for enumeration in other locations
  Dean Herbert · 2024-01-23 05:32:11 +09:00
  02bb506cce
• Reduce enumerator overhead in GameplayLeaderboard
  Dean Herbert · 2024-01-23 05:31:53 +09:00
  069af13aaf
• Expand xmldoc
  Bartłomiej Dach · 2024-01-22 21:13:59 +01:00
  24be6d92ce
• Update assertions to match expected behaviour
  Bartłomiej Dach · 2024-01-22 20:52:54 +01:00
  d53fb5a165
• Remove legacy computation of accuracy & ranks
  Bartłomiej Dach · 2024-01-22 20:52:54 +01:00
  cdd6e71d01
• Remove superfluous recomputation of accuracy
  Bartłomiej Dach · 2024-01-22 20:52:54 +01:00
  217cbf684b
• Unify legacy total score / accuracy / rank recomputation flows
  Bartłomiej Dach · 2024-01-22 20:52:51 +01:00
  db4849442e
• Use lazer accuracy & rank implementations across the board
  Bartłomiej Dach · 2024-01-22 20:30:16 +01:00
  2958631c5d
• Move maximum statistics population to LegacyScoreDecoder
  Bartłomiej Dach · 2024-01-22 20:01:24 +01:00
  aa8eee0796
• Add another failing tests covering recomputation of ranks
  Bartłomiej Dach · 2024-01-22 20:01:18 +01:00
  3f31593a19
• Adjust existing test to fail
  Bartłomiej Dach · 2024-01-22 20:00:00 +01:00
  81a02665b6
• Remove remnant of old implementation of showing "A due to misses"
  Bartłomiej Dach · 2024-01-22 19:58:11 +01:00
  45dc9de1e0
• Fix back-to-front conditional in taiko processor

  Would be weird to degrade a score due to *no* misses wouldn't it?

  Bartłomiej Dach · 2024-01-22 19:57:12 +01:00
  20ed7e13e3
• Make RankFromScore()'s dictionary param readonly

  Just to make sure nobody tries any "funny" business.

  Bartłomiej Dach · 2024-01-22 19:56:30 +01:00
  cb8ec48717
• Merge branch 'master' into s-rank-change
  Bartłomiej Dach · 2024-01-22 19:54:53 +01:00
  5bae9074aa