1
0
mirror of https://github.com/ppy/osu.git synced 2024-11-12 09:37:24 +08:00
Commit Graph

47795 Commits

Author SHA1 Message Date
Dean Herbert
bb54f438aa Merge branch 'master' into positional-sounds-strength-adjustment 2022-01-03 12:40:56 +09:00
Dean Herbert
cf864e58f7
Merge pull request #16253 from peppy/reduce-chat-overhead
Reduce overhead from chat polling when game is not active
2022-01-01 23:42:31 +09:00
Bartłomiej Dach
e7d7587ea5
Merge branch 'master' into reduce-chat-overhead 2022-01-01 15:02:55 +01:00
Bartłomiej Dach
2bdf470d83
Merge pull request #16292 from peppy/storyboard-outro-test-reliability
Improve reliability of `TestStoryboardSkipOutro`
2022-01-01 14:10:17 +01:00
Dean Herbert
04d8fd3a58 Improve reliability of TestStoryboardSkipOutro
Aims to resolve failures as seen at
https://github.com/peppy/osu/runs/4677353822?check_suite_focus=true.

Have run quite a lot locally with no failures (while removing the skip step 100% fails).
2022-01-01 15:32:39 +09:00
Dean Herbert
675bdd3213 Fix MultiplayerMatchSubScreen mutating mods outside of bindable lease
As seen at https://github.com/peppy/osu/runs/4674501626?check_suite_focus=true.
2022-01-01 12:13:59 +09:00
Dean Herbert
1262e76a58 Fix test failure due to missing DI cached IdleTracker 2021-12-31 23:18:03 +09:00
Dean Herbert
f656e7d2d2
Merge pull request #16284 from peppy/archive-reader-synchronous-flow
Avoid potential deadlocks in `ArchiveReader` synchronous implementation
2021-12-31 12:46:13 +09:00
Bartłomiej Dach
cbb62fab26
Merge pull request #16282 from peppy/fix-kiai-drawable-nullref
Fix null reference causing crash in `KiaiFlashingDrawable`
2021-12-30 23:43:58 +01:00
Bartłomiej Dach
42b93283ca
Merge branch 'master' into fix-kiai-drawable-nullref 2021-12-30 23:15:42 +01:00
Bartłomiej Dach
d68c47e710
Merge pull request #16283 from peppy/fix-leaderboard-test
Fix `TestSceneMultiSpectatorLeaderboard` not waiting for user population
2021-12-30 23:00:24 +01:00
Dean Herbert
670a30b64b Remove usage of .Result in ArchiveReader 2021-12-31 01:52:01 +09:00
Dean Herbert
e38e1bb1d7 Enable a couple of missing async related inspections 2021-12-31 01:52:01 +09:00
Dean Herbert
f53a675ca3 Fix TestSceneMultiSpectatorLeaderboard not waiting for user population 2021-12-31 00:48:31 +09:00
Dean Herbert
408e8d5710 Fix null reference causing crash in KiaiFlashingDrawable
Can occur if there is no fallback graphics available. Previously would
work as it was only setting the `Texture`.

As reported in https://github.com/ppy/osu/discussions/16281.
2021-12-30 22:21:39 +09:00
Dean Herbert
089b756f93 Invert logic to make reading easier 2021-12-30 16:03:16 +09:00
Dean Herbert
ef49f2ed0e Add extra extra safety against attempting to load a previously expired editor 2021-12-30 16:02:31 +09:00
Joseph Madamba
cdc148f78e Increase scope of identifier typo disables on special cases 2021-12-29 14:07:36 -08:00
Dean Herbert
b1a444180f Fix Show then Reset potentially resulting in incorrect load target 2021-12-29 21:46:34 +09:00
Dean Herbert
2fd4647e6e
Merge pull request #16272 from bdach/animated-hit-circle-overlay
Add support for animated hit circle overlay
2021-12-29 21:39:27 +09:00
Dean Herbert
471eea750a Fix calling SkinEditorOverlay.Show before the overlay is loaded causing an exception
As seen at https://github.com/ppy/osu/runs/4652969942?check_suite_focus=true.
2021-12-29 21:18:17 +09:00
Joseph Madamba
c22a07d9fc Bump identifier typo inspection and fix remaining identifier names 2021-12-28 11:26:42 -08:00
Bartłomiej Dach
eea0fea69f
Add support for animated legacy hit circle overlay 2021-12-28 15:58:34 +01:00
Bartłomiej Dach
b29c2bf9f3
Add test resources for animated legacy hit circle overlay 2021-12-28 15:58:34 +01:00
Bartłomiej Dach
448c6ed515
Generalise KiaiFlashingSprite for arbitrary drawables 2021-12-28 15:58:34 +01:00
Bartłomiej Dach
f78adbea36
Merge pull request #16271 from turbedi/remove_sharpraven_package
Remove unused SharpRaven package reference from osu.iOS.props
2021-12-28 15:57:51 +01:00
Berkan Diler
d74e438f0a Remove unused SharpRaven package reference from osu.iOS.props
Seems like a leftover from #6824
2021-12-28 15:17:18 +01:00
Dean Herbert
f2ed8af9cb
Merge pull request #16268 from bdach/implicit-newtonsoft-properties
Revert rename of implicitly-used newtonsoft method
2021-12-28 18:45:08 +09:00
Bartłomiej Dach
63e0492725
Mark ShouldSerialize() methods as implicitly used 2021-12-28 09:02:03 +01:00
Bartłomiej Dach
bc39c2a877
Revert incorrect property rename 2021-12-28 08:31:27 +01:00
Dean Herbert
73dca0c7e3
Merge pull request #16266 from Joehuu/fix-identifier-typos
Fix and normalise most identifier names in code
2021-12-28 15:21:42 +09:00
Dean Herbert
40df8124d7
Merge pull request #16265 from peppy/update-framework
Update framework
2021-12-28 15:08:10 +09:00
Joseph Madamba
0bd928b5cd Fix incorrect naming / apply review 2021-12-27 21:44:19 -08:00
Joseph Madamba
5082b0e63f Fix some identifiers using shortened naming 2021-12-27 20:26:28 -08:00
Joseph Madamba
7de43e3aba Fix most open compound words in identifiers being closed 2021-12-27 20:26:28 -08:00
Joseph Madamba
98524d60a4 Fix clear identifier typos 2021-12-27 20:26:28 -08:00
Joseph Madamba
55768d8c11 Add some osu! words to dictionary 2021-12-27 20:26:28 -08:00
Joseph Madamba
eed0ecf8c5 Add special prefixed/suffixed words to dictionary 2021-12-27 20:26:28 -08:00
Bartłomiej Dach
568cab6808
Add clarification comment about explicit ProcessFrame() call 2021-12-27 21:13:04 +01:00
Dean Herbert
eb04cc9213 Update framework 2021-12-27 23:04:10 +09:00
Bartłomiej Dach
9f8ad9f833
Fix menu background storyboard stopping after track reload 2021-12-27 12:30:53 +01:00
Bartłomiej Dach
ef763e9bd7
Add failing test for storyboard not tracking current track 2021-12-27 12:28:49 +01:00
Dan Balasescu
f7715b930f
Merge pull request #16257 from bdach/catch-combo-counter-visible
Fix legacy combo counter not fully hiding for rulesets that implement their own
2021-12-27 17:53:17 +09:00
Dean Herbert
8d927920cb Add comment explainng why to block idle updates when host is not active 2021-12-27 13:31:07 +09:00
Bartłomiej Dach
5a591713ae
Fix legacy combo counter not fully hiding for rulesets that implement their own 2021-12-26 16:49:20 +01:00
Bartłomiej Dach
34b0101ff4
Add visual test coverage of "hidden by ruleset" combo option 2021-12-26 16:49:18 +01:00
Dean Herbert
edf5e558ac
Merge pull request #16254 from bdach/storyboard-samples-vs-skin-hitsounds
Fix "disable beatmap hitsounds" setting also preventing storyboard samples from playing
2021-12-26 23:20:15 +09:00
Bartłomiej Dach
724b601d2a
Rename AllowSampleLookup argument to something saner 2021-12-26 14:29:07 +01:00
Bartłomiej Dach
dc21c8901e
Always allow looking up storyboard samples from beatmap skin 2021-12-26 14:25:28 +01:00
Bartłomiej Dach
2b4c2f7ff3
Add failing test for storyboard sample playback with beatmap hitsounds off 2021-12-26 14:25:05 +01:00