61265 Commits

This Branch

This Branch

All Branches

• Replace various local implementations of rewinding checks with new property
  Dean Herbert · 2023-07-07 15:21:24 +09:00
  e0fc97bb93
• Fix GameplaySampleTriggerSource not handling rewinds correctly
  Dean Herbert · 2023-07-06 19:08:42 +09:00
  753db044b4
• Expose rewinding state of IGameplayClocks

  The implementation of this requires a bit of a special case
  for 0, so makes sense to implement in a central place.

  Dean Herbert · 2023-07-06 19:08:42 +09:00
  2e98ab0a48
• Add sample trigger tests covering rewinding of gameplay
  Dean Herbert · 2023-07-06 19:08:42 +09:00
  7a3a14e50d
• Merge pull request #24139 from peppy/fix-tourney-read-bracket

  Fix tournament bracket parsing regression

  Dean Herbert · 2023-07-06 19:03:12 +09:00
  001d09057e
• Fix tournament bracket parsing regression

  Closes #24136.
  Regressed in #24037.

  Dean Herbert · 2023-07-06 17:17:17 +09:00
  b40532dde1
• Merge pull request #24129 from peppy/toggle-replay-overlay

  Remember state of replay settings visibility and allow key customisation

  Dean Herbert · 2023-07-06 12:27:30 +09:00
  65384d6125
• Move replay settings toggle to replay key bindings section
  Bartłomiej Dach · 2023-07-05 22:45:10 +02:00
  1938bdbf9d
• Remove weird aliased using

  Doesn't appear to be required.

  Bartłomiej Dach · 2023-07-05 22:41:22 +02:00
  cdb8a56df4
• Merge pull request #24121 from peppy/fix-judged-fallback

  Fix fallback for `Judged` to be more correct

  Bartłomiej Dach · 2023-07-05 22:15:04 +02:00
  f3576b88a4
• Merge pull request #24088 from peppy/taiko-hitsounding-drum-sample-player

  Move all remaining osu!taiko sample playback logic out of `DrawableHitObject`s

  Bartłomiej Dach · 2023-07-05 21:57:49 +02:00
  afc0c4f3c2
• Make key for toggling replay settings customisable
  Dean Herbert · 2023-07-06 01:00:41 +09:00
  9291895305
• Remember state of replay settings visibility
  Dean Herbert · 2023-07-06 00:53:37 +09:00
  95a9b532df
• Remove not-yet-implemented settings group comments
  Dean Herbert · 2023-07-06 00:46:09 +09:00
  fbab5acac1
• Fix new scoring related properties not storing to realm due to internal spec
  Dean Herbert · 2023-07-05 19:47:44 +09:00
  00c68cad53
• Merge pull request #24072 from smoogipoo/diffcalc-total-scorev1

  Add difficulty attributes to facilitate conversion from legacy score, and convert existing scores

  Dean Herbert · 2023-07-05 18:47:18 +09:00
  49e5558e4f
• Merge branch 'master' into taiko-hitsounding-drum-sample-player
  Dean Herbert · 2023-07-05 18:44:24 +09:00
  4bb65a54b8
• Fix reversed order of sample return
  Dean Herbert · 2023-07-05 18:44:01 +09:00
  9a7bf1bedd
• Add test coverage of Judged state
  Dean Herbert · 2023-07-05 18:20:25 +09:00
  e21dc56fcb
• Fix fallback for Judged to be more correct

  Without this change, when the `Judged` value is checked on an
  `HitObjectLifetimeEntry` it would return `true` if a `DrawableHitObject`
  has not yet been associated with the entry. Which is completely wrong.
  
  Of note, the usage in `DrawableHitObject` will have never fallen through
  to this incorrect value as they always have a result populated:
  
  https://github.com/ppy/osu/blob/f26f001e1d01ca6bb53225da7bf06c0ad21153c5/osu.Game/Rulesets/Objects/Drawables/DrawableHitObject.cs#L721-L726

  Dean Herbert · 2023-07-05 18:03:58 +09:00
  3f8dfc7cb0
• Merge pull request #24118 from bdach/nested-entries

  Add links to nested objects' lifetime entries to `HitObjectLifetimeEntry`

  Dean Herbert · 2023-07-05 14:10:14 +09:00
  674ade0c24
• Add assertions covering correctness of judged flags on entry
  Bartłomiej Dach · 2023-07-04 23:48:46 +02:00
  b0f6b22fa7
• Redirect judgement-related flags from DHO to HOLE
  Bartłomiej Dach · 2023-07-04 23:45:08 +02:00
  6c4e52821d
• Ensure synthetic entries from non-pooled DHO are linked to parents
  Bartłomiej Dach · 2023-07-04 23:45:08 +02:00
  0ceaf3c451
• Redirect HitObjectEntryManager child mapping to HOLE
  Bartłomiej Dach · 2023-07-04 23:41:06 +02:00
  bae7670855
• Add test coverage for mixed pooled/non-pooled usages
  Bartłomiej Dach · 2023-07-04 23:41:06 +02:00
  2b098bdf61
• Add HitObjectLifetimeEntry.NestedEntries
  Bartłomiej Dach · 2023-07-04 23:39:56 +02:00
  6dc8c7b617
• Merge pull request #24115 from peppy/fix-progress-cancelled

  Fix cancelled progress notifications requiring exit confirmation

  Bartłomiej Dach · 2023-07-04 21:48:56 +02:00
  b13e2c5d87
• Rename and adjust xmldoc on TotalScoreVersion
  Dean Herbert · 2023-07-04 20:04:02 +09:00
  f2aa80f413
• Rewrite comment regarding LegacyTotalScore
  Dean Herbert · 2023-07-04 19:59:57 +09:00
  aee89e5e4b
• Fix cancelled progress notifications requiring exit confirmation
  Dean Herbert · 2023-07-04 18:39:19 +09:00
  664294cef4
• Count missing beatmaps as errored items
  Dean Herbert · 2023-07-04 18:35:03 +09:00
  dd9998127e
• Improve messaging around failed scores
  Dean Herbert · 2023-07-04 18:34:53 +09:00
  d3eb06578e
• Allow user cancellation
  Dean Herbert · 2023-07-04 18:22:10 +09:00
  56bfb92ba6
• Fix background beatmap processor thread not correctly exiting
  Dean Herbert · 2023-07-04 18:21:22 +09:00
  257a96ef60
• Fix realm silly business
  Dean Herbert · 2023-07-04 18:08:26 +09:00
  4de15f975e
• Move preconditions to realm migration step to simplify marker version logic
  Dean Herbert · 2023-07-04 17:53:53 +09:00
  a0c3fa9c13
• ILegacyScoreProcessor -> ILegacyScoreSimulator
  Dean Herbert · 2023-07-04 17:32:54 +09:00
  1629024111
• Tidy up and improve messaging on completion notification
  Dean Herbert · 2023-07-04 15:53:24 +09:00
  3b5f3b67a7
• Reduce code repetition for sleep logic
  Dean Herbert · 2023-07-04 15:35:09 +09:00
  1a6381bcbb
• Remove unnecessary null check
  Dean Herbert · 2023-07-04 14:19:25 +09:00
  67650831bd
• Merge branch 'master' into diffcalc-total-scorev1
  Dean Herbert · 2023-07-04 14:15:24 +09:00
  4203e2183d
• Merge pull request #24071 from peppy/availability-fixes

  Add handling of "unknown" beatmap availability in multiplayer flow

  Bartłomiej Dach · 2023-07-02 21:32:40 +02:00
  f6939223b3
• Merge branch 'master' into availability-fixes
  Bartłomiej Dach · 2023-07-02 20:38:37 +02:00
  21f758947d
• Merge pull request #24068 from peppy/fix-sign-out-string

  Use more correct localised string source for "sign out" text

  Bartłomiej Dach · 2023-07-02 19:20:24 +02:00
  7b3cb5b410
• Duplicate sign out string for now
  Dean Herbert · 2023-07-03 00:14:26 +09:00
  95c30fe12a
• Merge pull request #24099 from bdach/fix-oob-selection-box-again

  Fix edge cases where selection buttons go outside playfield bounds

  Dean Herbert · 2023-07-02 09:37:50 +09:00
  b3c874fdc5
• Merge pull request #24081 from Cootz/restore-scores-after-bearmap-reinstallation

  Reattach any orphaned scores when a beatmap is imported

  Bartłomiej Dach · 2023-07-01 22:33:38 +02:00
  d017be50f1
• Use slightly different condition for better UX
  Bartłomiej Dach · 2023-07-01 21:39:08 +02:00
  9eec1337b3
• Fix edge cases where selection buttons go outside playfield bounds

  Addresses
  https://github.com/ppy/osu/discussions/23599#discussioncomment-6300885.

  Bartłomiej Dach · 2023-07-01 21:27:17 +02:00
  183777f8df