Dean Herbert
ff2eae4597
Rename confusing variable
2021-10-19 11:37:46 +09:00
Dan Balasescu
30af27e561
Merge branch 'master' into realm-importer
2021-10-19 11:06:11 +09:00
Dan Balasescu
4fcdeffbd9
Merge pull request #15176 from peppy/realm-indexed-online-id
...
Change `OnlineID` to non-nullable to allow for indexing in Realm
2021-10-19 11:05:34 +09:00
Dean Herbert
05bd440cbb
Merge pull request #15183 from bdach/fix-failing-assert-ruleset-tests
...
Fix ruleset template player tests failing due to null ruleset ID
2021-10-19 10:06:25 +09:00
Bartłomiej Dach
95ed9a431c
Add test coverage for no submission for ruleset with null ID
2021-10-19 00:06:07 +02:00
Bartłomiej Dach
8db2fc439d
Change ruleset ID assert in player to null-check
2021-10-18 23:45:06 +02:00
Bartłomiej Dach
6d9d85685f
Fix settings item having zero height
2021-10-18 23:30:38 +02:00
Bartłomiej Dach
cc9727ec11
Merge branch 'master' into default-value-indicator
2021-10-18 22:07:58 +02:00
Bartłomiej Dach
88a1b31fae
Remove grid usage in SettingsItem
2021-10-18 22:07:32 +02:00
Bartłomiej Dach
6c3637a62a
Remove grid usage in KeyBindingRow
2021-10-18 22:07:30 +02:00
Bartłomiej Dach
830f49bca6
Remove doubled-up opacity specification
2021-10-18 19:43:48 +02:00
Dean Herbert
b3219bb592
Update usages of OnlineID
2021-10-18 16:16:36 +09:00
Dean Herbert
6904938dc1
Merge branch 'realm-indexed-online-id' into realm-importer
2021-10-18 16:14:37 +09:00
Dean Herbert
88a575462c
Work around weird null inspection
2021-10-18 16:11:55 +09:00
Dean Herbert
2c5ba1d8e2
Change OnlineID to non-nullable to allow for indexing in Realm
2021-10-18 15:53:40 +09:00
Dan Balasescu
8643c725cc
Merge pull request #15175 from peppy/fail-animation-flash-controlled-by-setting
...
Don't flash screen red on fail if the user has disabled red tinting
2021-10-18 15:27:10 +09:00
Dan Balasescu
f2f9872718
Merge pull request #15173 from peppy/fix-epilepsy-warning-fade-out
...
Fix epilepsy warning not being faded out on an early exit during gameplay load
2021-10-18 15:18:38 +09:00
Dean Herbert
b2f9f8b8da
Update logic surrounding removal of previous OnlineIDs when running a new import
2021-10-18 15:14:13 +09:00
Dan Balasescu
cd80d8eb51
Merge pull request #15174 from peppy/disable-stupid-syntax
...
Disable new null check inspections which we won't be using
2021-10-18 15:10:55 +09:00
Dean Herbert
264fa703f2
Remove some forgotten temporary code from BeatmapImporter
...
And make the online queue not `dynamic`, at very least.
2021-10-18 14:43:50 +09:00
Dean Herbert
75bfa705cf
Remove unused method for now
2021-10-18 14:32:38 +09:00
Dean Herbert
ad112cbbc5
Fix intendation in a way it doesn't regress with older inspectcode
2021-10-18 14:28:29 +09:00
Dean Herbert
3c4c9ab7a7
Move ICanAcceptFiles specification to IModelImporter<TModel>
2021-10-18 14:25:51 +09:00
Dean Herbert
762949f49f
Don't flash screen red on fail if the user has disabled red tinting
2021-10-18 14:20:38 +09:00
Dean Herbert
6d6eed61aa
Fix new indentation inspections
2021-10-18 14:00:35 +09:00
Dean Herbert
d37913a8b4
Disable null check pattern type check syntax inspections
2021-10-18 13:59:25 +09:00
Dean Herbert
50bde0fe38
Refactor test to better keep existing toggle values
...
I also changed the type of the button to `float` because it was mentally
hard to parse a default button that is tracking a `bool` state. Probably
not what we want for a test like this.
2021-10-18 13:53:28 +09:00
Dean Herbert
59dc04017e
Fix epilepsy warning not being faded out on an early exit from PlayerLoader
2021-10-18 13:30:37 +09:00
Dean Herbert
0d992a0493
Add failing test showing epilepsy warning is not fading on early exit
2021-10-18 13:30:24 +09:00
Dan Balasescu
43c2e9bf3e
Merge pull request #15086 from stanriders/effective-miss-count
...
Approximate amount of effective misses using combo
2021-10-18 10:01:15 +09:00
Dan Balasescu
a9ba4e592d
Merge pull request #15159 from 5ln/multi-status
...
Hide mods when spectating or beatmap isn't locally available
2021-10-18 09:59:19 +09:00
Bartłomiej Dach
2a41e8bd1f
Remove unneeded extra padding from settings number box
2021-10-17 21:50:04 +02:00
Bartłomiej Dach
552fc1dc8a
Adjust key binding rows to accommodate new default value indicator
2021-10-17 21:50:04 +02:00
Bartłomiej Dach
f422ebb281
Adjust SettingsItem to accommodate new default value indicator
2021-10-17 21:50:03 +02:00
Bartłomiej Dach
818f35c35f
Restyle default value indicator
2021-10-17 21:50:03 +02:00
5ln
3529f34c98
Multi: Hide mods when spectating or Beatmap isn't Locally Available.
...
Signed-off-by: 5ln <xnafumie@gmail.com>
2021-10-18 02:01:50 +08:00
Dean Herbert
92a3658753
Merge pull request #15130 from bdach/spectator-convert-failure
...
Fix score created in player not populating ruleset ID
2021-10-17 20:00:24 +09:00
Bartłomiej Dach
874decb3cd
Replace spectator-local fix for wrong ruleset ID with player-global consistency check
2021-10-16 16:10:42 +02:00
Bartłomiej Dach
b34086a792
Add failing test case for incorrect RulesetID population in submission flow
2021-10-16 16:10:42 +02:00
smoogipoo
80827b741f
Merge branch 'master' into effective-miss-count
2021-10-16 21:43:34 +09:00
StanR
ccaac97794
Clamp comboBasedMissCount
2021-10-16 14:50:15 +03:00
Bartłomiej Dach
e57d6e930e
Source spectator state sent to server from gameplay state
2021-10-16 13:48:49 +02:00
Bartłomiej Dach
29ec498f6c
Add failing test case for player sending wrong ruleset ID to spectator server
2021-10-16 13:34:24 +02:00
Bartłomiej Dach
e925c416cb
Merge pull request #15122 from peppy/fail-animation-update
...
Add new fail animation to better match new sound effects
2021-10-15 20:23:09 +02:00
Bartłomiej Dach
f6d98e8cf2
Merge branch 'master' into fail-animation-update
2021-10-15 19:58:07 +02:00
Dean Herbert
7a5a612896
Move retry and exit hotkey overlays to same depth / container
2021-10-16 02:29:45 +09:00
Dan Balasescu
b1989e6e50
Merge pull request #15009 from stanriders/fix-invisible-sinners
...
Fix instant spinners giving insane amounts of strain
2021-10-16 02:10:48 +09:00
Dean Herbert
e9f50179ab
Merge branch 'master' into fail-animation-update
2021-10-15 23:32:10 +09:00
StanR
c8d99e68a5
Remove calculation for scores with combo above threshold, avoid division by zero
2021-10-15 16:51:05 +03:00
Dean Herbert
91754450b2
Remove dispose method completely
2021-10-15 21:27:44 +09:00
