Joseph Madamba
d98d330da2
Add expected behavior test for scroll back to previous position
2023-02-26 14:30:46 -08:00
Bartłomiej Dach
d679703fa2
Merge pull request #22659 from peppy/fix-taiko-drum-nested-sample-detection
...
Fix `GameplaySampleTriggerSource` not considering nested objects when determining the best sample to play
2023-02-22 18:56:59 +01:00
Dean Herbert
a8c692a215
Merge pull request #22635 from peppy/use-overlays-container-more
...
Use `Overlays` container rather than `KeyBindingInputManager` for flashlight
2023-02-22 18:30:21 +09:00
Dean Herbert
f61fbcf3fc
Update assertion to also check GameplayClockContainer
's current time
2023-02-22 15:26:09 +09:00
Dean Herbert
a511e64fa5
Seek using GameplayClockContainer
2023-02-22 14:41:20 +09:00
Dean Herbert
4f9f4b3970
Merge pull request #22674 from peppy/skin-editor-layer-select
...
Add the ability to select a target layer in the skin editor
2023-02-22 12:51:15 +09:00
Bartłomiej Dach
051eb18b33
Merge branch 'master' into skin-editor-layer-select
2023-02-21 21:38:51 +01:00
Bartłomiej Dach
ab97b02235
Remove contradictory remark from xmldoc
2023-02-21 21:05:46 +01:00
Bartłomiej Dach
d59d153654
Fix test compile failures from Audio
hoisting
2023-02-21 21:03:00 +01:00
Bartłomiej Dach
3d2fcb0cca
Merge branch 'master' into fix-taiko-drum-nested-sample-detection
2023-02-21 20:53:06 +01:00
Bartłomiej Dach
eb0c3ca174
Merge pull request #22650 from peppy/skin-editor-clipboard
...
Add skin editor clipboard support
2023-02-21 20:10:32 +01:00
Bartłomiej Dach
ec1bf7b0b2
Merge branch 'master' into skin-editor-clipboard
2023-02-21 19:35:58 +01:00
Dean Herbert
9384687d6d
Switch ModMuted
to add its metronome to components rather than overlays
2023-02-21 19:04:06 +09:00
Dean Herbert
1acc536248
Move DrawableRuleset.Audio
to a less generic level
2023-02-21 19:03:52 +09:00
Dean Herbert
af062e7a68
Change placeComponent
to only add to selection, not clear an existing selection
2023-02-21 14:11:18 +09:00
Dean Herbert
9321ec29dc
Update slider sample source asserts to match expected behaviour
...
As pointed out in review, if the current time is after the end of the
slider, the correct hit object to use for sample retrieval is the object
itself, not any nested object.
2023-02-21 14:04:38 +09:00
Dean Herbert
e686b4393e
Add wait steps to ensure frame-stable clock has caught up before checking state
2023-02-21 14:04:19 +09:00
Dean Herbert
5ba6059911
Merge branch 'master' into fix-taiko-drum-nested-sample-detection
2023-02-21 13:58:15 +09:00
Dean Herbert
ee87a29376
Merge pull request #22543 from Cwazywierdo/hitcircle-late-miss-fade
...
Fix hit circle late-miss fading differences compared to stable
2023-02-21 13:56:57 +09:00
Dean Herbert
0d229d959b
Remove unnecessary TriggerChange
call
2023-02-21 13:50:19 +09:00
Bartłomiej Dach
6799492596
Merge branch 'master' into skin-editor-layer-select
2023-02-20 21:33:48 +01:00
Bartłomiej Dach
8818341047
Merge pull request #22673 from peppy/skin-per-ruleset-layouts
...
Add support for per-ruleset skin layouts
2023-02-20 21:33:28 +01:00
Bartłomiej Dach
86a7f4dfd0
Do not serialise SkinLayoutInfo.AllDrawables
...
- It is entirely derived from `SkinLayoutInfo.DrawableInfo`, which is
the actual primary thing we want to serialise.
- It will never get read out from any serialised files anyway (corollary
of the previous point - it is a get-only property derived from another).
- It is only used in tests.
All of the three reasons above make serialising the property out to skin
files nothing more than a waste of space.
2023-02-20 20:37:48 +01:00
Bartłomiej Dach
c9999bdeb1
Merge branch 'master' into skin-per-ruleset-layouts
2023-02-20 20:14:38 +01:00
Bartłomiej Dach
43724472c4
Clarify comment to avoid playing pronoun game
2023-02-20 20:09:24 +01:00
Dean Herbert
6382314af1
Merge pull request #22697 from ggliv/tablet-area-drag
...
Allow tablet area to be dragged
2023-02-20 23:37:25 +09:00
Dean Herbert
43d33d45ca
Only add valid placed components to selected collection on paste
2023-02-20 20:02:43 +09:00
Dean Herbert
b68562b033
Make placeComponent
resilient to missing dependencies
2023-02-20 20:00:12 +09:00
Dean Herbert
a9c7edd087
Remove copy pasted comment
2023-02-20 19:57:16 +09:00
Dean Herbert
7a585e1fa1
Merge pull request #22669 from EVAST9919/mod-overlay-triangles
...
Add triangles animation to mod select overlay headers
2023-02-20 19:54:21 +09:00
Dean Herbert
ec12186d63
Remove unnecesasry null check on content
2023-02-20 19:53:04 +09:00
Dean Herbert
18700b4daa
Add note about skin migrations being on read and remove an older deprecation notice
2023-02-20 19:51:54 +09:00
Dean Herbert
1629c86b5d
Mark constant identifier as non-localisable
...
Co-authored-by: Bartłomiej Dach <dach.bartlomiej@gmail.com>
2023-02-20 19:48:39 +09:00
Dean Herbert
0ddda018fd
Add xmldoc for SkinComponentsContainerLookup.Ruleset
...
Co-authored-by: Bartłomiej Dach <dach.bartlomiej@gmail.com>
2023-02-20 19:48:18 +09:00
Dean Herbert
5f7a6d13c3
Remove unused GetSerialisableIdentifier
for now
2023-02-20 19:47:17 +09:00
Gabe Livengood
c86c1a9029
allow tablet area to be dragged
2023-02-20 00:06:20 -05:00
Bartłomiej Dach
b5dda407a8
Merge pull request #22291 from ekrctb/revert-result-in-playfield
...
Move judgement result revert logic to Playfield
2023-02-19 17:06:08 +01:00
Bartłomiej Dach
8a488ebccc
Actually simplify condition
2023-02-19 16:39:35 +01:00
Bartłomiej Dach
0611fd4035
Add coverage for classic/hidden interactions
2023-02-19 16:39:25 +01:00
Bartłomiej Dach
3183f5cee2
Merge branch 'master' into revert-result-in-playfield
2023-02-19 16:33:10 +01:00
Bartłomiej Dach
2cda7fced3
Merge pull request #22670 from peppy/blueprint-improve-visuals
...
Improve the appearance of skin blueprints
2023-02-19 16:31:29 +01:00
Bartłomiej Dach
1ba1298850
Merge branch 'master' into blueprint-improve-visuals
2023-02-19 15:55:30 +01:00
Dean Herbert
d7381b762c
Also tween origin position
2023-02-19 23:52:21 +09:00
Dean Herbert
cff57d7ee9
Merge pull request #22686 from MaxKruse/fix-automatic-seeking
...
Add toggle to disable automatic seeking to object after placement
2023-02-19 23:38:23 +09:00
Bartłomiej Dach
d9ca7102f0
Use more generic wording for future-proofing
2023-02-19 15:06:40 +01:00
Bartłomiej Dach
8b25598d82
Rename moved test method to describe its purpose better
2023-02-19 13:54:48 +01:00
Bartłomiej Dach
80ee917c77
Rewrite test cases
...
- Depend less on arbitrary timings
- Remove unnecessary seeks
- Change method name to make more sense
- Use nunit style assertions
2023-02-19 13:37:06 +01:00
Bartłomiej Dach
80b329f069
Rename test scene to match contents
...
It does not only test "placement before track start" anymore.
2023-02-19 13:16:40 +01:00
Bartłomiej Dach
aac32a2c9f
Combine config and time checks into one
...
Functionally equivalent right now, but the combined variant is more
localised to what it actually needs to do, and less error-prone if
any new code gets appended to the method.
2023-02-19 13:14:51 +01:00
Maximilian Kruse
723a043c43
naming change from Hitobject to HitObject
2023-02-19 10:18:22 +01:00