53786 Commits

This Branch

This Branch

All Branches

• Fix scenario where import is expected to be empty
  Dean Herbert · 2022-07-25 23:59:27 +09:00
  d41ac36a69
• Fix test nullability assertions
  Dean Herbert · 2022-07-25 20:06:37 +09:00
  9c411c2250
• Fix some realm pieces not being cleaned up
  Dean Herbert · 2022-07-25 19:51:19 +09:00
  8a0c8f5fd8
• Add test coverage of actual update flow
  Dean Herbert · 2022-07-25 19:51:19 +09:00
  92dd1bcddb
• Move implementation of updating a beatmap to BeatmapImporter
  Dean Herbert · 2022-07-25 19:51:19 +09:00
  2e14d8730c
• Persist DateAdded over beatmap updates
  Dean Herbert · 2022-07-25 19:51:19 +09:00
  2363a3fb7b
• Ensure previous version prior to update loses online info after marked pending delete
  Dean Herbert · 2022-07-25 19:51:19 +09:00
  e5ad07454c
• Ensure scores are transferred after beatmap update if difficulty hash didn't change
  Dean Herbert · 2022-07-25 19:51:19 +09:00
  912218e123
• Fix old version of beatmap potentially not being deleted during update flow

  This can happen if the online IDs are not present in the `.osu` files.
  Previously this was only working due to the early logic in the import
  process (that relies on matching all online IDs perfectly).

  Dean Herbert · 2022-07-25 19:51:19 +09:00
  b7f6413bce
• Centralise calls to reset online info of a BeatmapInfo
  Dean Herbert · 2022-07-25 19:51:19 +09:00
  6a3e8e31de
• Add basic coverage of current behaviour of beatmap reimport
  Dean Herbert · 2022-07-25 19:51:19 +09:00
  ec477a3ebf
• Merge pull request #19371 from peppy/fix-working-cache-invalidation

  Fix calls to `GetWorkingBeatmap` invalidating cache too often

  Dan Balasescu · 2022-07-25 18:29:46 +09:00
  068063a43a
• Merge pull request #19373 from peppy/fix-negative-star-rating-display

  Fix star ratings which are still being calculated showing as "-1" at song select

  Dan Balasescu · 2022-07-25 18:20:30 +09:00
  1d48cee230
• Merge pull request #19374 from peppy/fps-counter-no-scheduler

  Refactor `FPSCounter` to not use scheduled tasks

  Dan Balasescu · 2022-07-25 18:19:59 +09:00
  6937296192
• Merge pull request #19367 from smoogipoo/log-diffcalc-failure

  Log beatmap difficulty retrieval failures during score calculation

  Salman Ahmed · 2022-07-25 11:49:55 +03:00
  35462a04a0
• Merge branch 'master' into log-diffcalc-failure
  Salman Ahmed · 2022-07-25 11:16:31 +03:00
  678acabf7e
• Merge pull request #19372 from frenzibyte/more-unprocessed-pp-handling

  Update more places to support displaying unprocessed PP placeholder

  Dean Herbert · 2022-07-25 16:45:54 +09:00
  3c12b357e6
• Refactor FPSCounter to not use scheduled tasks

  While on the surface this looks harmless (ignoring allocations),
  `Scheduler` doesn't clear cancelled tasks until they reach their
  execution time. This can cause an increase in time spent processing the
  scheduler itself.
  
  I don't think a per-frame updating component should use scheduled tasks
  in this way in the first place, so I've just rewritten the logic to
  avoid that overhead altogether.

  Dean Herbert · 2022-07-25 16:26:48 +09:00
  2dd99ef1fd
• Flip method to read better
  Salman Ahmed · 2022-07-25 10:03:06 +03:00
  4d90e6bbac
• Fix StarRatingDisplay not handling negative numbers as "pending"
  Dean Herbert · 2022-07-25 15:44:54 +09:00
  6bf2645b1a
• Add visual test coverage
  Salman Ahmed · 2022-07-25 09:40:20 +03:00
  6bdd1f43a2
• Display placeholder for user profile scores
  Salman Ahmed · 2022-07-25 09:40:20 +03:00
  e402e919ab
• Fix calls to GetWorkingBeatmap invalidating cache too often

  With recent changes, the pathway between refetching (on request) and
  refetching (on requirement due to unpopulated files) was combined.
  Unfortunately this pathway also added a forced invalidation, which
  should not have been applied to the second case.
  
  Closes https://github.com/ppy/osu/issues/19365.

  Dean Herbert · 2022-07-25 15:30:49 +09:00
  2ec90e37bb
• Add test coverage of WorkingBeatmap retrieval from BeatmapManager
  Dean Herbert · 2022-07-25 15:30:49 +09:00
  bbbc0a863f
• Display placeholder for leaderboard top scores
  Salman Ahmed · 2022-07-25 09:18:04 +03:00
  f54cee0270
• Separate unprocessed PP placeholder to own class
  Salman Ahmed · 2022-07-25 09:07:51 +03:00
  91d1c9686c
• Merge pull request #19343 from frenzibyte/beatmap-overlay-null-pp

  Display exclamation icon for online scores with unprocessed PP

  Dan Balasescu · 2022-07-25 14:45:15 +09:00
  fa1bc0fe0e
• Merge branch 'master' into beatmap-overlay-null-pp
  Salman Ahmed · 2022-07-25 07:38:59 +03:00
  7facd6d822
• Mark test score with null PP for visual testing
  Salman Ahmed · 2022-07-25 07:31:52 +03:00
  6c95c49da3
• Display exclamation triangle on scores with unprocessed PP
  Salman Ahmed · 2022-07-25 07:30:57 +03:00
  54eb2b98a9
• Merge pull request #19368 from smoogipoo/disable-timeline-test

  Disable timeline test for now

  Dean Herbert · 2022-07-25 13:21:10 +09:00
  40b76d7560
• Disable timeline test for now
  Dan Balasescu · 2022-07-25 13:20:33 +09:00
  0226b358ee
• Merge branch 'master' into beatmap-overlay-null-pp
  Salman Ahmed · 2022-07-25 07:18:03 +03:00
  3beb1da3de
• Merge pull request #19349 from bdach/mod-overlay/presets-column

  Implement basic appearance of mod preset column

  Dean Herbert · 2022-07-25 13:10:47 +09:00
  12e2e63a1c
• Log beatmap difficulty retrieval failures during score calculation
  Dan Balasescu · 2022-07-25 13:03:47 +09:00
  3d97b74813
• Merge pull request #19363 from frenzibyte/late-end-playing-signal

  Fix `Player` potentially disappearing in spectator list after restart

  Dan Balasescu · 2022-07-25 12:05:36 +09:00
  af8349e673
• Fix TestSceneReplayRecorder not using score provided by gameplay state
  Salman Ahmed · 2022-07-25 05:21:27 +03:00
  fa9daa6899
• Reword comment slightly
  Salman Ahmed · 2022-07-25 04:39:14 +03:00
  e0266b0d81
• Fix players potentially not displaying in spectator after restart
  Salman Ahmed · 2022-07-25 04:21:53 +03:00
  f5a5887669
• Add potentially failing test case
  Salman Ahmed · 2022-07-25 04:18:30 +03:00
  feef16b09b
• Move localisation string to common location
  Bartłomiej Dach · 2022-07-24 23:30:52 +02:00
  446485f804
• Add readonly modifier
  Bartłomiej Dach · 2022-07-24 23:29:18 +02:00
  8af9cfbe40
• Add basic mod preset column implementation
  Bartłomiej Dach · 2022-07-24 16:39:04 +02:00
  6a67d76d7c
• Extract base mod select column presentation logic
  Bartłomiej Dach · 2022-07-24 16:39:03 +02:00
  b2f8934117
• Merge pull request #19345 from frenzibyte/fix-slider-bar-crash

  Fix `OsuSliderBar` throwing on negative draw width

  Dean Herbert · 2022-07-24 19:36:19 +09:00
  08024e70eb
• Fix OsuSliderBar throwing on negative draw width
  Salman Ahmed · 2022-07-24 08:34:24 +03:00
  4332e6cae9
• Add failing test case
  Salman Ahmed · 2022-07-24 08:34:24 +03:00
  0c16ef3e2e
• Fix beatmap overlay leaderboard not handling null PP scores properly
  Salman Ahmed · 2022-07-24 04:20:49 +03:00
  7c477e6f22
• Merge pull request #19324 from peppy/background-processor-error-logging

  Add error logging for background processing failures

  Dean Herbert · 2022-07-24 07:38:26 +09:00
  2205e0dc3d
• Add error logging for background processing failures
  Dean Herbert · 2022-07-23 19:22:16 +09:00
  f1791e79e3