93 Commits

Author	SHA1	Message	Date
Bartłomiej Dach	1008d32ddb	Fix old looping samples not stopping when replacing a SkinnableSound's Samples ... Closes https://github.com/ppy/osu/issues/30365.	2024-10-22 14:35:21 +02:00
Dean Herbert	9d9e6fcfdb	Remove LINQ calls in hot paths	2024-01-07 14:31:22 +09:00
Bartłomiej Dach	b321d556b6	Enforce minimum gameplay sample volume of 5%	2023-10-20 15:50:13 +02:00
Terochi	edc6314634	Drank some coffee and figured out the fix	2023-03-15 10:49:59 +01:00
Terochi	b0f1a69523	Update the pauseLoop sample instantly on skin change	2023-03-15 09:05:34 +01:00
Terochi	a9c349fa6d	Cache any skin changes in SkinReloadableDrawable to ScheduledDelegate	2023-03-15 09:03:29 +01:00
Terochi	390ad335d0	Reloading samples before playing then when skin change occurs	2023-03-14 21:35:52 +01:00
Dean Herbert	74ab036f3e	Refactor SkinnableSound.Samples to be non-nullable	2023-01-27 19:32:30 +09:00
Dean Herbert	4352c56c3e	Apply NRT to all simple auxiliary skin classes	2023-01-26 17:53:04 +09:00
Dan Balasescu	7bc8908ca9	Partial everything	2022-11-27 00:00:27 +09:00
Dean Herbert	a215d009fe	Update Remove/RemoveRange/RemoveAll calls in line with framework changes	2022-08-29 15:57:40 +09:00
Dan Balasescu	f8830c6850	Automated #nullable processing	2022-06-17 16:37:17 +09:00
Dean Herbert	1eed2436e6	Clean up unused resolved properties	2021-12-03 18:49:49 +09:00
Dean Herbert	ca943a897a	Fix back to front initialisation order	2021-03-20 10:51:58 +09:00
Dean Herbert	c0c8b3e46c	Fix regression meaning SkinnableSound initialisation may never happen	2021-03-19 19:22:50 +09:00
Dean Herbert	0e821e857e	Remove unnecessary duplicated skin changed handling ... For some reason we were handling this both in `DrawableSkinnableSound` and `PoolableSkinnableSample` in very similar ways. Only one seems required.	2021-03-19 15:23:32 +09:00
smoogipoo	ee6a94273d	Merge branch 'master' into fix-unsafe-skinnable-sample-play	2021-02-22 18:31:27 +09:00
Dean Herbert	63dd55c92c	Add missing methods from updated audio component interface implementation	2021-02-22 14:18:52 +09:00
Dean Herbert	487a39eea9	Update interface implementations with framework changes	2021-02-18 18:52:34 +09:00
Dean Herbert	143e145670	Update implementation of AdjustableAudioComponents	2021-02-18 15:44:23 +09:00
smoogipoo	bdb9d4f7d0	Restart sound on play	2021-01-20 13:59:30 +09:00
smoogipoo	de9d075f94	Initial sample + samplechannel rework	2021-01-19 17:11:40 +09:00
Dean Herbert	ced7a36788	Update namespaces	2021-01-18 21:24:10 +09:00
Dean Herbert	8a6857f151	Add support for playing a SkinnableSample without restarting it	2021-01-15 17:16:12 +09:00
Bartłomiej Dach	f6d15b9757	Invert back-to-front logic	2020-12-06 18:59:38 +01:00
Bartłomiej Dach	fcd9483ffa	Merge branch 'master' into fix-multiple-playback-on-skin-change	2020-12-06 18:21:24 +01:00
smoogipoo	c29ad8edf8	Better API for dealing with the contained drawable samples	2020-11-30 19:26:25 +09:00
smoogipoo	afb8eb636d	Apply simple PR reviews	2020-11-30 18:40:22 +09:00
Dean Herbert	8080fe942c	Fix samples being played more than once on skin change	2020-11-20 20:38:26 +09:00
smoogipoo	7c83a27002	Add more xmldocs	2020-11-19 22:48:21 +09:00
smoogipoo	8a656f7cee	Fix missing SkinChanged event + safety	2020-11-19 22:42:44 +09:00
smoogipoo	d388c44428	Cleanup, refactoring, and restart sample on skin change	2020-11-19 22:30:21 +09:00
smoogipoo	0287269b2f	Fix volume discrepancies	2020-11-19 21:21:30 +09:00
smoogipoo	70cb197957	Cleanups	2020-11-19 20:38:36 +09:00
smoogipoo	812d5d59b1	Fix looping not being propagated	2020-11-19 20:29:09 +09:00
smoogipoo	003fed857c	Separate files	2020-11-19 19:52:34 +09:00
smoogipoo	730b14b5bb	Add initial hit sample pooling	2020-11-19 19:51:09 +09:00
Dean Herbert	0b28cca7e6	Don't force Gameplay prefix on all skin sample lookups	2020-10-30 11:59:40 +09:00
Dean Herbert	367b35bb10	Merge branch 'master' into fix-storyboard-sample-pausing	2020-09-30 22:42:26 +09:00
Dean Herbert	414c40d298	Reverse inheritance order of SkinnableSound's pause logic	2020-09-30 15:45:14 +09:00
Dean Herbert	136843c8e4	Make DrawableStoryboardSample a SkinnableSound ... Allows sharing pause logic with gameplay samples.	2020-09-29 14:25:39 +09:00
Dean Herbert	74e74e1c31	Fix pause loop sound not working because paused	2020-09-29 14:20:41 +09:00
Dean Herbert	d6f3beffb6	Use existing bindable flow instead	2020-09-29 12:50:17 +09:00
Salman Ahmed	735b6b0d6f	Remove a pointless portion of the inline comment	2020-09-19 05:54:40 +03:00
Salman Ahmed	35c7677d0a	Fix gameplay samples potentially start playing while player is paused	2020-09-16 01:59:07 +03:00
Dean Herbert	365aae799e	Merge branch 'master' into fix-skinnable-sound-mute	2020-08-10 23:55:51 +09:00
Dean Herbert	ffb2e56a8d	Reverse direction of bool to make mental parsing easier	2020-08-08 23:25:52 +09:00
Dean Herbert	0d1f273603	Merge branch 'master' into fix-skinnable-sound-mute	2020-08-08 23:24:03 +09:00
Dean Herbert	1090137da3	Adjust comment to read better ... Co-authored-by: Bartłomiej Dach <dach.bartlomiej@gmail.com>	2020-08-08 23:23:02 +09:00
Dean Herbert	c84452cfbf	Update usages	2020-08-06 21:53:20 +09:00