1757 Commits

• Fix rider EAP new naming inspections
  Dean Herbert · 2025-05-25 20:39:55 +09:00
  5e3fd7a42a
• Expose total scores count from backend
  Salman Alshamrani · 2025-05-22 00:57:49 +03:00
  6bc407310e
• Merge pull request #32972 from bdach/multiplayer-position-indicator

  Add non-skinnable position indicator to multiplayer player

  Dean Herbert · 2025-05-13 20:53:15 +09:00
  3ce5389558
• Fix test not showing immediately useful state

  Also standardises the testing leaderboard provider component for
  (immediate) future use.

  Dean Herbert · 2025-05-13 15:53:47 +09:00
  1d7f922068
• Merge pull request #33075 from bdach/do-not-allow-reading-garbage-from-hitwindows

  Fix `HitWindows.WindowFor()` returning values for invalid results

  Dean Herbert · 2025-05-09 22:24:26 +09:00
  afe8ab842d
• Fix HitWindows.WindowFor() returning values for invalid results

  This fell out of my work on hit window-related replay issues. In my WIP
  branch (that is probably going to get PR'd as draft soon) I refactored
  `HitWindows` and found a few straggling test failures due to some places
  reading hit windows for results that were not actually supported by the
  underlying `HitWindows` implementations, leading to returning garbage
  (mostly zeroes).
  
  Importantly, there is one actual usage in game code with impact here -
  `TaikoModSingleTap` was attempting to read the hit window for MEH, when
  MEH was never actually a valid hit result in taiko (OK is). This was a
  result of a copy-paste oversight from osu!, specifically from
  
  	https://github.com/ppy/osu/blob/51cf835fb6300aca53b5b98143d606f64d7a4d49/osu.Game.Rulesets.Osu/Mods/InputBlockingMod.cs#L58

  Bartłomiej Dach · 2025-05-09 09:40:20 +02:00
  ceb58a1141
• Fix gameplay leaderboard not always being expanded in gameplay leaderboard

  I'd have preferred a `get; init;` property but tests were also attached
  at the hip to the public bindable. Without some extra composition this
  is the best that I can do.

  Bartłomiej Dach · 2025-05-07 12:09:26 +02:00
  8cc2af4060
• Merge branch 'master' into gameplay-leaderboard-skinnable
  Bartłomiej Dach · 2025-05-07 10:45:51 +02:00
  5b61761bbd
• Merge pull request #32947 from bdach/use-actual-score-positions-in-gameplay-leaderboard

  Use actual score positions in gameplay leaderboard

  Dean Herbert · 2025-04-30 17:20:12 +09:00
  1b5553a2d8
• Merge branch 'master' into gameplay-leaderboard-skinnable
  Bartłomiej Dach · 2025-04-28 13:11:22 +02:00
  4ad86685e0
• Remove failing test

  The sorting logic is now exercised in
  `TestSceneSoloGameplayLeaderboardProvider`. Trying to work around
  it with local test classes would mean that the test would be covering
  test code, i.e. complete nonsense and having a green test for the sake
  of having a green test.

  Bartłomiej Dach · 2025-04-28 12:32:41 +02:00
  c1fbf50622
• Adjust variables for legibility

  I found the previous way things were written a bit awkward. Easier to
  just enforce non-null here.

  Dean Herbert · 2025-04-26 05:18:24 +09:00
  0301463810
• Fix filename not matching test scene
  Dean Herbert · 2025-04-26 04:51:03 +09:00
  0287ca285c
• Add test coverage of new behaviour of solo gameplay leaderboard
  Bartłomiej Dach · 2025-04-25 12:45:28 +02:00
  7822412c42
• Use actual score positions in gameplay leaderboard

  Intends to close https://github.com/ppy/osu/issues/32859.
  
  The difference between this and https://github.com/ppy/osu/pull/32942 is
  that this PR takes the approach of completely moving the score sorting
  behaviour to `IGameplayLeaderboardProvider` implementations.
  
  This is going to be helpful for further work - to be precise, I am
  looking to add a leaderboard position indicator in the bottom right of
  multiplayer player to match stable, and having the position in the
  provider will make the implementation of that *much* easier.

  Bartłomiej Dach · 2025-04-25 12:40:55 +02:00
  06dc4235f0
• Delete no-longer-relevant test
  Bartłomiej Dach · 2025-04-24 14:50:09 +02:00
  242f1bf68f
• Remove (currently) unused resolved dependency
  Bartłomiej Dach · 2025-04-24 13:23:00 +02:00
  9818f859cb
• Convert gameplay leaderboard to skinnable component

  This PR converts the leaderboard into a full-fledged skinnable component
  that can be manipulated by users at will.
  
  Notably, this finally allows https://github.com/ppy/osu/issues/20422 to
  be fixed - although it's a very mixed bag, for several reasons:
  
  - Because of taiko players' refusal to see reason^W^W^W^Winsistence on
    keeping stable behaviours related to aspect ratio treatment, I have to
    assume the worst case scenario, which means than on typical
    resolutions like 16:9 (or even worse, 4:3), the leaderboard will
    likely not occupy as much vertical space as it probably could.
  
  - Additionally, there's the problem of where to put the spectator list.
    I settled on putting it to the right of the leaderboard, but that's
    kind of janky, because the leaderboard sometimes collapses and
    sometimes fully hides, leading to a very awkward space left behind. If
    we had the capability to anchor elements to other elements, maybe this
    could be resolved, but for now, I'm not sure what to do. I think if
    some users are bothered by it they can move it where they want it. Or
    delete it.

  Bartłomiej Dach · 2025-04-24 13:10:30 +02:00
  59b826c321
• Add test scene coverage of HUD layouts on various ruleset/skin combinations

  As time goes on, default skin layouts are getting more and more
  complicated because of per-ruleset overrides. This was already sort of
  apparent in https://github.com/ppy/osu/pull/31527, and I'm about to make
  it worse, so before I do, this is a test scene that is supposed to make
  it easier to check all possible combinations at a glance.

  Bartłomiej Dach · 2025-04-24 12:50:34 +02:00
  33f45b0a6d
• Merge branch 'master' into leaderboards/gameplay-provider
  Bartłomiej Dach · 2025-04-21 09:03:24 +02:00
  6b0567e882
• Add failing test coverage
  Bartłomiej Dach · 2025-04-18 14:21:50 +02:00
  20b2cc8251
• Remove unnecessary interface
  Bartłomiej Dach · 2025-04-18 12:12:21 +02:00
  6d258d4ed5
• Add failing test for incorrect score position treatment
  Bartłomiej Dach · 2025-04-18 12:01:04 +02:00
  39f9eabf40
• Fix code quality
  Bartłomiej Dach · 2025-04-18 09:09:57 +02:00
  2c690ae94c
• Separate gameplay leaderboard data management from display

  This is a prerequisite for supporting skinning of leaderboards.
  
  - New `IGameplayLeaderboardProvider` and `IGameplayLeaderboardScore`
    interfaces are introduced. They are strictly concerned with supplying
    leaderboard data.
  
  - Logic of managing display, which was previously jammed into the
    inheritance hierarchy of `GameplayLeaderboard`, is now moved into
    `IGameplayLeaderboardProvider` implementations. Solo play,
    multiplayer, and multiplayer spectator get their own implementation of
    the interface.
  
  - The inheritance hierarchy of `GameplayLeaderboard` and per-player
    overriding of the implementation of the gameplay leaderboard is gone.
    Only one drawable class (renamed to `DrawableGameplayLeaderboard`) is
    allowed to display the leaderboards, across all modes of play.

  Bartłomiej Dach · 2025-04-16 14:46:55 +02:00
  c231571f06
• Merge pull request #32601 from sineplusx/median-offset

  Use median instead of mean for average hit error calculations

  Dean Herbert · 2025-04-03 18:56:04 +09:00
  db0811bad9
• Add failing test case

  Co-authored-by: Rodrigo Correia <rodrigo.figueiredo.correia@tecnico.ulisboa.pt>

  Bartłomiej Dach · 2025-03-31 14:25:35 +02:00
  79375eccb7
• Adapt TestNotEnoughTimedHitEvents with new minimum hit amount
  sineplusx · 2025-03-29 20:43:59 +01:00
  403b24ef9b
• Fix LetterboxOverlay not handling its own visibility
  Dean Herbert · 2025-03-12 17:46:18 +09:00
  77aac2922f
• Fix storyboard letterbox hiding HUD elements

  Addresses https://github.com/ppy/osu/discussions/29788.

  Dean Herbert · 2025-03-12 14:20:16 +09:00
  72854d0ae6
• Disable user customisation of spectator list font / colour

  It's all a bit weird so let's just disable it for now. For instance,
  this is exposed as "text" font / colour but only affects the header.
  Also, no other headers are cusotmisable in similar components.

  Dean Herbert · 2025-03-10 15:19:34 +09:00
  3cb32c38ad
• Fix test
  Dan Balasescu · 2025-02-11 21:28:21 +09:00
  8c85616d1c
• Fix spectator list showing other users in multiplayer room even if they're not spectating
  Bartłomiej Dach · 2025-02-10 11:17:17 +01:00
  ad642b8425
• Add test coverage for scores with zero total not submitting
  Bartłomiej Dach · 2025-02-07 08:21:34 +01:00
  a49b1b61b4
• Expose GameplayStartTime in IGameplayClock
  Dean Herbert · 2025-01-24 15:29:49 +09:00
  5cc8181bad
• Merge spectator list classes into one skinnable
  Bartłomiej Dach · 2025-01-17 11:23:14 +01:00
  3c4bfc0a01
• Merge branch 'spectator-list-visuals' into spectator-list-ready
  Bartłomiej Dach · 2025-01-16 15:13:04 +01:00
  0c54853710
• Adjust test to work better when running in sequence
  Dean Herbert · 2025-01-16 18:56:21 +09:00
  56dfe4a231
• Add client methods allowing users to be notified of who is watching them
  Bartłomiej Dach · 2025-01-15 14:18:01 +01:00
  43fc48a3f3
• Implement spectator list display

  - First step for https://github.com/ppy/osu/issues/22087
  - Supersedes / closes https://github.com/ppy/osu/pull/22795
  
  Roughly uses design shown in
  https://github.com/ppy/osu/pull/22795#issuecomment-1579936284 with some
  modifications to better fit everything else, and some customisation
  options so it can fit better on other skins.

  Bartłomiej Dach · 2025-01-15 14:17:53 +01:00
  582c5180b9
• Add reason for making test interactive-only
  Dean Herbert · 2025-01-09 13:33:55 +09:00
  0fe6b4be0d
• Add test showing that rate adjustments cause discrepancies in replay frame precision
  Dean Herbert · 2025-01-09 13:30:04 +09:00
  2a7a3d932e
• Add test covering required behaviour

  See https://github.com/ppy/osu/issues/30885.

  Dean Herbert · 2025-01-02 16:20:09 +09:00
  2d3595f768
• Silence test that apparently can't work on CI
  Bartłomiej Dach · 2024-12-20 11:20:32 +01:00
  3ec63d00cb
• Add test coverage
  Bartłomiej Dach · 2024-12-16 16:03:26 +09:00
  68a5618e81
• Merge branch 'master' into netcore-analyzer
  Huo Yaoyuan · 2024-12-05 17:18:56 +08:00
  d92ea910cf
• Fix CA1865
  Huo Yaoyuan · 2024-11-30 02:32:09 +08:00
  68f21709a8
• Merge branch 'master' into beatmap-info-purge
  Dean Herbert · 2024-11-22 18:47:32 +09:00
  086a34f5c0
• Add failing test case
  Dean Herbert · 2024-11-21 02:27:57 +09:00
  945139635f
• Merge pull request #30623 from peppy/fix-flash-transition-player

  Fix occasional flash when quick exiting / retrying from player

  Bartłomiej Dach · 2024-11-15 08:42:43 +01:00
  21d407680b