52431 Commits

This Branch

This Branch

All Branches

• Rename variables and remove unnecessary nested call to GetFullPath
  Dean Herbert · 2022-06-15 15:05:51 +09:00
  cca7633e59
• Fix test files stream not disposed after creation
  Salman Ahmed · 2022-06-15 08:24:20 +03:00
  3d638abc52
• Handle subdirectories during beatmap stable import
  Salman Ahmed · 2022-06-15 07:33:21 +03:00
  22c09ec893
• Add failing test case
  Salman Ahmed · 2022-06-15 07:33:21 +03:00
  ee8045d507
• Merge pull request #18669 from peppy/fix-hit-error-when-not-visible

  Fix hit error meters not updating visual state when hidden

  Salman Ahmed · 2022-06-15 00:39:19 +03:00
  674a9bb399
• Merge branch 'master' into fix-hit-error-when-not-visible
  Salman Ahmed · 2022-06-14 23:58:15 +03:00
  9517e0f789
• Merge pull request #15702 from jaxxibae/master

  Add "View beatmap" button to Discord Rich Presence

  Bartłomiej Dach · 2022-06-14 22:34:40 +02:00
  a8f5daa2f1
• Merge branch 'master' into fix-hit-error-when-not-visible
  Salman Ahmed · 2022-06-14 22:47:11 +03:00
  36599d1174
• Merge branch 'master' into master
  Bartłomiej Dach · 2022-06-14 21:47:07 +02:00
  439ce63eb1
• Merge pull request #18691 from peppy/toolbar-scrolling-ruleset-selection

  Allow scrolling overflow of ruleset buttons in the toolbar

  Bartłomiej Dach · 2022-06-14 21:43:00 +02:00
  54eb2083c0
• Merge branch 'master' into toolbar-scrolling-ruleset-selection
  Bartłomiej Dach · 2022-06-14 20:25:06 +02:00
  300663684c
• Always use current ruleset to ensure URL is valid
  Dean Herbert · 2022-06-15 02:38:44 +09:00
  c55c7becba
• Remove call to RegisterUriScheme

  Seems both unnecessary, and crashes the whole came on macOS.

  Dean Herbert · 2022-06-15 02:27:51 +09:00
  1951eb30bc
• Fix up code quality, use more correct URL and update button text
  Dean Herbert · 2022-06-15 02:25:06 +09:00
  0d36495cfc
• Merge pull request #18690 from frenzibyte/toolbar-block-scroll

  Block scroll input from passing through game toolbar

  Dean Herbert · 2022-06-15 02:23:28 +09:00
  7861043202
• Merge branch 'master' into jaxxibae/master
  Dean Herbert · 2022-06-15 02:15:24 +09:00
  cf82843e3d
• Allow scrolling overflow of ruleset buttons in the toolbar
  Dean Herbert · 2022-06-15 01:43:10 +09:00
  49ec2572b8
• Allow Toolbar to block scroll input from passing through
  Salman Ahmed · 2022-06-14 19:10:13 +03:00
  d89c11e49e
• Add failing test case
  Salman Ahmed · 2022-06-14 19:10:13 +03:00
  cd74f22e12
• Fix AlwaysPresent specification in wrong container
  Dean Herbert · 2022-06-15 01:04:43 +09:00
  6be4209458
• Merge pull request #18688 from peppy/too-many-import-methods

  Various clean-up on model managers / importer classes

  Dean Herbert · 2022-06-15 00:12:33 +09:00
  cf2238f683
• Merge pull request #18687 from peppy/editor-repeat-behaviour-change-collapsing

  Fix timing adjustment repeat buttons firing one change per repeat invocation

  Dan Balasescu · 2022-06-14 20:24:13 +09:00
  cc7943dfb1
• Remove one more usage of lowPriority
  Dean Herbert · 2022-06-14 20:21:28 +09:00
  94ba71aa13
• Merge pull request #18685 from peppy/fix-editor-z-key

  Fix ctrl-z in editor also seeking to start in addition to undo

  Dean Herbert · 2022-06-14 20:12:42 +09:00
  c179a13d25
• Remove duplicate implementation of same thing
  Dean Herbert · 2022-06-14 20:01:11 +09:00
  6250caca29
• Move and correct xmldoc to interfaces
  Dean Herbert · 2022-06-14 20:00:16 +09:00
  e96c5ce703
• Move methods around to make more sense
  Dean Herbert · 2022-06-14 20:00:08 +09:00
  84e526a2d9
• Remove unused lowPriority flag from one Import method
  Dean Herbert · 2022-06-14 19:52:30 +09:00
  9f599a5ab4
• Tidy up various delegation implementations
  Dean Herbert · 2022-06-14 19:46:59 +09:00
  ca0765a932
• Remove unused methods from IModelImporter

  All the xmldoc is already present in `RealmArchiveModelImporter` so
  nothing is lost here.

  Dean Herbert · 2022-06-14 19:42:11 +09:00
  d73c0ca659
• Fix timing adjustment repeat buttons firing one change per repeat invocation
  Dean Herbert · 2022-06-14 19:21:02 +09:00
  c30644328c
• Fix ctrl-z in editor also seeking to start in addition to undo
  Dean Herbert · 2022-06-14 18:48:57 +09:00
  aeca138930
• Add test coverage of HUD components still getting updated when hidden
  Dean Herbert · 2022-06-14 18:35:49 +09:00
  0147a8ecee
• Ensure containers which are being used to hide HUD elements still update for now

  I don't think this is necessarily a final solution (as this means all
  HUD elements are adding overhead even when not visible), but this will
  make the implementations much easier for the time being.
  
  I've checked and can't notice any perceivable overhead in profiling so
  we should be fine for now.

  Dean Herbert · 2022-06-14 18:22:25 +09:00
  a20e43c2ae
• Revert most unnecessary changes

  Turns out `AlwaysPresent` at top level is actually enough.
  
  This reverts commit 86163d2225.

  Dean Herbert · 2022-06-13 23:58:14 +09:00
  bd9ea9bd6f
• Merge pull request #18458 from apollo-dw/evaluators

  Move individual object difficulty calculations to separate methods in osu!

  Dan Balasescu · 2022-06-13 22:23:17 +09:00
  0771265caf
• Remove for loop
  Dan Balasescu · 2022-06-13 20:43:56 +09:00
  f73142c50f
• Fix ever-increasing flashlight-strain
  Dan Balasescu · 2022-06-13 20:41:32 +09:00
  b300bc1e24
• Merge remote-tracking branch 'master/master' into evaluators
  apollo-dw · 2022-06-13 12:27:02 +01:00
  4e3dd1ce18
• Merge branch 'master' into evaluators
  apollo-dw · 2022-06-13 12:16:22 +01:00
  add9b4a7a4
• Merge pull request #18674 from peppy/remvoe-unnecessary-existing-check

  Remove unnecessary file existence check in model import process

  Bartłomiej Dach · 2022-06-13 12:52:21 +02:00
  54980cbfc1
• Remove unnecessary file existence check

  This is not required due to `createFileInfos` always being run before we
  get to this point (I believe this was added after the initial code to
  check existence was added).
  
  This flow is covered in
  `BeatmapImportTests.TestImportThenReimportAfterMissingFiles`, which
  still passes with the change.
  
  While this check isn't doing any harm, as I'm going through the flow for
  import-skipping, less checks are appreciated.

  Dean Herbert · 2022-06-13 18:57:30 +09:00
  336df62a1f
• Merge pull request #18671 from peppy/latency-scrolling-gameplay

  Add scrolling gameplay visualisation mode to latency certifier

  Dan Balasescu · 2022-06-13 18:46:46 +09:00
  b88461b3c9
• Merge pull request #18368 from apollo-dw/dho

  Move object history in difficulty calculation to the object itself

  Dan Balasescu · 2022-06-13 17:31:08 +09:00
  7ac8ba0a74
• Add scrolling gameplay visualisation mode to latency certifier
  Dean Herbert · 2022-06-13 17:18:32 +09:00
  f997886142
• Merge pull request #18667 from peppy/remove-unlimited-frames-warning

  Remove unlimited frame limiter warning

  Dean Herbert · 2022-06-13 16:40:36 +09:00
  fd09760421
• Fix hit error meters not updating visual state when hidden

  It is an expectation of users that when the HUD is shown after a period
  of being hidden, it will visually reflect the state based on recent
  judgements.
  
  To achieve this, I've added `AlwaysPresent` and moved the transform
  application to the meter level, rather than at a child level. If this is
  seen as a bad direction, `AlwaysPresent` can be applied to the drawable
  children and the transforms can be moved back.
  
  Also of note, `ColourHitErrorMeter` is pretty weird. The flow class
  could potentially be removed and reduce `AlwaysPresent` usage by one.
  Can do that refactor as part of this PR if preferred.
  
  Closes #18624.

  Dean Herbert · 2022-06-13 16:38:57 +09:00
  86163d2225
• Add failing test coverage showing hit meters don't update when not visible
  Dean Herbert · 2022-06-13 16:36:22 +09:00
  17eaf7bb5c
• Remove unlimited frame limiter warning

  This should not be required now that we have a 1,000 Hz limiter in
  place.

  Dean Herbert · 2022-06-13 15:40:27 +09:00
  77fcf35d1d
• Merge pull request #18664 from smoogipoo/font-matching-refactor

  Match family string via GetFamilyString()

  Dean Herbert · 2022-06-13 13:17:11 +09:00
  5b5caa88a0