817 Commits

• Fix timeline potentially scrolling at extents while not dragging
  Salman Ahmed · 2022-11-18 09:43:16 +03:00
  90cd386323
• Fix editor hard crash when beatmap file specified out-of-range timeline zoom value
  Dean Herbert · 2022-11-07 12:54:02 +09:00
  f6d93fcd5a
• Fix time snap of sliders not matching when SV is not 1.0x

  This regressed with https://github.com/ppy/osu/pull/20850 because the
  function was used in other places which expect it to factor slider
  velocity into the equation.
  
  Rather than reverting, I've added a new argument, as based on the method
  naming alone it was hard to discern whether SV should actually be
  considered.
  
  The reason for the change in #20850 was to avoid the SV coming in from a
  reference object which may not have a correct SV in the first place. In
  such cases, passing `false` to the function will give the expected
  behaviour.

  Dean Herbert · 2022-11-01 15:12:58 +09:00
  2a88409dfe
• Reuse function TimeAtPosition() and PositionAtTime().
  andy840119 · 2022-10-30 17:21:50 +08:00
  a753369d3e
• Offset start of distance snap grid drawing if reference object's start time doesn't align

  Closes #20938.

  Dean Herbert · 2022-10-26 13:11:26 +09:00
  2016d33055
• Add ability to use Shift+Number to set current beat divisor in editor
  Dean Herbert · 2022-10-24 15:20:15 +09:00
  1d5df15027
• Reorganise beatmap snap control to work better in compact mode
  Dean Herbert · 2022-10-13 15:47:54 +09:00
  c3902728f6
• Reorder and rename toggle checkboxes to fit better
  Dean Herbert · 2022-10-13 15:44:33 +09:00
  a525b3f9f8
• Merge branch 'master' into improve-drag-selection
  Dean Herbert · 2022-10-12 13:20:17 +09:00
  ab24e87013
• Refactor blueprint container drag code
  ekrctb · 2022-10-11 22:39:53 +09:00
  fcb9e2cc00
• Avoid casting by accepting all Playfields but throwing on a bad choice
  Dean Herbert · 2022-10-11 16:54:41 +09:00
  f41b79688f
• Anchor drag box on time (catch, mania)

  Not done for taiko because I cannot figure out how it should work with the overlapping scroll algorithm.

  ekrctb · 2022-10-11 14:23:17 +09:00
  6ab29a62d0
• Improve drag box selection logic

  `AllowDeselectionDuringDrag` is remove.
  Instead, selected hit objects are not automatically deselected
  when clock is seeked to a later time (the hit object is dead).
  Update drag box selection even if mouse is not moved
  (in case clock is running or scroll wheel is used).

  ekrctb · 2022-10-11 14:11:45 +09:00
  1a24762f9b
• Don't reselect already selected items in SelectAll
  ekrctb · 2022-10-07 10:46:07 +09:00
  6164e0896a
• Ensure blueprint is added for selected hit object
  ekrctb · 2022-10-06 13:59:54 +09:00
  29cc554632
• Fix items without blueprints are not deselected
  ekrctb · 2022-10-06 13:50:56 +09:00
  0d448e6cc8
• Use mid time instead of start time

  It is closer to the old blueprint-based behavior

  ekrctb · 2022-10-05 22:19:22 +09:00
  b0213c29e9
• Move AllowDeselectionDuringDrag down

  Because it is now ignored in the timeline implementation anyways

  ekrctb · 2022-10-05 22:14:11 +09:00
  6753f6b01a
• Fix inspect issues
  ekrctb · 2022-10-05 22:04:43 +09:00
  3108c42ece
• Improve timeline selection performance

  But selecting a large number of hit objects is still very slow
  because all DHOs must be added
  and also `AddBlueprintFor` has quadratic behaviors

  ekrctb · 2022-10-05 21:58:05 +09:00
  00b3d97f69
• Make sure all selected items get deleted
  ekrctb · 2022-10-05 21:58:05 +09:00
  0613388aaa
• Use hit object time for timeline selection
  ekrctb · 2022-10-05 21:51:01 +09:00
  0ffde02f79
• Move selection logic from DragBox to BlueprintContainer
  ekrctb · 2022-10-05 21:51:01 +09:00
  8d29e9e76b
• Fix weird conditional
  Dean Herbert · 2022-09-27 20:09:21 +09:00
  58217b6839
• Add assert/log output when too many ticks are being displayed
  Dean Herbert · 2022-09-27 17:18:46 +09:00
  a9088d9231
• Don't attempt to render timeline ticks until DrawWidth is above zero
  Dean Herbert · 2022-09-27 17:18:46 +09:00
  e227519b09
• Ensure ZoomableScrollContainer content isn't shown until zoom is set
  Dean Herbert · 2022-09-27 17:07:11 +09:00
  ccae721af2
• Remove unused static
  Dean Herbert · 2022-09-27 17:04:56 +09:00
  9dc0eb7fd0
• Create a test and a check if initial zoom value of ZoomableScrollContainer is in range
  Drison64 · 2022-09-17 22:43:40 +02:00
  c075d3de08
• Update osu.Game/Screens/Edit/Compose/Components/Timeline/Timeline.cs

  Co-authored-by: Salman Ahmed <frenzibyte@gmail.com>

  Ondřej Vajďák · 2022-09-17 19:51:44 +02:00
  9d94343317
• Changed == to <= on TimelineZoom check
  Drison64 · 2022-09-17 19:00:50 +02:00
  c8768eb399
• Update
  Drison64 · 2022-09-17 18:57:09 +02:00
  3c7ea5c8fa
• Rename event to be more generic (and add comprehensive xmldoc)
  Dean Herbert · 2022-09-13 14:59:30 +09:00
  f53507828c
• fix with new event
  OliBomby · 2022-09-13 02:20:52 +02:00
  fd48249eef
• Enable nullability on TimelineHitObjectBlueprint
  Dean Herbert · 2022-09-05 14:50:43 +09:00
  57954bb8f5
• Merge branch 'master' into remove-dispose-updates
  Dean Herbert · 2022-09-01 23:03:19 +09:00
  6a35b233e5
• Merge pull request #20009 from frenzibyte/fix-back-to-front-comparison

  Adjust weirdly back-to-front fallback comparison in `HitObjectOrderedSelectionContainer`

  Dean Herbert · 2022-08-31 14:14:10 +09:00
  cfc7c32aff
• Update Remove/RemoveRange/RemoveAll calls in line with framework changes
  Dean Herbert · 2022-08-29 15:57:40 +09:00
  a215d009fe
• Fix back-to-front fallback comparison in HitObjectOrderedSelectionContainer
  Salman Ahmed · 2022-08-29 09:23:53 +03:00
  3ff2058975
• Remove Track access in Timeline
  Dean Herbert · 2022-08-26 18:25:48 +09:00
  cd90536e4b
• Remove unused method
  Dan Balasescu · 2022-07-26 14:15:59 +09:00
  1b2158ff04
• Mark SetupZoom and parameterless ZoomableScrollContainer ctor as protected
  Salman Ahmed · 2022-07-25 12:07:50 +03:00
  48bcf57066
• Fix Timeline attempting to setup zoom with unloaded track
  Salman Ahmed · 2022-07-25 12:07:50 +03:00
  07c6b44864
• Refactor ZoomableScrollContainer to allow setting up zoom range and initial zoom after load
  Salman Ahmed · 2022-07-25 12:07:50 +03:00
  123930306b
• Fix timeline zoom focus point when using buttons
  Dan Balasescu · 2022-07-22 17:03:05 +09:00
  e1df50c8ff
• Merge pull request #19294 from peppy/fix-timeline-feedback-loop

  Fix timeline `alt`+`scroll` zoom not correctly zooming to current mouse position

  Dean Herbert · 2022-07-22 16:05:38 +09:00
  72916d708c
• Fix timeline zoom receiving feedback from bindable changes

  This causes the focal point zooming to not work (as the focal point is
  lost). There's no need to handle ongoing changes to
  `BeatmapInfo.TimelineZoom` because it is not a property which is changed
  at runtime.

  Dean Herbert · 2022-07-22 15:25:57 +09:00
  6eb42d08ce
• Combine both calls to use same pathway
  Dean Herbert · 2022-07-22 14:59:20 +09:00
  4cec9a085a
• Fix zoom delta math
  Adam Baker · 2022-07-21 17:29:13 -05:00
  997fe00cdc
• Extract zoom delta method
  Adam Baker · 2022-07-21 17:28:43 -05:00
  d69dc457ba