83 Commits

• Fix Simplified Rhythm mod breaking diffcalc when applied to some maps (#36947)

  - closes https://github.com/ppy/osu/issues/36942
  - fixes https://osu.ppy.sh/community/forums/topics/2187041?n=1
  
  ## [Ensure Simplified Rhythm mod does not produce beatmaps with objects
  out of
  order](https://github.com/ppy/osu/commit/f4807b3a42dbf46ea0e669b0ba658feaef9baca5)
  
  This is a last ditch safety.
  
  This mod has more apparent issues (see below) but this is a first step
  of restoring sanity.
  
  Aside than the other fix described below I have not attempted to figure
  out further why this is happening because the conversion logic is in
  over my head. I just want hard breakage to not be possible. Why this
  extra sort is necessary can be investigated by @Hiviexd if he's so
  inclined.
  
  ## [Fix `GetClosestBeatDivisor()` not working correctly with negative
  time
  instants](https://github.com/ppy/osu/commit/88dc0d8a73c712a040635af262d7519fe6d772a0)
  
  This was causing the 1/3 -> 1/2 conversion in Simplified Rhythm to
  engage on some maps that weren't even mapped in waltz time. Those maps
  had the common trait of having a timing point with a negative start
  time.
  
  Notably this could feasibly affect other places as well, like mania beat
  snap colouring, or the Synesthesia osu! mod.
  
  <details>
  
  <summary>testing</summary>
  
  Tested with Simplified Rhythm engaged, with 1/6 -> 1/4 and 1/3 -> 1/2
  conversion enabled
  
  [BULANOVA - NE PLACH'
  [oni]](https://osu.ppy.sh/beatmapsets/1740291#taiko/3664995) (1/8 snap):
  - No mods: 5.18*
  - Simplified Rhythm @ master: 0.00*
  - Simplified Rhythm @ f4807b3a: 3.48*
  - Simplified Rhythm @ 933de7ab: 5.18*
  
  [BULANOVA - NE PLACH' [inner
  oni]](https://osu.ppy.sh/beatmapsets/1740291#taiko/3648625) (1/8 snap):
  - No mods: 5.84*
  - Simplified Rhythm @ master: 0.00*
  - Simplified Rhythm @ f4807b3a: 4.13*
  - Simplified Rhythm @ 933de7ab: 5.84*
  
  [BULANOVA - NE PLACH' [don't
  cry]](https://osu.ppy.sh/beatmapsets/1740291#taiko/3557681) (1/8 snap):
  - No mods: 6.91*
  - Simplified Rhythm @ master: 0.00*
  - Simplified Rhythm @ f4807b3a: 4.84*
  - Simplified Rhythm @ 933de7ab: 6.91*
  
  [Mili - Peach Pit and Cyanide [nik's
  Normal]](https://osu.ppy.sh/beatmapsets/2468654#osu/5405909) (1/6 snap):
  - No mods: 1.63*
  - Simplified Rhythm @ master: 0.00*
  - Simplified Rhythm @ f4807b3a: 1.10*
  - Simplified Rhythm @ 933de7ab: 1.10*
  
  [Mili - Peach Pit and Cyanide [Ix's
  Hard]](https://osu.ppy.sh/beatmapsets/2468654#osu/5405906) (1/3 snap):
  - No mods: 2.50*
  - Simplified Rhythm @ master: 0.00*
  - Simplified Rhythm @ f4807b3a: 1.71*
  - Simplified Rhythm @ 933de7ab: 1.71*
  
  [Mili - Peach Pit and Cyanide [nomi's Hidden
  Insane]](https://osu.ppy.sh/beatmapsets/2468654#osu/5405910) (1/3 snap):
  - No mods: 3.93*
  - Simplified Rhythm @ master: 0.00*
  - Simplified Rhythm @ f4807b3a: 2.59*
  - Simplified Rhythm @ 933de7ab: 2.59*
  
  [Within Temptation - The Unforgiving [Stairway To The
  Skies]](https://osu.ppy.sh/beatmapsets/29157#osu/172617) (1/3 snap in
  editor):
  - No mods: 1.53*
  - Simplified Rhythm @ master: 0.00*
  - Simplified Rhythm @ f4807b3a: 1.48*
  - Simplified Rhythm @ 933de7ab: 1.48*
  
  [Within Temptation - The Unforgiving
  [Iron]](https://osu.ppy.sh/beatmapsets/29157#osu/172612) (1/6 snap in
  editor):
  - No mods: 2.76*
  - Simplified Rhythm @ master: 0.00*
  - Simplified Rhythm @ f4807b3a: 1.75*
  - Simplified Rhythm @ 933de7ab: 1.75*
  
  [Within Temptation - The Unforgiving
  [Marathon]](https://osu.ppy.sh/beatmapsets/29157#osu/156352) (1/4 snap
  in editor, but has 1/3 / 1/6 sections for sure):
  - No mods: 2.96*
  - Simplified Rhythm @ master: 0.00*
  - Simplified Rhythm @ f4807b3a: 2.75*
  - Simplified Rhythm @ 933de7ab: 2.75*
  	
  [Halozy - Genryuu Kaiko [Higan
  Torrent]](https://osu.ppy.sh/beatmapsets/180138#osu/433005) (1/4 snap):
  - No mods: 5.37*
  - Simplified Rhythm @ master: 0.00*
  - Simplified Rhythm @ f4807b3a: 3.95*
  - Simplified Rhythm @ 933de7ab: 5.37*
  
  </details>

  Bartłomiej Dach · 2026-03-12 22:05:39 +09:00
  28fbb83cc6
• move timing point binary search back inline
  OliBomby · 2024-08-21 01:50:52 +02:00
  8d72ec8bd6
• Take into account next timing point when snapping time
  OliBomby · 2024-08-16 01:01:24 +02:00
  2e11172e8e
• Add BinarySearchUtils
  OliBomby · 2024-08-16 00:15:40 +02:00
  ac064e814f
• Merge pull request #28444 from bdach/scrolling-ruleset-editor-reloads

  Reload scrolling hitobject composer on control point changes

  Dean Herbert · 2024-06-20 15:15:26 +09:00
  0eb533f2fd
• Also annotate ControlPointInfo

  Same deal with this class. Fully qualifying the type names because this
  has `#nullable disable` and makes use of `NotNull` which is also present
  in the `System.Diagnostics.CodeAnalysis` namespace and AAAAAAARGH
  NAMESPACE CONFLICTS.

  Dan Balasescu · 2024-06-17 17:13:44 +09:00
  f86e9c9a4a
• Expose singular coarse-grained change event on ControlPointInfo
  Bartłomiej Dach · 2024-06-11 09:16:45 +02:00
  694cfd0e25
• Make snapped time always positive
  ansel · 2023-01-12 03:38:57 +03:00
  51e21ee6f0
• Use new ArgumentNullException.ThrowIfNull throw-helper API
  Berkan Diler · 2022-12-22 21:27:59 +01:00
  08d2fbeb8e
• Use MaxBy in all locations that can and update inspection level to match dotnet-build
  Dean Herbert · 2022-12-19 16:47:10 +09:00
  4a7d7c6ed9
• Fix some more inspections
  Dean Herbert · 2022-12-16 20:21:19 +09:00
  192536643c
• Fix incorrect fallback logic

  Regressed when attempting to share implementation of binary search.

  Dean Herbert · 2022-10-20 23:08:44 +09:00
  5c13c443ff
• Expose binary search methods publicly

  Co-authored-by: Dan Balasescu <smoogipoo@smgi.me>

  Dean Herbert · 2022-10-20 14:34:07 +09:00
  a754dc6d3b
• Standardise control point search logic in OverlappingScrollAlgorithm

  Was using a very local algorithm which I cannot guarantee is correct.
  I'd rather it just use the one used everywhere else.

  Dean Herbert · 2022-10-18 16:01:05 +09:00
  ec3761ced9
• Update parameter discards
  Dean Herbert · 2022-06-24 21:26:19 +09:00
  31a447fda0
• Automated #nullable processing
  Dan Balasescu · 2022-06-17 16:37:17 +09:00
  f8830c6850
• Add flow for changing set of valid divisors between presets
  Bartłomiej Dach · 2022-02-27 15:37:51 +01:00
  d0c01afc2e
• Apply batch fixing of built-in types using var
  Dean Herbert · 2021-10-27 13:04:41 +09:00
  6944151486
• Throw rather than ignore on invalid control point addition
  Dean Herbert · 2021-09-06 22:04:37 +09:00
  eabca016d4
• Move DifficultyControlPoints list to LegacyControlPointInfo
  Dean Herbert · 2021-09-03 16:58:16 +09:00
  db3fc1d4af
• Fix editor not cloning control points as expected
  Dean Herbert · 2021-08-30 21:55:08 +09:00
  a2cff75fc0
• Move to legacy namespace
  Dean Herbert · 2021-08-30 17:14:53 +09:00
  ccacf56dd8
• Move samples to LegacyControlPointInfo
  Dean Herbert · 2021-08-30 17:14:53 +09:00
  7257aae7f2
• Add IDeepCloneable interface and update existing CreateCopy methods to use it
  Dean Herbert · 2021-07-19 12:54:17 +09:00
  3c028ce05c
• Specify types explicitly and don't handle non-nullable values with fallbacks
  Dean Herbert · 2021-06-16 16:24:30 +09:00
  5944c45f55
• Fix GetClosestBeatDivisor returning the wrong divisor
  Justus Franklin Tumacder · 2021-05-01 14:13:42 +08:00
  0d077b7a5d
• Refactor lookup methods to avoid linq and reduce TimingPointAt calls
  Dean Herbert · 2021-04-28 17:16:05 +09:00
  859898d98f
• Revert return values to non-rounded doubles
  Dean Herbert · 2021-04-28 16:59:49 +09:00
  c5186b6a69
• Rename methods to match generally how these find-methods are named elsewhere
  Dean Herbert · 2021-04-28 16:57:52 +09:00
  f3c7694eeb
• Move snap/divisor helper methods to inside ControlPointInfo
  Dean Herbert · 2021-04-28 16:47:30 +09:00
  48d6c9ac4b
• Make most common BPM more accurate
  smoogipoo · 2021-01-15 14:28:49 +09:00
  c6e9a6cd5a
• Use CreateCopy instead of Clone interface

  I was going for conformity by using the IClonable interface, but it
  doesn't look like we use it anywhere else in the project.

  Dean Herbert · 2021-01-05 13:13:52 +09:00
  caa88c6100
• Clone and copy ControlPointInfo when retrieving a playable beatmap
  Dean Herbert · 2021-01-04 16:37:07 +09:00
  ba4e411422
• Handle changes via SamplePoints list for simplicity
  Dean Herbert · 2020-11-02 14:40:40 +09:00
  3adf451e82
• Fix individual control points not being removed from group when group is removed
  Dean Herbert · 2020-10-02 15:28:21 +09:00
  f501c88b46
• Add back missing default implementations for lookup functions
  Dean Herbert · 2020-07-19 14:11:21 +09:00
  3823bd8343
• Remove unnecessary new() specification
  Dean Herbert · 2020-07-18 12:06:41 +09:00
  7250bc351d
• Use static instances in all fallback ControlPoint lookups to reduce allocations
  Dean Herbert · 2020-07-18 11:53:04 +09:00
  8147e67f53
• Don't serialise AllControlPoints
  smoogipoo · 2020-04-21 13:58:23 +09:00
  9252b7876b
• Add back null check
  smoogipoo · 2020-04-17 17:10:13 +09:00
  0fba93bf65
• Remove unnecessary time property
  smoogipoo · 2020-04-17 17:06:12 +09:00
  9aac98664c
• Use redundancy test
  Alchyr · 2020-04-08 01:42:35 -07:00
  65823fb2e1
• Merge branch 'master' into fix-effect-points
  Dean Herbert · 2019-12-18 01:43:15 +09:00
  036efb9947
• Use index and range expressions
  Huo Yaoyuan · 2019-12-15 20:17:35 +08:00
  c457571da6
• Fix first sample point being treated as redundant
  smoogipoo · 2019-12-13 18:14:01 +09:00
  87a7f340e3
• Use paramref.
  Huo Yaoyuan · 2019-11-17 20:49:36 +08:00
  b1b234c6fb
• Add xmldoc and combine GroupAt / CreateGroup
  Dean Herbert · 2019-10-28 11:40:33 +09:00
  45da22afe9
• Disallow inserting a group if one already exists with the current time value
  Dean Herbert · 2019-10-28 11:40:10 +09:00
  2a6b3fd67c
• Allow binding to ControlPointInfo's Groups
  Dean Herbert · 2019-10-28 11:39:53 +09:00
  59d983b66e
• Add special case for timing points

  Timing points can't fallback to defaults and must be added at least once.

  Dean Herbert · 2019-10-26 11:38:05 +09:00
  4290a71f44