* Use correct `HitWindows` class for osu!taiko hit windows in difficulty calculator
* Remove redundant (and incorrect) hit window creation
* Balance rhythm against hit window changes
* Replace long interval nerf with a new one that uses stamina difficulty
* Turn tabs into spaces
* Update unit tests
---------
Co-authored-by: StanR <hi@stanr.info>
* Penalise reading difficulty of high velocity notes at high densities
* Use System for math functions
* Lawtrohux changes
* Clean up density penalty comment
* Swap midVelocity and highVelocity back around
* code quality pass
---------
Co-authored-by: Jay Lawton <jaime@merkids.com>
Co-authored-by: StanR <hi@stanr.info>
* further considerations for rhythm
* new rhythm balancing
* fix license header
* use isNormal to validate ratio
* adjust tests
---------
Co-authored-by: StanR <hi@stanr.info>
* revert acc scaling shift to previous values
* increase variance in accuracy values across od
* move return values, move nullcheck into return
---------
Co-authored-by: James Wilson <tsunyoku@gmail.com>
In order for the new star difficulty to be shown to users on the next
release.
catch's difficulty calculator version is not bumped because the only
catch change pending deploy is https://github.com/ppy/osu/pull/28353 and
that affects performance points only.
Reported in https://discord.com/channels/188630481301012481/1097318920991559880/1221836384038551613.
Example score: https://osu.ppy.sh/scores/1855965185
The cause of the overestimation was an error in taiko's score simulator.
In lazer taiko, swell ticks don't give any score anymore, while they did
in stable.
For all intents and purposes, swell ticks can be considered "bonus"
objects that "don't give any actual bonus score". Which is to say,
during simulation of a legacy score swell ticks hit should be treated
as bonus, because if they aren't, then otherwise they will be treated
essentially as *normal hits*, meaning that they will be included in
the *accuracy* portion of score, which breaks all sorts of follow-up
assumptions:
- The accuracy portion of the best possible total score becomes
overinflated in comparison to reality, while the combo portion of
that maximum score becomes underestimated.
- Because the affected score has low accuracy, the estimated accuracy
portion of the score (as given by maximmum accuracy portion of score
times the actual numerical accuracy of the score) is also low.
- However, the next step is estimating the combo portion, which is done
by taking legacy total score, subtracting the aforementioned
estimation for accuracy total score from that, and then dividing
the result by the maximum achievable combo score on the map. Because
most of actual "combo" score from swell ticks was "moved" into the
accuracy portion due to the aforementioned error, the maximum
achievable combo score becomes so small that the estimated combo
portion exceeds 1.
Instead, this change makes it so that gains from swell ticks are treated
as "bonus", which means that they are excluded from the accuracy portion
of score and instead count into the bonus portion of score, bringing the
scores concerned more in line with expectations - although due to
pessimistic assumptions in the simulation of the swell itself,
the conversion will still overestimate total score for affected scores,
just not by *that* much.
