Dean Herbert
276c37bcf7
Update framework
2024-11-29 13:47:56 +09:00
Dean Herbert
a67f7ea3fb
Merge branch 'master' into save-android
2024-11-29 13:46:53 +09:00
Salman Alshamrani
489d7a30ec
Perform a single Save call rather than doing it in each difficulty
2024-11-28 18:37:13 -05:00
Salman Alshamrani
f664e97496
Merge pull request #30906 from Hiviexd/daily-challenge-tier-thresholds
...
Adjust daily challenge tier thresholds to match expectations
2024-11-28 18:36:31 -05:00
Salman Alshamrani
311f0947e4
Abstractify resource change logic and share between background and audio
2024-11-28 17:57:47 -05:00
Salman Alshamrani
51bcde67aa
Remove no longer required comment
2024-11-28 17:55:15 -05:00
Salman Alshamrani
078d62fe09
Fix weird default in test scene
2024-11-28 17:54:03 -05:00
Salman Alshamrani
a8db35ac45
Merge branch 'master' into daily-challenge-tier-thresholds
2024-11-28 17:46:55 -05:00
Salman Alshamrani
932afcde01
Make editor make sense
2024-11-28 17:43:32 -05:00
Jamie Taylor
58cf1c11e4
Improve menu/context-menu sample playback
2024-11-29 06:54:48 +09:00
Huo Yaoyuan
fced254594
Enable selected rules for usage
2024-11-28 22:33:03 +08:00
Huo Yaoyuan
0a8ec4db2b
Enable recommended rules for reliability
2024-11-28 22:20:36 +08:00
Huo Yaoyuan
5b63d725c5
Mark CA1826/CA1860 as suggestion
2024-11-28 22:13:59 +08:00
Bartłomiej Dach
c93c549b05
Fix ready button not disabling on playlist close
2024-11-28 14:17:31 +01:00
Bartłomiej Dach
9926ffd326
Make button a little narrower
2024-11-28 14:06:12 +01:00
Bartłomiej Dach
ac2c4e81c7
Use switch
2024-11-28 14:04:39 +01:00
Bartłomiej Dach
2e6f43a75d
Merge branch 'master' into close-playlists
2024-11-28 14:01:36 +01:00
Huo Yaoyuan
f5a7716509
Apply minor performance rules
2024-11-28 20:41:44 +08:00
Huo Yaoyuan
13d7c6a2d8
Enable recommended rules for maintainability
2024-11-28 20:41:41 +08:00
Huo Yaoyuan
cd9b5927eb
Enable recommended rules for globalization
2024-11-28 20:41:35 +08:00
Huo Yaoyuan
c57ace0b5f
Enable recommended rules for documentation
2024-11-28 20:41:32 +08:00
Bartłomiej Dach
d0e80ce982
Merge pull request #30895 from peppy/watch-replay-reliability
...
Fix watch replay button sometimes not loading the replay on first click
2024-11-28 13:16:40 +01:00
Hiviexd
6ed21229b7
update test
2024-11-28 12:49:48 +01:00
Hiviexd
66093872e8
Adjust daily challenge tier thresholds to match expectations
2024-11-28 12:49:30 +01:00
Bartłomiej Dach
98a156ae2d
Merge pull request #30874 from peppy/chat-order
...
Sort public chat channels alphabetically, private channels based on recent messages
2024-11-28 12:46:14 +01:00
Huo Yaoyuan
8f6e5c4754
Convert legacy ruleset to globalconfig
2024-11-28 19:34:56 +08:00
Bartłomiej Dach
c14fe21219
Fix LCA call crashing in actual usage
...
It's not allowed to call `LoadComponentsAsync()` on a background thread:
fd64f2f0d4/osu.Framework/Graphics/Containers/CompositeDrawable.cs (L147)
2024-11-28 11:19:00 +01:00
Dan Balasescu
1575eed5ba
Merge pull request #30893 from peppy/realm-perf-improvements
...
Improve realm update performance
2024-11-28 19:08:22 +09:00
Dan Balasescu
077719903b
Merge pull request #30905 from peppy/fix-multiple-offset-applications
...
Clear previous `LastLocalUserScore` when returning to song select
2024-11-28 18:58:13 +09:00
Bartłomiej Dach
b0958c8d41
Attempt to fix test failures
2024-11-28 10:29:53 +01:00
Bartłomiej Dach
d218c19799
Merge pull request #30852 from frenzibyte/fix-daily-challenge-leaderboard
...
Fix daily challenge results screen fetching scores beginning from the user's highest
2024-11-28 10:21:52 +01:00
Dean Herbert
c26c84ba45
Add test coverage governing new behaviour
2024-11-28 18:03:19 +09:00
Dean Herbert
ced8dda1a2
Clear previous LastLocalUserScore when returning to song select
...
This seems like the lowest friction way of fixing
https://github.com/ppy/osu/issues/30885 .
We could also only null this on application, but this feels worse
because
- It would require local handling (potentially complex) in
`BeatmapOffsetControl` if we want to continue displaying the graph and
button after clicking it.
- It would make the session static very specific in usage and
potentially make future usage not possible due to being nulled in only
a very specific scenario.
One might argue that it would be nice to have this non-null until the
next play, but if such a usage comes up I'd propose we rename this
session static and add a new one with that purpose.
2024-11-28 18:01:28 +09:00
Bartłomiej Dach
0d491e3159
Merge branch 'master' into fix-daily-challenge-leaderboard
2024-11-28 09:41:24 +01:00
Dan Balasescu
5d7aafaab3
Merge pull request #30894 from HenintsoaSky/star-fountains-toggle-setting
...
Add a toggle for star fountains during gameplay
2024-11-28 17:35:11 +09:00
Bartłomiej Dach
4314f9c0a9
Remove unused accessors
2024-11-28 09:22:08 +01:00
Salman Alshamrani
b1d0939142
Add localisation support
2024-11-28 02:37:31 -05:00
Salman Alshamrani
4a1401a33d
Rewrite bindable flow to make more sense
2024-11-28 02:37:27 -05:00
Dean Herbert
70eee8882a
Remove unnecessary null check
2024-11-28 15:42:37 +09:00
Dean Herbert
32b34c1967
Rename container to make more sense
2024-11-28 15:20:51 +09:00
Dean Herbert
4d9d5adbf4
Rename parameter to be more clear
2024-11-28 15:13:59 +09:00
Salman Alshamrani
19e396f878
Fix android workflow not installing .NET 8 version
2024-11-27 23:46:21 -05:00
Dean Herbert
e0fdcaf523
Merge pull request #30848 from Joehuu/dicord-fix-beatmap-button-visibility
...
Fix discord "view beatmap" button being shown when editing and hide identifiable information is set
2024-11-28 13:29:09 +09:00
Salman Alshamrani
24c0799680
Move beatmap ID lookup to UesrActivity
2024-11-27 16:54:51 -05:00
Salman Alshamrani
238a1ce284
Fix tests reliability and improve code
...
Shaved off lots of copypasta so the test actually shows what it's testing.
2024-11-27 15:27:21 -05:00
Salman Alshamrani
f792b6de00
Fix comment
2024-11-27 06:07:10 -05:00
Salman Alshamrani
4ae3ccfe48
Make BackButtonVisibility in game class private
2024-11-27 06:05:02 -05:00
Salman Alshamrani
4b8094d0db
Update test coverage
2024-11-27 05:58:06 -05:00
Salman Alshamrani
efb68e4232
Refactor ResourcesSection to support new form of selection
2024-11-27 05:53:22 -05:00
Salman Alshamrani
b70fb4b0fe
Add FormBeatmapFileSelector for intermediate user-choice step
2024-11-27 05:52:43 -05:00
