1
0
mirror of https://github.com/ppy/osu.git synced 2025-01-18 08:32:54 +08:00
Commit Graph

70874 Commits

Author SHA1 Message Date
Jay Lawton
c7691b3a2c adjust tests 2025-01-17 08:43:53 +10:00
StanR
ef96583e44
Merge branch 'pp-dev' into rhythm-considerations 2025-01-17 03:02:59 +05:00
Jay Lawton
a83f917d87
osu!taiko star rating and performance points rebalance (#31338)
* rebalance

* revert pp scaling change

* further rebalancing

* comment

* adjust tests
2025-01-16 21:14:05 +00:00
Bartłomiej Dach
b9894f67ce
Bump NVika tool to 4.0.0
Code quality CI runs have suddenly started failing out of nowhere:

- Passing run: https://github.com/ppy/osu/actions/runs/12806242929/job/35704267944#step:10:1
- Failing run: https://github.com/ppy/osu/actions/runs/12807108792/job/35707131634#step:10:1

In classic github fashion, they began rolling out another runner change
wherein `ubuntu-latest` has started meaning `ubuntu-24.04` rather than
`ubuntu-22.04`. `ubuntu-24.04` no longer has .NET 6 bundled.

Therefore, upgrade NVika to 4.0.0 because that version is compatible
with .NET 8.
2025-01-17 00:29:57 +09:00
Jay Lawton
9da8dcd815
osu!taiko stamina balancing (#31337)
* stamina considerations

* remove consecutive note count

* adjust multiplier

* add back comment

* adjust tests

* adjusts tests post merge

* use diffcalcutils

---------

Co-authored-by: StanR <hi@stanr.info>
2025-01-16 10:30:02 +00:00
molneya
974fa76987
fix spinners not increasing cumulative strain time (#31525)
Co-authored-by: StanR <hi@stanr.info>
2025-01-16 09:08:47 +00:00
Jay Lawton
0a21183e54
reading mono nerf (#31510) 2025-01-15 10:34:21 +00:00
Jay Lawton
e2a94ecf56 use isNormal to validate ratio 2025-01-15 20:13:11 +10:00
Natelytle
5bed7c22e3
Remove lower cap on deviation without misses (#31499) 2025-01-14 19:12:08 +00:00
James Wilson
6cf15e3e5a
Remove problematic total deviation scaling, rebalance aim (#31515)
* Remove problematic total deviation scaling, rebalance aim

* Fix tests
2025-01-14 18:27:25 +00:00
StanR
c53188cf45
Use total deviation to scale accuracy on aim, general aim buff (#31498)
* Make aim accuracy scaling harsher

* Use deviation-based scaling

* Bring the balancing multiplier down

* Adjust multipliers, fix incorrect deviation when using slider accuracy

* Adjust multipliers

* Update osu.Game.Rulesets.Osu/Difficulty/OsuPerformanceAttributes.cs

Co-authored-by: James Wilson <tsunyoku@gmail.com>

* Change high speed deviation threshold to 22-27 instead of 20-24

* Update tests

---------

Co-authored-by: James Wilson <tsunyoku@gmail.com>
2025-01-14 13:18:02 +00:00
Jay Lawton
7cf216dd34 fix license header 2025-01-14 21:32:38 +10:00
Jay Lawton
d1d2f00f64 new rhythm balancing 2025-01-14 21:08:23 +10:00
Givikap120
b21c6457b1
Punish speed PP for scores with high deviation (#30907) 2025-01-09 13:27:54 +00:00
StanR
db58ec8645
Apply a bunch of balancing changes to aim (#31456)
* Apply a bunch of balancing changes to aim

* Update tests

---------

Co-authored-by: James Wilson <tsunyoku@gmail.com>
2025-01-09 09:57:48 +00:00
StanR
392bb5718c
Simplify angle bonus formula (#31449)
* Simplify angle bonus formula

* Simplify further

* Simplify acute too

* Tests
2025-01-08 10:03:22 +00:00
StanR
3b58d5e435
Clamp OD in performance calculation to fix negative OD gaining pp (#31447)
Co-authored-by: James Wilson <tsunyoku@gmail.com>
2025-01-07 12:49:55 +00:00
Jay Lawton
4095b2662b
Add consistentRatioPenalty to the Colour skill. (#31285)
* fix colour

* review fix

Co-authored-by: StanR <castl@inbox.ru>

* remove cancelled out operand

* increase nerf, adjust tests

* fix automated spacing issues

* up penalty

* adjust tests

* apply review changes

* fix nullable hell

---------

Co-authored-by: StanR <castl@inbox.ru>
2025-01-07 11:36:56 +00:00
StanR
76ac11ff59
Fix angle bonuses calculating repetition incorrectly, apply distance scaling to wide bonus (#31320)
* Fix angle bonuses calculating repetition incorrectly, apply distance scaling to wide bonus

* Buff speed to compensate for streams losing pp

* Adjust speed multiplier

* Adjust wide scaling

* Fix tests
2025-01-06 15:08:14 +00:00
James Wilson
988ed374ae
Add basic difficulty & performance calculation for Autopilot mod on osu! ruleset (#21211)
* Set speed distance to 0

* Reduce speed & flashlight, remove aim

* Remove speed AR bonus

* cleanup autopilot mod check in `SpeedEvaluator`

* further decrease speed rating for extra hand availability

* Pass all mods to the speed evaluator, zero out distance bonus instead of distance

---------

Co-authored-by: tsunyoku <mbruhyo@gmail.com>
Co-authored-by: StanR <hi@stanr.info>
2024-12-29 19:29:57 +00:00
Jay Lawton
da172b3554 further considerations for rhythm 2024-12-29 21:37:29 +10:00
Jay Lawton
824497d82c
Rewrite of the Rhythm Skill within osu!taiko (#31284)
* implement bell curve into diffcalcutils

* remove unneeded attributes

* implement new rhythm skill

* change dho variables

* update dho rhythm

* interval interface

* implement rhythmevaluator

* evenhitobjects

* evenpatterns

* evenrhythm

* change attribute ordering

* initial balancing

* change naming to Same instead of Even

* remove attribute bump for display

* Fix diffcalc tests

---------

Co-authored-by: StanR <hi@stanr.info>
2024-12-27 16:30:30 +03:00
James Wilson
3ddeaf8460
Use lastAngle when nerfing repeated angles on acute bonus (#31245)
* Use `lastAngle` when nerfing repeated angles on acute bonus

* Bump acute multiplier

* Correct outdated wiggle bonus comment

* Update test

---------

Co-authored-by: StanR <hi@stanr.info>
2024-12-24 12:43:44 +03:00
StanR
6808a5a77c
Change slider drop penalty to use actual number of difficult sliders, fix slider drop penalty being too lenient (#31055)
* Change slider drop penalty to use actual number of difficult sliders, fix slider nerf being too lenient

* Move cubing to performance calculation

* Add separate list for slider strains

* Rename difficulty atttribute

* Rename attribute in perfcalc

* Check if AimDifficultSliderCount is more than 0, code quality fixes

* Add `AimDifficultSliderCount` to the list of databased attributes

* Code quality

---------

Co-authored-by: James Wilson <tsunyoku@gmail.com>
2024-12-21 23:45:29 +00:00
Jay Lawton
f6a36f7b2e
Implement Reading Skill into osu!taiko (#31208) 2024-12-21 13:19:14 +03:00
StanR
f722f94f26
Simplify osu! high-bpm acute angle jumps bonus (#30902)
* Simplify osu! high-bpm acute angle jumps bonus

* Add aim wiggle bonus

* Add hitwindow-based aim velocity decrease

* Revert "Add hitwindow-based aim velocity decrease"

This reverts commit bcebe9662c.

* Move wiggle multiplier to a const, slightly decrease acute bonus multiplier

* Make sure the previous object in the wiggle bonus is also part of the wiggle

* Scale the wiggle bonus multiplayer down

* Increase the acute angle jump bonus multiplier

* Make wiggle bonus only apply on >150 bpm streams, make repetitive angle penalty

* Reduce wiggle bonus multiplier to not break velocity>difficulty relation

* Adjust wiggle falloff function to fix stability issues

* Adjust wiggle consts

* Update tests
2024-12-20 23:32:51 +00:00
Jay Lawton
d8c3d899eb
remove particular condition on convert nerf (#31196)
Co-authored-by: James Wilson <tsunyoku@gmail.com>
2024-12-19 17:22:16 +00:00
Jay Lawton
ecd6b41928
Increase accscalingshift and include countok in hit proportion (#31195)
* revert acc scaling shift to previous values

* increase variance in accuracy values across od

* move return values, move nullcheck into return

---------

Co-authored-by: James Wilson <tsunyoku@gmail.com>
2024-12-19 14:45:11 +00:00
Jay Lawton
4ca88ae2d6
Refactor TaikoDifficultyCalculator and add DifficultStrain attributes (#31191)
* refactor + countdifficultstrain

* norm in utils

* adjust scaling shift

* fix comment

* revert all value changes

* add the else back

* remove cds comments
2024-12-19 11:32:59 +00:00
YaniFR
0f2f25db53
Adjust DifficultyValue curve to avoid lower star rating of osu!taiko being too inflated (#31067)
* low sr

* merge two line

* update decimal

* fix formatting

---------

Co-authored-by: StanR <hi@stanr.info>
2024-12-18 21:11:51 +03:00
Jay Lawton
79a3afe06f
Implement considerations for Relax within osu!taiko diffcalc (#30591) 2024-12-18 18:16:27 +03:00
Dan Balasescu
d54238240a
Merge pull request #31156 from frenzibyte/mobile-delayed-resume-overlay
Use time-based resume overlay when playing osu! on touchscreen
2024-12-18 15:25:10 +09:00
Salman Alshamrani
4bf90a5571 Use time-based resume overlay when playing osu! on touchscreen 2024-12-16 08:24:22 -05:00
Bartłomiej Dach
d72a0b04b8
Merge pull request #31084 from NicholasChin28/mania-profile-overlay-tooltip
Add missing mania tooltip overlay for 4k and 7k
2024-12-16 14:22:41 +09:00
Bartłomiej Dach
8a2f161619
Merge pull request #31139 from peppy/settings-sensitivity
Expose high precision mouse toggle when searching for "sensitivity" and other keywords
2024-12-16 13:40:32 +09:00
Bartłomiej Dach
9652c5a7ca
Merge pull request #31110 from peppy/timing-current-point-indicator
Change the way "current" points are hinted on timing screen
2024-12-16 13:27:06 +09:00
Bartłomiej Dach
ecb7a809f2
Revert "Fix text anchor for mania tooltip"
This reverts commit c0b6e784a5.

The change affects editor and other stuff and I'm not sure it's correct.
It's not like client needs to match the appearance really. It already
doesn't in many places.
2024-12-16 13:18:47 +09:00
Bartłomiej Dach
cfdb959cf6
Split actual methods & fix completely broken localisation
Localisable strings cannot be plainly interpolated or joined. That is a
lossy operation that loses data.
2024-12-16 13:16:52 +09:00
Bartłomiej Dach
8d1d026f56
Clean up model
- Properly annotate things as nullable
- Remove weird passthrough property (more on that later)
2024-12-16 13:14:21 +09:00
Dean Herbert
a8948628e6
Expose high precision mouse toggle when searching for "sensitivity" and other keywords 2024-12-16 13:12:21 +09:00
Bartłomiej Dach
573d709fae
Merge pull request #31109 from peppy/fix-editor-timing-undo-redo
Fix adjusting control point offset after undo/redo causing catastrophic failure
2024-12-16 12:40:22 +09:00
Bartłomiej Dach
98e8d0b497
Merge branch 'master' into timing-current-point-indicator 2024-12-16 12:22:14 +09:00
Bartłomiej Dach
1058abb4ab
Fix code quality 2024-12-16 12:22:06 +09:00
Nicholas Chin
e2edd9e0d5 Fix code quality issues 2024-12-15 13:53:33 +08:00
Nicholas Chin
153e6c0c22 Use Count comparison instead of Any 2024-12-14 08:29:32 +08:00
Dean Herbert
c93b6dba2b
Merge pull request #31108 from peppy/quick-retry-for-replays
Allow using "quick retry" shortcut in more cases from results screen
2024-12-13 08:18:59 -08:00
Nicholas Chin
c0b6e784a5 Fix text anchor for mania tooltip 2024-12-13 21:58:23 +08:00
Dean Herbert
9025103b8b
Reword comment to hopefully be more understandable 2024-12-13 20:02:17 +09:00
Dean Herbert
da840e3fac
Change the way "current" points are hinted on timing screen
I actually thought things were bugged with the previous display method,
since the hinting was very similar to the hover colour/state.

I've adjusted this to hopefully give users a better idea of what this is
intending to show them.
2024-12-13 19:45:18 +09:00
Dean Herbert
64555debc2
Fix adjusting control point offset after undo/redo causing catastrophic failure
Closes https://github.com/ppy/osu/issues/31098.

Low effort fix because it was already half broken. The test was testing
in isolation but in actual editor usage it wasn't working as expected.
2024-12-13 19:33:51 +09:00