h1or4dme8/osu-lazer
1
0
Fork 0
mirror of https://github.com/ppy/osu.git synced 2025-01-18 10:43:22 +08:00
Code Issues Releases Wiki Activity

further considerations for rhythm

Browse Source
This commit is contained in:
Jay Lawton 2024-12-29 21:37:29 +10:00
parent 824497d82c
commit da172b3554
1 changed files with 21 additions and 6 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

27
osu.Game.Rulesets.Taiko/Difficulty/Evaluators/RhythmEvaluator.cs
View File

@ -45,7 +45,7 @@ namespace osu.Game.Rulesets.Taiko.Difficulty.Evaluators
}
/// <summary>
/// Determines if the changes in hit object intervals is consistent based on a given threshold.
/// Determines if the changes in hit object intervals are consistent based on a given threshold.
/// </summary>
private static double repeatedIntervalPenalty(SameRhythmHitObjects sameRhythmHitObjects, double hitWindow, double threshold = 0.1)
{
@ -62,31 +62,46 @@ namespace osu.Game.Rulesets.Taiko.Difficulty.Evaluators
double sameInterval(SameRhythmHitObjects startObject, int intervalCount)
{
List<double?> intervalRatios = new List<double?>();
List<double?> intervals = new List<double?>();
var currentObject = startObject;
for (int i = 0; i < intervalCount && currentObject != null; i++)
{
intervalRatios.Add(currentObject.HitObjectIntervalRatio);
intervals.Add(currentObject.HitObjectInterval);
currentObject = currentObject.Previous;
}
intervalRatios.RemoveAll(interval => interval == null);
intervals.RemoveAll(interval => interval == null);
if (intervals.Count < intervalCount)
if (intervalRatios.Count < intervalCount || intervals.Count < intervalCount)
return 1.0; // No penalty if there aren't enough valid intervals.
// Check for penalties based on HitObjectIntervalRatio
for (int i = 0; i < intervalRatios.Count; i++)
{
for (int j = i + 1; j < intervalRatios.Count; j++)
{
double ratio = intervalRatios[i]!.Value / intervalRatios[j]!.Value;
if (Math.Abs(1 - ratio) <= threshold) // If any two ratios are similar
return 0.0;
}
}
// Check for penalties based on HitObjectInterval
for (int i = 0; i < intervals.Count; i++)
{
for (int j = i + 1; j < intervals.Count; j++)
{
double ratio = intervals[i]!.Value / intervals[j]!.Value;
if (Math.Abs(1 - ratio) <= threshold) // If any two intervals are similar, apply a penalty.
return 0.3;
double difference = Math.Abs(intervals[i]!.Value - intervals[j]!.Value);
if (difference <= hitWindow) // If any two intervals are close
return 0.5;
}
}
return 1.0; // No penalty if all intervals are different.
return 1.0; // No penalty if all intervals are sufficiently different.
}
}