1
0
mirror of https://github.com/ppy/osu.git synced 2024-12-16 03:02:53 +08:00
Commit Graph

1111 Commits

Author SHA1 Message Date
Bartłomiej Dach
168a828f23
Revert "Block input to objects lying under already-hit hitcircles when classic note lock is active"
This reverts commit 03c61a573e.

The goal here was to handle an edge case discovered during work on note
lock, wherein it was determined that on stable hit circles would block
input from reaching objects underneath them. However, the change
mentioned above did that _too_ hard and caused overlaps to also be
blocked even long past a hit circle has been faded out.

Revert the change pending further (and more careful) investigation.
2023-09-08 10:11:21 +02:00
Bartłomiej Dach
59bd6d827e
Add failing test case for overlapping objects blocking each other when not intended 2023-09-08 10:01:32 +02:00
Dean Herbert
1a37543d28 Rename SliderVelocity to SliderVelocityMultiplier to distinguish from Velocity 2023-09-06 19:01:08 +09:00
Bartłomiej Dach
6d3a6b7a5d
Fix HitCircleLateFade failures due to hitcircle not being loaded when applying mods 2023-09-05 23:35:03 +02:00
Bartłomiej Dach
03c61a573e
Block input to objects lying under already-hit hitcircles when classic note lock is active 2023-09-05 22:50:27 +02:00
Bartłomiej Dach
40d1196aea
Add test cases covering overlapping slider input expectations 2023-09-05 22:49:54 +02:00
Dean Herbert
ede9fae381 Remove broken check from TestSceneHitCircleLateFade 2023-09-01 17:28:31 +09:00
Dean Herbert
90121814f9 Merge branch 'master' into stable-notelock 2023-09-01 17:15:48 +09:00
Dean Herbert
2d88135198 Add automated test coverage for new test 2023-08-31 16:18:53 +09:00
Salman Ahmed
b8df714f56 Remove unused using directives 2023-08-30 21:50:52 +03:00
Salman Ahmed
c91031604c Add test cases for hitting hit circles with "early fade" behaviour 2023-08-30 21:41:57 +03:00
Bartłomiej Dach
38e3459391
Fix broken assertion 2023-08-24 08:54:38 +02:00
Bartłomiej Dach
7f215f163f
Use reduced hittable range with autopilot active 2023-08-24 08:52:49 +02:00
Bartłomiej Dach
a316036460
Add failing test case for special autopilot hittable range 2023-08-24 08:52:49 +02:00
Bartłomiej Dach
ed2b1a0754
Contain entirety of legacy notelock badness inside the hit policy 2023-08-24 08:52:49 +02:00
Bartłomiej Dach
64b36a73b1
Rename test scene to match tested class 2023-08-24 08:52:49 +02:00
Bartłomiej Dach
48b3f7dced
Add test case covering stacks not shaking 2023-08-24 08:52:49 +02:00
Bartłomiej Dach
9ffc6cdd61
Add test case covering overlapping slider fail case 2023-08-24 08:52:49 +02:00
Bartłomiej Dach
a045cb71fc
Add assertions checking action type taken by legacy hit policy 2023-08-24 08:52:49 +02:00
Bartłomiej Dach
1f3121bdf2
Merge branch 'master' into stable-notelock 2023-08-24 08:52:43 +02:00
Bartłomiej Dach
b777b34cc0
Merge branch 'master' into stable-notelock 2023-08-24 08:43:59 +02:00
Dean Herbert
981e0c1ad7 Rename export test step to better fit purpose 2023-08-24 14:26:26 +09:00
Bartłomiej Dach
052bf2a6e0
Use alternative solution for timing offset woes on export 2023-08-23 13:54:34 +02:00
Bartłomiej Dach
64786aaee8
Adjust test cases slightly to avoid running into hitwindow edge issue
Some note lock test cases do not play out correctly when exported out
to stable due to a completely separate issue, namely #11311.
Adjust the test cases for now to isolate failure vectors.
2023-08-23 10:43:48 +02:00
Bartłomiej Dach
a1b4a56215
Add capability to export ordered object policy test cases for stable crosscheck 2023-08-23 10:43:41 +02:00
Bartłomiej Dach
9fd59b807f
Rewrite TestSceneObjectOrderedHitPolicy to not rely on custom hitwindows 2023-08-22 15:36:36 +02:00
Bartłomiej Dach
ab4d47b594
Rewrite assertions to use nunit constraints 2023-08-22 14:37:58 +02:00
Bartłomiej Dach
c9f611a713
Enable NRT in TestSceneObjectOrderedHitPolicy 2023-08-22 14:30:55 +02:00
Bartłomiej Dach
1d657a8844
Merge branch 'master' into fix-slider-reversing 2023-08-21 09:29:46 +02:00
Bartłomiej Dach
3d52a1267e
Fix test failures via test-local popover containers 2023-08-19 15:08:30 +02:00
Bartłomiej Dach
5219b8a13b
Add test coverage for precise rotation control 2023-08-16 11:37:52 +02:00
Pasi4K5
6346872c39 Improve code readability and add assertion to test scene 2023-08-15 23:27:12 +02:00
Pasi4K5
cd70673463 Fix property name 2023-08-14 22:41:25 +02:00
Pasi4K5
28994166bc Split up assertions 2023-08-14 22:09:12 +02:00
Pasi4K5
449bee98cc Code cleanup 2023-08-14 21:56:08 +02:00
Pasi4K5
bbd91e3ee4 Add TestSceneSliderReversal 2023-08-14 14:14:11 +02:00
Bartłomiej Dach
cd416e09f9
Add test scene for checking spinner judgements 2023-07-29 00:49:21 +02:00
Liam DeVoe
15af85226c adjust test for correct stable notelock
stable actually allows for hitobjs to be hit in the middle of sliders, as long as it doesn't interfere with the end time of the slider.
2023-07-19 02:06:29 -04:00
Dean Herbert
b9a66ad7b3 Add test coverage of incorrect selection behaviour 2023-07-19 14:59:22 +09:00
Liam DeVoe
768d7b5e1c correct implementation of stable notelock 2023-07-17 23:31:21 -04:00
Dean Herbert
547f247669 Fix test to work regardless of screen sizes 2023-07-12 17:41:58 +09:00
Dean Herbert
b20190ed4f Merge branch 'master' into fix-blueprint-end-placement 2023-07-12 17:38:47 +09:00
Dean Herbert
ca9c31b492 Add test coverage of slider blueprint end placement failing outside playfield 2023-07-11 17:29:28 +09:00
Bartłomiej Dach
2cd5fd5944
Add failing legacy mod conversion test cases 2023-07-09 16:09:25 +02:00
Bartłomiej Dach
e9ecad9839
Add failing test cases covering NaN-timing-point sliders 2023-07-08 23:24:38 +02:00
tsrk
350d722c8d
Merge branch 'master' into hud/kc-skinnable 2023-06-25 15:42:08 +02:00
Bartłomiej Dach
f8d2f2f7e1
Fix more issues discovered by CI that can be fixed game-side 2023-06-24 19:04:05 +02:00
Bartłomiej Dach
d7ae430ec2
Merge branch 'master' into framework-update 2023-06-24 18:47:52 +02:00
Dean Herbert
3585c3f1d5 Apply required nullability changes 2023-06-24 09:58:36 +09:00
Dean Herbert
0ab0c52ad5 Automated pass 2023-06-24 01:00:03 +09:00