298 Commits

Author	SHA1	Message	Date
Dean Herbert	14104e57d4	Merge branch 'master' into timeline-drag-selection-crash	2024-06-20 15:16:10 +09:00
Bartłomiej Dach	7cfe8d8df2	Reduce editor opacity of several editor components when hovering over composer ... Addresses https://github.com/ppy/osu/discussions/24384.	2024-06-17 12:14:28 +02:00
Bartłomiej Dach	bdeea37a44	Commit active placement when starting drag selection via timeline ... This was reported in https://github.com/ppy/osu/pull/28474, albeit the code changes proposed there did not fix the issue at all. See 8b6385f7d0 for demonstration of the crash scenario. Basically what is happening there is: - The starting premise is that there is a spinner placement active. - At this time, a drag selection is started via the timeline. - Once the drag selection finds at least one suitable object to select, it mutates `SelectedItems`. - When selection changes for any reason, the `HitObjectComposer` decides to switch to the "select" tool, regardless of why the selection changed. - Changing the active tool causes the current placement - if any - to be committed, which mutates the beatmap. - Back at the drag box selection code, this causes a "collection modified when enumerating" exception. The proposed fix here is to eagerly commit active placement - if any - when drag selection is initiated via the timeline, which avoids this issue. This also appears to vaguely match stable behaviour and is sort of consistent with the logic of committing any outstanding changes upon switching to the selection tool.	2024-06-14 09:32:40 +02:00
Nguyên Minh Hồ	6f782266b5	Fix inspection	2024-03-30 17:28:57 +07:00
Nguyên Minh Hồ	5d497ba4a8	Simplify TooltipText for EditorRadioButton	2024-03-30 16:04:22 +07:00
Nguyên Minh Hồ	94ada87cba	Un-hardcode tooltip from EditorRadioButton and add disabled tooltip for rotation popover	2024-01-25 14:32:48 +07:00
Nguyên Minh Hồ	500bed0121	Split editor toolbox radio button disabling logic from EditorRadioButton, then add disabling logic for rotate popover	2024-01-25 14:24:35 +07:00
Bartłomiej Dach	b6215b2809	Rename and document SelectFromTimestamp	2023-11-20 21:57:14 +09:00
ratinfx	4e1e19728c	Refactor HitObject selection in Composer	2023-11-11 14:02:42 +01:00
ratinfx	aa87e0a44d	HitObject Selection logic and separation for gamemodes ... + moved time_regex into EditorTimestampParser	2023-11-07 01:36:58 +01:00
Bartłomiej Dach	2c6bf9e346	Remove unused using directive	2023-10-19 20:45:47 +02:00
Dean Herbert	013b5fa916	Move beat snap grid implementation details to ScrollingHitObjectComposer	2023-10-19 23:54:34 +09:00
Bartłomiej Dach	7abd7fe658	Remove redundant explicit array type specification	2023-10-17 10:26:02 +02:00
Dean Herbert	4381169a3f	Combine selection and input handling logic for beat snap grids across all rulesets	2023-10-17 17:09:42 +09:00
Dean Herbert	d26d4b8b79	Cache IScrollingInfo at a HitObjectComposer level automatically	2023-10-17 16:42:22 +09:00
Dean Herbert	41a8239e49	Remvoe null default for mods which can't be null	2023-09-20 15:27:50 +09:00
Dean Herbert	37c2b330a2	Move toggle implementation to work on all scrolling rulesets automatically	2023-09-01 19:53:10 +09:00
Bartłomiej Dach	caad931a16	Move comment to more fitting place	2023-07-28 22:10:10 +02:00
Bartłomiej Dach	6d018c08af	Rename Apply{Vertical -> Horizontal}Centering to match common understanding	2023-07-28 22:09:28 +02:00
Dean Herbert	c9155f85ab	Fix playfield not taking up full width correclty when not vertically centered	2023-07-28 16:40:14 +09:00
Dean Herbert	deba6e2508	Fix osu!taiko editor playfield missing a piece ... Regressed with recent centering changes in https://github.com/ppy/osu/pull/24220	2023-07-27 02:24:10 +09:00
Dean Herbert	b58354ac64	Fix playfield getting cut off (again) at tall aspect ratios	2023-07-21 15:20:20 +09:00
Dean Herbert	f489dbd7a9	Reduce width of right toolbar ever so slightly (and use more shared constants)	2023-07-21 14:39:15 +09:00
Bartłomiej Dach	53c91349fe	Merge branch 'master' into slider-control-point-no-distance-snap	2023-05-26 19:52:54 +02:00
Dean Herbert	804671ca74	Split out grid snapping modes into "relative" and "global" types	2023-05-25 21:41:19 +09:00
Dean Herbert	a22ad98cb7	Fix hotkeys not actually working	2023-05-24 14:56:11 +09:00
Dean Herbert	298989ffd2	Merge branch 'master' into sample-set-controls	2023-05-24 14:03:04 +09:00
Dean Herbert	67f83f246b	Add more padding around playfield in editor to avoid overlap with tool areas ... Closes #23130.	2023-05-02 15:37:02 +09:00
Dean Herbert	3209b09270	Move inspector into own file	2023-04-04 19:17:34 +09:00
Dean Herbert	4aed483005	Tidy up dependency resolution	2023-04-04 19:14:30 +09:00
Dean Herbert	195b5fc3f1	Add view for selections of size != 1	2023-04-04 19:11:48 +09:00
Dean Herbert	b0d5761667	Add object type	2023-04-04 19:05:50 +09:00
Dean Herbert	c356c163fa	Add hit object inspector view	2023-04-04 19:03:45 +09:00
Dean Herbert	f9ebdadfe8	Move right-side editor toolbox to base HitObjectComposer ... Move right-side editor toolbox to base `HitObjectComposer`	2023-04-04 19:00:56 +09:00
Bartłomiej Dach	d9ca7102f0	Use more generic wording for future-proofing	2023-02-19 15:06:40 +01:00
Bartłomiej Dach	aac32a2c9f	Combine config and time checks into one ... Functionally equivalent right now, but the combined variant is more localised to what it actually needs to do, and less error-prone if any new code gets appended to the method.	2023-02-19 13:14:51 +01:00
Maximilian Kruse	f3522c4162	change bindable seekToHitObject to private	2023-02-19 10:18:02 +01:00
Maximilian Kruse	ddd37bb319	Add setting to disable automatic seeking after object placement	2023-02-18 19:43:45 +01:00
Derrick Timmermans	6a61e70766	Expose Ruleset from HitObjectComposer instead	2022-11-30 12:17:58 +01:00
Dean Herbert	4215f4f5d7	Merge branch 'master' into Editor-DrawableRuleset-Dependencies	2022-11-30 17:42:46 +09:00
Derrick Timmermans	93ba84e5ff	Fix code style	2022-11-27 21:48:44 +01:00
Derrick Timmermans	70c320b2e8	Provide ruleset dependencies only to Compose Placement Blueprints	2022-11-27 21:43:33 +01:00
Dan Balasescu	7bc8908ca9	Partial everything	2022-11-27 00:00:27 +09:00
Derrick Timmermans	65e5c9a3ae	Dispose DrawableRulesetDependencies in HitObjectComposer	2022-11-25 08:27:22 +01:00
Derrick Timmermans	7b620392fe	Provide DrawableRulesetDependencies from HitObjectComposer	2022-11-24 13:13:45 +01:00
Dean Herbert	d0e6bda9ef	Stop HitObjectComposer from handling Shift+Number keys	2022-10-24 15:19:36 +09:00
Dean Herbert	50e24ddd87	Add icon and radio button logic	2022-10-19 21:35:08 +09:00
Dean Herbert	6a7f6c76ff	Fix osu! editor padding being applied to toolboxes ... The result of https://github.com/ppy/osu/pull/20739 and https://github.com/ppy/osu/pull/20738 having unintended side effects when applied together.	2022-10-18 14:32:00 +09:00
Dean Herbert	4d99c7002b	Add background behind editor toolbox groups	2022-10-13 16:36:19 +09:00
Dan Balasescu	f8830c6850	Automated #nullable processing	2022-06-17 16:37:17 +09:00