51162 Commits

This Branch

This Branch

All Branches

• Remove leftover border thickness spec in mod settings area

  Was never supposed to be there, it was a vestige of a previous design
  iteration that went by unnoticed.

  Bartłomiej Dach · 2022-05-06 15:34:49 +02:00
  c533c93ffd
• Merge pull request #18119 from bdach/mod-overlay/broken-hover

  Fix mod panels not hovering correctly after closing customisation area via mouse on new mod select

  Dean Herbert · 2022-05-06 20:42:33 +09:00
  98eab9668d
• Merge pull request #18069 from peppy/exit-multiplayer-is-dangerous

  Make exiting multiplayer a dangerous operation, requiring hold

  Dean Herbert · 2022-05-06 20:00:41 +09:00
  cfcd64873c
• Merge branch 'master' into exit-multiplayer-is-dangerous
  Bartłomiej Dach · 2022-05-06 12:57:13 +02:00
  839f9373b2
• Merge pull request #18118 from peppy/fix-toolbox-expand-coi

  Fix toolbox expand being interrupted by gaps between groups

  Bartłomiej Dach · 2022-05-06 12:47:02 +02:00
  3e75e7184a
• Fix click-to-return container still handling hover when inactive
  Bartłomiej Dach · 2022-05-06 12:28:53 +02:00
  08fd0ea086
• Fix toolbox expand being interrupted by gaps between groups
  Dean Herbert · 2022-05-06 19:06:40 +09:00
  c6bc6be128
• Add failing test case for broken hover behaviour
  Bartłomiej Dach · 2022-05-06 11:37:50 +02:00
  8f217d1e97
• Merge pull request #18116 from peppy/guest-is-system-user

  Mark `GuestUser` as system user via `Id` for now

  Dan Balasescu · 2022-05-06 18:13:03 +09:00
  09139ef9f4
• Mark GuestUser as system user via Id for now

  Should resolve https://github.com/ppy/osu/issues/18105.
  
  Checking through usages, it doesn't immediately look like this will
  regress any other scenarios.

  Dean Herbert · 2022-05-06 17:37:46 +09:00
  319867f73c
• Bind to button's activation delay directly
  Bartłomiej Dach · 2022-05-06 10:04:36 +02:00
  f5026bbbeb
• Remove commented-out code
  Bartłomiej Dach · 2022-05-06 10:04:00 +02:00
  f39fcee41b
• Add test coverage of multiplayer gameplay exit flow
  Dean Herbert · 2022-05-06 15:22:22 +09:00
  060461a431
• Add animation to denote a dangerous player exit
  Dean Herbert · 2022-05-06 15:02:22 +09:00
  78959a6e05
• Rename non-descript Button nested class
  Dean Herbert · 2022-05-06 14:45:53 +09:00
  1c4aa12585
• Add full xmldoc to HoldToConfirmContainer
  Dean Herbert · 2022-05-06 14:45:53 +09:00
  c38e97c9ec
• Better encapsulate exposed bindables of HoldToConfirmContainer
  Dean Herbert · 2022-05-06 14:45:53 +09:00
  a11771c11b
• Move dangerous hold specification to base class
  Dean Herbert · 2022-05-06 14:34:31 +09:00
  be960eb092
• Merge branch 'master' into exit-multiplayer-is-dangerous
  Dean Herbert · 2022-05-06 14:25:18 +09:00
  0d8e42b941
• Merge pull request #18110 from jai-x/new-chat-min-max-height

  Clamp maximum and minimum height the chat overlay can be resized to

  Dean Herbert · 2022-05-06 12:43:58 +09:00
  35e307672b
• Use BindableFloat in chat height tests
  Jai Sharma · 2022-05-05 23:13:43 +01:00
  7ffe3b132f
• Use BindableFloat for chat height
  Jai Sharma · 2022-05-05 23:13:32 +01:00
  0974de8fb0
• Clamp maximum and minimum height the chat overlay can be resized to
  Jai Sharma · 2022-05-05 21:40:37 +01:00
  16a6c11bc8
• Merge pull request #18108 from bdach/mod-overlay/customisation-auto-show-bug

  Close new design's mod customisation area on escape press before exiting

  Dean Herbert · 2022-05-06 04:21:08 +09:00
  e2895ea145
• Close customisation area on escape press before exiting
  Bartłomiej Dach · 2022-05-05 19:17:36 +02:00
  79e1b93b30
• Add test coverage for dismissing customisation area with Escape
  Bartłomiej Dach · 2022-05-05 19:17:36 +02:00
  8002726c9c
• Fix hidden issue with automatic customisation panel show logic

  Doesn't cause tests to fail headless, but they do fail in the test
  browser.

  Bartłomiej Dach · 2022-05-05 19:17:36 +02:00
  2cc56a4b19
• Merge pull request #18033 from jai-x/new-chat-overlay

  Implement basic layout and behaviour of new chat overlay

  Dean Herbert · 2022-05-06 00:10:46 +09:00
  14d2159b8c
• Merge branch 'master' into new-chat-overlay
  Dean Herbert · 2022-05-05 23:12:31 +09:00
  9d48bb41c9
• Fix chat height saving/loading test
  Jai Sharma · 2022-05-05 14:52:03 +01:00
  5657e7f11e
• Add tests for chat height saving/loading
  Jai Sharma · 2022-05-05 14:21:26 +01:00
  9cb52f8879
• Merge pull request #18090 from peppy/playlist-keyboard-traversal

  Add support for traversing playlist items using next/previous bindings

  Bartłomiej Dach · 2022-05-05 15:21:02 +02:00
  b9d8d1b4f6
• Ensure RelativePositionAxes is set in BDL for animations to work
  Jai Sharma · 2022-05-05 14:20:33 +01:00
  5ea6f62951
• Merge branch 'master' into playlist-keyboard-traversal
  Bartłomiej Dach · 2022-05-05 14:45:58 +02:00
  a859ca0b89
• Merge pull request #18093 from peppy/dialog-overlay-thread-woes

  Fix dialogs pushed to `DialogOverlay` too early potentially doing cross-thread transforms

  Dan Balasescu · 2022-05-05 21:44:52 +09:00
  8ac4d72dc8
• Merge branch 'master' into dialog-overlay-thread-woes
  Dan Balasescu · 2022-05-05 20:57:51 +09:00
  e46f99bdba
• Merge pull request #18100 from peppy/snapping-tidy-distance

  Add xmldoc for `IDistanceSnapProvider` and related properties

  Salman Ahmed · 2022-05-05 14:56:24 +03:00
  8a1f63e50e
• Merge branch 'master' into snapping-tidy-distance
  Bartłomiej Dach · 2022-05-05 13:15:24 +02:00
  a9eae3a544
• Merge pull request #18082 from frenzibyte/beatmap-selection-keybinding

  Add key binding for beatmap selection in song select

  Dean Herbert · 2022-05-05 20:14:16 +09:00
  85dd49cdb0
• Merge branch 'master' into snapping-tidy-distance
  Dan Balasescu · 2022-05-05 19:55:55 +09:00
  39d10487b9
• Merge branch 'master' into beatmap-selection-keybinding
  Salman Ahmed · 2022-05-05 13:44:08 +03:00
  542bb54ba0
• Reword binding text to read better
  Dean Herbert · 2022-05-05 19:40:44 +09:00
  684db27bb8
• Merge pull request #18101 from peppy/cache-at-interface

  Move caching specification to interface for several editor interfaces

  Dan Balasescu · 2022-05-05 19:36:08 +09:00
  ab2e30d625
• Tidy up initialisation
  Dean Herbert · 2022-05-05 19:24:18 +09:00
  97221d2ef1
• Adjust value change variables to avoid e usage
  Dean Herbert · 2022-05-05 19:22:20 +09:00
  e54f5e2d92
• Remove ! usage (also seems to fix height saving/loading)
  Dean Herbert · 2022-05-05 19:22:12 +09:00
  74505ba166
• Replace HandlePositionalInput override with simple hover effect
  Dean Herbert · 2022-05-05 19:13:48 +09:00
  25ea660b0b
• Reset all test data before each test method to avoid channels stuck in joined state
  Dean Herbert · 2022-05-05 19:09:56 +09:00
  e7205d8593
• Merge pull request #18102 from frenzibyte/fix-inspection

  Wrap `BeatmapOnlineLookupQueue` cache request in a task

  Dean Herbert · 2022-05-05 19:06:58 +09:00
  2ff900fd22
• Merge branch 'master' into new-chat-overlay
  Dean Herbert · 2022-05-05 18:57:00 +09:00
  4efaa41670