38619 Commits

• Be slightly more specific with error message
  Bartłomiej Dach · 2023-06-10 02:19:34 +09:00
  06040828c0
• Inline binary reading to avoid polluting RealmAccess with nested class
  Dean Herbert · 2023-06-10 02:19:34 +09:00
  7fe06185b9
• try-catch more
  Dean Herbert · 2023-06-10 02:19:34 +09:00
  50e3932256
• Catch errors during score parsing
  Dan Balasescu · 2023-06-10 02:19:34 +09:00
  f47bca7e32
• Don't scale stable scores with the classic scoring mode
  Dan Balasescu · 2023-06-10 02:19:34 +09:00
  8c1d6e0aeb
• Parse ScoreInfo.IsLegacyScore from replays
  Dan Balasescu · 2023-06-10 02:19:34 +09:00
  1d5464022c
• Fix incorrect realm schema comment

  Co-authored-by: timiimit <32331609+timiimit@users.noreply.github.com>

  Dean Herbert · 2023-06-10 02:19:34 +09:00
  b90b76c039
• Bump schema version
  Dean Herbert · 2023-06-10 02:19:34 +09:00
  90c30dee62
• Rename variable and ensure timestamp is updated even when not saving
  Dean Herbert · 2023-06-10 02:19:34 +09:00
  38fda7ac7d
• Use LastEditTime in Editor
  timiimit · 2023-06-10 02:19:34 +09:00
  aa0e4e16f7
• Add BeatmapInfo.LastEditTime property
  timiimit · 2023-06-10 02:19:34 +09:00
  2c327a74b2
• Update framework
  Dean Herbert · 2023-06-10 01:47:30 +09:00
  1765e6d430
• Bump replay version in encoder after Score V2 changes

  One release too late, but this may help in the future if we need to
  discern replays set with Score V2 from older lazer replays.

  Bartłomiej Dach · 2023-06-10 01:46:09 +09:00
  e07cae50a2
• Merge pull request #23741 from peppy/fix-manage-collection-commit-on-focus-loss

  Fix collection name changes not being reflected if enter is not pressed

  Bartłomiej Dach · 2023-06-04 17:19:13 +02:00
  25d0f0f3da
• Ensure collection edit textbox commits on focus loss

  As discussed in https://github.com/ppy/osu/discussions/23739

  Dean Herbert · 2023-06-04 12:51:03 +09:00
  eb7586b517
• Merge branch 'master' into tidy-results-grid-usage
  Bartłomiej Dach · 2023-06-03 19:45:23 +02:00
  331e90f720
• Simplify column dimensions code

  `dimensions` would always receive exactly one item, so might as well
  inline it.
  
  And yes, at this point the grid container is mostly a glorified
  `FillFlowContainer { Direction = FlowDirection.Vertical }`, but I am not
  touching that in this pull pending further decisions with respect to
  direction.

  Bartłomiej Dach · 2023-06-03 19:40:01 +02:00
  602d5db3bb
• Fix code quality inspection
  Bartłomiej Dach · 2023-06-03 16:50:58 +02:00
  474f7c2bc0
• Merge branch 'master' into update-multiplayer-room-diff-range
  Bartłomiej Dach · 2023-06-03 16:50:09 +02:00
  a9d4556647
• Merge pull request #23719 from peppy/disable-tablet-support-on-error

  Automatically disable tablet support on error

  Bartłomiej Dach · 2023-06-03 12:25:06 +02:00
  0b841eda71
• Merge pull request #23730 from smoogipoo/reduce-legacy-diffcalc-mod-init

  Fix legacy mod difficulty calculation creating all mods unnecessarily

  Dean Herbert · 2023-06-02 22:22:19 +09:00
  8063d50369
• Fix legacy diffcalc creating all mods unnecessarily
  Dan Balasescu · 2023-06-02 17:37:43 +09:00
  bfe80fe143
• Disable all tablet handlers to guard against a grim future
  Dean Herbert · 2023-06-02 08:48:47 +09:00
  c33ddedca0
• Merge pull request #23720 from peppy/fix-mouse-disappear-screenshot-fail

  Fix mouse cursor potentially disappearing for good if screenshot capture fails

  Bartłomiej Dach · 2023-06-01 23:09:23 +02:00
  f8289927d2
• Merge branch 'master' into editor-timeline-fix
  Bartłomiej Dach · 2023-06-01 21:18:08 +02:00
  8433813677
• Adjust inline comment
  Bartłomiej Dach · 2023-06-01 21:18:00 +02:00
  c2d89a32a9
• Fix nullability
  Andrei Zavatski · 2023-06-01 21:21:01 +03:00
  03eb7c7830
• Use combined area of children as a mask instead
  Andrei Zavatski · 2023-06-01 15:32:17 +03:00
  949fe32740
• Merge pull request #23691 from smoogipoo/mania-scroll-speed

  Replace mania scroll "time" with scroll "speed"

  Dean Herbert · 2023-06-01 17:23:27 +09:00
  00bf79d51f
• Use FireAndForget to avoid unobserved exception
  Dean Herbert · 2023-06-01 15:50:37 +09:00
  289f0e9862
• Fix mouse cursor potentially disappearing for good if screenshot capture fails
  Dean Herbert · 2023-06-01 15:50:13 +09:00
  0a7d5a51d4
• Automatically disable tablet support on error

  Closes #23710.

  Dean Herbert · 2023-06-01 15:16:48 +09:00
  9f8a13480b
• Return StatisticItems rather than StatisticRows from ruleset

  There were no usages of more than one column being provided per row, so
  it seemed like unnecessarily complexity. I'm currently trying to reduce
  complexity so we can improve the layout of the results screen, which
  currently has up to three levels of nested `GridContainer`s.
  
  Of note, I can't add backwards compatibility because the method
  signature has not changed in `Ruleset` (only the return type). If we do
  want to keep compatibility with other rulesets, we could designate a new
  name for the updated method.

  Dean Herbert · 2023-06-01 14:35:15 +09:00
  985604fab5
• Remove unused Dimension specification from StatisticItem
  Dean Herbert · 2023-06-01 14:25:18 +09:00
  dc595b83f1
• Merge pull request #23708 from peppy/labelled-slider-visibility

  Adjust background colour used in `LabelledDrawable`s to allow visibility of some elements

  Dean Herbert · 2023-06-01 13:08:17 +09:00
  55a3847036
• Merge pull request #23695 from peppy/realm-startup-error-handling

  Adjust realm startup for added reliability

  Bartłomiej Dach · 2023-05-31 22:46:58 +02:00
  d78df0b084
• Update framework
  Dean Herbert · 2023-06-01 00:44:13 +09:00
  7bc3b2072c
• Adjust background colour used in LabelledDrawables to allow visibility of sliders
  Dean Herbert · 2023-05-31 23:24:21 +09:00
  20439e80f6
• Merge pull request #23661 from peppy/fix-multiplayer-present-crash

  Fix `OnResume` / `OnSuspending` potentially getting called before `OnEntering` on a sub screen

  Dean Herbert · 2023-05-31 19:43:30 +09:00
  812def124f
• Gracefully handle failures in cleaning up pending file deletions
  Dean Herbert · 2023-05-31 19:39:43 +09:00
  18eb15bfa5
• Move comment to more correct place
  Bartłomiej Dach · 2023-05-30 23:18:34 +02:00
  2e81cae201
• Apply same comment & reworded condition to suspend too
  Bartłomiej Dach · 2023-05-30 21:54:56 +02:00
  62d1774407
• Fix editor timeline hitobjects popping in
  Andrei Zavatski · 2023-05-30 16:41:42 +03:00
  d119447a10
• Add comment and use full conditional similar to extension method

  Co-authored-by: Bartłomiej Dach <dach.bartlomiej@gmail.com>

  Dean Herbert · 2023-05-30 18:38:28 +09:00
  741ee84ed6
• Merge branch 'master' into scorev2
  Dean Herbert · 2023-05-30 14:34:43 +09:00
  14a376c041
• Split out multiplier retrieval into a function and use a default multiplier for all rulesets
  Dean Herbert · 2023-05-30 14:20:26 +09:00
  4e0f40bee5
• Merge branch 'master' into acc-challenge
  Dean Herbert · 2023-05-30 13:24:34 +09:00
  fd919879c3
• Adjust realm backup procedure to hard fail if running out of attempts

  Previously, if the backup procedure failed, startup would continue and
  the user's realm database may be deleted. I think in such a fail case
  I'd rather the game didn't startup so the user gets in touch (or reads
  the log files themselves) rather than potentially losing data.

  Dean Herbert · 2023-05-30 13:04:34 +09:00
  a0be526266
• Ensure a potential exception from cleanupPendingDeletions doesn't mark realm corrupt

  The whole restructure here is to move the nested call out of the
  `try-catch`. I noticed this while looking at a corrupt database issue a
  user reported (https://github.com/ppy/osu/discussions/23694).
  
  It's not the first time we've seen a corrupt database error where the
  "corrupt" version works just fine on a second attempt.
  
  Maybe this isn't the issue and it's just a transitive file access violation
  but it definitely feels like this should be fixed regardless.

  Dean Herbert · 2023-05-30 13:00:17 +09:00
  79694897be
• Merge pull request #23640 from 17steen/make_pause_menu_translatable

  Make GameplayMenuOverlay translatable

  Dean Herbert · 2023-05-30 09:36:19 +09:00
  61d9b50993