65317 Commits

This Branch

This Branch

All Branches

• Merge remote-tracking branch 'upstream/master' into edit-nodesample
  OliBomby · 2024-01-25 11:33:29 +01:00
  c2d57dc77c
• Merge pull request #26630 from peppy/s-rank-change

  Change S rank to require no miss

  Dean Herbert · 2024-01-24 13:27:40 +09:00
  2024.124.0 b272d34960
• Merge pull request #26674 from peppy/use-better-enumerator

  Reduce enumerator overhead in `GameplayLeaderboard`

  Bartłomiej Dach · 2024-01-23 16:31:17 +01:00
  871683a3dc
• Merge pull request #26680 from peppy/fix-now-playing-centering

  Fix now playing beatmap backgrounds not being correctly centred

  Bartłomiej Dach · 2024-01-23 16:17:34 +01:00
  0486c77a74
• Do not reprocess ranks for custom rulesets

  Chances are that because we've broken rank API, it would utterly fail
  for all custom rulesets anyhow.

  Bartłomiej Dach · 2024-01-23 12:59:36 +01:00
  6c169e3156
• Remove outdated test

  Non-legacy scores *are* subject to upgrades again - albeit it is *rank*
  upgrades that they are subject to.

  Bartłomiej Dach · 2024-01-23 12:53:16 +01:00
  0b5be3c40c
• Move transferal of LegacyTotalScore back to original spot

  This subtle detail was messing with server-side score import flows.
  Server-side, legacy total score will *already* be in `LegacyTotalScore`
  from the start, and `TotalScore` will be zero until recomputed via
  `StandardisedScoreMigrationTools.UpdateFromLegacy()` - so in that
  context, attempting to move it across is incorrect.

  Bartłomiej Dach · 2024-01-23 12:42:57 +01:00
  cb87d6ce50
• Apply more correct visual offset adjustment

  Co-authored-by: Walavouchey <36758269+Walavouchey@users.noreply.github.com>

  Dean Herbert · 2024-01-23 19:16:55 +09:00
  0cf90677e6
• Merge pull request #26677 from EVAST9919/triangles-better-clamp

  Implement per-axis clamping in `Triangles` backgrounds

  Dean Herbert · 2024-01-23 18:28:03 +09:00
  413c34ce06
• Fix now playing beatmap backgrounds not being correctly centred

  https://github.com/ppy/osu/discussions/26679

  Dean Herbert · 2024-01-23 17:30:00 +09:00
  c8cd7ebe6c
• Implement per-axis triangles clamping
  Andrei Zavatski · 2024-01-23 04:54:27 +03:00
  da992ccc55
• Remove redundant assertion

  It does look pretty dumb to be checking if something is `null` *after
  calling an instance method on it*...

  Bartłomiej Dach · 2024-01-22 22:01:03 +01:00
  4d253ebf3c
• Fix rank background processing not working (and not bumping score version)
  Bartłomiej Dach · 2024-01-22 21:34:28 +01:00
  fdd499a485
• Avoid using .Children for enumeration in other locations
  Dean Herbert · 2024-01-23 05:32:11 +09:00
  02bb506cce
• Reduce enumerator overhead in GameplayLeaderboard
  Dean Herbert · 2024-01-23 05:31:53 +09:00
  069af13aaf
• Expand xmldoc
  Bartłomiej Dach · 2024-01-22 21:13:59 +01:00
  24be6d92ce
• Update assertions to match expected behaviour
  Bartłomiej Dach · 2024-01-22 20:52:54 +01:00
  d53fb5a165
• Remove legacy computation of accuracy & ranks
  Bartłomiej Dach · 2024-01-22 20:52:54 +01:00
  cdd6e71d01
• Remove superfluous recomputation of accuracy
  Bartłomiej Dach · 2024-01-22 20:52:54 +01:00
  217cbf684b
• Unify legacy total score / accuracy / rank recomputation flows
  Bartłomiej Dach · 2024-01-22 20:52:51 +01:00
  db4849442e
• Use lazer accuracy & rank implementations across the board
  Bartłomiej Dach · 2024-01-22 20:30:16 +01:00
  2958631c5d
• Move maximum statistics population to LegacyScoreDecoder
  Bartłomiej Dach · 2024-01-22 20:01:24 +01:00
  aa8eee0796
• Add another failing tests covering recomputation of ranks
  Bartłomiej Dach · 2024-01-22 20:01:18 +01:00
  3f31593a19
• Adjust existing test to fail
  Bartłomiej Dach · 2024-01-22 20:00:00 +01:00
  81a02665b6
• Remove remnant of old implementation of showing "A due to misses"
  Bartłomiej Dach · 2024-01-22 19:58:11 +01:00
  45dc9de1e0
• Fix back-to-front conditional in taiko processor

  Would be weird to degrade a score due to *no* misses wouldn't it?

  Bartłomiej Dach · 2024-01-22 19:57:12 +01:00
  20ed7e13e3
• Make RankFromScore()'s dictionary param readonly

  Just to make sure nobody tries any "funny" business.

  Bartłomiej Dach · 2024-01-22 19:56:30 +01:00
  cb8ec48717
• Merge branch 'master' into s-rank-change
  Bartłomiej Dach · 2024-01-22 19:54:53 +01:00
  5bae9074aa
• Merge pull request #26608 from mouzedrift/taiko-drum-fade-fix

  Fix taiko legacy input drum animation fade not matching osu!stable

  Bartłomiej Dach · 2024-01-22 18:05:41 +01:00
  1cde18b895
• Merge pull request #26612 from peppy/fix-back-sample-playback

  Fix back sound being too loud when exiting many screens

  Bartłomiej Dach · 2024-01-22 16:18:32 +01:00
  4cd1573a4c
• Merge pull request #26667 from peppy/fix-star-fountains

  Fix star fountains sometimes resetting visually

  Bartłomiej Dach · 2024-01-22 16:13:55 +01:00
  3cf83e7106
• Merge branch 'master' into fix-back-sample-playback
  Bartłomiej Dach · 2024-01-22 15:36:32 +01:00
  43fa89ebcd
• Revert incorrect removal of exitConfirmed flag

  Removing it meant that it was _literally impossible_ to exit
  multiplayer.

  Bartłomiej Dach · 2024-01-22 15:35:03 +01:00
  9aa7c7f591
• Merge pull request #26668 from peppy/adjust-tick-end-misses

  Adjust slider tick / end miss animations to be less busy

  Bartłomiej Dach · 2024-01-22 15:03:33 +01:00
  b85a861175
• Merge pull request #26609 from peppy/fix-per-ruleset-hud-positioning

  Fix gameplay elements not correctly offsetting to avoid per-ruleset skin layout

  Bartłomiej Dach · 2024-01-22 15:00:03 +01:00
  49c117793c
• Merge pull request #26591 from peppy/offset-awareness

  Show offset explanation tooltip on settings offset adjust slider bar

  Bartłomiej Dach · 2024-01-22 14:59:31 +01:00
  95435ecd13
• Fix non-miss drawable judgements fading out instantly on triangles skin

  `else if` proves to be insidious once again.

  Bartłomiej Dach · 2024-01-22 14:23:46 +01:00
  17d05b0fdf
• Merge branch 'master' into fix-per-ruleset-hud-positioning
  Bartłomiej Dach · 2024-01-22 13:55:56 +01:00
  b8dd78eec8
• Revert keyboard seek speed change
  Dean Herbert · 2024-01-22 21:47:38 +09:00
  15df6b1da1
• Fix crash if ruleset components container is not present
  Bartłomiej Dach · 2024-01-22 13:45:55 +01:00
  99d3fcc326
• Adjust results screen to handle S->A rank adjustment when misses are present
  Dean Herbert · 2024-01-22 21:43:32 +09:00
  83f9118b22
• Add migration
  Dean Herbert · 2024-01-22 21:43:32 +09:00
  644e7d6fe6
• Move BackgroundDataStoreProcessor to better namespace
  Dean Herbert · 2024-01-22 21:43:32 +09:00
  4eba3b5d70
• Update test in line with new rank definitions always being applied
  Dean Herbert · 2024-01-22 21:43:32 +09:00
  bb1eab5844
• Change S rank to require no miss
  Dean Herbert · 2024-01-22 21:43:32 +09:00
  c8521b49cd
• Merge pull request #26648 from peppy/fix-followpoint-pooling

  Fix `FollowPointConnection` pool filling up when follow points are hidden

  Bartłomiej Dach · 2024-01-22 13:31:43 +01:00
  7f31070b87
• Merge pull request #26649 from peppy/fix-more-allocations

  Remove `FillFlow` overhead of argon counters

  Bartłomiej Dach · 2024-01-22 12:57:16 +01:00
  0d6c681275
• Merge pull request #26669 from bdach/fix-score-submission-test-failures-again-aaaaaaaaAAAAAA

  Fix score submission test failures due to checking audio playback validity (again)

  Dean Herbert · 2024-01-22 20:07:51 +09:00
  2ab0be7606
• Merge pull request #26600 from peppy/frame-stable-catchup-zoom

  Change frame stable catch-up method to allow for much faster sync

  Bartłomiej Dach · 2024-01-22 11:29:15 +01:00
  c8053a8077
• Fix score submission test failures due to checking audio playback validity (again)

  As seen in https://github.com/ppy/osu/actions/runs/7607899979/job/20716013982?pr=26662#step:5:75
  
  In https://github.com/ppy/osu/pull/26484, I went "well if I'm moving the
  enabling of validation of playback rate to `SubmittingPlayer` context,
  then surely I can remove the local override in the test scene, right?"
  
  Reader: Apparently I did not notice that `FakeImportingPlayer :
  TestPlayer : SoloPlayer : SubmittingPlayer`. So no, I could not remove
  the local override in the test scene.
  
  You could probably attempt to conjure up some excuse about deep
  inheritance hierarchies here but nah. Really just a failure to read
  on my behalf as usual.

  Bartłomiej Dach · 2024-01-22 11:15:42 +01:00
  9b2740f8a4