Dean Herbert
8193038986
Expose no-op constructors as protected
2024-10-18 13:30:29 +09:00
Dean Herbert
53671ad11e
Only update beatmaps which actually had offsets
...
Without this every beatmap gets a write and it reloads the whole of song
select, basically.
2024-10-14 00:35:18 +09:00
Artemis Rosman
e4f9c861ba
Add functionality to mass reset offsets
2024-10-13 00:50:45 +11:00
Dean Herbert
307cc5581d
Fix usage of locked context without locking
...
Raised in the latest Rider EAP, seems valid enough.
2024-10-01 18:01:06 +09:00
Dean Herbert
89e8baf1d3
Add inline comments for iOS locals
2024-09-26 16:48:42 +09:00
Dan Balasescu
3ab04d98f6
Fix Realm-related iOS crashes by removing object references
2024-09-25 16:45:37 +09:00
Bartłomiej Dach
a4f6d4a300
Backpopulate missing ranked/submitted dates using new local metadata cache
...
People keep asking why https://github.com/ppy/osu/pull/29553 didn't fix
their databases (as stated in the PR, it didn't intend to), so this
should do it for them.
2024-09-13 16:00:49 +02:00
Dan Balasescu
5d09aaae27
Merge pull request #29446 from OliBomby/last-anchor
...
Fix path control points losing curve type on save/reload or undo
2024-09-02 18:40:19 +09:00
Bartłomiej Dach
bd6943ebc2
Merge pull request #29537 from normalid-awa/feature/song-select/allow-copy-url-from-context-menu
...
Allow copying beatmap link in song select carousel context menu
2024-08-22 14:03:39 +02:00
Dean Herbert
066c34e950
Merge pull request #29553 from bdach/local-cache-updates
...
Add support for retrieving submit/rank date from local metadata cache in version 2
2024-08-22 14:55:43 +09:00
Dean Herbert
87123d99bf
Move URL implementation to extension methods and share with other usages
2024-08-22 02:08:01 +09:00
Dean Herbert
a943000579
Merge pull request #29435 from OliBomby/improve-snaps
...
Fix timeline snapping ignoring nearby timing points
2024-08-22 01:36:30 +09:00
Bartłomiej Dach
5f88435d96
Add support for retrieving submit/rank date from local metadata cache in version 2
...
Closes https://github.com/ppy/osu/issues/22416 .
2024-08-21 15:42:22 +02:00
OliBomby
8d72ec8bd6
move timing point binary search back inline
2024-08-21 01:50:52 +02:00
Bartłomiej Dach
c2dd2ad978
Clamp beat divisor to sane range when decoding
...
In my view this is a nice change, but do note that on its own it does
nothing to fix https://github.com/ppy/osu/issues/29492 , because of
`BeatmapInfo` reference management foibles when opening the editor. See
also: https://github.com/ppy/osu/issues/20883#issuecomment-1288149271 ,
https://github.com/ppy/osu/pull/28473 .
2024-08-20 13:52:29 +02:00
OliBomby
4cc38cea63
fix last anchor converting to implicit segment
2024-08-16 14:24:03 +02:00
Joseph Madamba
e2bf02cf94
Fix preview play button having incorrect click area
2024-08-15 22:49:12 -07:00
Joseph Madamba
fda17a5a72
Expose BeatmapCardNormal height const
2024-08-15 22:49:12 -07:00
OliBomby
2e11172e8e
Take into account next timing point when snapping time
2024-08-16 01:01:24 +02:00
OliBomby
ac064e814f
Add BinarySearchUtils
2024-08-16 00:15:40 +02:00
Dean Herbert
d2c1d83567
Merge branch 'master' into daily-challenge-intro-audio-auto-download
2024-08-10 01:21:43 +09:00
Dean Herbert
d072c6a743
Fix hit object coordinates being truncated to int values
...
Closes https://github.com/ppy/osu/issues/29340 .
2024-08-09 16:34:39 +09:00
Dean Herbert
5d66eda982
Add support for automatically downloading daily challenge during the intro display
2024-08-08 15:10:18 +09:00
Dean Herbert
60fc02bb9b
Merge branch 'master' into feature/skin/legacy-input-overlay
2024-08-06 14:05:33 +09:00
Dean Herbert
dc73856f76
Fix original date not being restored when no changes are made on an import-as-update operation
2024-08-02 20:46:03 +09:00
Bartłomiej Dach
3c28c116ca
Simplify input overlay text colour decode (and fix incorrect default)
2024-07-24 14:53:01 +02:00
normalid
b24be96d04
Fix code quality
2024-07-24 12:57:30 +08:00
normalid
c52a993607
Support custom input overlay color
2024-07-23 23:35:25 +08:00
Dean Herbert
f11f01f9b7
Fix various visuals of playlist beatmap panels
...
Supersedes https://github.com/ppy/osu/pull/28907 .
- Fix border being fat
- Fix thumbnail not masking correctly
- Fix background layer not being correctly fit to the panel
- Dim the main background on hover
- Minor tweaks to dimming
2024-07-19 19:26:04 +09:00
Dean Herbert
e6b7d2530e
Change red shade for timing control points
2024-07-12 13:39:40 +09:00
Dean Herbert
95464ebf36
Merge branch 'master' into timeline-redesign
2024-07-11 18:38:17 +09:00
Dean Herbert
b5bb94e4ec
Merge branch 'master' into file-mounting-v3
2024-07-11 15:54:54 +09:00
Dean Herbert
2eb6cf57af
Fix incorrect continuation in ImportAsUpdate causing UI blockage
2024-07-11 13:42:24 +09:00
Dean Herbert
2ba1ebe410
Fix beatmap card progress bar becoming pancake when starting
2024-07-10 19:19:49 +09:00
Dean Herbert
d3c66e2404
Add basic flow for mounting beatmaps for external editing
2024-07-10 18:29:51 +09:00
Bartłomiej Dach
5d5dd0de00
Redesign bottom timeline pieces to match stable better
2024-07-09 09:25:22 +02:00
Bartłomiej Dach
0d22c9a9c6
Pass comparer in all usages for consistency
2024-07-08 15:58:21 +02:00
Salman Ahmed
b33e54d064
Enforce IBeatmap.Breaks to be sorted chronologically
2024-07-08 16:06:38 +03:00
Dan Balasescu
537e3a1642
Merge pull request #28619 from bdach/fix-tail-volume-not-saving
...
Fix slider tail volume not saving
2024-07-03 16:13:18 +09:00
Dean Herbert
5350945340
Update HasFlag usages
2024-07-03 00:19:04 +09:00
Bartłomiej Dach
d4a8f6c8b0
Do not add extra sample control point after end of IHasRepeats objects
2024-07-02 09:13:07 +02:00
Dan Balasescu
04da1209f7
Revert "Change breaks list to IReadOnlyList"
...
This reverts commit 2c3b411bb5
2024-07-02 12:16:11 +09:00
Dan Balasescu
db84711214
Revert "Move break cloning back to non-virtual method"
...
This reverts commit f69bc40a4b
2024-07-02 12:16:10 +09:00
Dean Herbert
f69bc40a4b
Move break cloning back to non-virtual method
2024-07-02 12:07:13 +09:00
Dean Herbert
2c3b411bb5
Change breaks list to IReadOnlyList
2024-07-02 11:59:24 +09:00
Dean Herbert
f694ae416e
Fix typo in xmldoc
2024-07-02 11:47:40 +09:00
Dean Herbert
005af280f2
Isolate bindable breaks list to EditorBeatmap
2024-07-02 11:31:55 +09:00
Dan Balasescu
f942595829
Fix ManiaModInvert permanently messing up the beatmap
2024-07-01 15:02:00 +09:00
Bartłomiej Dach
847946937e
Fix test failures
2024-06-26 16:56:43 +02:00
Bartłomiej Dach
fff27e619d
Fix slider tail volume not saving
...
Closes https://github.com/ppy/osu/issues/28587 .
As outlined in the issue thread, the tail volume wasn't saving because
it wasn't actually attached to a hitobject properly, and as such the
`LegacyBeatmapEncoder` logic, which is based on hitobjects, did not
pick them up on save.
To fix that, switch to using `NodeSamples` for objects that are
`IHasRepeats`. That has one added complication in that having it work
properly requires changes to the decode side too. That is because the
intent is to allow the user to change the sample settings for each node
(which are specified via `NodeSamples`), as well as "the rest of the
object", which generally means ticks or auxiliary samples like
`sliderslide` (which are specified by `Samples`).
However, up until now, `Samples` always queried the control point
which was _active at the end time of the slider_. This obviously can't
work anymore when converting `NodeSamples` to legacy control points,
because the last node's sample is _also_ at the end time of the slider.
To bypass that, add extra sample points after each node (just out of
reach of the 5ms leniency), which are supposed to control volume of
ticks and/or slides.
Upon testing, this *sort of* has the intended effect in stable, with
the exception of `sliderslide`, which seems to either respect or _not_
respect the relevant volume spec dependent on... not sure what, and not
sure I want to be debugging that. It might be frame alignment, or it
might be the phase of the moon.
2024-06-26 15:52:16 +02:00
