399 Commits

Author	SHA1	Message	Date
Dan Balasescu	c0b13c7e1f	Refactor ScoreProcessor ComputeScore() methods	2022-08-29 13:51:10 +09:00
Dan Balasescu	9bca7223f6	Adjust xmldoc to better explain score contribution	2022-08-25 17:16:30 +09:00
Dan Balasescu	e2e10a8f26	Add some explanatory comments to conditions	2022-08-25 17:14:53 +09:00
Salman Ahmed	eb57ea76ab	Merge branch 'master' into legacy-combo-increase	2022-08-25 09:46:12 +03:00
Dan Balasescu	e7cbb6c63d	Fix test failures/nullability	2022-08-24 19:53:16 +09:00
Dan Balasescu	c9ff39f8c3	Add HitResult.LegacyComboIncrease	2022-08-24 19:46:41 +09:00
Dan Balasescu	5ec95c9269	Update ScoreProcessor to make use of MaximumStatistics	2022-08-24 19:46:41 +09:00
Dan Balasescu	f70af779a4	Add maximum statistics to ScoreInfo/SoloScoreInfo	2022-08-24 17:28:41 +09:00
its5Q	abca3d1b2a	Prefix common strings for context	2022-08-10 00:35:19 +10:00
its5Q	5080d62e77	Add missing localisation for settings enums	2022-08-08 21:51:23 +10:00
Salman Ahmed	a97170a272	Keep Rank bindable enabled on score fail	2022-07-21 08:16:17 +03:00
Salman Ahmed	9df49db45f	Include bonus/ignore judgements in statistics fill logic	2022-07-21 08:13:09 +03:00
Salman Ahmed	ad09e728fd	Move Passed assignment inside FailScore	2022-07-21 08:12:06 +03:00
Salman Ahmed	c1bcbd9c8a	Fix fail score not handling bonus/tick-only beatmaps	2022-07-21 07:20:59 +03:00
Salman Ahmed	0f0b19da4a	Populate score with remaining "miss" statistics on fail/exit	2022-07-21 06:01:36 +03:00
Salman Ahmed	c4089b71bd	Store maximum score results from simulated autoplay	2022-07-21 06:00:41 +03:00
Dan Balasescu	f8830c6850	Automated #nullable processing	2022-06-17 16:37:17 +09:00
Dan Balasescu	6351f652a2	Fix combo starting at 0 when spectating	2022-06-06 17:56:25 +09:00
Dan Balasescu	a638392e81	Rename member	2022-06-02 16:35:50 +09:00
Dan Balasescu	055845d4f5	Throw exception on access before ApplyBeatmap()	2022-06-02 16:34:45 +09:00
Dan Balasescu	e551e48697	Use ScoreInfo overload in more places	2022-06-02 11:01:46 +09:00
Dan Balasescu	425390e13b	Refactor to reduce nested conditions	2022-06-01 09:54:47 +09:00
Dan Balasescu	50c3dfca31	Apply code reviews	2022-06-01 09:54:47 +09:00
Dan Balasescu	1e0ee1b214	Expose MaximumScoringValues for user consumption	2022-05-31 19:49:37 +09:00
Dan Balasescu	93240073a6	Rename field + rewrite xmldoc a bit	2022-05-31 19:40:07 +09:00
Dan Balasescu	28d8799e11	Add overloads to + document + expose ExtractScoringValues	2022-05-31 19:40:07 +09:00
Dan Balasescu	d6d56ee22d	Fix unintentional truncation	2022-05-31 19:40:07 +09:00
Dan Balasescu	44ca350822	Reset minimal scoring values from frames	2022-05-31 19:40:07 +09:00
Dan Balasescu	20988be6bb	Fix incorrect value	2022-05-31 19:40:07 +09:00
Dan Balasescu	6ccdb61853	Use new ComputeScore() overload in more cases	2022-05-31 19:40:02 +09:00
Dan Balasescu	2289812801	Add method to compute score from ScoringValues	2022-05-31 19:39:53 +09:00
Dan Balasescu	a809a19eec	Remove getBonusScore()	2022-05-31 19:39:42 +09:00
Dan Balasescu	d0e3e50ca7	Extract score statistics directly into ScoringValues	2022-05-31 19:39:42 +09:00
Dan Balasescu	af0f934e1a	Move raw ScoreProcessor values into ScoringValues struct	2022-05-31 19:39:38 +09:00
Dan Balasescu	132c94c1b5	Remove Ruleset parameter from ResetFromReplayFrame()	2022-05-31 17:16:23 +09:00
Dan Balasescu	5ad9692467	Adjust minimum health targets to match osu-stable	2022-05-17 19:24:51 +09:00
Salman Ahmed	cccc9d7d39	Rename method to better reflect what it's doing	2022-04-27 00:03:48 +03:00
Salman Ahmed	31f64b1381	Fix HealthProcessor fail conditions not handling multiple invocations	2022-04-26 23:27:03 +03:00
Salman Ahmed	7d32490198	Change score accuracy grading logic to be inclusive	2022-04-26 04:55:27 +03:00
Salman Ahmed	8078a8c1f8	Simplify IncreasesCombo/BreaksCombo helper method implementation	2022-03-18 17:18:42 +03:00
Salman Ahmed	5ec2d86c09	Update ScoreProcessor to use new defined helper methods	2022-03-18 15:22:53 +03:00
Salman Ahmed	fc576b1369	Separate increase/break combo helper methods from AffectsCombo	2022-03-18 15:22:01 +03:00
Dan Balasescu	3a6d254d1f	Add safeguards around incorrect ruleset sources	2022-03-15 09:20:32 +09:00
Dan Balasescu	028750936c	Apply review suggestions	2022-03-14 17:10:37 +09:00
Dan Balasescu	3fff7f4b7e	Require ScoreProcessor to receive ruleset	2022-03-14 15:51:10 +09:00
Dan Balasescu	9cc7f70872	Nullable annotate classes	2022-03-14 15:38:00 +09:00
Dan Balasescu	cf91353009	Merge branch 'master' into scoreprocessor-rework	2022-03-10 16:14:28 +09:00
Dan Balasescu	c36badab4b	Add per-ruleset score multipliers for classic scoring	2022-03-10 10:26:09 +09:00
Dan Balasescu	6fd8b4d891	Safeguard method against invalid invocation	2022-03-08 22:30:44 +09:00
Dan Balasescu	f1c40bd9ed	Rework GetScore() method signatures + implementations ... Rename legacy-facing overload to mention as much	2022-03-08 22:30:44 +09:00