97 Commits

• Add legacy storyboard encoder (#37790)

  - Closes https://github.com/ppy/osu/issues/37757
  
  Commit-by-commit reading is recommended. Commits will be split to PRs on
  request but I consider this to be the minimal viable functional
  increment.
  
  ## Done
  
  - This adds a first version of a full storyboard encoder
  (a66dc406f498e35d4e0c8f2a462e946a9a1aeccc). I expect there to be hiccups
  due to weird corners of the `.osb` format; this is only intended to be
  somewhat correct as a start to build upon. Storyboarders are asked to
  file issues as necessary.
  - Due to the fact that storyboard definitions can reside both in the
  `.osu` and the `.osb`, b60698a95c4de1bfeb36fbb159fd5a6028920832 adds the
  required storage to be able to tell which storyboard element lives
  where, so that it can be decoded properly later.
  - In c9d3e04a4135886b5b0943c85f3cc6f4fe99c84c, the storyboard decoder is
  weaved into the beatmap decoder to handle the `.osu` part of the
  storyboard, via the
  `LegacyStoryboardEncoder.Encode{General,Events}ToBeatmap()` methods. For
  `.osb`s, `LegacyStoryboardEncoder.EncodeStandaloneStoryboard()` is
  intended, but for now is not used outside tests.
  - Because of the above, dd1c4e43dc51154cd67860f096712f8b4f229661 removes
  `Beatmap.UnhandledEventLines` as no longer required.
  - 26ac417ed98a8937c42e5f52c4e15ef065a48902 adds tests. They are mostly
  handwritten to ensure basic encode-decode roundtripping. Using existing
  storyboards is difficult, see "Known issues" section as to why.
  - 5cc542366db7caac38eb0729260d884905a2c0d5 fixes a bug in the storyboard
  decoder where the trigger group number was not properly negated on
  decode (see inline comment reference to relevant stable code).
  
  ## Known issues
  
  - Any and all variables in the `[Variables]` section are inlined into
  their usages by `LegacyStoryboardDecoder`, and as such
  `LegacyStoryboardEncoder` will end up inlining them and discarding the
  `[Variables]` section. As far as I can tell stable will also do this.
  - `LegacyStoryboardDecoder` splits all `M` (move) commands into
  `MX`/`MY` commands. Therefore, `LegacyStoryboardEncoder` will write out
  things in the same split way. I did not put in effort to attempt to
  reconcile this, for reasons of part laziness, part not wanting to bloat
  this already-large diff.
  - Ordering of storyboard samples on decode may not match the order on
  decode. I'm crossing fingers this doesn't matter.

  Bartłomiej Dach · 2026-05-20 17:46:51 +09:00
  0e443b1c47
• Fix replay/spectator scroll text not toggling with Ctrl+H (#37027)

  Intended to add toggle but forgot.
  
  This also fixes https://github.com/ppy/osu/issues/37012 via a convoluted
  refactor of a lot of stuff. The basic overview is:
  
  - Moved all replay overlay concerns out of `HUDOverlay`. We can display
  this above everything confidently (i think).
  - Split out `ReplayOverlay` and `ReplaySettingsOverlay` so the base
  class can handle the visibility, hotkeys and everything that should be
  shared with *all* replay overlay components going forward. `Ctrl+H` is
  supposed to hide any of these kinds of details, and I'm sure we'll add
  more in the future.
  - Reorganised some things in `Player` so the new structure would work.
  Mainly the overlays which add a black layer during fade out.

  Dean Herbert · 2026-04-01 11:29:25 +02:00
  279effe23c
• Add failing test
  Bartłomiej Dach · 2025-09-02 12:23:38 +02:00
  a799720232
• Add failing test case
  Bartłomiej Dach · 2025-08-19 12:03:12 +02:00
  62b4999184
• Mark some more recent flaky tests
  Dean Herbert · 2025-06-03 16:23:31 +09:00
  ef29eda3e0
• Fix one more test failure
  Bartłomiej Dach · 2025-04-25 08:14:12 +02:00
  ae8fb2ce08
• Separate gameplay leaderboard data management from display

  This is a prerequisite for supporting skinning of leaderboards.
  
  - New `IGameplayLeaderboardProvider` and `IGameplayLeaderboardScore`
    interfaces are introduced. They are strictly concerned with supplying
    leaderboard data.
  
  - Logic of managing display, which was previously jammed into the
    inheritance hierarchy of `GameplayLeaderboard`, is now moved into
    `IGameplayLeaderboardProvider` implementations. Solo play,
    multiplayer, and multiplayer spectator get their own implementation of
    the interface.
  
  - The inheritance hierarchy of `GameplayLeaderboard` and per-player
    overriding of the implementation of the gameplay leaderboard is gone.
    Only one drawable class (renamed to `DrawableGameplayLeaderboard`) is
    allowed to display the leaderboards, across all modes of play.

  Bartłomiej Dach · 2025-04-16 14:46:55 +02:00
  c231571f06
• Split out methods so retrieving the room is not a callback function
  Dean Herbert · 2025-03-04 19:19:53 +09:00
  918315aa65
• Merge branch 'master' into remove-selectedroom
  Dan Balasescu · 2025-03-04 17:00:43 +09:00
  cf3664349d
• Fix test
  Bartłomiej Dach · 2025-02-19 15:24:58 +01:00
  a274b9a1fd
• Remove SelectedRoom abstraction from OnlinePlayTestScene
  Dan Balasescu · 2025-02-12 22:55:19 +09:00
  205d6ecffb
• Merge branch 'master' into beatmap-info-purge
  Dean Herbert · 2024-11-22 18:47:32 +09:00
  086a34f5c0
• Enable NRT for multiplayer and playlists
  Dan Balasescu · 2024-11-21 20:32:09 +09:00
  6870c99eb2
• Move AudioLeadIn out of BeatmapInfo
  Bartłomiej Dach · 2024-06-12 13:04:28 +02:00
  4339e2dc4a
• Reorder command properties to match general format

  I had them shuffled around in the middle of the refactor.

  Salman Ahmed · 2024-03-08 21:33:53 +03:00
  c1649b76d6
• Add generics to ApplyInitialValue/ApplyTransforms for ability to return custom transform sequences

  *sigh*

  Salman Ahmed · 2024-03-08 03:07:39 +03:00
  fa9b2f0cd5
• Apply major refactor to the storyboard commands flow structrure
  Salman Ahmed · 2024-03-08 01:10:09 +03:00
  585ab59768
• Add more test coverage to multi spectator screen
  Dean Herbert · 2023-08-16 17:14:42 +09:00
  26d05afadc
• Merge branch 'master' into multi-spectator-flow-fixes
  Bartłomiej Dach · 2023-08-01 19:03:48 +02:00
  5b6c3321cf
• Add visual-only test coverage for centred player case
  Bartłomiej Dach · 2023-08-01 17:41:07 +02:00
  bcfc76b469
• Add failing test coverage showing crash on multiple StartGameplay invocations
  Dean Herbert · 2023-08-01 19:21:58 +09:00
  ed0c7e8880
• Add test with only one player
  Dean Herbert · 2023-07-30 14:40:24 +09:00
  feea412bec
• Remove no longer necessary interface type
  Dean Herbert · 2023-01-18 15:23:55 +09:00
  e8770b84cd
• refactor(hud/gameplay/SongProgress): Add interface to designate SongProgressBars
  tsrk · 2023-01-09 21:48:53 +01:00
  0f1fe1d683
• Partial everything
  Dan Balasescu · 2022-11-27 00:00:27 +09:00
  7bc8908ca9
• Change Leaderboard to use IUser instead of APIUser
  Dean Herbert · 2022-09-13 18:00:21 +09:00
  d2b80645ab
• Add test coverage of track rate adjusting during multi spectator
  Dean Herbert · 2022-09-07 20:00:24 +09:00
  770c1ade2f
• Split out test assertion methods to read better
  Dean Herbert · 2022-08-26 16:56:03 +09:00
  9050f54681
• Fix lead in tests not waiting for player to start running

  The tests are only meant to ensure that gameplay eventually starts.
  
  The case where failures can occur is where the master clock is behind
  the player clock (due to being in lead-in time). Because the test is
  running in real-time, it can take arbitrary amounts of time to catch up.
  
  If it took too long, the test would fail.

  Dean Herbert · 2022-08-25 18:00:14 +09:00
  a8c699610a
• Rename asserts to method names to make it easier to track in logs
  Dean Herbert · 2022-08-25 17:30:13 +09:00
  ddb434f47a
• Improve understandability of TestMostInSyncUserIsAudioSource
  Dean Herbert · 2022-08-25 16:47:33 +09:00
  a5c61d9a52
• Remove dollar sign
  Dean Herbert · 2022-08-24 17:17:59 +09:00
  ddccf4defe
• Rename PlayerArea.GameplayClock to SpectatorPlayerClock for clarity
  Dean Herbert · 2022-08-24 17:13:14 +09:00
  27b57947e4
• Ensure elapsed time is always non-zero when advancing SpectatorPlayerClock
  Dean Herbert · 2022-08-24 17:13:14 +09:00
  5f01f461b3
• Rename spectator clock sync classes
  Dean Herbert · 2022-08-24 15:13:08 +09:00
  995e6664b6
• Update usages of GameplayClockContainer.GameplayClock to access properties directly
  Dean Herbert · 2022-08-15 18:08:49 +09:00
  6d78218142
• Fix multi-spectator test updating state after removing user

  Removing user triggers `playingUsers.Remove`, but doing so before
  updating the state leads to `EndGameplay` being called with `State ==
  Playing` rather than `Quit`.

  Salman Ahmed · 2022-08-06 05:41:26 +03:00
  789e8b4d8d
• Fix potential test failures due to Setup/SetUpSteps ordering
  Dan Balasescu · 2022-07-29 15:27:39 +09:00
  aaa6f963bd
• Update various tests to enable NRT to avoid new inspection failures
  Dean Herbert · 2022-07-07 17:51:49 +09:00
  dd5b127fb5
• Automated #nullable processing
  Dan Balasescu · 2022-06-17 16:37:17 +09:00
  f8830c6850
• Fix existing test coverage false-passing

  Also improves general test coverage to test more realisticly, in order
  to produce accurate results.

  Salman Ahmed · 2022-05-21 17:12:04 +03:00
  d73afcaf48
• Remove startFromSkipTarget parameter and update usages that required said behaviour
  Dean Herbert · 2022-04-13 14:25:43 +09:00
  fbf0e5a45c
• Fix test regression due to missing argument
  Dean Herbert · 2022-03-18 16:27:14 +09:00
  4bc7c69bf7
• Tidy up constructor logic overlap with gameplayStartTime
  Dean Herbert · 2022-03-18 01:35:50 +09:00
  e3ab5de8cd
• Merge branch 'master' into spectator-reliability
  Dan Balasescu · 2022-02-25 20:20:30 +09:00
  e947c97e10
• Add chat display to multiplayer spectator screen
  Dan Balasescu · 2022-02-25 16:03:28 +09:00
  f9d9ad388b
• Add ability to simulate network failures to TestSpectatorClient
  Dean Herbert · 2022-02-24 02:23:48 +09:00
  c94e7e2abe
• Prefix all test send methods in TestSpectatorClient with Send
  Dean Herbert · 2022-02-24 02:23:48 +09:00
  14c8ce50a0
• Rename "client" fields in tests to specify whether spectator or multiplayer
  Dean Herbert · 2022-02-16 09:52:18 +09:00
  6a08fd57ef
• Add failing test case
  Salman Ahmed · 2022-01-30 01:46:10 +03:00
  4f4f60248f