57 Commits

Author	SHA1	Message	Date
Bartłomiej Dach	df43e758ee	Add editable beatmap skin	2021-08-15 21:18:07 +02:00
Dean Herbert	3ae5f6707a	Expose whether an EditorBeatmap has timing present or not via bindable	2021-07-17 02:30:00 +09:00
Dean Herbert	f3c7694eeb	Rename methods to match generally how these find-methods are named elsewhere	2021-04-28 16:57:52 +09:00
Dean Herbert	48d6c9ac4b	Move snap/divisor helper methods to inside ControlPointInfo	2021-04-28 16:47:30 +09:00
Naxess	7b9ed924be	Rename snapping methods ... Further separates them from `IBeatSnapProvider`'s `SnapTime`, and groups them together more, to prevent confusion between the two interfaces. Also changes the xmldoc of the reference time to that of `IBeatSnapProvider` for consistency.	2021-04-26 16:07:30 +02:00
Naxess	049e42fa85	Move snapping responsibility to IBeatmap ... Seems `EditorBeatmap` already implements a different kind of `SnapTime` from `IBeatSnapProvider`, so method names here aren't great. This is very similar to what https://github.com/ppy/osu/pull/12558 is doing, so may need to do some duplicate resolution later, especially surrounding `ClosestBeatSnapDivisor`. Worth noting that this change makes 1/7, 1/5, etc unsupported for now, as we now rely on `BindableBeatDivisor.VALID_DIVISORS`.	2021-04-26 05:07:24 +02:00
Bartłomiej Dach	6f2ebb20a7	Fix test failing due to null beatmap skin ... Also annotate the field on `EditorBeatmap` as nullable for future travelers.	2021-04-18 20:46:42 +02:00
Dean Herbert	cd1c1bf534	Centralise cases of performing actions on the current selection ... By moving this to a central location, we can avoid invoking the EditorChangeHandler when there is no selection made. This helps alleviate the issue pointed out in https://github.com/ppy/osu/issues/11901, but not fix it completely.	2021-02-26 14:15:13 +09:00
smoogipoo	69ca440ae5	Merge branch 'master' into more-accurate-most-common-bpm	2021-02-08 18:40:58 +09:00
Dean Herbert	d6e6b4bbee	Revert forced cloning of ControlPointInfo ... This reverts commit 3c3e860dbc. Closes https://github.com/ppy/osu/issues/11491.	2021-01-15 17:34:59 +09:00
smoogipoo	c6e9a6cd5a	Make most common BPM more accurate	2021-01-15 14:28:49 +09:00
Dean Herbert	4ccd751604	Further simplify non-transactional change logic	2020-10-08 18:42:53 +09:00
Dean Herbert	3114174e09	Add missing non-transactional SaveState calls	2020-10-08 18:41:03 +09:00
Dean Herbert	afed832b19	Tidy up EditorBeatmap slightly	2020-10-08 18:06:49 +09:00
Dean Herbert	1027b608ff	Copy list content before firing events to avoid pollution	2020-10-08 18:04:07 +09:00
Dean Herbert	0781fbd443	Make EditorBeatmap implement TransactionalCommitComponent	2020-10-08 18:04:07 +09:00
Dean Herbert	ef092de9ba	Add missing UpdateHitObject calls and move local to usages (not via bindables)	2020-10-08 18:04:07 +09:00
Dan Balasescu	f206ea96ce	Merge pull request #10391 from peppy/editor-setup-screen-difficulty-adjust ... Add difficulty adjustment settings to editor setup screen	2020-10-07 16:33:10 +09:00
Dean Herbert	c1a8fe01ef	Fix postprocess order in batch events	2020-10-07 11:09:45 +09:00
Dean Herbert	09f5e9c9eb	Use batch change application in many places that can benefit from it	2020-10-06 22:10:07 +09:00
Dean Herbert	14c734c244	Add a very simple method of applying batch changes to EditorBeatmap	2020-10-06 22:10:07 +09:00
Dean Herbert	7a20a34aff	Add support to EditorBeatmap to update all hitobjects	2020-10-06 17:36:18 +09:00
Dean Herbert	1fcf443314	Ensure BeatmapProcessor.PostProcess is run before firing HitObjectUpdated events	2020-09-18 19:33:03 +09:00
Dean Herbert	daf54c7eb9	Revert EditorBeatmap.Remove API	2020-09-14 17:55:41 +09:00
Dean Herbert	692f2c8489	Simplify debounced update pathway	2020-09-14 14:58:00 +09:00
Dean Herbert	3854caae9b	Remove secondary schedule logic	2020-09-12 21:23:12 +09:00
Dean Herbert	8e028dd88f	Fix incorrect ordering of ApplyDefaults for newly added objects	2020-09-11 19:54:11 +09:00
Craftplacer	c2ade44656	Change types back	2020-09-01 17:58:06 +02:00
Craftplacer	db413686bb	Add BeatmapSkin to EditorBeatmap	2020-08-30 21:12:45 +02:00
smoogipoo	dcfef6b443	Add clear method to EditorBeatmap	2020-05-08 18:46:37 +09:00
smoogipoo	c96bc5c51c	Fix undo/redo behaving poorly with simultaneous objects	2020-04-30 20:39:41 +09:00
Dean Herbert	0c60dbe796	Merge branch 'master' into editor-undo-redo	2020-04-13 16:03:53 +09:00
smoogipoo	ee7e2b0854	Fix editor beatmap potentially not updating hitobjects	2020-04-10 13:29:46 +09:00
smoogipoo	86243d463f	Add legacy beatmap diffing	2020-04-09 20:48:59 +09:00
smoogipoo	ee6ea08cf8	Cleanup handling of hitobject updates	2020-04-09 20:16:44 +09:00
Dean Herbert	801e39a543	Improve xmldoc for PlacementObject	2020-02-08 11:35:27 +09:00
Dean Herbert	e08437c5dc	Track placement object in EditorBeatmap	2020-02-07 18:03:14 +09:00
Dean Herbert	96986bf5fc	Remove beat divisor from ctor and use DI instead	2020-02-05 17:48:21 +09:00
Dean Herbert	63c595ed97	Make EditorBeatmap a component and move UpdateHitObject to it	2020-02-05 17:48:21 +09:00
smoogipoo	9a47428bfd	Remove out of date comment	2020-01-29 14:40:42 +09:00
Dean Herbert	596a01661c	Remove 1ms offset and update tests	2020-01-28 13:42:22 +09:00
Dean Herbert	58654f28b6	Fix beat snap implementation being incorrect	2020-01-28 12:48:24 +09:00
Dean Herbert	289be7a17b	Merge branch 'i-beat-snapping' into timeline-maybe	2020-01-23 15:45:33 +09:00
Dean Herbert	ccf911884b	Remove passed in BaetDivisor	2020-01-23 15:31:56 +09:00
Dean Herbert	098d643955	Move beat snapping to its own interface	2020-01-23 14:39:56 +09:00
Dean Herbert	56c044c44a	Move beat snapping to its own interface	2020-01-23 14:30:25 +09:00
Dean Herbert	c88bdbd4a0	Share selected hitobjects across multiple blueprint containers	2020-01-21 20:46:39 +09:00
Dean Herbert	f09f9eb07d	Merge branch 'master' into general-editor-beatmap	2020-01-01 23:27:08 +09:00
Dean Herbert	4f2fa2626a	Centralise calls to mutable hitobjects list	2020-01-01 21:24:00 +09:00
smoogipoo	8c378dc625	Move EditorBeatmap construction/conversion to Editor	2019-12-30 14:51:14 +09:00