466 Commits

• Merge pull request #8238 from voidedWarranties/editor-song-end
  Dean Herbert · 2021-03-19 16:32:23 +09:00
  711d895a04
• Fix selection box operation hotkeys not registering in change handler

  Could lead to crashes after reversing a note cluster and playing it
  back.
  
  The root cause of the crash was that the hotkey operations were not ran
  inside of an editor change handler operation. This, in turn, caused the
  autoplay replay to not be regenerated after flipping an object cluster,
  therefore finally manifesting as a hard crash due to negative time
  offsets appearing in judgement results, which interfered with the
  default implementation of note lock.
  
  Note that this incidentally also fixes the fact that selection box
  hotkey operations (reverse and flip) did not handle undo/redo.

  Bartłomiej Dach · 2021-03-17 22:17:42 +01:00
  2e63c2ce20
• Merge branch 'master' into editor-song-end
  Bartłomiej Dach · 2021-03-17 18:18:19 +01:00
  a691291ae8
• Centralise cases of performing actions on the current selection

  By moving this to a central location, we can avoid invoking the
  EditorChangeHandler when there is no selection made. This helps
  alleviate the issue pointed out in
  https://github.com/ppy/osu/issues/11901, but not fix it completely.

  Dean Herbert · 2021-02-26 14:15:13 +09:00
  cd1c1bf534
• Move default sample addition to inside PlacementBlueprint

  This isn't actually required to fix the behaviour but it does feel like
  a better place to put this logic.

  Dean Herbert · 2021-02-11 17:16:18 +09:00
  e9730d4782
• Merge branch 'master' into zero-spinner-slider
  Vincent Maggioli · 2021-02-05 09:40:55 -05:00
  96652e07cd
• Switch to beat length
  vmaggioli · 2021-02-05 09:39:14 -05:00
  5061231e59
• Fix TimelineParts not using correct beatmap
  Dean Herbert · 2021-01-25 18:44:36 +09:00
  b489e92c9e
• Merge branch 'master' into fix-editor-scroll-interruption
  Dan Balasescu · 2021-01-21 17:46:18 +09:00
  04095cd5b9
• Apply comment suggestion

  Co-authored-by: Bartłomiej Dach <dach.bartlomiej@gmail.com>

  Dan Balasescu · 2021-01-21 17:40:15 +09:00
  9eb74e86ed
• Use AlmostEquals
  vmaggioli · 2021-01-20 13:00:25 -05:00
  5ee3a5f230
• Fix zero length spinners and sliders
  vmaggioli · 2021-01-20 12:19:52 -05:00
  ce3c2f07dc
• Expose and consume boolean covering whether an ongoing smooth seek is running
  Dean Herbert · 2021-01-15 16:14:38 +09:00
  831c06a3c7
• Rename and add xmldoc for smooth seeking method
  Dean Herbert · 2021-01-15 16:14:21 +09:00
  04fa32bc34
• Fix editor timeline not snapping on non-precise wheel scroll

  For wheel input with precision, we still prefer exact tracking for now.
  May change this in the future based on feedback from mappers, but it
  makes little sense to do non-snapped scrolling when input is coming from
  a non-precise source.

  Dean Herbert · 2021-01-15 15:47:42 +09:00
  ed78be825f
• Highlight timeline drag area when hovered for better visibility
  Dean Herbert · 2020-12-21 18:10:11 +09:00
  423c6158e1
• Increase height of timeline drag area
  Dean Herbert · 2020-12-21 18:09:56 +09:00
  d1be7c23d9
• Increase size of circle display on timeline
  Dean Herbert · 2020-12-21 18:09:37 +09:00
  d11d754715
• Use yet another solution leveraging padding
  Bartłomiej Dach · 2020-12-18 23:45:42 +01:00
  f1878eff63
• replace drag cirle function with dictionary
  Graham Johnson · 2020-12-18 10:45:23 -05:00
  122250f454
• X before Y for sanity
  Dean Herbert · 2020-12-18 11:20:21 +09:00
  9079d33412
• Fix spacing
  Dean Herbert · 2020-12-18 11:19:40 +09:00
  44f4ed4fd3
• update comment
  Graham Johnson · 2020-12-17 19:40:21 -05:00
  a0235a06e6
• Align the drag circles on the selction box in the editor to be on the center of the border
  Graham Johnson · 2020-12-17 19:34:16 -05:00
  a01ed1827a
• improve selection box rotation UX
  Graham Johnson · 2020-12-13 07:58:58 -05:00
  7d2b77cdbd
• Merge pull request #11033 from smoogipoo/immutable-hit-samples

  Make HitSampleInfo immutable

  Dean Herbert · 2020-12-02 14:44:26 +09:00
  71a121389b
• Allow editor change handler to be null
  Bartłomiej Dach · 2020-12-01 20:08:31 +01:00
  94a8784e04
• Fix timeline not updating ticks correctly after arbitrary timing control point changes
  Dean Herbert · 2020-12-01 16:44:08 +09:00
  190c6ef45e
• Make HitSampleInfo immutable
  smoogipoo · 2020-12-01 15:37:51 +09:00
  5760e1c1fc
• Merge branch 'master' into editor-beat-snap-always
  Dean Herbert · 2020-11-30 18:34:38 +09:00
  c17d67bc7d
• Avoid updating hitobjects unnecessarily for start time changes

  This was firing regardless of whether the start time was changed, such
  as where beat snap provided the same time the object already has.
  
  The case where a change actually occurs is already handled by
  EditorBeatmap (see `startTimeBindables`), so it turns out this local
  handling is not required at all.

  Dean Herbert · 2020-11-27 16:31:06 +09:00
  7edbba58f7
• Merge pull request #10971 from smoogipoo/fix-timeline-combo-colour

  Fix timeline blueprints sometimes not receiving combo colours

  Dean Herbert · 2020-11-26 19:47:21 +09:00
  741902f1b3
• Apply beat snap if positional snap doesn't give a time result
  Dean Herbert · 2020-11-26 19:20:51 +09:00
  da6bccc812
• Expose EditorClock for consumption
  Dean Herbert · 2020-11-26 19:20:39 +09:00
  91592cf32d
• Rename application method to better describe what it actually does
  Dean Herbert · 2020-11-26 19:16:18 +09:00
  9811c46e35
• Completely separate combo colours from DHOs
  smoogipoo · 2020-11-26 18:14:25 +09:00
  e53f849aa0
• Fix timeline objects sometimes not receiving combo colours
  smoogipoo · 2020-11-26 17:22:22 +09:00
  f562854feb
• Fix incorrect index lookup on non-ordered selections
  Dean Herbert · 2020-11-25 17:25:54 +09:00
  0ddeff648d
• Make all objects in selection candidates for spatial snapping

  Closes #10898.

  Dean Herbert · 2020-11-24 17:35:54 +09:00
  c9a41f9dae
• Add comment + xmldoc
  smoogipoo · 2020-11-18 13:37:15 +09:00
  f00c23b4a0
• Make sealed and cleanup comparator
  smoogipoo · 2020-11-18 13:33:22 +09:00
  783c172b5d
• Define blueprint order similarly to hitobjects
  smoogipoo · 2020-11-17 22:56:31 +09:00
  58c8184ad7
• Merge branch 'master' into fix-quick-delete-crash
  Dean Herbert · 2020-11-16 13:54:54 +09:00
  7b79b9b9c1
• Refactor beginClickSelection in a slightly different way
  Bartłomiej Dach · 2020-11-15 21:06:47 +01:00
  399a1a16a0
• Revert beginClickSelection logic
  kamp · 2020-11-15 16:54:48 +01:00
  1db303b159
• Add more missed null checks
  Bartłomiej Dach · 2020-11-14 15:52:12 +01:00
  8a78d408db
• Add null checks to unguarded resolved-as-null fields
  Bartłomiej Dach · 2020-11-14 14:52:58 +01:00
  610ed99ae3
• Fix crash on shift+right-click deleting objects
  kamp · 2020-11-14 13:20:16 +01:00
  4d2bc790fd
• Add timeline visible range adjustment
  smoogipoo · 2020-11-13 17:10:29 +09:00
  0219aff7bc
• Add pooling support to the editor
  smoogipoo · 2020-11-13 17:08:20 +09:00
  3957697c48