OliBomby
5d82190b70
Merge remote-tracking branch 'upstream/master' into legacy-export
2023-07-18 12:18:49 +02:00
OliBomby
c02684d985
truncate hit object end time
2023-07-18 12:18:43 +02:00
Bartłomiej Dach
88ac53557a
Merge pull request #24236 from Joehuu/remove-android-manifest-overlay
...
Remove android manifest overlay
2023-07-17 22:12:11 +02:00
Bartłomiej Dach
551c243945
Merge pull request #24189 from peppy/discord-rpc-reconnect-fix
...
Re-enable connection retrying on discord connector
2023-07-17 19:58:37 +02:00
NiceAesth
ff529d9df7
Rename variables, fix check message formatting
2023-07-17 20:48:53 +03:00
Bartłomiej Dach
17aac0694e
Re-enable connection retrying on discord connector
2023-07-17 19:19:03 +02:00
Dean Herbert
66269be189
Merge pull request #24256 from tybug/update-download-icon
...
Use `FontAwesome.Download` for updates instead of `FontAwesome.Upload`
2023-07-17 12:25:04 +09:00
NiceAesth
b3974b34e7
Test break checks
2023-07-16 23:03:30 +03:00
NiceAesth
3888471148
Add break length and bounds checks
2023-07-16 23:03:21 +03:00
Liam DeVoe
6200e207d2
use fa_download for updates instead of fa_upload
2023-07-16 15:21:15 -04:00
Dean Herbert
a472fe6789
Merge pull request #24255 from bdach/multiplayer-disconnection-schedule-bomb
...
Fix several issues in multiplayer exit-on-disconnection flow
2023-07-17 04:04:38 +09:00
Bartłomiej Dach
7fbd47e9ee
Fix MultiplayerMatchSubScreen
erroneously pushing exit dialog on API failure
...
If `IAPIProvider.State` changes from `Online` at any point when being on
an `OnlinePlayScreen`, it will be forcefully exited from. However,
`MultiplayerMatchSubScreen` had local logic that suppressed the exit in
order to show a confirmation dialog.
The problem is, that in the suppression logic,
`MultiplayerMatchSubScreen` was checking
`MultiplayerClient.IsConnected`, which is a SignalR flag, and was not
checking `IAPIAccess.State`, which is maintained separately. Due to
differing timeouts and failure thresholds, it is not impossible to have
`MultiplayerClient.IsConnected == true` but `IAPIAccess.State !=
APIState.Online`.
In such a case, the match subscreen would wrongly consider itself to be
still online and due to that, push useless confirmation dialogs, while
being in the process of being forcefully exited. This then caused the
dialog to cause a crash, as it was calling `.Exit()` on the screen which
would already have been exited by that point, by the force-exit flow.
2023-07-16 19:56:22 +02:00
Bartłomiej Dach
cd02a8a9ca
Fix PopupDialog
potentially accumulating schedules during load
2023-07-16 19:43:37 +02:00
Dean Herbert
a6b1559e1f
Update DiscordRichPresence
to pull in performance fix
...
See https://github.com/Lachee/discord-rpc-csharp/pull/237
2023-07-17 02:24:51 +09:00
Dean Herbert
acb51dfca3
Merge pull request #24246 from bdach/fix-exit-dialog-crash
...
Fix potential crash in confirm exit dialog while attempting to exit game
2023-07-17 01:11:07 +09:00
Dean Herbert
e25cd03e4b
Update framework
2023-07-17 00:55:25 +09:00
Bartłomiej Dach
a42992d3fd
Remove unused local variable
2023-07-16 17:10:26 +02:00
Bartłomiej Dach
d25a03984b
Fix PerformAction<T>()
potentially crashing when no matching button is found
2023-07-16 16:55:20 +02:00
Bartłomiej Dach
72bf43e297
Add failing test covering exit dialog crash
2023-07-16 16:55:20 +02:00
Joseph Madamba
ce12afde70
Remove android manifest overlay
2023-07-15 23:38:06 -07:00
Dean Herbert
50e6f0aee9
Merge pull request #24233 from chayleaf/fix-taiko-maps-not-finishing
...
Fix taiko maps sporadically not completing with Hidden mod active
2023-07-16 13:32:38 +09:00
Dean Herbert
416ee0d99c
Fix covariant array spec in new test
2023-07-16 12:48:58 +09:00
Dean Herbert
2d51aa21b7
Merge pull request #24235 from AkiSakurai/toplocalrank
...
Compute the top local rank directly without an expensive detach call
2023-07-16 12:14:56 +09:00
Dean Herbert
cf70f5e04d
Merge pull request #24219 from peppy/fix-mania-everything
...
Fix osu!mania scores failing to convert to new standardised score due to cast failure
2023-07-16 11:54:42 +09:00
Aki
cb354685ca
simplify code
2023-07-16 10:21:32 +08:00
Bartłomiej Dach
041e818892
Fix nested hits not being hittable if cut off by parent object ending
2023-07-15 18:44:47 +02:00
Bartłomiej Dach
955aa70e46
Add failing test case for hitting nested hit past parent end time
2023-07-15 18:43:31 +02:00
Bartłomiej Dach
9e960894c2
Add inline commentary about OnKilled()
override
2023-07-15 18:22:04 +02:00
Bartłomiej Dach
24d63a4d96
Add test coverage for failing hit judgement with HD active
2023-07-15 18:17:45 +02:00
Bartłomiej Dach
542916f857
Bring back test coverage for fail case from #16475
...
It was inadvertently dropped during refactoring in
b185194d07
.
2023-07-15 18:15:42 +02:00
chayleaf
3e91d30825
move StrongNestedHit OnKilled to DrawableStrongNestedHit
2023-07-15 22:33:16 +07:00
Aki
309c852222
Compute the top local rank directly without an expensive detach call
2023-07-15 23:00:13 +08:00
chayleaf
7f957d3fbe
Fix some taiko maps not finishing in some conditions
...
I don't know how to reproduce this issue in a test, so no tests for now.
Nonetheless, this fixes the issue for me at least on one map:
https://osu.ppy.sh/beatmapsets/1899665#taiko/3915653
This workaround is similar to #16475 (the test from that commit got
eventually removed for some reason).
2023-07-15 20:24:40 +07:00
Dean Herbert
eb81eac635
Flag decoded scores more correctly
2023-07-15 12:19:18 +09:00
Dean Herbert
e58488d04a
Fix incorrect comparer implementation
2023-07-15 11:19:34 +09:00
Dean Herbert
1868826d69
Update framework
2023-07-15 01:12:10 +09:00
Dean Herbert
480259b8d2
Ensure migration is never run on scores with new-enough TotalScoreVersion
s
2023-07-14 20:02:25 +09:00
Dean Herbert
d4fb0bef95
Fix osu!mania scores failing to convert to new standardised score due to cast failure
...
Regressed in https://github.com/ppy/osu/pull/23917 .
Closes #24217 .
2023-07-14 19:38:10 +09:00
Dean Herbert
fe70f24925
Update design of summary timeline current time marker
2023-07-14 17:00:42 +09:00
Dean Herbert
e6b8cd0c06
Add editor header
2023-07-14 16:55:12 +09:00
Dean Herbert
57abb15724
Update design of timeline centre marker and adjust surrounding paddings
2023-07-14 16:37:57 +09:00
Dean Herbert
00e9746174
Implement longer design for timing point piece
2023-07-14 16:37:56 +09:00
Dean Herbert
6b222cfafd
Fix slight misalignment so timeline is now completely centered
2023-07-14 14:29:13 +09:00
Dean Herbert
01750dd091
Update metrics of checkboxes and backgrounds to match design better
2023-07-14 14:29:02 +09:00
Dean Herbert
1dc293ed61
Allow specifying a custom width for nubs in OsuCheckbox
es
2023-07-14 14:24:55 +09:00
Dean Herbert
5b2e704264
Move beat divisor control inside of TimelineArea
and adjust metrics to match design
2023-07-14 14:19:04 +09:00
Dean Herbert
ebaf63b764
Apply NRT to timeline related classes
2023-07-14 14:04:12 +09:00
Dean Herbert
56acc9e3dd
Change BeatDivisorControl
to retrive bindable divisor via DI
2023-07-14 14:03:25 +09:00
Dean Herbert
dd8774a640
Vertically centre the editor osu! playfield
2023-07-14 13:21:28 +09:00
Bartłomiej Dach
cdbb6f90be
Merge pull request #24199 from peppy/revert-to-default-design-change
...
Update design of "revert to default" button
2023-07-13 23:44:24 +02:00