Bartłomiej Dach
b811b9baf6
Fix DetachedBeatmapStore special condition for detecting resets from blocking all operations failing on empty databases
...
See https://discord.com/channels/188630481301012481/188630652340404224/1293309912591368244 .
2024-10-08 23:16:17 +02:00
Bartłomiej Dach
1633cbdb66
Fix OsuGameBase.Migrate() eating exception messages for breakfast
...
Whomst've thought this was an ok thing to do? How did this pass review?
Let's leave these as rhetorical questions right now. Huge chances are
I'd implicate myself with at least one of them.
2024-10-08 23:16:17 +02:00
Bartłomiej Dach
310eec69fc
Fix any and all migration attempts dying on MusicController
...
I'm not sure why this was "fine" for as long as it apparently was,
but what `MusicController` was doing was completely incorrect and
playing with fire (accessing raw managed realm objects), which went
wrong somewhere around - admittedly -
https://github.com/ppy/osu/pull/29917 , likely because that one started
*storing* these raw managed realm objects to fields, and you know what
will happen to those after you do a migration and recycle realms.
To attempt to circumvent this, (ab)use `DetachedBeatmapStore` instead.
Which does necessitate moving it to `OsuGameBase`, but it's the simplest
way out I can see. I guess the alternative would be to faff around with
`Live<T>` but it's ugly and I'm attempting to fix this relatively quick
right now.
2024-10-08 23:16:10 +02:00
Dean Herbert
bfad281f62
Merge pull request #26313 from OliBomby/grids-4
...
Add grid placement tool
2024-10-08 19:16:52 +09:00
OliBomby
de2f9dec39
Let right-click reset grid to default values
2024-10-08 10:51:35 +02:00
OliBomby
e794862da5
update comment
2024-10-08 10:46:10 +02:00
Dean Herbert
b1be31cd6a
Switch back to last tool after using grid tool, rather than always select tool
2024-10-08 17:34:51 +09:00
Dean Herbert
682023e130
Merge branch 'master' into grids-4
2024-10-08 16:26:42 +09:00
Dean Herbert
b658d9a681
Merge pull request #30073 from peppy/updates-outside-of-gameplay-only-2
...
Avoid updates (and update notifications) from appearing in more gameplay cases
2024-10-08 15:17:09 +09:00
Dan Balasescu
105008672d
Merge pull request #30139 from bdach/bump-diffcalc-versions
...
Bump difficulty calculator versions
2024-10-08 15:00:28 +09:00
OliBomby
dc267733d1
Use FA icon instead
2024-10-07 19:09:21 +02:00
OliBomby
66459c50de
Rename to 'Grid'
2024-10-07 19:09:09 +02:00
OliBomby
076c8dec5a
Revert "Use new place grid icon"
...
This reverts commit db10202642
2024-10-07 19:06:32 +02:00
Dean Herbert
a02cda6528
Update resources
2024-10-08 01:51:56 +09:00
OliBomby
db10202642
Use new place grid icon
2024-10-07 16:51:53 +02:00
OliBomby
533ed609fb
Fix crash on placing circular grid
2024-10-07 16:19:01 +02:00
Bartłomiej Dach
1af464d5ae
Bump difficulty calculator versions
...
In order for the new star difficulty to be shown to users on the next
release.
catch's difficulty calculator version is not bumped because the only
catch change pending deploy is https://github.com/ppy/osu/pull/28353 and
that affects performance points only.
2024-10-07 15:38:41 +02:00
Bartłomiej Dach
6608d0527e
Merge pull request #20963 from Natelytle/taikostatacc
...
Statistical accuracy PP and difficulty scaling for the osu!taiko ruleset
2024-10-07 15:34:42 +02:00
Bartłomiej Dach
84d6467e48
Merge branch 'master' into taikostatacc
2024-10-07 14:15:29 +02:00
Bartłomiej Dach
6d3eec3563
Merge pull request #16280 from apollo-dw/no-combo-scaling
...
Remove combo scaling from Aim and Speed from osu! performance calculation
2024-10-07 14:09:30 +02:00
Dan Balasescu
c3f2c82b10
Remove unused parameter
2024-10-07 19:48:57 +09:00
Dan Balasescu
7cc6fe3819
Return true while in gameplay
...
A `false` value marks the user as being on the latest release, and
notifies them as such when clicking the button in settings. In reality,
we don't know whether this is the case yet - we're just deferring the
check.
Somewhat minor change because the chance of a user manually going into
settings and clicking the button is very small.
2024-10-07 19:35:09 +09:00
OliBomby
a755ae70a3
fix warning
2024-10-07 12:13:56 +02:00
Bartłomiej Dach
6596d30fb9
Merge pull request #30135 from smoogipoo/diffcalc-workflow-state-at-comment
...
Save `master` state when running diffcalc workflow
2024-10-07 12:11:28 +02:00
OliBomby
7b998219d7
move grid placement tool to left toolbox
2024-10-07 12:04:14 +02:00
Dan Balasescu
aee5f0ebf5
Fix incorrect condition
2024-10-07 19:01:25 +09:00
OliBomby
d7526be243
Merge remote-tracking branch 'upstream/master' into grids-4
2024-10-07 11:56:35 +02:00
Dan Balasescu
639caf167d
Save master state in workflow
2024-10-07 18:52:13 +09:00
Bartłomiej Dach
f30ac5d996
Merge branch 'master' into no-combo-scaling
2024-10-07 11:50:58 +02:00
Bartłomiej Dach
9a8a5cd45d
Merge pull request #27063 from tsunyoku/account-for-sliders-in-accuracy-pp
...
Include sliders in accuracy pp if slider head accuracy is in use
2024-10-07 11:50:46 +02:00
Dean Herbert
5cb106e8e6
Merge pull request #30134 from bdach/center-button-breakage
...
Fix "Center on selected object" button not changing grid coordinates
2024-10-07 18:12:19 +09:00
Bartłomiej Dach
707c237acc
Merge branch 'master' into account-for-sliders-in-accuracy-pp
2024-10-07 10:51:41 +02:00
Bartłomiej Dach
fe97f15e95
Merge pull request #28871 from stanriders/rhythm-fixes
...
Implement a bunch of rhythm difficulty calculation fixes
2024-10-07 10:50:26 +02:00
Dan Balasescu
6e659e156e
Refactoring for correctness
2024-10-07 17:50:23 +09:00
Bartłomiej Dach
958ee8a651
Merge pull request #30133 from peppy/delete-header-text
...
Fix delete dialogs having generic "Caution" header text
2024-10-07 10:48:00 +02:00
Dan Balasescu
19b586e6f7
Remove unrelated test
2024-10-07 17:45:23 +09:00
OliBomby
0a7d2395d2
fix tooltip in SettingsButton
2024-10-07 10:43:24 +02:00
Dan Balasescu
8dece70097
Merge branch 'master' into updates-outside-of-gameplay-only-2
2024-10-07 17:41:42 +09:00
Bartłomiej Dach
2b5ddddf4f
Fix "centre on selected object" button not respecting precision of allowable grid positions
2024-10-07 10:29:45 +02:00
Bartłomiej Dach
04c65ad919
Fix "centre on selected object" sometimes remaining disabled after moving grid
2024-10-07 10:29:18 +02:00
Bartłomiej Dach
3da59f44b5
Fix clicking "centre on selected object" button not updating slider state
2024-10-07 10:29:09 +02:00
Dean Herbert
38ee824b12
Add second call of runOutsideGameplay on update progress notification
...
At this point the update is already started in the background but I
guess we can still block the notification from interrupting the user.
2024-10-07 17:07:25 +09:00
Dean Herbert
1f45b2134f
Remove unnecessary runOutsideOfGameplay call
2024-10-07 17:04:52 +09:00
Dean Herbert
11fc811e2f
Fix delete dialogs having generic "Caution" header text
...
Regressed in https://github.com/ppy/osu/pull/28363 .
2024-10-07 16:46:53 +09:00
Dean Herbert
a41c6dce04
Fix android build failure due to enum rename
2024-10-07 16:43:50 +09:00
Bartłomiej Dach
5a4901754d
Merge branch 'master' into rhythm-fixes
2024-10-07 09:43:29 +02:00
Bartłomiej Dach
cf66d40b00
Merge pull request #30132 from smoogipoo/diffcalc-workflow-new-comment
...
Make diffcalc workflow recreate comment on completion
2024-10-07 09:42:55 +02:00
Bartłomiej Dach
9508b0ecab
Fix tests
2024-10-07 09:32:23 +02:00
Bartłomiej Dach
f47b8d5eb6
Merge branch 'slight-rebalance' into rhythm-fixes
2024-10-07 09:30:16 +02:00
Bartłomiej Dach
6507e3e406
Merge branch 'master' into rhythm-fixes
2024-10-07 09:29:51 +02:00
