osu-lazer

Update lots of packages (#36996 )

It's been a while.

Notes:

- `SharpCompress` usages changed a bit. Manually adjusted these, mostly
just renames or adjusted parameters.
- nUnit 3 -> 4 migrated using
https://gist.github.com/peppy/07994386d793a117350cb5f24b156585. there's
a mode in this script to update to the newer `Assert.That` syntax but it
requires fixes and couldn't really be bothered.
- DeepEqual nuked as the only usage was on a disabled test. The reason
it's disabled has been merged upstream, but it's failing for other
(realm) reasons which I don't think is worthwhile to investigate for
now.
- This bumps Moq. I think the author is back in a sensible headspace and
the new version has the stupid shit removed, so probably okay? Nice to
be on a level playing field with packages for once in a long time.
- Automapper is silly, but we've discussed this elsewhere.
- `TestRealmKeyBindingStore` failures are a wildcard, but fixed by using
a more standardised testing method. Dunno why, don't care.

---------

Co-authored-by: Bartłomiej Dach <dach.bartlomiej@gmail.com>

Dean Herbert · 2026-03-17 03:58:02 +09:00

a996261304

Preserve bookmarks when creating a new difficulty from scratch (#36675 )

Closes #33395

Copies the bookmarks from `referenceWorkingBeatmap` while creating a new
difficulty from scratch. I adapted the tests in
`TestSceneEditorBeatmapCreation` to include the bookmark checks.

---------

Co-authored-by: Dean Herbert <pe@ppy.sh>

Arthur Araujo · 2026-02-16 12:50:04 +09:00

2f459dd94e

Ensure editor is loaded in more places

While I can't reproduce any test failures because of this, I can
reproduce exceptions by simply running the tests with debugger attached.

There's one other similar related test failure in `TestSingleAudioFile`
but that appears to be an o!f issue.

Dan Balasescu · 2025-06-16 16:29:10 +09:00

18195120ae

Adjust condition to be more thorough

Dan Balasescu · 2025-06-16 16:21:27 +09:00

54ef42a09e

Attempt to fix flaky editor test

Dan Balasescu · 2025-06-16 15:36:55 +09:00

74a173cdfd

Fix default beatmap not being correctly set after aborting new beatmap creation

Closes https://github.com/ppy/osu/issues/32337.

Dean Herbert · 2025-03-12 14:01:11 +09:00

65cdcb4696

Remove duplicated assert

Dan Balasescu · 2025-03-04 17:22:19 +09:00

5b0e54a77d

Attempt to fix common editor test failures

See
https://github.com/ppy/osu/actions/runs/13623586844/job/38143232417?pr=32180
for one example.

Arguably the bindable usage in
[`ControlPointPart`](https://github.com/ppy/osu/blob/2365b065a4994f38fe67bab7d193e5a09bee538c/osu.Game/Screens/Edit/Components/Timelines/Summary/Parts/ControlPointPart.cs#L24-L26)
is dangerous, but it's only dangerous in tests (because control points
aren't mutated outside the editor) so I'm willing to turn a blind eye
for now to favour async loading support.

Dean Herbert · 2025-03-04 15:51:08 +09:00

a0888a7f2c

Fix flaky editor beatmap creation test

As seen in
https://github.com/ppy/osu/actions/runs/12289146465/job/34294167417#step:5:1588
or
https://github.com/ppy/osu/actions/runs/12310133160/job/34358241666#step:5:53.

Exception messages hint pretty strongly at this being a threading issue
and there does seem to be a rather frivolous lack of waiting for
`CreateNewDifficulty()` to do its thing, so I'm thinking maybe this will
help.

Bartłomiej Dach · 2024-12-13 17:35:41 +09:00

fdc41ace7e

Merge branch 'master' into editor-multiple-background-audio-files

Dean Herbert · 2024-12-10 14:19:55 +09:00

7ec2d91e14

Re-encode difficulties on resource change

Salman Alshamrani · 2024-12-04 04:36:00 -05:00

8e0f6fc12d

Add failing test case

Salman Alshamrani · 2024-12-04 04:20:09 -05:00

06824c1658

Add failing test case

Salman Alshamrani · 2024-12-04 02:32:00 -05:00

2a6fbb59ff

Perform a single Save call rather than doing it in each difficulty

Salman Alshamrani · 2024-11-28 18:37:13 -05:00

489d7a30ec

Fix tests reliability and improve code

Shaved off lots of copypasta so the test actually shows what it's testing.

Salman Alshamrani · 2024-11-27 15:27:21 -05:00

238a1ce284

Update test coverage

Salman Alshamrani · 2024-11-27 05:58:06 -05:00

4b8094d0db

Add test coverage for sync button

Salman Alshamrani · 2024-11-24 00:45:11 -05:00

dc210d59b5

Add failing test cases

Salman Alshamrani · 2024-11-23 23:52:14 -05:00

259ad8ae0f

Add test coverage of failure case

Bartłomiej Dach · 2023-12-29 10:36:53 +01:00

9bb0663b3b

Fix various other inspections

Dean Herbert · 2023-10-17 17:48:51 +09:00

e081fa48a2

Fix flaky editor beatmap creation test

Came up as a failure when locally running tests for
ppy/osu-framework#6001 - but the test is actually a previously-known
flaky that I couldn't reproduce the failure of until the aforementioned
PR.

This appears to be a simple race; the test scene queries the track
length from update thread, but the length is actually set on the audio
thread. So it's not unreasonable that given unlucky timing, the length
will not be set by `TrackBass` before it is queried.

To fix, switch assert to until step. I'm generally not really willing
to give this more time of day until this change is proven insufficient.

Bartłomiej Dach · 2023-09-26 16:42:59 +02:00

12585c9f27

Remove flaky test documentation for fixed test

Dean Herbert · 2023-08-16 14:30:10 +09:00

a8824c8c8a

Add test case covering exit block

Co-authored-by: Joseph Madamba <madamba.joehu@outlook.com>

Bartłomiej Dach · 2023-08-08 22:06:49 +02:00

d91798271d

Don't transfer MD5 hashes in collections when copying beatmaps

Fixes #22306.

Changes beatmap saving so that by default it does not transfer
the hashes in collections, and only transfers them when saving the same
difficulty in the editor.

Issue seems to have been introduced in https://github.com/ppy/osu/pull/20641.

naoey · 2023-01-22 01:14:18 +09:00

a1b5c9d910

Add failing test for new difficulty creation

Bartłomiej Dach · 2023-01-14 18:46:14 +01:00

3102044d00

Partial everything

Dan Balasescu · 2022-11-27 00:00:27 +09:00

7bc8908ca9

Add more test coverage of locally-modified state change

Dean Herbert · 2022-08-05 14:25:10 +09:00

7c952f8069

Update existing test expectations

Dean Herbert · 2022-08-03 20:20:06 +09:00

bacbf5b7f0

Add test coverage of editor crash

Dean Herbert · 2022-08-01 16:53:49 +09:00

2519706ad6

Add extra steps to TestExitWithoutSave to guarantee track type

Dean Herbert · 2022-07-13 19:41:46 +09:00

2e86e7ccee

Update various tests to enable NRT to avoid new inspection failures

Dean Herbert · 2022-07-07 17:51:49 +09:00

dd5b127fb5

Mark and document remaining flaky tests

Dean Herbert · 2022-07-01 16:17:40 +09:00

b597843579

Centralise and harden editor-ready-for-use check

Not only does this combine the check into one location, but it also adds
a check on the global `WorkingBeatmap` being updated, which is the only
way I can see the following failure happening:

```csharp
05:19:07     osu.Game.Tests: osu.Game.Tests.Visual.Editing.TestSceneEditorBeatmapCreation.TestAddAudioTrack
05:19:07       Failed TestAddAudioTrack [161 ms]
05:19:07       Error Message:
05:19:07        TearDown : System.NullReferenceException : Object reference not set to an instance of an object.
05:19:07       Stack Trace:
05:19:07       --TearDown
05:19:07        at osu.Game.Database.ModelManager`1.<>c__DisplayClass7_0.<AddFile>b__0(TModel managed) in C:\BuildAgent\work\ecd860037212ac52\osu.Game\Database\ModelManager.cs:line 36
05:19:07        at osu.Game.Database.ModelManager`1.<>c__DisplayClass8_0.<performFileOperation>b__0(Realm realm) in C:\BuildAgent\work\ecd860037212ac52\osu.Game\Database\ModelManager.cs:line 49
05:19:07        at osu.Game.Database.RealmExtensions.Write(Realm realm, Action`1 function) in C:\BuildAgent\work\ecd860037212ac52\osu.Game\Database\RealmExtensions.cs:line 14
05:19:07        at osu.Game.Database.ModelManager`1.performFileOperation(TModel item, Action`1 operation) in C:\BuildAgent\work\ecd860037212ac52\osu.Game\Database\ModelManager.cs:line 46
05:19:07        at osu.Game.Database.ModelManager`1.AddFile(TModel item, Stream contents, String filename) in C:\BuildAgent\work\ecd860037212ac52\osu.Game\Database\ModelManager.cs:line 36
05:19:07        at osu.Game.Screens.Edit.Setup.ResourcesSection.ChangeAudioTrack(FileInfo source) in C:\BuildAgent\work\ecd860037212ac52\osu.Game\Screens\Edit\Setup\ResourcesSection.cs:line 115
05:19:07        at osu.Game.Tests.Visual.Editing.TestSceneEditorBeatmapCreation.<TestAddAudioTrack>b__13_0() in C:\BuildAgent\work\ecd860037212ac52\osu.Game.Tests\Visual\Editing\TestSceneEditorBeatmapCreation.cs:line 101
05:19:07        at osu.Framework.Testing.Drawables.Steps.AssertButton.checkAssert()
05:19:07        at osu.Framework.Testing.Drawables.Steps.StepButton.PerformStep(Boolean userTriggered)
05:19:07        at osu.Framework.Testing.TestScene.runNextStep(Action onCompletion, Action`1 onError, Func`2 stopCondition)
```

Dean Herbert · 2022-06-27 16:22:01 +09:00

5a7d339cc8

Ensure files are cleaned up even on test step failure in TestAddAudioTrack

Dean Herbert · 2022-06-27 15:53:05 +09:00

b70b365411

Merge branch 'master' into editor-metadata-name-unification

Bartłomiej Dach · 2022-06-18 10:22:52 +02:00

f6a3047596

Automated #nullable processing

Dan Balasescu · 2022-06-17 16:37:17 +09:00

f8830c6850

Use FileInfo as current bindable type