38077 Commits

This Branch

This Branch

All Branches

• Update asserts to use better nunit specifications
  Dean Herbert · 2021-04-13 15:04:01 +09:00
  b45d7de4ec
• Use static for playfield centre positioning
  Dean Herbert · 2021-04-13 14:44:52 +09:00
  4837cef095
• Use is class instead of Equals with template index

  Ensures ordering of `PossibleTemplates` does not affect tests.

  Naxess · 2021-04-13 02:29:25 +02:00
  6d3f9fa9ce
• Remove redundant space
  Naxess · 2021-04-13 02:17:35 +02:00
  0bcc39bd36
• Add CheckOffscreenObjects tests
  Naxess · 2021-04-13 01:22:36 +02:00
  8a6dfcfae1
• Add CheckBackground tests
  Naxess · 2021-04-13 01:22:24 +02:00
  47cf4bcf25
• Add Equals method to IssueTemplate

  This will be useful in tests.

  Naxess · 2021-04-13 01:21:34 +02:00
  d8088777ea
• Rename checkOrigin -> check

  More consistent with `Issue.ctor`'s "template".

  Naxess · 2021-04-12 17:28:12 +02:00
  19a154ddf1
• Remove check ctors and locals
  Naxess · 2021-04-12 17:12:37 +02:00
  bb720c23a0
• Remove redundant parameter naming
  Dean Herbert · 2021-04-12 23:37:47 +09:00
  62c1812282
• Move nested classes to bottom of file
  Dean Herbert · 2021-04-12 23:36:10 +09:00
  36bd235021
• Make IssueTemplate.Check readonly
  Naxess · 2021-04-12 16:23:05 +02:00
  6d50d01186
• Rename Check -> ICheck
  Naxess · 2021-04-12 16:20:53 +02:00
  caaaba5950
• Reverse IssueType ordering

  Reversed both in the enum and where it's displayed, so ends up the same in the end.

  Naxess · 2021-04-12 15:49:13 +02:00
  008dbc7dd6
• Fix Template.Origin -> Check
  Naxess · 2021-04-12 15:47:58 +02:00
  1c69829ad4
• Rework template usage

  Includes moving the origin check back to templates, constructing nested template classes in each check, and making parameterized template usage.

  Naxess · 2021-04-12 15:47:26 +02:00
  7c4f6d2b62
• Rename CreateChecker -> CreateBeatmapVerifier
  Naxess · 2021-04-12 10:08:30 +02:00
  a2fc9c398f
• Move check origin from IssueTemplate to Issue

  As a result we can also make check an interface, and need to provide the check itself when constructing an issue.

  Naxess · 2021-04-12 10:08:08 +02:00
  65ebdd8f7a
• Add binding for verify mode (and move enum entry to end)
  Dean Herbert · 2021-04-12 16:15:27 +09:00
  42604afcdc
• Change Metadata into a get property
  Dean Herbert · 2021-04-12 15:52:29 +09:00
  8bf85d737c
• Tidy some remaining code
  Dean Herbert · 2021-04-12 15:52:18 +09:00
  78bbc8f5c8
• Change some methods to get properties
  Dean Herbert · 2021-04-12 15:52:18 +09:00
  8c31e96cdf
• Move enums out of nesting
  Dean Herbert · 2021-04-12 15:52:18 +09:00
  f78239c7f2
• Fix formatting of colour getter
  Dean Herbert · 2021-04-12 15:52:18 +09:00
  3551322f1d
• Colour constants to private
  Dean Herbert · 2021-04-12 15:52:18 +09:00
  257acf9cd8
• Wrap xmldoc less and make a few fixes
  Dean Herbert · 2021-04-12 15:52:18 +09:00
  136627b9ac
• Checker -> BeatmapVerifier
  Dean Herbert · 2021-04-12 15:29:05 +09:00
  1c553b5d48
• Merge branch 'master' into verify-tab
  Dean Herbert · 2021-04-12 15:14:37 +09:00
  14bd5bdc77
• Merge pull request #12367 from Joehuu/lazy-flashlight

  Add follow delay setting to osu! flashlight mod

  Dean Herbert · 2021-04-11 19:07:06 +09:00
  4853ac802c
• Add follow delay setting to osu! flashlight mod
  Joseph Madamba · 2021-04-10 23:04:15 -07:00
  a42714540b
• Fix field name and accessibility
  Naxess · 2021-04-10 15:49:57 +02:00
  dac733cced
• Remove old todo
  Naxess · 2021-04-10 15:18:15 +02:00
  7d40b01722
• Merge Check and BeatmapCheck

  We're probably not going to need GeneralChecks or BeatmapsetChecks.
  
  The verify tab is only available to a single difficulty at a time, and we already have access to the rest of the set through `IBeatmap`.

  Naxess · 2021-04-10 14:56:30 +02:00
  3289bb0379
• Improve table formatting
  Naxess · 2021-04-10 13:10:05 +02:00
  747e0f00dc
• Show table even if no issues
  Naxess · 2021-04-10 13:09:16 +02:00
  3a4f2e3d7e
• Remove todo

  Doesn't really matter in the end, as only one checker will run at a time in this case.

  Naxess · 2021-04-10 13:05:24 +02:00
  c995eca029
• Add issue selection

  This mainly helps with keeping track of which issue was clicked, since doing so switches tab.

  Naxess · 2021-04-10 13:04:39 +02:00
  6d3cf78e4a
• Replace checks with realistic ones
  Naxess · 2021-04-10 13:03:16 +02:00
  bc4f3351f3
• Fix comment; mode -> ruleset
  Naxess · 2021-04-10 13:02:36 +02:00
  b30e41b805
• Move components to more appropriate spot
  Naxess · 2021-04-10 13:02:22 +02:00
  d1007ff26a
• Remove visibility settings

  Can look into this later, not really important for a first iteration.

  Naxess · 2021-04-10 12:58:40 +02:00
  43174b708c
• Merge pull request #12356 from peppy/update-framework

  Update framework

  Dean Herbert · 2021-04-10 03:34:24 +09:00
  2021.410.0 ab49e84d17
• Update framework
  Dean Herbert · 2021-04-10 02:14:28 +09:00
  b66ef2fdec
• Merge pull request #12353 from nekodex/songselect-hoversamples

  Add a hover sample type for SongSelect buttons

  Dean Herbert · 2021-04-10 01:45:47 +09:00
  dfe3240b45
• Merge pull request #11688 from Syriiin/diffcalc/dynamic-history

  Implement dynamic previous hitobject retention for Skill class

  Dan Balasescu · 2021-04-10 01:25:07 +09:00
  9aa30fb323
• Update resources
  Dean Herbert · 2021-04-10 01:03:15 +09:00
  affc878db9
• Implement custom enumerator for ReverseQueue to avoid allocations
  Samuel Cattini-Schultz · 2021-04-10 01:16:54 +10:00
  bfd3d0cce9
• Merge pull request #12354 from nekodex/reduce-sample-pitch-randomisation

  Reduce the randomised pitch range of hover sounds

  Dean Herbert · 2021-04-09 23:43:51 +09:00
  8bd972c525
• Reduce the randomised pitch range of hover sounds
  Jamie Taylor · 2021-04-09 23:03:14 +09:00
  ffacd38e57
• Add a hover sample type for SongSelect buttons
  Jamie Taylor · 2021-04-09 23:00:40 +09:00
  8a0da06e89