Dean Herbert
e77d203a24
Refactor delayed load logic to hopefully read better
2024-01-09 01:08:17 +09:00
Bartłomiej Dach
8c82bb006c
Fix mania score conversion using score V1 accuracy
...
Partially addresses https://github.com/ppy/osu/discussions/26416
As pointed out in the discussion thread above, the total score
conversion process for mania was using accuracy directly from the
replay. In mania accuracy is calculated differently in score V1 than in
score V2, which meant that scores coming from stable were treated more
favourably (due to weighting GREAT and PERFECT equally).
To fix, recompute accuracy locally and use that for the accuracy
portion.
Note that this will still not be (and cannot be made) 100% accurate, as
in stable score V2, as well as in lazer, hold notes are *two*
judgements, not one as in stable score V1, meaning that full and correct
score statistics are not available without playing back the replay.
The effects of the change can be previewed on the following spreadsheet:
https://docs.google.com/spreadsheets/d/1wxD4UwLjwcr7n9y5Yq7EN0lgiLBN93kpd4gBnAlG-E0/edit#gid=1711190356
Top 5 changed scores with replays:
| score | master | this PR | replay |
| :------------------------------------------------------------------------------------------------------------------------------- | ------: | ------: | ------: |
| [Outlasted on Uwa!! So Holiday by toby fox [[4K] easy] (0.71\*)](https://osu.ppy.sh/scores/mania/460404716 ) | 935,917 | 927,269 | 920,579 |
| [ag0 on Emotional Uplifting Orchestral by bradbreeck [[4K] Rocket's Normal] (0.76\*)](https://osu.ppy.sh/scores/mania/453133066 ) | 921,636 | 913,535 | 875,549 |
| [rlarkgus on Zen Zen Zense by Gom (HoneyWorks) [[5K] Normal] (1.68\*)](https://osu.ppy.sh/scores/mania/458368312 ) | 934,340 | 926,787 | 918,855 |
| [YuJJun on Harumachi Clover by R3 Music Box [4K Catastrophe] (1.80\*)](https://osu.ppy.sh/scores/mania/548215786 ) | 918,606 | 911,111 | 885,454 |
| [Fritte on 45-byou by respon feat. Hatsune Miku & Megpoid [[5K] Normal] (1.52\*)](https://osu.ppy.sh/scores/mania/516079410 ) | 900,024 | 892,569 | 907,456 |
2024-01-08 16:38:43 +01:00
Bartłomiej Dach
bd4b20c63d
Merge pull request #26411 from zacwm/disable-intro-track-pause
...
Disable pausing music during intro sequence
2024-01-08 13:37:59 +01:00
Bartłomiej Dach
5337d999b5
Merge branch 'master' into disable-intro-track-pause
2024-01-08 12:54:37 +01:00
Bartłomiej Dach
b6ce57b777
Use override that was intended to steer global track control rather than local sets
2024-01-08 12:54:16 +01:00
Bartłomiej Dach
b869be2f46
Fix typo
2024-01-08 12:52:23 +01:00
Bartłomiej Dach
50eba9ebdb
Reduce code duplication in test
2024-01-08 12:52:14 +01:00
Bartłomiej Dach
3e9d222d67
Merge pull request #26409 from peppy/overall-ranking-overlap
...
Fix overall ranking text overlapping at some aspect ratios
2024-01-08 12:29:42 +01:00
Bartłomiej Dach
991c6d239d
Merge pull request #26410 from peppy/ranking-leaderboard-whiz
...
Remove scores from song select leaderboard when leaving the screen
2024-01-08 11:51:46 +01:00
Bartłomiej Dach
7b663a27bd
Fix score conversion incorrectly assuming zero combo score in certain cases
2024-01-08 10:47:22 +01:00
Dean Herbert
962c8ba4ac
Reset child anchor position cache on hitobject position change
2024-01-07 20:55:28 +09:00
Dean Herbert
dc31c66f62
Return null on font lookup failure instead of asserting
...
Fallback weirdness.
2024-01-07 20:41:58 +09:00
Dean Herbert
16ea7f9b77
Avoid completely unnecessary string allocations in ArgonCounterTextComponent
2024-01-07 14:31:22 +09:00
Dean Herbert
5cc4a586ac
Avoid iteration over NestedHitObjects in silder's Update unless necessary
2024-01-07 14:31:22 +09:00
Dean Herbert
35eff639cb
Remove unnecessary second iteration over NestedHitObjects
2024-01-07 14:31:22 +09:00
Dean Herbert
9d9e6fcfdb
Remove LINQ calls in hot paths
2024-01-07 14:31:22 +09:00
Dean Herbert
b809d4c068
Remove delegate overhead from argon health display's animation updates
2024-01-07 14:31:22 +09:00
Dean Herbert
d3710f0bfd
Remove scores from song select leaderboard when leaving the screen
2024-01-06 20:53:20 +09:00
Dean Herbert
14a43375a7
Fix overall ranking text overlapping at some aspect ratios
...
Can't confirm on the actual ranking screen due to stuff not working.
Maybe it'll work tomorrow.
Closes https://github.com/ppy/osu/issues/26341 .
2024-01-06 20:25:07 +09:00
Zachary
e2769dbda1
Attempt at creating a test.
2024-01-06 19:29:41 +10:00
Bartłomiej Dach
ea7078fab5
Implement approximate score conversion algorithm matching score V2
2024-01-05 20:46:11 +01:00
Bartłomiej Dach
8295ad1feb
Change catch scoring to match score V2
2024-01-05 20:46:11 +01:00
Zachary
091241634c
Make IntroScreen set AllowTrackControl to false instead
2024-01-05 23:55:17 +10:00
Dean Herbert
fbc40ffc65
Merge pull request #26381 from Joehuu/flash-ongoing-operations-dialog
...
Flash blocking ongoing operations dialog when trying to force quit
2024-01-05 18:34:06 +09:00
Dean Herbert
e9289cfbe7
Reduce precision of audio balance adjustments during slider sliding
2024-01-05 02:26:30 +09:00
Dean Herbert
5b55ca6692
Cache legacy skin character glyph lookups to reduce string allocations
2024-01-05 02:26:30 +09:00
Joseph Madamba
b190333c17
Use repeat step for more delay between the two exits
2024-01-04 09:00:24 -08:00
Dean Herbert
91bb3f6c57
Cache argon character glyph lookups to reduce string allocations
2024-01-05 01:24:00 +09:00
Zachary
9b734bac25
Allow track control after intro screen finishes.
2024-01-05 01:14:34 +10:00
Dean Herbert
35b9940c4e
Merge pull request #26140 from CaffeeLake/multiplier1x
...
Fix mod score multiplier rounding to 1.00x with specific mod combinations
2024-01-04 19:26:49 +09:00
Dean Herbert
085f5acd1a
Fix another rider inspection (why do these keep coming up at random)
2024-01-04 19:26:28 +09:00
Dean Herbert
81c6fd5589
Load items closer to the centre of the screen as a priority
2024-01-04 19:25:12 +09:00
Dean Herbert
adac3b65ce
Fix beatmap carousel not preloading panels when off-screen
2024-01-04 19:25:12 +09:00
Dan Balasescu
8e6f6521a9
Merge pull request #26384 from peppy/fix-multiplayer-fail-online-submit
...
Fix multiplayer scores being submitted as pass even if failed
2024-01-04 18:45:17 +09:00
Dean Herbert
fc1a2c594c
Add a bit more test coverage
2024-01-04 18:02:37 +09:00
Dean Herbert
44d35020d1
Add test coverage of failed multiplayer score
2024-01-04 17:54:52 +09:00
Dean Herbert
b12011d501
Avoid rank updates after failing
2024-01-04 17:13:24 +09:00
Dean Herbert
a4dee1a01a
Don't unset Disabled on rank (never actually disabled?)
2024-01-04 17:13:24 +09:00
Dean Herbert
705f25e4b9
Make ScoreProcessor.Rank read-only
2024-01-04 17:13:24 +09:00
Dean Herbert
0bbc27e380
Add a gameplay configuration flag to disable fail animation
2024-01-04 17:13:24 +09:00
Dean Herbert
f0aeeeea96
...in a safer way
2024-01-04 17:13:21 +09:00
Dean Herbert
df99a37254
Fix another realm null inspection
2024-01-04 17:11:40 +09:00
Dean Herbert
b1813b17a2
Few new rider inspection
2024-01-04 16:39:50 +09:00
Dean Herbert
0f11743fff
Merge pull request #26379 from wooster0/chat
...
Make chat command names case-insensitive
2024-01-04 16:17:42 +09:00
Bartłomiej Dach
cfdc9e5887
Merge pull request #26378 from wooster0/typos
...
Fix wiki link path inconsistencies
2024-01-04 08:12:04 +01:00
Dean Herbert
3419c59b06
Fix failing tests due to frame stable seeks taking longer
2024-01-04 15:47:16 +09:00
Dean Herbert
65c29b4f09
Make editor remain frame stable during normal playback
2024-01-04 15:47:16 +09:00
Dean Herbert
1beb3f5462
Add failing test coverage of fast streams not working in editor
2024-01-04 15:47:16 +09:00
Joseph Madamba
ea714c86d4
Fix potential null reference with flash sample when exiting rapidly
...
Fixes `TestForceExitWithOperationInProgress()`.
2024-01-03 22:30:46 -08:00
Joseph Madamba
cd9bf0c753
Flash blocking ongoing operations dialog when trying to force quit
2024-01-03 22:30:46 -08:00
