Bartłomiej Dach
21796900e2
Fix code quality naming issue
2024-09-27 09:26:08 +02:00
Dean Herbert
5be63ee304
Reorganise with ruleset shader separated out
2024-09-27 16:19:24 +09:00
Dean Herbert
4205a21c0c
Add one more shader usage
2024-09-27 16:11:24 +09:00
Bartłomiej Dach
8ca68be5fe
Merge pull request #30017 from peppy/file-picker-hover-states
...
Add basic hover states for file selector elements
2024-09-27 08:57:16 +02:00
Dean Herbert
b2983e2562
Update shader preloader with missing shader usages
2024-09-27 14:21:20 +09:00
Dean Herbert
5efdc6cdd7
Merge pull request #29936 from u4vh3/skinning-colour-customisation
...
Add colour customisation to layout editor
2024-09-27 14:20:58 +09:00
Dean Herbert
eacd9b9756
Move dependent files to namespace
2024-09-27 14:00:54 +09:00
Dean Herbert
cbeeb4a2b4
Add basic hover states for file selector elements
2024-09-27 13:44:37 +09:00
Dean Herbert
cec3f1487a
Merge pull request #30005 from bdach/editor/setup-screen-file-picker
...
Implement "form" file picker
2024-09-27 13:42:52 +09:00
Dean Herbert
9e9bfc3721
Update velopack with zstd changes
...
Closes https://github.com/ppy/osu/issues/29810 .
2024-09-27 12:48:50 +09:00
Dan Balasescu
33c40079b6
Merge pull request #29997 from peppy/async-wait-exit-velopack
...
Update velopack and switch to using async version of `WaitExitThenApplyUpdates`
2024-09-26 21:56:24 +09:00
Bartłomiej Dach
f4a4807449
Implement "form" file picker
2024-09-26 14:36:24 +02:00
Bartłomiej Dach
f16f419928
Merge pull request #29983 from bdach/directory-selector-redesign
...
Redesign directory & file selector
2024-09-26 14:14:22 +02:00
Dean Herbert
b1a05f463e
Reduce size of hidden toggle slightly
2024-09-26 19:42:31 +09:00
Dean Herbert
78c1426a30
Merge pull request #29992 from smoogipoo/fix-ios-realm-crashes
...
Fix reflection-related iOS crashes
2024-09-26 17:34:36 +09:00
Dean Herbert
89e8baf1d3
Add inline comments for iOS locals
2024-09-26 16:48:42 +09:00
Dean Herbert
df0966abb2
Update velopack and switch to using async version of WaitExitThenApplyUpdates
2024-09-26 01:12:19 +09:00
Dan Balasescu
2fe229d620
Inline condition
2024-09-25 22:47:37 +09:00
Dan Balasescu
fd4891cf31
Fix similar Bindable-related crashes
2024-09-25 20:59:35 +09:00
Dan Balasescu
3111d6a74d
Merge pull request #29986 from OliBomby/refactor-placement-tool
...
Refactor placement blueprints to not be limited to hit objects
2024-09-25 17:59:43 +09:00
Dan Balasescu
5b8ae90ec1
Merge pull request #29962 from Givikap120/use_max_combo
...
Make all difficulty calculators use `GetMaxCombo` function
2024-09-25 17:51:49 +09:00
Dan Balasescu
3ab04d98f6
Fix Realm-related iOS crashes by removing object references
2024-09-25 16:45:37 +09:00
OliBomby
d26e677bb7
fix warnings
2024-09-24 20:32:08 +02:00
OliBomby
e3b4483872
Refactor PlacementBlueprint to not be hitobject specific
2024-09-24 20:31:00 +02:00
OliBomby
796fc948e1
Rewrite Welzl's algorithm to use no recursion
2024-09-24 20:15:03 +02:00
OliBomby
2d95c0b0bb
remove tail recursion form welzl
2024-09-24 18:45:52 +02:00
Dean Herbert
84d7fed23d
Merge pull request #29985 from bdach/user-statistics-update-too-fast
...
Fix statistics update not being shown on results screen if it arrives too fast
2024-09-25 01:35:28 +09:00
Bartłomiej Dach
20e7ade3b0
Fix statistics update not being shown on results screen if it arrives too fast
...
As reported in
https://discord.com/channels/188630481301012481/1097318920991559880/1288160137286258799 .
2024-09-24 17:52:19 +02:00
Bartłomiej Dach
555d4ffe89
Add failing test case
2024-09-24 17:51:54 +02:00
Marvin Schürz
99a80b399c
Animate SelectionBox buttons on unfreeze
2024-09-24 16:42:37 +02:00
Bartłomiej Dach
9f4e48dde7
Actually use bindables rather than stick things in Update()
2024-09-24 15:15:28 +02:00
Bartłomiej Dach
16fc413a4a
Apply NRT to directory & file selectors
2024-09-24 14:55:05 +02:00
Bartłomiej Dach
7f8b64bb6d
Redesign directory & file selector (and update usages accordingly)
2024-09-24 14:54:48 +02:00
Dean Herbert
b7d8cb2371
Merge pull request #29968 from bdach/cache-for-spectate-screen
...
Use cache for beatmap lookups on spectate screen
2024-09-24 20:59:33 +09:00
Marvin Schürz
15c4b1dc8f
Move mouse horizontally in test to make sure it doesn't accidentally maintain aspect ratio
2024-09-24 13:45:03 +02:00
Marvin Schürz
3ad7342964
Add tests for shift and alt modifiers in select box
2024-09-24 13:35:56 +02:00
Bartłomiej Dach
4f57a67ea4
Merge branch 'master' into skinning-colour-customisation
2024-09-24 13:02:22 +02:00
Bartłomiej Dach
145f2b6de7
Merge pull request #29942 from minetoblend/fix/slider-scale-origin
...
Fix scaling sliders ignoring the scale origin
2024-09-24 13:02:04 +02:00
Bartłomiej Dach
4c2ebdb2db
Simplify accent colour assignment in argon wedge piece
2024-09-24 12:53:54 +02:00
Marvin Schürz
b54b4063be
Rename parameter
2024-09-24 12:40:28 +02:00
OliBomby
3031b68552
add TestMinimumEnclosingCircle
2024-09-24 11:56:04 +02:00
Bartłomiej Dach
86432078dd
Remove usage of switch expression syntax
...
It's not universally accepted here and a `when` crept in that can be
bypassed entirely using rather clean baseline language constructs, so
why bother at this point.
2024-09-24 11:53:02 +02:00
OliBomby
c857de3a9a
Revert "add a max depth to prevent stack overflow"
...
This reverts commit bf245aa9d6
2024-09-24 11:44:02 +02:00
Dean Herbert
f08134f443
Merge pull request #29966 from bdach/unsafe-deep-clone
...
Fix score being cloned in async method causing random errors (again)
2024-09-23 23:37:46 +09:00
Dean Herbert
31e423058d
Merge pull request #29972 from bdach/editor/setup-screen-dropdown
...
Implement "form" dropdown control
2024-09-23 23:30:25 +09:00
Bartłomiej Dach
d6c17f6ac0
Implement "form" dropdown control
2024-09-23 14:41:39 +02:00
Bartłomiej Dach
e8a394f894
Fix argon volume-aware hitsounds not correctly playing immediately after object placement
...
Closes https://github.com/ppy/osu/issues/29832 .
The underlying reason for the incorrect sample playback was an equality
comparer failure.
Samples are contained in several pools which are managed by the
playfield. In particular, the pools are keyed by `ISampleInfo`
instances. This means that for correct operation, `ISampleInfo` has to
implement `IEquatable<ISampleInfo>` and also provide an appropriately
correct `GetHashCode()` implementation. Different audible samples must
not compare equal to each other when represented by `ISampleInfo`.
As it turns out, `VolumeAwareHitSampleInfo` failed on this, due to not
overriding equality members. Therefore, a `new
HitSampleInfo(HitSampleInfo.HIT_NORMAL, HitSampleInfo.BANK_NORMAL,
volume: 70)` was allowed to compare equal to a
`VolumeAwareHitSampleInfo` wrapping it, *even though they correspond to
completely different sounds and go through entirely different lookup
path sequences*.
Therefore, to fix, provide more proper equality implementations for
`VolumeAwareHitSampleInfo`.
When testing note that this issue *only occurs immediately after
placing an object*. Saving and re-entering editor makes this issue go
away. I haven't looked too long into why, but the general gist of it is
ordering; it appears that a `normal-hitnormal` pool exists at point
of query of a new object placement, but does not seem to exist when
entering editor afresh. That said I'm not sure that ordering aspect of
this bug matters much if at all, since the two `IHitSampleInfo`s should
never be allowed to alias with each other at all wrt equality.
2024-09-23 13:38:26 +02:00
Bartłomiej Dach
41826d0606
Add failing test case to demonstrate failure
2024-09-23 13:17:46 +02:00
OliBomby
bf245aa9d6
add a max depth to prevent stack overflow
2024-09-23 13:16:45 +02:00
OliBomby
eead6b9eae
return to stackalloc because its faster
2024-09-23 13:13:33 +02:00
