54587 Commits

This Branch

This Branch

All Branches

• Fix merge breakage
  Dean Herbert · 2022-08-24 16:52:36 +09:00
  af56cd0126
• Merge branch 'master' into no-gameplay-clock-gameplay-offset
  Dean Herbert · 2022-08-24 16:52:10 +09:00
  5079e0d83d
• Merge pull request #19936 from peppy/catch-up-woes-2

  Move `MasterClockState` handling in to `SpectatorSyncManager`

  Dean Herbert · 2022-08-24 16:48:28 +09:00
  b5c244e624
• Simplify MultiSpectatorScreen hierarchy construction
  Dean Herbert · 2022-08-24 16:08:48 +09:00
  7f9246637a
• Remove unused CreateMasterGameplayClockContainer method
  Dean Herbert · 2022-08-24 16:03:38 +09:00
  7c1fc4814e
• Inline ReadyToStart action binding for added safety
  Dean Herbert · 2022-08-24 16:03:38 +09:00
  871365bbb0
• Don't use bindable flow for masterState
  Dean Herbert · 2022-08-24 16:03:38 +09:00
  6c50f618a3
• Move MasterClockState handling in to SpectatorSyncManager
  Dean Herbert · 2022-08-24 16:03:38 +09:00
  683d49c608
• Make WaitingOnFrames non-bindable
  Dean Herbert · 2022-08-24 16:03:38 +09:00
  d33d705684
• Simplify interface implementations
  Dean Herbert · 2022-08-24 16:03:38 +09:00
  d05d8aeb22
• Tidy up ProcessFrame and privatise const
  Dean Herbert · 2022-08-24 16:03:38 +09:00
  2f5be6efca
• Don't process master clock (is a noop)
  Dean Herbert · 2022-08-24 16:03:38 +09:00
  b564c34dbc
• Merge pull request #19933 from peppy/catch-up-woes

  Tidy up spectator clock/manager naming and interfaces

  Dan Balasescu · 2022-08-24 16:03:29 +09:00
  f5a71ecdfe
• Use readonly instead of get-only
  Dean Herbert · 2022-08-24 15:28:18 +09:00
  b4eede61fb
• Fix incorrect IsRunning value
  Dean Herbert · 2022-08-24 15:27:31 +09:00
  0b271fe4b3
• Remove unnecessary casting
  Dean Herbert · 2022-08-24 15:23:31 +09:00
  b6254a1f25
• Change running state of SpectatorPlayerClock using IsRunning
  Dean Herbert · 2022-08-24 15:17:56 +09:00
  a86fc6f248
• Don't expose MasterClock in SpectatorClockSyncManager
  Dean Herbert · 2022-08-24 15:13:08 +09:00
  0c9a4ec13c
• Rename spectator clock sync classes
  Dean Herbert · 2022-08-24 15:13:08 +09:00
  995e6664b6
• Remove ISpectatorPlayerClock interface

  Too many levels of redirection.
  
  One interface with one implementation is not useful, IMO.

  Dean Herbert · 2022-08-24 15:12:57 +09:00
  31f657fe01
• Remove ISyncManager interface

  Too many levels of redirection.
  
  One interface with one implementation is not useful, IMO.

  Dean Herbert · 2022-08-24 15:12:57 +09:00
  882dd93942
• Fix multiplayer spectator getting stuck
  Dean Herbert · 2022-08-24 15:12:57 +09:00
  22963ab951
• Accept MasterGameplayClockContainer rather than generic clock
  Dean Herbert · 2022-08-24 14:51:14 +09:00
  ec31f37ff7
• Fix multiplayer spectator getting stuck
  Dean Herbert · 2022-08-24 13:11:53 +09:00
  85fbe7abca
• Fix test regressions on windows due to Reset never being called

  I'm not sure this is great. Without calling `Reset`, the correct initial
  time may not be set (ever). In practice this doesn't happen anywhere in
  the gameplay flow, but something worth noting.
  
  This change is required now that `Reset` isn't called in the
  constructor. It couldn't be called in the constructor because it would
  cause the audio track to reset its position too early.
  
  What an ordeal.

  Dean Herbert · 2022-08-24 11:50:20 +09:00
  46d000b8ce
• Avoid setting the source clock until gameplay is ready to start

  Without this change, the audio track may audibly seek during load
  proceedings.

  Dean Herbert · 2022-08-23 18:34:17 +09:00
  29fed0c4a3
• Merge branch 'master' into no-gameplay-clock-gameplay-offset
  Dean Herbert · 2022-08-23 17:36:06 +09:00
  ec61a94dc9
• Merge pull request #19911 from smoogipoo/multi-spectator-clock-cleanup

  Invert creation of clocks in multi-spectator

  Dean Herbert · 2022-08-23 14:26:06 +09:00
  51e607e834
• Remove AddClock method to CreateManagedClock
  Dean Herbert · 2022-08-23 13:52:43 +09:00
  553897f2f0
• Remove unused Source_Set implementation on ISpectatorPlayerClock
  Dean Herbert · 2022-08-23 13:44:41 +09:00
  1191b6c080
• Enable NRT
  Dan Balasescu · 2022-08-22 21:55:04 +09:00
  c59298f0ce
• Simplify track start/stop/paused tracking
  Dean Herbert · 2022-08-22 19:43:18 +09:00
  489e172a76
• Invert creation of clocks in multi spectator
  Dan Balasescu · 2022-08-22 19:14:06 +09:00
  5d3d8681d4
• Merge pull request #19906 from peppy/fix-editor-crash-mobile

  Fix editor crashing on mobile releases

  Dan Balasescu · 2022-08-22 16:31:19 +09:00
  3fb3a18e68
• Merge pull request #19695 from naoei/ruleset-localization

  Change most ruleset-accessible string types to Localisable strings

  Dean Herbert · 2022-08-22 16:13:23 +09:00
  058d67f8e8
• Fix editor crashing on mobile releases
  Dean Herbert · 2022-08-22 15:57:24 +09:00
  19bba143ee
• Merge pull request #19783 from bdach/mod-select/presets-dont-open-customisation

  Fix selecting preset containing Difficulty Adjust automatically opening customisation panel

  Dan Balasescu · 2022-08-22 15:44:00 +09:00
  0815b01b75
• Merge pull request #19830 from peppy/test-ruleset-compatibility

  Test ruleset compatibility during initial startup to avoid runtime errors

  Dan Balasescu · 2022-08-22 15:24:46 +09:00
  2bc0a68911
• Update GetVariantName to also support localisation
  Dean Herbert · 2022-08-22 14:51:00 +09:00
  d199b3b100
• Don't throw when a ruleset type is completely missing
  Dean Herbert · 2022-08-22 14:35:44 +09:00
  9d31f61ca9
• Merge pull request #19905 from smoogipoo/fix-text-boldening

  Fix language change removing mod column bold text

  Dean Herbert · 2022-08-22 14:15:22 +09:00
  594353fca1
• Elaborate with example of GameplayClockContainer managing its own Stop state
  Dean Herbert · 2022-08-22 14:14:44 +09:00
  e6b669db8e
• Move operation of setting GameplayClockContainer.StartTime to Reset call
  Dean Herbert · 2022-08-22 14:11:06 +09:00
  af2e82d7d5
• Fix incorrect implicit null specification for user audio offset bindable
  Dean Herbert · 2022-08-22 14:03:51 +09:00
  17a1df281c
• Make FramedBeatmapClock.Track non-null
  Dean Herbert · 2022-08-22 14:02:41 +09:00
  ba23ce75c2
• Reword class xmldoc to better explain that offset application is optional
  Dean Herbert · 2022-08-22 14:02:20 +09:00
  85d0b7fc57
• Merge pull request #19868 from peppy/fix-test-deadlocks

  Add safeties to avoid deadlock in `SubmittingPlayer`

  Dan Balasescu · 2022-08-22 13:17:41 +09:00
  b81c7ffc60
• Fix language change removing mod column bold text
  Dan Balasescu · 2022-08-22 13:00:47 +09:00
  e1fa959f0b
• Merge pull request #19898 from bdach/mod-select/fix-difficulty-multiplier-rounding

  Adjust rounding in mod select difficulty multiplier to match song select footer

  Dean Herbert · 2022-08-22 11:18:34 +09:00
  3ef6c60d1f
• Adjust rounding in mod select difficulty multiplier to match song select footer

  The 0.01 `Precision` spec on `DifficultyMultiplierDisplay.Current` would
  cause the difficulty multiplier to use a different midpoint rounding
  strategy than `double.ToString()`, which is the one that the song select
  footer relies on. For example, a value of 0.015 would be rounded down
  to 0.01 by `double.ToString()`, but rounded up to 0.02
  by `BindableDouble`.
  
  Fix the discrepancy by just deleting the `Precision` spec. Since the
  value of the bindable would go through `ToLocalisableString(@"N2")`
  anyway, it was redundant as is.
  
  Fixes #19889.

  Bartłomiej Dach · 2022-08-21 23:15:49 +02:00
  aa15e84bea