5707 Commits

• Replace current AR and HD bonuses with a new Reading skill on the osu! ruleset (#33196)

  This PR aims to replace the current bonuses used to award high approach
  rates and scores made using the Hidden mod with a Reading skill that
  takes into account each note's reading difficulty separately, Important
  to note is the fact that as reading difficulty is now a skill the
  bonuses are now additive instead of multiplicative, meaning there are
  vast changes in deltas on the high and low end of scores. Due to the
  nature of adding a new skill new difficulty and performance attributes
  need to be added.
  
  Huis page:
  [https://pp.huismetbenen.nl/rankings/admin/kwotaq-reading](url)
  
  ---------
  
  Co-authored-by: apollo-dw <83023433+apollo-dw@users.noreply.github.com>
  Co-authored-by: js1086 <js1086@student.le.ac.uk>
  Co-authored-by: tsunyoku <tsunyoku@gmail.com>
  Co-authored-by: StanR <hi@stanr.info>

  kwotaq · 2026-01-26 01:49:51 +05:00
  562f1f8004
• Add HarmonicSkill (#36153)

  * Add `OsuHarmonicSkill`
  
  * Make `ProcessInternal` a sealed override
  
  * Move to main game project

  James Wilson · 2025-12-28 17:42:26 +00:00
  c6441723b3
• Extend Skill to include ObjectDifficulties (#36152)

  * Extend `Skill` to include `ObjectDifficulties`
  
  * Remove generic
  
  * Change `ObjectDifficulties` to be modifiable by children skills
  
  * Fix tests

  StanR · 2025-12-28 13:56:55 +00:00
  a07d7ad4cb
• Reduce calls to DifficultyValue where possible (#36112)
  James Wilson · 2025-12-23 00:41:24 +00:00
  d150e27381
• Use number calculated at runtime from DecayWeight (#33733)

  Replaces a constant that assumes DecayWeight == 0.9
  
  Co-authored-by: James Wilson <tsunyoku@gmail.com>
  Co-authored-by: StanR <8269193+stanriders@users.noreply.github.com>

  Nathan Corbett · 2025-12-23 00:16:01 +00:00
  6356d50f13
• Disallow zero-length sliders from specifying a non-zero number of repeats (#35220)
  Bartłomiej Dach · 2025-10-08 16:01:04 +09:00
  1a522a19f1
• Re-remove duplicate error functions
  Dean Herbert · 2025-10-07 16:30:40 +09:00
  743a94bd22
• Merge branch 'master' into pp-dev
  Dean Herbert · 2025-10-07 16:11:54 +09:00
  bda5737135
• Merge pull request #34934 from Valerus9/fixtestdouble

  Fix TestDouble failing on systems where the decimal separator isn't a dot

  Bartłomiej Dach · 2025-09-29 16:46:32 +09:00
  5336bcd71d
• Merge pull request #35120 from LumpBloom7/fix-toolbox-tooltip

  Fix composition tool tooltip not changing text when enabled

  Bartłomiej Dach · 2025-09-29 16:04:15 +09:00
  ba3d7392bf
• Merge branch 'master' into fixtestdouble
  Bartłomiej Dach · 2025-09-29 08:43:49 +02:00
  9257e62bac
• Use slightly nicer way of invarianting rate adjust setting value
  Bartłomiej Dach · 2025-09-29 08:39:01 +02:00
  70f683e7fa
• Handle disabled text in composition tool button
  Derrick Timmermans · 2025-09-26 09:28:04 +02:00
  c66cc5ebb1
• Adjust matchmaking naming, namespaces, xmldoc (#35123)

  * Adjust matchmaking naming, namespaces, xmldoc
  
  * Change partial filenames to use `.` instead of `_` separator

  Dean Herbert · 2025-09-26 12:17:28 +09:00
  e1ba1b45b0
• Fix composition tool tooltip not changing text when enabled
  Derrick Timmermans · 2025-09-25 10:44:05 +02:00
  df795da070
• Remove databasing of MechanicalDifficulty and ReadingDifficulty attributes (#35028)

  * Remove databasing of `MechanicalDifficulty` and `ReadingDifficulty` attributes
  
  * Update attribute IDs

  James Wilson · 2025-09-15 13:46:00 +03:00
  2749184c38
• Fix testtooltip failure
  Valerus9 · 2025-09-13 06:44:29 +02:00
  e34b0659da
• Merge branch 'master' into pp-dev
  Dan Balasescu · 2025-09-07 19:22:08 +09:00
  ffab8342f2
• Make OsuGame dependency optional for sanity
  Dean Herbert · 2025-09-02 21:40:52 +09:00
  a1105ba16f
• Change bass workaround fix to use game clock intead of another-audio-clock

  paper trail:
  https://github.com/ppy/osu/pull/34890#issuecomment-3244549790

  Dean Herbert · 2025-09-02 21:39:12 +09:00
  bee6c32b83
• Fix gameplay freezing on stutter frames / long load times

  Closes https://github.com/ppy/osu/issues/34732.
  
  May hotfix for this one.

  Dean Herbert · 2025-09-02 17:37:33 +09:00
  677beb4251
• Revert "Adjust bass invalid data threshold"

  This reverts commit ddce11fbc8.

  Dean Herbert · 2025-09-02 17:36:08 +09:00
  a8ef57ad0a
• Merge pull request #34830 from minetoblend/fix/hitobject-lifetime-delay

  Fix hitobject drawables becoming visible 1 frame too late

  Dan Balasescu · 2025-08-29 18:38:24 +09:00
  d5575b4037
• Fix obviously incorrect conditional

  Co-authored-by: Bartłomiej Dach <dach.bartlomiej@gmail.com>

  Dean Herbert · 2025-08-29 16:01:49 +09:00
  9e77a5b050
• Fix some mods showing tooltips when settings are default
  Dean Herbert · 2025-08-29 14:08:18 +09:00
  e83f3d5e77
• Return early to avoid creating mod description strings unnecessarily
  Dean Herbert · 2025-08-29 14:08:06 +09:00
  f2f5cf19a2
• Fix operations in PooledDrawableWithLifetimeContainer.CheckChildrenLife being in wrong order

  Previously CompositeDrawable.CheckChildrenLife() would be run before lifetimeManager.Update() which lead to the new drawables being inserted into the container but not being made alive immediately, leading to the drawable not becoming visibile until the next update loop.

  marvin · 2025-08-28 23:36:29 +02:00
  bb9f9e4d35
• Fix HealthProcessor potentially incorrectly reverting failed state

  This stems from me looking into `TestSceneFailAnimation` failures
  (https://github.com/ppy/osu/runs/48663953318). As it turns out, I should
  not have been mad by CI, and rather should have been mad at myself for
  failing to read.
  
  `FailedAtJudgement` in fact does not mean "this judgement, and only this
  judgement, triggered failure". If any further judgements occur
  post-fail, they will also have `FailedAtJudgement` set to true. It is
  essentially a *dump* of the state of `HealthProcessor.Failed` prior to
  applying the judgement.
  
  	https://github.com/ppy/osu/blob/ec21685c2531af3b243f7f0833ffbb340bf3c044/osu.Game/Rulesets/Scoring/HealthProcessor.cs#L49-L57
  
  Because of this, reverting several judgements which occur post-fail
  could lead to failed state reverting earlier than intended, and thus
  potentially trigger a second fail, thus tripping the `Player` assertion.

  Bartłomiej Dach · 2025-08-27 12:27:11 +02:00
  197c318180
• Merge pull request #34761 from frenzibyte/fix-flashlight

  Fix flashlight not always matching gameplay scaling

  Bartłomiej Dach · 2025-08-25 12:03:58 +02:00
  6e8246b539
• Fix xmldoc error and reword
  Salman Alshamrani · 2025-08-24 18:55:45 +03:00
  3cca458c21
• Fix flashlight not handling internal playfield sizing changes

  Note that this does not handle sizing/scaling changes applied directly
  to `Playfield`, but it handles any changes within the layers inside
  `PlayfieldAdjustmentContainer`.

  Salman Alshamrani · 2025-08-24 17:51:05 +03:00
  bc59270f3e
• Merge pull request #34757 from bdach/new-mod-icons

  Update mod icons

  Dean Herbert · 2025-08-23 19:55:10 +09:00
  acafc06bcc
• Fix flashlight not correctly scaled to match playfield
  Salman Alshamrani · 2025-08-21 19:03:43 +03:00
  a049f5065d
• Adjust icon sizings in mod display to match new assets
  Bartłomiej Dach · 2025-08-21 09:00:48 +02:00
  c053cfbf9b
• Add and use new mod icon assets
  Bartłomiej Dach · 2025-08-21 09:00:44 +02:00
  92016a7d9b
• Log bass issues for more than one frame
  Dean Herbert · 2025-08-21 13:27:14 +09:00
  e75a6b4010
• Adjust bass invalid data threshold
  Dean Herbert · 2025-08-21 13:27:13 +09:00
  ddce11fbc8
• Merge pull request #34667 from Hiviexd/verify/exclude-audio-from-hs-check

  Exclude all beatmap audios from the hitsounds format check

  Bartłomiej Dach · 2025-08-19 14:33:35 +02:00
  3b49673e83
• Merge pull request #34666 from Hiviexd/verify/check-inconsistent-audio

  Add verify check for inconsistent audio usage

  Bartłomiej Dach · 2025-08-19 14:33:13 +02:00
  b1296b0c83
• more correct hashset usage
  Hivie · 2025-08-15 14:41:59 +01:00
  0bcf29304b
• Merge pull request #34628 from bdach/show-results-on-failed-replay

  Show indicator in replay player once replay fails

  Dean Herbert · 2025-08-15 19:33:47 +09:00
  a14d7a23bd
• Merge pull request #34651 from Hiviexd/verify/check-video-usage

  Add verify check for inconsistent video usage

  Bartłomiej Dach · 2025-08-15 11:06:20 +02:00
  099d1dc459
• Rename variables
  Bartłomiej Dach · 2025-08-15 10:21:50 +02:00
  5722e85791
• Fix half written comment and adjust threshold down slightly
  Dean Herbert · 2025-08-15 15:40:30 +09:00
  1f10bff7a7
• Don't enforce hotfix during debug builds, to allow interactive tests to run correctly
  Dean Herbert · 2025-08-15 15:29:51 +09:00
  69647f4c9c
• exclude all beatmap audios from the check

  - prevents false positives on maps with multiple audios

  Hivie · 2025-08-15 00:11:16 +01:00
  7b455efe34
• add check for inconsistent audio usage
  Hivie · 2025-08-15 00:08:55 +01:00
  148bc4ac34
• handle pairwise comparison for video start times
  Hivie · 2025-08-14 13:14:58 +01:00
  f928f9953b
• Ignore more potentially incorrect data from BASS

  This is still a workaround but arguably it's something we could leave in
  place without much loss. I think this at least feels better than the
  previous code.
  
  Notably, you could argue the test coverage of the fail case is lower
  since made it implicit that all tests will avoid the "backwards seek"
  detections.  But we never really had tests correctly- fail on the original
  so I don't see any loss of value.

  Dean Herbert · 2025-08-14 19:20:30 +09:00
  82906300b4
• add verify check for video usage
  Hivie · 2025-08-13 20:26:46 +01:00
  e52a4638fe