osu-lazer

Make sliderless aim in fact sliderless (#29993 )

Part of this PR - https://github.com/ppy/osu/pull/27303

Current aim calculation have a flaw of sliderless aim still accounting
for sliders. This happens because of usage of `LazyJumpDistance` as a
main distance metric.

This PR is fixing this by adding `JumpDistance` as true sliderless
metric, using it instead of `LazyJumpDistance`.
This can introduce very rare cases where sliderless aim is worth more
than normal aim (because of velocity change bonus).

The effect of this is minimal on most of the maps. It can be seen the
best on this map - https://osu.ppy.sh/beatmapsets/594751#osu/1257904
Before:

![image](https://github.com/user-attachments/assets/e96773e6-3274-4ed6-8293-ed9bdfa213d0)

After:

![image](https://github.com/user-attachments/assets/126e861b-c28d-4ed4-a0db-f5305225a749)

---------

Co-authored-by: James Wilson <tsunyoku@gmail.com>
Co-authored-by: StanR <8269193+stanriders@users.noreply.github.com>

Givy120 · 2026-01-27 20:23:22 +00:00

aefe31d315

Make reading and flashlight pp to be LP summed (#36464 )

Right now they're summed normally what opens a problem that FL rewards
too much pp when combined with reading map, since you're memorizing FL
anyway.

Co-authored-by: James Wilson <tsunyoku@gmail.com>

Givy120 · 2026-01-26 18:47:08 +00:00

ea87e82a91

Use deviation-based Speed accuracy scaling (#36475 )

https://pp.huismetbenen.nl/rankings/players/tap-statacc

---------

Co-authored-by: James Wilson <tsunyoku@gmail.com>

StanR · 2026-01-26 18:23:04 +00:00

ae43d3e3b1

Move TD difficulty reduction to Aim (#36476 )

StanR · 2026-01-26 14:23:44 +00:00

02b76db094

Move speed distance bonus to aim (#36168 )

This doesn't solve _flow_ aim in any way, but makes it so that `Speed`
doesn't have distance scaling (read as "aim") anymore which fixes some
issues related to that like the length bonus behaving incorrectly, and
in general `Speed` being an aim+tap skill instead of just a tapping
skill

---------

Co-authored-by: James Wilson <tsunyoku@gmail.com>

StanR · 2026-01-25 21:21:20 +00:00

0afcebe8bf

Replace current AR and HD bonuses with a new Reading skill on the osu! ruleset (#33196 )

This PR aims to replace the current bonuses used to award high approach
rates and scores made using the Hidden mod with a Reading skill that
takes into account each note's reading difficulty separately, Important
to note is the fact that as reading difficulty is now a skill the
bonuses are now additive instead of multiplicative, meaning there are
vast changes in deltas on the high and low end of scores. Due to the
nature of adding a new skill new difficulty and performance attributes
need to be added.

Huis page:
[https://pp.huismetbenen.nl/rankings/admin/kwotaq-reading](url)

---------

Co-authored-by: apollo-dw <83023433+apollo-dw@users.noreply.github.com>
Co-authored-by: js1086 <js1086@student.le.ac.uk>
Co-authored-by: tsunyoku <tsunyoku@gmail.com>
Co-authored-by: StanR <hi@stanr.info>

kwotaq · 2026-01-26 01:49:51 +05:00

562f1f8004

Use correct object for the aim slider bonus (#36216 )

Currently the slider bonus works on the assumption that the travel
velocity of the previous slider is a part of the current object's
difficulty because it is part of the movement from prev to curr.
However, this is contradicted by the fact that `currVelocity` is a
combination of prev->curr + curr slider velocity and is actually
breaking the assumption that slider difficulty is contained in the
slider itself that we take when calculating difficult slider strains.

This makes it so that the slider bonus difficulty is contained in the
slider itself instead of buffing the next object, which makes both the
calculation overall more consistent and the slider factor calculation
actually work as expected.

Aim multiplier got slightly lowered because this change makes most of
the sliders gain a little bit

---------

Co-authored-by: James Wilson <tsunyoku@gmail.com>

StanR · 2026-01-24 22:49:23 +00:00

c25820aa57

Improve angle calculation to better represent the path taken on sliders (#35555 )

## This pr resolves the issue with the angle calculation.
The old system calculated the angle between three objects. If the last
object was a long slider that the player needed to follow, the system
calculated the angle using only the slider’s end point and the previous
object, which caused long sliders to have incorrect angle values.

---------

Co-authored-by: StanR <hi@stanr.info>
Co-authored-by: James Wilson <tsunyoku@gmail.com>

Dark98 · 2026-01-24 22:05:59 +00:00

fb8d198a64

Replace Speed skill strain summation with a per-note harmonic sum (#34696 )

The purpose of this change is to remove the arbitrary note based length
bonus for speed and replace it with a more concrete per note difficulty
aware calculation. As a result of the summation needing to be per-note,
chunking and in consequence peak strain reduction have both been removed
from the skill. ~~The various strain counting functions also heavily
relied on chunking and the way summation worked, so they have also been
changed to match values held before the change as much as possible
(given the different summation some changes in values are bound to
happen).~~ Above was a bug.

Huis page:
[https://pp.huismetbenen.nl/rankings/players/length-bonus](https://pp.huismetbenen.nl/rankings/players/length-bonus)

---------

Co-authored-by: James Wilson <tsunyoku@gmail.com>

kwotaq · 2026-01-24 19:40:01 +00:00

520173e37d

Move strain's influence in the difficulty of a note based on deltaTime to the evaluator level (#36417 )

This PR moves the influence of d/t^2 from the skill (through strain)
directly into the evaluator level as a bonus applied at the end. This
makes it more clear what d/t^2 is, and the fact that it applies to *all*
bonuses in the evaluator. As well, the peak strain value of a note is
now equal to the evaluator value. This comes with a couple benefits:

1. The BPM weight is now subject to balance, and can be flattened easily
for a more "d/t" like system (previously this required hacky solutions)
2. StrainDecayBase becomes a much more useful variable now that it does
not affect the difficulty of the note itself. When adjusting this in
live, your star rating would double upon changing from 0.15 in aim to
0.3, and now it is intuitive what it does (makes strain take longer to
accumulate). This means that future balancing efforts can use evaluators
to dynamically adjust strainDecayBase (potentially letting large spikes
provide more strain for the same difficulty if they're wide angle, for
example).
3. In the object inspector, you get the actual maximum difficulty value
of a note as seen in the ObjectDifficulties list. This makes it easier
to tell what notes are deemed as harder by the system. For context,
previously, a note of difficulty 1 at 200bpm would cap out at 6 as a
result of strain, and a note of the same difficulty but at 300bpm would
cap out at 8.

The actual implementation is really really simple. I'm willing to move
this to flashlight if wanted (I don't think it's necessary), or even
abstract this away so that (1 - decay) doesn't look like a balancing
constant.

Side note: this is equivalent to live, except for notes with a deltaTime
of less than 25ms (since I am using AdjustedDeltaTime in the aim
evaluator for the bonus to avoid divisions by zero).

Natelytle · 2026-01-23 00:05:21 +05:00

2876cebdd7

Add comment for wiggle bonus multiplier (#36373 )

It's a common mistake by newer pp dev contributors to increase the
wiggle multiplier not knowing its at its maximum, so I added a comment
to try to avoid more people doing it.

---------

Co-authored-by: StanR <8269193+stanriders@users.noreply.github.com>

kwotaq · 2026-01-18 13:56:23 +00:00

cda52cdae8

Fix legacy score base multiplier being calculated using modded difficulty values (#36209 )

Fun correctness bug.

ScoreV1 multiplier uses the **nomod** peppy stars (i.e the beatmap's
"base" HP, OD and CS) in all cases, which was generally the intention
with this code but it passes the wrong beatmap resulting in it using
modded values for this.

Cross referenced with stable and this now results in the expected
multipliers.

Results in some very minor (<3pp from my testing) changes for HR and EZ
scores with combo breaks.

James Wilson · 2026-01-17 09:30:37 +00:00

7fc24c6566

Improve fullcombo threshold formula (#35724 )

* Implement new portion formula

* Change the formula

* Use base value of 5 sliders

* Make the threshold harsher

---------

Co-authored-by: StanR <8269193+stanriders@users.noreply.github.com>

Givy120 · 2026-01-04 00:51:45 +05:00

bcaf35dae7

Change the doubletapness scaling to be more punishing on the low end of the hitwindow (#36148 )

StanR · 2025-12-29 10:11:25 +00:00

dd261623cd

Add HarmonicSkill (#36153 )

* Add `OsuHarmonicSkill`

* Make `ProcessInternal` a sealed override

* Move to main game project

James Wilson · 2025-12-28 17:42:26 +00:00

c6441723b3

Extend Skill to include ObjectDifficulties (#36152 )

* Extend `Skill` to include `ObjectDifficulties`

* Remove generic

* Change `ObjectDifficulties` to be modifiable by children skills

* Fix tests

StanR · 2025-12-28 13:56:55 +00:00

a07d7ad4cb

Reduce calls to DifficultyValue where possible (#36112 )

James Wilson · 2025-12-23 00:41:24 +00:00

d150e27381

Use number calculated at runtime from DecayWeight (#33733 )

Replaces a constant that assumes DecayWeight == 0.9

Co-authored-by: James Wilson <tsunyoku@gmail.com>
Co-authored-by: StanR <8269193+stanriders@users.noreply.github.com>

Nathan Corbett · 2025-12-23 00:16:01 +00:00

6356d50f13

change FL calc depending on HD settings (#33019 )

Co-authored-by: StanR <8269193+stanriders@users.noreply.github.com>

Givy120 · 2025-12-23 04:50:35 +05:00

906df15cbe

Uses real distance in speed instead of mishandling variables (#35387 )

Co-authored-by: StanR <8269193+stanriders@users.noreply.github.com>

Nathan Corbett · 2025-12-22 22:58:31 +00:00

90e820b76a

Simplify osu! star rating calculations (#36063 )

* Simplify star rating calculations

* Refactor

StanR · 2025-12-19 12:59:22 +00:00

99daec3835

Use DifficultyCalculationUtils.Norm (#36064 )

StanR · 2025-12-18 18:19:16 +00:00

16c1adf0f7

Skip score-based miss count estimation for ScoreV2 (#35962 )

* Add basic scorev2 support

* Revert unnecessary score statistic changes

* Fix CI

* Revert changes

* Disable score-based misscount for scoreV2

Givy120 · 2025-12-13 12:29:20 +00:00

346461ffdc

Remove drain rate attribute (#35817 )

Givy120 · 2025-11-29 19:01:15 +00:00

1b230b3fdd

Reading bonus hotfix for Traceable mod (#35266 )

* Pass slider factor to visibility bonus correctly for TC

* Decrease reading bonuses for TC

James Wilson · 2025-10-13 13:34:57 +09:00

2025.1013.0 28c846b4d9

Quick play forward design work (#35253 )

* Remove unnecessary information from matchmaking beatmap panel

* Move avatar overlay inside card for better layout

* Allow higher jumping when jumping in succession

* Exclude player panel avatars from masking

* Adjust player panel animations a bit further

* Add avatar-only display mode

* Fix round warmup test not working

* Remove dead test scenes

* Fix edge case where users are added to not-yet-loaded card

* Decouple `PlayerPanel` from `UserPanel`

* Fix remaining test failure (and rename test to match new naming)

Dean Herbert · 2025-10-13 13:28:09 +09:00

8e36533f65

Merge pull request #35255 from dnfd1/rotate

Fix default origin in skin editor when rotating multiple objects

Bartłomiej Dach · 2025-10-10 12:19:53 +02:00

9ebc5b0a35

Merge pull request #35252 from bdach/song-select-present-sometimes-fails

Fix wrong beatmap shown when presenting a beatmap from results screen

Dean Herbert · 2025-10-10 14:54:50 +09:00

1f2928bf2f

Add some logging when FindWithRefresh triggers a slow realm refresh

Dean Herbert · 2025-10-10 13:36:28 +09:00

94c7489c1c

Merge branch 'ppy:master' into rotate

dnfd1 · 2025-10-09 08:52:21 -07:00

3bb6685e75

convert origin of rotation to screen space for selections multiple objects in skin editor

dnfd1 · 2025-10-09 08:36:01 -07:00

e3459eccf2

Merge pull request #35240 from bdach/song-select-preserve-selection-on-update-attempt-3

Fix song select V2 not preserving selection after an update operation

Dean Herbert · 2025-10-09 17:30:28 +09:00

52f82c7e56

Fix weird xmldoc issue

Rider was fine with it...

Bartłomiej Dach · 2025-10-09 10:17:55 +02:00

3fc3a53521

Merge pull request #35251 from smoogipoo/fix-broken-tests

Fix test failures during individual runs

Dean Herbert · 2025-10-09 17:09:01 +09:00

2136d95087

Merge pull request #35250 from smoogipoo/fix-test-leaks

Fix test scene leaks through RealmRulesetStore/RealmAccess

Dean Herbert · 2025-10-09 17:08:07 +09:00

c58d13b802

Fix wrong beatmap shown when presenting a beatmap from results screen

- Closes https://github.com/ppy/osu/issues/35023.
- Supersedes / closes https://github.com/ppy/osu/pull/35107.

Bartłomiej Dach · 2025-10-09 09:52:22 +02:00

b477790d3e

Add test demonstrating failure scenario

Bartłomiej Dach · 2025-10-09 09:46:32 +02:00

e33de9b658

Fix test failures during individual runs

Dan Balasescu · 2025-10-09 16:34:55 +09:00

6eaf91d31a

Fix shift-clicking not working on extra size beatmap cards

Was broken due to double assignment to `Action`.

Bartłomiej Dach · 2025-10-09 08:59:26 +02:00

6da6edd1d1

Fix undisposed Realm subscription

Dan Balasescu · 2025-10-09 15:56:34 +09:00

6af5158bb4

Fix test scene leaks through RealmRulesetStore/RealmAccess

Dan Balasescu · 2025-10-09 15:28:15 +09:00

79c367d208

Merge pull request #35241 from bdach/song-select-crash-on-missing-group

Fix carousel sometimes crashing when attempting to select next random set

Dean Herbert · 2025-10-09 06:20:22 +09:00

91019dcdf7

Update framework

Dean Herbert · 2025-10-08 23:18:35 +09:00

422392233b

Fix carousel sometimes crashing when attempting to select next random set

I'm not exactly sure on the reproduction scenario here, but I have had
switching ruleset with converts disabled crash on me a few times
today. It appears to happen sometimes when after the switch the expanded
group no longer exists in the set mapping, because a filter just ran and
removed that group from set of possible groups because there'd be no
beatmaps under it.

I tried to manufacture a quick test but it's not a quick one to test
because filtering intereference is required to reproduce, I think.
I will try again on request but I mostly just want to get this fix out
ASAP before I finish up for the day.

Bartłomiej Dach · 2025-10-08 15:13:00 +02:00

7b1e3cd537

Fix song select V2 not preserving selection after an update operation

Because the detached store exists and has a chance to actually
semi-reliably intercept a beatmap update operation, I decided to try
this. It still uses a bit of a heuristic in that it checks for
transactions that delete and insert one beatmap each, but probably the
best effort thus far?

Notably old song select that was already doing the same thing locally to
itself got a bit broken by this, but with some tweaking that *looks* to
be more or less harmless I managed to get it unbroken. I'm not too
concerned about old song select, mind, mostly just want to keep it
*vaguely* working if I can help it.

Bartłomiej Dach · 2025-10-08 14:42:26 +02:00

30412ba3f2

Merge pull request #35233 from diquoks/quick-fix/sfx-mute-on-restart

Mute SFX when holding restart beatmap bind

Dean Herbert · 2025-10-08 21:39:07 +09:00

4622d39f41

Merge pull request #35234 from diquoks/quick-fix/spinner-rpm-layering

Fix `spinner-rpm` being layered above `spinner-spin` / `spinner-clear`

Dean Herbert · 2025-10-08 21:21:21 +09:00

0d5c041cac

Merge pull request #35239 from bdach/song-select-weirdness

Fix current beatmap set being incorrectly expanded after collapsing group with current selection

Dean Herbert · 2025-10-08 21:19:08 +09:00

ffe8b9f4c3

Fix current beatmap set being incorrectly expanded after collapsing group with current selection

Noticed in passing. See preceding commit for failure scenario.

Regressed in https://github.com/ppy/osu/pull/35163.

Bartłomiej Dach · 2025-10-08 13:42:43 +02:00

9ba9966078

Add failing test

Bartłomiej Dach · 2025-10-08 13:42:31 +02:00

f1ec04114f

75515 Commits