164 Commits

• Reduce HitSampleInfo constants allocations
  Andrei Zavatski · 2025-01-07 00:36:58 +03:00
  e8dc09f5bc
• Centralise supported file extensions to one helper class

  As proposed in
  https://github.com/ppy/osu-server-beatmap-submission/pull/5#discussion_r1861680837.

  Bartłomiej Dach · 2024-11-29 08:42:45 +01:00
  110e4fbb30
• Fix typo
  Bartłomiej Dach · 2024-07-03 16:13:47 +02:00
  00a0058fc7
• Use one less regex
  Bartłomiej Dach · 2024-07-03 16:13:30 +02:00
  bcb479d4f7
• Adjust conditionals

  The fact that checking the unicode title was gated behind a
  `hasRomanisedTitle` guard was breaking my brain.

  Bartłomiej Dach · 2024-07-03 15:52:05 +02:00
  5696e85b68
• Compile regexes for speed
  Bartłomiej Dach · 2024-07-03 15:49:21 +02:00
  32b3d3d7df
• Address code quality issues
  Bartłomiej Dach · 2024-07-03 15:49:17 +02:00
  901fec65ef
• Make MarkerChecks and MarkerCheck class private
  Arthur Araujo · 2024-07-02 21:09:49 -03:00
  7143ff523f
• Fix explicit array type specification in MarkerChecks
  Arthur Araujo · 2024-07-02 20:55:52 -03:00
  7cdad20119
• Add verify checks for title markers
  Arthur Araujo · 2024-07-02 17:20:00 -03:00
  7cb3d7445c
• Implement automatic break period generation
  Bartłomiej Dach · 2024-06-19 10:22:06 +02:00
  4022a8b06c
• Do not attempt to pass files that don't look like audio to BASS
  Bartłomiej Dach · 2024-04-22 10:45:09 +02:00
  70a5288a68
• Use explicit reference equality check
  Bartłomiej Dach · 2024-04-22 10:27:30 +02:00
  ceeb9b0819
• Remove redundant array type specification
  Bartłomiej Dach · 2024-04-22 10:25:46 +02:00
  1bcf835d22
• Use bitwise to check hitsound formats
  Arthur Araujo · 2024-04-22 04:44:38 -03:00
  49563f4e5b
• Remove ChannelType from messages
  Arthur Araujo · 2024-04-19 08:01:23 -03:00
  92b85beff6
• Remove unsued import and add a blankline before yield break;
  Arthur Araujo · 2024-04-19 07:39:31 -03:00
  68e86b5105
• Use periods instead of semicolons

  Co-authored-by: Bartłomiej Dach <dach.bartlomiej@gmail.com>

  Arthur Araujo · 2024-04-19 07:20:59 -03:00
  eac9dededf
• Fix test methods names
  Arthur Araujo · 2024-04-17 08:22:05 -03:00
  ac03856ebd
• Remove BassFlags.Prescan and free the decodeStream
  Arthur Araujo · 2024-04-17 08:14:19 -03:00
  8d94f8d995
• Deal with corrupt audio files

  This removes the corrupt file check from CheckTooShortAudioFiles and makes the audio formats checks deal with it instead to avoid redundant messages.

  Arthur Araujo · 2024-04-16 06:53:55 -03:00
  c32d99250f
• Add checks for audio formats
  Arthur Araujo · 2024-04-16 06:15:21 -03:00
  9ef27104ce
• Merge branch 'master' into verify-abnormal-difficulty-settings
  Bartłomiej Dach · 2024-03-26 11:13:16 +01:00
  b74f8dba41
• Refactor abstract check to reduce duplication
  Bartłomiej Dach · 2024-03-26 11:13:03 +01:00
  1866b4b6b1
• Fix formatting issue
  Arthur Araujo · 2024-03-23 23:28:55 -03:00
  8a05fecad5
• Add video resolution check
  Arthur Araujo · 2024-03-23 19:22:47 -03:00
  6fbe1a5b8d
• Make CheckAbnormalDifficultySettings abstract
  Arthur Araujo · 2024-03-22 01:37:06 -03:00
  a4822fd615
• Fix codefactor issues
  Arthur Araujo · 2024-03-20 18:54:38 -03:00
  b132734f9c
• Add mania keycount check
  Arthur Araujo · 2024-03-20 15:52:16 -03:00
  c605e463a4
• Add abnormal difficulty settings checks
  Arthur Araujo · 2024-03-20 09:31:58 -03:00
  4904c49c38
• Fix check crash on empty beatmap
  Bartłomiej Dach · 2024-03-19 19:17:22 +01:00
  2b83e6bc4c
• Add different warning to maps with storyboard/video
  Arthur Araujo · 2024-03-18 16:08:41 -03:00
  5241c999c1
• Use GetLastObjectTime to calculate mapped length
  Arthur Araujo · 2024-03-18 14:02:33 -03:00
  c23212f4ef
• Fix issue type and display percentage left
  Arthur Araujo · 2024-03-18 13:51:36 -03:00
  915a9682b5
• Inline percentage calculation
  Arthur Araujo · 2024-03-18 13:27:43 -03:00
  a3f3dcf853
• Fix codefactor issues
  Arthur Araujo · 2024-03-16 23:03:06 -03:00
  f7aff76592
• Add verify checks to unused audio at the end
  Arthur Araujo · 2024-03-16 21:20:12 -03:00
  63816adbc0
• Fix audio in video check crashing on unexpected failures
  Bartłomiej Dach · 2024-03-13 13:55:49 +01:00
  20c760835a
• Use new LINQ Order() instead of OrderBy() when possible
  Berkan Diler · 2024-02-08 18:01:00 +01:00
  6adf0ac01e
• style: remove usage of HIT_FLOURISH

  Unaware clueless usage

  tsrk · 2023-09-01 21:02:43 +02:00
  a4e146ad9b
• fix(AudioCheckUtils): use Path.GetExtension()

  To avoid filename escaping

  tsrk · 2023-09-01 20:56:54 +02:00
  2e2dcd99a6
• style: convert to using declaration for less nesting
  tsrk · 2023-09-01 20:54:02 +02:00
  5f00d3e2a4
• fix(AudioCheckUtils): add license header
  tsrk · 2023-08-29 23:27:15 +02:00
  5ecd5142d8
• fix: issue template typo in CheckDelayedHitsounds
  tsrk · 2023-08-29 20:15:33 +02:00
  b3d432b0d5
• style: move common audio utils to separate static class
  tsrk · 2023-08-29 20:10:35 +02:00
  c1a7ad09b4
• fix: use using statement for waveform auto-disposal
  tsrk · 2023-08-29 19:46:19 +02:00
  a7a64b57e9
• style: use HitSampleInfo.All properties
  tsrk · 2023-08-29 19:42:37 +02:00
  a04333c17b
• style(editor/checks): add issues for delays with no silence
  tsrk · 2023-08-25 11:46:09 +02:00
  29a46f5b36
• style: use more rigorous hitsound filtering
  tsrk · 2023-08-25 00:37:45 +02:00
  4c32e9a479
• revert: use old wording

  This makes more sense wrt to the complete silence thing.
  
  Refs: f7599c5b

  tsrk · 2023-08-24 23:52:41 +02:00
  50dbf564a5