h1or4dme8/osu-lazer
1
0
Fork 0
mirror of https://github.com/ppy/osu.git synced 2024-09-22 04:07:25 +08:00
Code Issues Releases Wiki Activity

style: use more rigorous hitsound filtering

Browse Source
This commit is contained in:
tsrk 2023-08-25 00:37:45 +02:00
parent f05659a1c0
commit 4c32e9a479
No known key found for this signature in database
GPG Key ID: EBD46BB3049B56D6
1 changed files with 16 additions and 2 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

18
osu.Game/Rulesets/Edit/Checks/CheckDelayedHitsounds.cs
View File

@ -23,7 +23,8 @@ namespace osu.Game.Rulesets.Edit.Checks
private const int delay_threshold_negligible = 1;
private readonly string[] audioExtensions = { "mp3", "ogg", "wav" };
private readonly string[] sampleBankPrefixes = { HitSampleInfo.BANK_NORMAL, HitSampleInfo.BANK_SOFT, HitSampleInfo.BANK_DRUM };
private readonly string[] bankNames = { HitSampleInfo.BANK_NORMAL, HitSampleInfo.BANK_SOFT, HitSampleInfo.BANK_DRUM };
private readonly string[] sampleSets = { HitSampleInfo.HIT_NORMAL, HitSampleInfo.HIT_WHISTLE, HitSampleInfo.HIT_FINISH, HitSampleInfo.HIT_CLAP };
public CheckMetadata Metadata => new CheckMetadata(CheckCategory.Audio, "Delayed hit sounds.");
@ -100,7 +101,20 @@ namespace osu.Game.Rulesets.Edit.Checks
}
private bool hasAudioExtension(string filename) => audioExtensions.Any(filename.ToLowerInvariant().EndsWith);
private bool isHitSound(string filename) => sampleBankPrefixes.Select(p => p + "-").Any(filename.ToLowerInvariant().StartsWith);
private bool isHitSound(string filename)
{
// <bank>-<sampleset>
string[] parts = filename.ToLowerInvariant().Split('-');
if (parts.Length != 2)
return false;
string bank = parts[0];
string sampleSet = parts[1];
return bankNames.Contains(bank) && sampleSets.Any(sampleSet.StartsWith);
}
public class IssueTemplateConsequentDelay : IssueTemplate
{