138 Commits

• Remove ScorePerformanceCache

  This class was only used in two places, both on the results screen, but
  was holding references to `OsuPlayfield` game-wide (due to unrelated
  issues, but still).
  
  Because I can't really think of future use cases for this, and running
  the calculation twice at results screen isn't a huge overhead, let's
  just do that for now to keep things simple.

  Dean Herbert · 2024-01-29 15:28:20 +09:00
  76832a1495
• Fix overall ranking text overlapping at some aspect ratios

  Can't confirm on the actual ranking screen due to stuff not working.
  
  Maybe it'll work tomorrow.
  
  Closes https://github.com/ppy/osu/issues/26341.

  Dean Herbert · 2024-01-06 20:25:07 +09:00
  14a43375a7
• Fix differing anchor specs on statistics panel flow items
  Bartłomiej Dach · 2023-07-13 20:00:29 +02:00
  20bde40ce2
• Disable masking on inner scroll container
  Dean Herbert · 2023-07-13 19:01:59 +09:00
  2c27b17c85
• Rename StatisticContainer to StatisticItemContainer and add a background
  Dean Herbert · 2023-07-13 18:59:11 +09:00
  e34839c891
• Change OverallRanking to use a two-column layout similar to statistics table
  Dean Herbert · 2023-07-13 18:45:32 +09:00
  b333945cde
• Adjust metrics of HitEventTimingDistributionGraph
  Dean Herbert · 2023-07-13 18:45:32 +09:00
  0881f4772c
• Adjust metrics of SimpleStatisticTable
  Dean Herbert · 2023-07-13 18:45:32 +09:00
  947b40149f
• Centralise font size specification for statistic items (and reduce slightly)
  Dean Herbert · 2023-07-13 18:31:40 +09:00
  d54cf63983
• Adjust metrics of PerformanceBreakdown
  Dean Herbert · 2023-07-13 18:30:57 +09:00
  f223fd7c3b
• Adjust metrics of OverallRanking
  Dean Herbert · 2023-07-13 18:30:57 +09:00
  7637a9e603
• Remove more GridContainer nonsense
  Dean Herbert · 2023-07-13 18:30:57 +09:00
  98bf15182e
• Fix animation restarting unexpectedly
  Dean Herbert · 2023-07-13 15:07:26 +09:00
  1d62a041cc
• Fix graph breaking when resized vertically
  Dean Herbert · 2023-07-13 14:57:01 +09:00
  21f26f98da
• Split bar drawable creation into own method
  Dean Herbert · 2023-07-13 14:43:41 +09:00
  e2b5abd4e8
• Fix timing distribution graph sometimes not displaying correctly

  Weird "basal" height logic just didn't make any sense (was getting stuck at 1 when `DrawHeight` was 0)

  Dean Herbert · 2023-07-12 19:21:39 +09:00
  4f4c481a67
• Adjust results screen transition tweens to feel better
  Dean Herbert · 2023-07-07 17:39:54 +09:00
  82babbf8fa
• Manual fixes to reduce warnings to zero
  Dean Herbert · 2023-06-24 01:52:53 +09:00
  df5b389629
• Automated pass
  Dean Herbert · 2023-06-24 01:00:03 +09:00
  0ab0c52ad5
• Simplify column dimensions code

  `dimensions` would always receive exactly one item, so might as well
  inline it.
  
  And yes, at this point the grid container is mostly a glorified
  `FillFlowContainer { Direction = FlowDirection.Vertical }`, but I am not
  touching that in this pull pending further decisions with respect to
  direction.

  Bartłomiej Dach · 2023-06-03 19:40:01 +02:00
  602d5db3bb
• Return StatisticItems rather than StatisticRows from ruleset

  There were no usages of more than one column being provided per row, so
  it seemed like unnecessarily complexity. I'm currently trying to reduce
  complexity so we can improve the layout of the results screen, which
  currently has up to three levels of nested `GridContainer`s.
  
  Of note, I can't add backwards compatibility because the method
  signature has not changed in `Ruleset` (only the return type). If we do
  want to keep compatibility with other rulesets, we could designate a new
  name for the updated method.

  Dean Herbert · 2023-06-01 14:35:15 +09:00
  985604fab5
• Remove unused Dimension specification from StatisticItem
  Dean Herbert · 2023-06-01 14:25:18 +09:00
  dc595b83f1
• Fix incorrect accuracy display on overall ranking view
  Bartłomiej Dach · 2022-12-27 19:51:51 +01:00
  e90619244d
• Don't show global rankings display when not logged in
  Bartłomiej Dach · 2022-12-24 14:35:11 +01:00
  36a6f3685e
• Add overall ranking display to solo results
  Bartłomiej Dach · 2022-12-24 14:35:04 +01:00
  da519acb20
• Add protected method for customising statistics panel rows
  Bartłomiej Dach · 2022-12-24 14:35:00 +01:00
  3abdf557ea
• Remove unused constructor param
  Bartłomiej Dach · 2022-12-24 10:44:38 +01:00
  83a50816b6
• Use plain bindable flow instead of binding to watcher directly
  Bartłomiej Dach · 2022-12-24 10:27:28 +01:00
  4e5109a649
• Implement overall ranking display for solo results screen
  Bartłomiej Dach · 2022-12-24 00:30:38 +01:00
  c7f248e13c
• Partial everything
  Dan Balasescu · 2022-11-27 00:00:27 +09:00
  7bc8908ca9
• Remove various simple obsoletions
  Dean Herbert · 2022-10-28 13:20:58 +09:00
  42eafe318c
• fix(osu.Game): reset Y axis of the bars in hit distribution graph at the first drawing
  Acid Chicken (硫酸鶏) · 2022-09-12 16:25:29 +09:00
  4f298db066
• fix(osu.Game): bars in hit distribution graph stretching in the opposite direction when DrawHeight is less than DrawWidth
  Acid Chicken (硫酸鶏) · 2022-09-12 16:20:33 +09:00
  0d0e2e7bcc
• Avoid using bindables
  Dean Herbert · 2022-09-12 15:56:06 +09:00
  96951057df
• Move helper functions down in file
  Dean Herbert · 2022-09-12 15:50:10 +09:00
  bcd2445d9b
• Apply NRT to HitEventTimingDistributionGraph
  Dean Herbert · 2022-09-12 15:48:50 +09:00
  0755289ec3
• fix(osu.Game): handle size changes in timing distribution graph
  Acid Chicken (硫酸鶏) · 2022-09-12 04:46:32 +09:00
  ac324c63e2
• Rename ordering helper method
  Dean Herbert · 2022-09-08 17:50:27 +09:00
  c6521e4c72
• chore(osu.Game): combine Osu.Colour.{Draw,Text}ForHitResult into OsuColour.ForHitResult
  Acid Chicken (硫酸鶏) · 2022-09-07 23:34:46 +09:00
  267465df18
• refactor(osu.Game): arrange the code for the timing distribution graph
  Acid Chicken (硫酸鶏) · 2022-09-07 23:29:10 +09:00
  b560b6f745
• Simplify children assignment
  Dean Herbert · 2022-09-07 16:51:51 +09:00
  99ef0c95fe
• refactor(osu.Game): improve code quality
  Acid Chicken (硫酸鶏) · 2022-09-07 02:29:15 +09:00
  3003fc1061
• chore(osu.Game): align height of bars on timing distribution graph to basalHeight first and combine their transitions into each one
  Acid Chicken (硫酸鶏) · 2022-09-06 00:04:10 +09:00
  b109e5de6c
• chore(osu.Game): only the first result should be white at zero position on HitEventTimingDistributionGraph
  Acid Chicken (硫酸鶏) · 2022-09-05 04:44:27 +09:00
  7e77c9e8b4
• chore(osu.Game): split transform duration of bars on HitTimingDistributionGraph
  Acid Chicken (硫酸鶏) · 2022-09-05 03:45:51 +09:00
  b67fd3d880
• chore(osu.Game): colorize bars by OD on HitEventTimingDistributionGraph
  Acid Chicken (硫酸鶏) · 2022-09-05 02:02:38 +09:00
  0af6b3dc0f
• Check if StatisticItem.Name is null or empty
  naoei · 2022-08-20 21:48:53 -04:00
  29ef1c8db8
• Make StatisticItem.Name not nullable
  naoei · 2022-08-20 21:48:35 -04:00
  9386d352b8
• Update incorrect xmldoc
  Bartłomiej Dach · 2022-08-17 22:03:35 +02:00
  d06959e1dd
• Allow StatisticItem's name param to be nullable
  naoei · 2022-08-14 14:51:35 -04:00
  18ce784ae0