685 Commits

• Simplify playback logic
  Salman Ahmed · 2024-02-05 01:03:04 +03:00
  44a594ba05
• Remove unused parameter
  Salman Ahmed · 2024-02-02 00:44:51 +03:00
  4dbcb41dd1
• Play legacy applause sound only when rank is B or higher
  Salman Ahmed · 2024-02-01 16:08:36 +03:00
  5bbaeb6836
• Merge branch 'master' into fix-results-f-rank
  Salman Ahmed · 2024-02-01 15:29:07 +03:00
  35c3f5e250
• Mark ResultsScreen.Score as nullable

  Is nullable in playlist results at very least.

  Dean Herbert · 2024-01-29 16:43:26 +09:00
  fb24c66342
• Add safety in ResultsScreen.Exit to ensure HitEvents are not holding references

  This is a catch-all safety disconnecting `ScoreInfo` from `HitObject`s.

  Dean Herbert · 2024-01-29 16:16:17 +09:00
  eb90ee5415
• Remove ScorePerformanceCache

  This class was only used in two places, both on the results screen, but
  was holding references to `OsuPlayfield` game-wide (due to unrelated
  issues, but still).
  
  Because I can't really think of future use cases for this, and running
  the calculation twice at results screen isn't a huge overhead, let's
  just do that for now to keep things simple.

  Dean Herbert · 2024-01-29 15:28:20 +09:00
  76832a1495
• Force results screen to play default D rank applause sound on fail (regardless of skin)
  Salman Ahmed · 2024-01-27 01:46:43 +03:00
  d25262944e
• Fix results screen showing other rank badges on F rank
  Salman Ahmed · 2024-01-27 01:46:12 +03:00
  47f0b86018
• Fix crash at results screen when hidden is enabled and S rank becomes A due to miss

  Closes https://github.com/ppy/osu/issues/26692.

  Dean Herbert · 2024-01-25 15:02:44 +09:00
  37e370e654
• Apply more correct visual offset adjustment

  Co-authored-by: Walavouchey <36758269+Walavouchey@users.noreply.github.com>

  Dean Herbert · 2024-01-23 19:16:55 +09:00
  0cf90677e6
• Remove remnant of old implementation of showing "A due to misses"
  Bartłomiej Dach · 2024-01-22 19:58:11 +01:00
  45dc9de1e0
• Adjust results screen to handle S->A rank adjustment when misses are present
  Dean Herbert · 2024-01-22 21:43:32 +09:00
  83f9118b22
• Change rolling counters to use quicker easing types
  Dean Herbert · 2024-01-17 18:18:53 +09:00
  a66ddc7813
• Merge pull request #26287 from wooster0/no-scores-yet

  Don't leave scores screen empty if no scores are present yet

  Bartłomiej Dach · 2024-01-15 19:49:20 +01:00
  a41108057f
• Revert "simplify the code even more"

  This reverts commit 9bc9db9138.

  Bartłomiej Dach · 2024-01-15 18:47:49 +01:00
  9d2c82452c
• simplify the code even more
  wooster0 · 2024-01-15 20:58:43 +09:00
  9bc9db9138
• apply some suggestions/corrections
  wooster0 · 2024-01-09 21:28:46 +09:00
  8ad697ff4c
• Fix overall ranking text overlapping at some aspect ratios

  Can't confirm on the actual ranking screen due to stuff not working.
  
  Maybe it'll work tomorrow.
  
  Closes https://github.com/ppy/osu/issues/26341.

  Dean Herbert · 2024-01-06 20:25:07 +09:00
  14a43375a7
• Use already existing message placeholder + localized string
  wooster0 · 2024-01-04 12:15:48 +09:00
  2c64db0628
• Don't leave scores screen empty if no scores are present yet

  Addresses https://github.com/ppy/osu/discussions/23787
  
  I originally wanted to set `allowShowingResults` to false if there are
  no results but because this involves an API request to fetch the scores
  that would mean all the scores would have to be fetched all at once so
  that it knows whether to hide or show the "View results" button on a
  beatmap.
  Because that would slow things down and be very inefficient, this still
  allows the user to view the scores screen but if there aren't any
  scores, it shows a text, which I think is at least for now better than
  nothing.
  
  As for the testing of this, I wasn't sure how to not generate scores
  only for one specific test so I opted into not using `SetUpSteps` and
  doing it that way.

  wooster0 · 2023-12-31 22:42:32 +09:00
  0c85fd496f
• Reorder badges so that SS shows above others

  This isn't perfect and probably needs much more consideration, but let's
  at least give the "better" ranks more visibility by bringing them to the
  front.
  
  Of note, this is only important due to the changes to osu!catch
  accuracy-grade cutoffs, which brings things closer in proximity than
  ever before.

  Dean Herbert · 2023-11-29 20:29:52 +09:00
  1cfcaee121
• Adjust catch score grade cutoffs
  Dan Balasescu · 2023-11-29 19:05:31 +09:00
  295a1b01d6
• Add silly annotation for now (more new r# rules)
  Dean Herbert · 2023-11-24 12:47:42 +09:00
  537b0ae870
• Delete ScoreInfo.HasReplay as no longer needed
  Bartłomiej Dach · 2023-10-27 12:39:54 +02:00
  96d784e06b
• Use both score ID types to deduplicate score on solo results screen
  Bartłomiej Dach · 2023-10-26 15:09:59 +02:00
  cbb2a0dd70
• Bypass Parent nullability checks for now
  Dean Herbert · 2023-10-17 17:48:45 +09:00
  5341a335a6
• Fix and use score user's IsBot property in results screen animation

  While a mod-created replay did flag itself as performed by a bot, the extension method converting it into a Score did not copy all the generated properties.
  
  As noted, it might be preferable for ModCreatedUser to inherit APIUser and forward it as-is to the Score instance.
  
  Related to PR #24675

  Nabile Rahmani · 2023-08-29 23:28:50 +02:00
  b658b0e346
• Privatise setter
  Bartłomiej Dach · 2023-08-01 18:09:48 +02:00
  f7d5ac9f92
• Show extended statistics in multiplayer spectator automatically
  Dean Herbert · 2023-08-01 20:02:36 +09:00
  df504e1fc2
• Merge branch 'master' into fix-replay-export-queued-op
  Bartłomiej Dach · 2023-07-30 14:58:14 +02:00
  1f7f336fd5
• Merge pull request #24361 from peppy/fix-editor-global-music-hotkey-conflicts

  Disallow interacting with the global track state in `Player` and `Editor`

  Bartłomiej Dach · 2023-07-30 12:28:53 +02:00
  e208f38bcb
• Remove pending export operation if active score is changed
  Dean Herbert · 2023-07-30 16:41:45 +09:00
  6d5b3617b3
• Don't queue export replay operations if button is disabled
  Dean Herbert · 2023-07-30 16:41:33 +09:00
  35ec55c1f6
• Fix ReplayDownloadButton handling key repeat
  Dean Herbert · 2023-07-26 15:21:43 +09:00
  e26afc2b89
• Disallow interacting with the global track state in Player and Editor
  Dean Herbert · 2023-07-25 20:20:53 +09:00
  3485b72eaa
• Fix differing anchor specs on statistics panel flow items
  Bartłomiej Dach · 2023-07-13 20:00:29 +02:00
  20bde40ce2
• Disable masking on inner scroll container
  Dean Herbert · 2023-07-13 19:01:59 +09:00
  2c27b17c85
• Rename StatisticContainer to StatisticItemContainer and add a background
  Dean Herbert · 2023-07-13 18:59:11 +09:00
  e34839c891
• Change OverallRanking to use a two-column layout similar to statistics table
  Dean Herbert · 2023-07-13 18:45:32 +09:00
  b333945cde
• Adjust metrics of HitEventTimingDistributionGraph
  Dean Herbert · 2023-07-13 18:45:32 +09:00
  0881f4772c
• Adjust metrics of SimpleStatisticTable
  Dean Herbert · 2023-07-13 18:45:32 +09:00
  947b40149f
• Centralise font size specification for statistic items (and reduce slightly)
  Dean Herbert · 2023-07-13 18:31:40 +09:00
  d54cf63983
• Adjust metrics of PerformanceBreakdown
  Dean Herbert · 2023-07-13 18:30:57 +09:00
  f223fd7c3b
• Adjust metrics of OverallRanking
  Dean Herbert · 2023-07-13 18:30:57 +09:00
  7637a9e603
• Remove more GridContainer nonsense
  Dean Herbert · 2023-07-13 18:30:57 +09:00
  98bf15182e
• Fix animation restarting unexpectedly
  Dean Herbert · 2023-07-13 15:07:26 +09:00
  1d62a041cc
• Fix graph breaking when resized vertically
  Dean Herbert · 2023-07-13 14:57:01 +09:00
  21f26f98da
• Split bar drawable creation into own method
  Dean Herbert · 2023-07-13 14:43:41 +09:00
  e2b5abd4e8
• Fix timing distribution graph sometimes not displaying correctly

  Weird "basal" height logic just didn't make any sense (was getting stuck at 1 when `DrawHeight` was 0)

  Dean Herbert · 2023-07-12 19:21:39 +09:00
  4f4c481a67