732 Commits

• Revert "Keep editor in frame stable mode when possible"
  Bartłomiej Dach · 2024-01-14 09:10:39 +01:00
  b7d74fda88
• Make editor remain frame stable during normal playback
  Dean Herbert · 2024-01-04 15:47:16 +09:00
  65c29b4f09
• Use new icons in editor

  Some that exist on figma are purposefully not used due to an editorial
  request from @peppy.

  Bartłomiej Dach · 2023-12-27 17:42:18 +01:00
  288ac930e4
• Merge branch 'master' into editor/checks/delayed-hitsounds
  Dan Balasescu · 2023-12-13 14:01:06 +09:00
  41ba1dcfce
• Rename and document SelectFromTimestamp
  Bartłomiej Dach · 2023-11-20 21:57:14 +09:00
  b6215b2809
• Simplify parsing code

  Less methods, less smeared around logic, saner data types.

  Bartłomiej Dach · 2023-11-20 21:57:12 +09:00
  0e0ab66148
• Updated comments, renamed method
  ratinfx · 2023-11-12 15:09:15 +01:00
  fab6fc9adb
• Changed TIME_REGEX to accept everything in the parentheses

  - changed osu-web link to the current value

  ratinfx · 2023-11-11 16:14:26 +01:00
  c367697559
• Refactor HitObject selection in Composer
  ratinfx · 2023-11-11 14:02:42 +01:00
  4e1e19728c
• HitObject Selection logic and separation for gamemodes

  + moved time_regex into EditorTimestampParser

  ratinfx · 2023-11-07 01:36:58 +01:00
  aa87e0a44d
• Fix some new nullable inspections
  Dean Herbert · 2023-10-30 15:10:10 +09:00
  a91b704d21
• Fix catch distance snap provider not hiding slider properly

  Regressed in https://github.com/ppy/osu/pull/25171.
  
  The old code was kinda dependent on correct order of setting `Disabled`.
  `CatchHitObjectComposer` would disable distance spacing in its BDL, and
  then via the base `DistancedHitObjectComposer.LoadComplete()`, the
  slider would be faded out. The switch to composition broke that
  ordering.
  
  To fix, stop relying on ordering and just respond to changes as they
  come. That's what bindables are for.

  Bartłomiej Dach · 2023-10-26 15:46:32 +02:00
  79910df959
• Remove unused using directive
  Bartłomiej Dach · 2023-10-19 20:45:47 +02:00
  2c6bf9e346
• Move beat snap grid implementation details to ScrollingHitObjectComposer
  Dean Herbert · 2023-10-19 23:54:34 +09:00
  013b5fa916
• Merge branch 'master' into taiko-beat-snap-grid
  Dean Herbert · 2023-10-19 23:53:01 +09:00
  52c2eb93de
• Remove DistancedHitObjectComposer
  Bartłomiej Dach · 2023-10-19 11:46:30 +02:00
  144ef5a87c
• Remove DistancedHitObjectComposer inheritance from osu! composer
  Bartłomiej Dach · 2023-10-19 11:46:30 +02:00
  dcfd6a0a8a
• Split IPositionSnapProvider from IDistanceSnapProvider

  In preparation to remove `DistancedHitObjectComposer`, split off
  `IPositionSnapProvider` from `IDistanceSnapProvider`.
  
  `DistancedHitObjectComposer` was not touching `IPositionSnapProvider`'s
  only interface member at all, it was just forwarding it for subclasses
  to override to their own leisure.

  Bartłomiej Dach · 2023-10-19 11:45:24 +02:00
  3ab083b696
• Remove redundant explicit array type specification
  Bartłomiej Dach · 2023-10-17 10:26:02 +02:00
  7abd7fe658
• Combine selection and input handling logic for beat snap grids across all rulesets
  Dean Herbert · 2023-10-17 17:09:42 +09:00
  4381169a3f
• Cache IScrollingInfo at a HitObjectComposer level automatically
  Dean Herbert · 2023-10-17 16:42:22 +09:00
  d26d4b8b79
• Persist the state of "show speed changes" between editor sessions

  Addresses https://github.com/ppy/osu/discussions/25149.

  Dean Herbert · 2023-10-17 16:01:02 +09:00
  165cd07428
• Remvoe null default for mods which can't be null
  Dean Herbert · 2023-09-20 15:27:50 +09:00
  41a8239e49
• Change implementation of "show speed changes" to require explicit ruleset support
  Dean Herbert · 2023-09-20 15:27:30 +09:00
  c6cc858967
• Merge branch 'master' into mania-edit-disable-sv
  Dean Herbert · 2023-09-20 14:23:07 +09:00
  c5397bdbb3
• Merge branch 'master' into editor/checks/delayed-hitsounds
  Dean Herbert · 2023-09-20 14:18:41 +09:00
  12611a09f1
• Rename SliderVelocity to SliderVelocityMultiplier to distinguish from Velocity
  Dean Herbert · 2023-09-06 19:01:08 +09:00
  1a37543d28
• style: remove usage of HIT_FLOURISH

  Unaware clueless usage

  tsrk · 2023-09-01 21:02:43 +02:00
  a4e146ad9b
• fix(AudioCheckUtils): use Path.GetExtension()

  To avoid filename escaping

  tsrk · 2023-09-01 20:56:54 +02:00
  2e2dcd99a6
• style: convert to using declaration for less nesting
  tsrk · 2023-09-01 20:54:02 +02:00
  5f00d3e2a4
• Move toggle implementation to work on all scrolling rulesets automatically
  Dean Herbert · 2023-09-01 19:53:10 +09:00
  37c2b330a2
• fix(AudioCheckUtils): add license header
  tsrk · 2023-08-29 23:27:15 +02:00
  5ecd5142d8
• fix: issue template typo in CheckDelayedHitsounds
  tsrk · 2023-08-29 20:15:33 +02:00
  b3d432b0d5
• style: move common audio utils to separate static class
  tsrk · 2023-08-29 20:10:35 +02:00
  c1a7ad09b4
• fix: use using statement for waveform auto-disposal
  tsrk · 2023-08-29 19:46:19 +02:00
  a7a64b57e9
• style: use HitSampleInfo.All properties
  tsrk · 2023-08-29 19:42:37 +02:00
  a04333c17b
• style(editor/checks): add issues for delays with no silence
  tsrk · 2023-08-25 11:46:09 +02:00
  29a46f5b36
• style: use more rigorous hitsound filtering
  tsrk · 2023-08-25 00:37:45 +02:00
  4c32e9a479
• revert: use old wording

  This makes more sense wrt to the complete silence thing.
  
  Refs: f7599c5b

  tsrk · 2023-08-24 23:52:41 +02:00
  50dbf564a5
• style: reword
  tsrk · 2023-08-24 23:41:56 +02:00
  f7599c5bc4
• style: typo
  tsrk · 2023-08-24 23:25:42 +02:00
  273593a0ee
• style(editor/checks): add type nullability for Stream
  tsrk · 2023-08-24 21:33:54 +02:00
  208e94e9be
• style(editor/checks): fix inconsistent argument names
  tsrk · 2023-08-24 21:31:28 +02:00
  df55a2f683
• feat(editor/checks): check for delayed hitsounds

  I really just borrowed the implementation from MapsetVerifier

  tsrk · 2023-08-24 21:05:40 +02:00
  a885bf6ebf
• Move comment to more fitting place
  Bartłomiej Dach · 2023-07-28 22:10:10 +02:00
  caad931a16
• Rename Apply{Vertical -> Horizontal}Centering to match common understanding
  Bartłomiej Dach · 2023-07-28 22:09:28 +02:00
  6d018c08af
• Fix playfield not taking up full width correclty when not vertically centered
  Dean Herbert · 2023-07-28 16:40:14 +09:00
  c9155f85ab
• Fix osu!taiko editor playfield missing a piece

  Regressed with recent centering changes in https://github.com/ppy/osu/pull/24220

  Dean Herbert · 2023-07-27 02:24:10 +09:00
  deba6e2508
• Merge branch 'master' into song-select-drain-length
  Bartłomiej Dach · 2023-07-25 22:40:45 +02:00
  57ccf82f34
• Add new property to avoid overlapping usages
  Dean Herbert · 2023-07-25 18:14:03 +09:00
  eac6271bd0