Dean Herbert
605fe71f46
Make empty hitwindows readonly static and slightly improve comparison performance
2024-11-25 19:17:32 +09:00
Dean Herbert
086a34f5c0
Merge branch 'master' into beatmap-info-purge
2024-11-22 18:47:32 +09:00
Darius Wattimena
16158710f9
Made reading of ReadCurrentDistanceSnap public
2024-11-18 23:49:40 +01:00
Bartłomiej Dach
bd1d3cad49
Do not show timing distribution graph in offset control if there's not enough timed hits
...
Intended to address concerns raised in
https://github.com/ppy/osu/pull/30620#issuecomment-2475744164 .
2024-11-14 13:17:03 +01:00
Dean Herbert
23167b0221
Merge pull request #30618 from Natelytle/ltca-broke-pp
...
Fix NaN PP counter values while SR is 0
2024-11-14 17:42:05 +09:00
Dean Herbert
7f8eebc510
Merge pull request #30578 from smoogipoo/beatmap-legacy-object-type
...
Simplify convertible hitobject parsing and add `IHasLegacyHitObjectType`
2024-11-14 16:16:44 +09:00
Nathen
d0e793a3b3
More correct but not too important
2024-11-14 01:50:05 -05:00
Nathen
2ea2e5f1db
Be doubly careful
2024-11-14 01:47:24 -05:00
Nathen
ce818f59e7
Fix NaN PP values when SR is 0
2024-11-14 01:42:07 -05:00
Dean Herbert
7670a81181
Merge branch 'master' into bat-max-performance
2024-11-14 13:35:29 +09:00
Dan Balasescu
60d45d44bb
Merge pull request #30536 from stanriders/add-diffcalc-helpers
...
Add `DifficultyCalculationUtils`
2024-11-13 17:49:40 +09:00
Dean Herbert
78084e33af
Merge pull request #30411 from frenzibyte/editor-slider-touch-support-2
...
Fix placing objects via touch in editor not working sometimes
2024-11-13 15:09:57 +09:00
Dan Balasescu
8c68db0a36
Remove unused params
2024-11-11 16:10:15 +09:00
Dan Balasescu
7206e97b7b
Add IHasLegacyHitObjectType to ConvertHitObject
2024-11-11 16:10:15 +09:00
Dan Balasescu
e1d93a7d9c
Merge implementations of ConvertHitObjectParser
...
Having these be separate implementations sounded awesome at the time,
but it only ever led to confusion. There's no practical difference if,
for example, catch sees hitobjects with `IHasPosition` instead of
`IHasXPosition`.
2024-11-11 15:09:13 +09:00
StanR
c9d3b6557d
Fix code issues
2024-11-07 21:23:26 +05:00
StanR
78c97d2cd7
Add DifficultyCalculationUtils
2024-11-07 20:36:00 +05:00
Jay Lawton
7c3a3c4d10
rename DifficultStrains for clarity
2024-11-07 21:56:42 +10:00
Jay Lawton
2b6a473164
update methods
2024-11-07 21:12:04 +10:00
Jay Lawton
a5e6da76cb
introduce difficult strains globally
2024-11-07 19:53:53 +10:00
Dean Herbert
c99c82ab08
Merge pull request #30460 from Lawtrohux/t-speed-deviation
...
Implement stamina consideration for Mono (single-coloured) patterns.
2024-11-04 19:38:50 +09:00
Bartłomiej Dach
3dc2408965
Merge branch 'master' into bat-max-performance
2024-11-01 13:13:20 +01:00
Dan Balasescu
9766d51559
Store attribute to the database
2024-11-01 16:02:02 +09:00
Dan Balasescu
372162de5d
Ignore casing when matching mods acronyms
2024-10-31 08:55:42 +09:00
Bartłomiej Dach
b72a50bbaa
Merge pull request #30387 from peppy/editor-sidebars-always-expanded
...
Keep editor sidebars expanded by default
2024-10-25 19:46:35 +02:00
Dean Herbert
68e8819f3b
Fix taiko playfield looking weird with new editor toolbox displays
2024-10-25 17:17:19 +09:00
Salman Alshamrani
1d559b2cad
Remove fade transitions
2024-10-24 16:20:49 -04:00
Dean Herbert
787d3dceea
Merge branch 'master' into auto-addition2
2024-10-24 18:40:27 +09:00
Salman Alshamrani
6e9ff49e59
Merge branch 'master' into editor-slider-touch-support-2
2024-10-23 17:02:38 -04:00
Salman Alshamrani
3a4d5af83e
Fix placement blueprints sometimes not behaving correctly with touch input
...
More specifically, this fixes placement blueprints not beginning placement when using touch input while the cursor was previously outside compose area, due to the placement blueprint not existing (removed from the scene by `ComposeBlueprintContainer`).
2024-10-23 16:51:21 -04:00
Dean Herbert
77d2f35765
Merge pull request #30375 from bdach/fix-broken-playfield-skin-layer-rotation
...
Fix playfield skinning layer no longer correctly rotating with the playfield
2024-10-23 19:50:39 +09:00
Dean Herbert
064aaeb60e
Initialise container earlier to avoid null reference failures
2024-10-23 18:46:20 +09:00
Dean Herbert
5939c78760
Merge branch 'master' into auto-addition2
2024-10-23 15:53:07 +09:00
Dean Herbert
2103b3e186
Merge pull request #28863 from OliBomby/additions
...
Add toggles and hotkeys for configuring sample addition bank
2024-10-23 15:52:55 +09:00
Dean Herbert
e37d415c6f
Keep editor sidebars expanded by default
...
They will not only contract if the user chooses to have them contract
(new setting in the `View` menu) or if the game isn't wide enough to
allow full interaction with the playfield while they are expanded.
Addressess https://github.com/ppy/osu/discussions/28970 .
2024-10-22 20:08:50 +09:00
Bartłomiej Dach
e89a4561ab
Fix playfield skinning layer no longer correctly rotating with the playfield
...
Closes https://github.com/ppy/osu/issues/30353 .
Regressed in
4a39873e2a
2024-10-21 13:49:12 +02:00
jhk2601
7416106321
Fixes cursor rotating along with playfield when using Barrel Roll in standard
2024-10-17 14:38:13 -04:00
Dan Balasescu
bfcf6693ca
Simplify implementation
2024-10-17 20:00:17 +09:00
Dan Balasescu
d195a69447
Compute maximum performance along with difficulty
2024-10-17 19:26:19 +09:00
Dean Herbert
b1be31cd6a
Switch back to last tool after using grid tool, rather than always select tool
2024-10-08 17:34:51 +09:00
Dean Herbert
682023e130
Merge branch 'master' into grids-4
2024-10-08 16:26:42 +09:00
Bartłomiej Dach
84d6467e48
Merge branch 'master' into taikostatacc
2024-10-07 14:15:29 +02:00
OliBomby
7b998219d7
move grid placement tool to left toolbox
2024-10-07 12:04:14 +02:00
Bartłomiej Dach
f30ac5d996
Merge branch 'master' into no-combo-scaling
2024-10-07 11:50:58 +02:00
Dean Herbert
1ab02b93b3
Merge branch 'master' into grids-4
2024-10-07 15:42:23 +09:00
tsunyoku
f54a5a5b0e
Merge branch 'master' into no-combo-scaling
2024-10-03 16:37:20 +01:00
Bartłomiej Dach
99eb26b7d5
Redo the layout of sections based on discord feedback
...
See
https://discord.com/channels/188630481301012481/188630652340404224/1291358770064130140
and everything after.
2024-10-03 13:53:21 +02:00
OliBomby
2c39ecbda3
Add xmldoc to SnapType
2024-10-03 11:16:37 +02:00
OliBomby
f8397cccc7
Merge remote-tracking branch 'upstream/master' into grids-4
2024-10-01 15:43:54 +02:00
Dean Herbert
54e68005ef
Merge pull request #29691 from bdach/hotkeys-in-context-menus
...
Add hotkey hints to editor menus
2024-10-01 19:29:05 +09:00
Dean Herbert
8ea1ff5de6
Merge pull request #30069 from peppy/grid-to-current-object
...
Add button to centre editor grid to current hit object
2024-10-01 19:24:46 +09:00
OliBomby
2381c2c72c
Fix hitobjects without custom sample banks parsing as not auto sample bank
2024-10-01 12:11:44 +02:00
Dean Herbert
ae75bfd966
Rename keyboard mapping methods to make more sense now that everything's on the left
2024-10-01 18:41:53 +09:00
Bartłomiej Dach
44b982864c
Fix test failures
2024-10-01 11:12:56 +02:00
OliBomby
0a78eb9628
Implement auto additions editor-only
2024-10-01 16:40:48 +09:00
Dean Herbert
1b4215576d
Merge branch 'master' into additions
2024-10-01 16:38:56 +09:00
Dean Herbert
0409edccce
Add button to centre editor grid to current hit object
2024-10-01 15:22:05 +09:00
Bartłomiej Dach
75fc57c34b
Fix distance spacing grid displaying incorrectly for unsnapped objects with duration
2024-09-30 13:36:16 +02:00
OliBomby
1c6e42671a
return grid placement tool to right toolbox
2024-09-28 17:04:11 +02:00
Dean Herbert
c46d787f1e
Merge pull request #29949 from minetoblend/feature/scale-around-center
...
Support scaling around center when scaling with select box
2024-09-28 21:37:39 +09:00
Bartłomiej Dach
a00ed8dd77
Merge pull request #29914 from peppy/fix-judgement-counter-sync
...
Fix judgement counter not showing correct counts when spectating user mid-play
2024-09-27 10:57:26 +02:00
OliBomby
b179e086c6
Merge remote-tracking branch 'upstream/master' into grids-4
2024-09-26 14:59:52 +02:00
Dean Herbert
78c1426a30
Merge pull request #29992 from smoogipoo/fix-ios-realm-crashes
...
Fix reflection-related iOS crashes
2024-09-26 17:34:36 +09:00
Dan Balasescu
fd4891cf31
Fix similar Bindable-related crashes
2024-09-25 20:59:35 +09:00
OliBomby
e3b4483872
Refactor PlacementBlueprint to not be hitobject specific
2024-09-24 20:31:00 +02:00
OliBomby
0f0f490598
Don't snap to global grid while placing grid
2024-09-23 17:24:09 +02:00
OliBomby
0a5a463380
Convert 'grid from points' button to placement tool
2024-09-23 16:36:45 +02:00
OliBomby
1a81e12192
Refactor PlacementBlueprint to not be hitobject specific
2024-09-23 16:33:36 +02:00
Marvin Schürz
3180468db1
Prevent the distance snap grid from being activated by alt key while dragging select box handle
2024-09-21 14:22:17 +02:00
OliBomby
e3aeaf6d85
Merge remote-tracking branch 'upstream/master' into grids-4
2024-09-19 20:06:47 +02:00
Dean Herbert
2d993645af
Add test coverage of judgements not being synced when resuming a replay
2024-09-18 15:28:10 +09:00
Dean Herbert
58fe502af4
Merge branch 'master' into beatmap-info-purge
2024-09-15 04:53:35 +09:00
Bartłomiej Dach
4a39873e2a
Fix replay analysis overlay not rotating with Barrel Roll enabled
...
Closes https://github.com/ppy/osu/issues/29839 .
2024-09-11 15:54:30 +02:00
Bartłomiej Dach
b78ef81bf1
Fix Flashlight not appearing on top of bubbles from Bubbles mod
...
Inadvertently regressed in 44d0dc6113
2024-09-11 15:54:07 +02:00
apollo-dw
a7e1d35f64
Update osu.Game/Rulesets/Difficulty/DifficultyAttributes.cs
...
Co-authored-by: James Wilson <tsunyoku@gmail.com>
2024-09-11 12:29:17 +01:00
Dan Balasescu
5d09aaae27
Merge pull request #29446 from OliBomby/last-anchor
...
Fix path control points losing curve type on save/reload or undo
2024-09-02 18:40:19 +09:00
Dean Herbert
60c1e0fa72
Merge pull request #29440 from OliBomby/spacebar-resume
...
Allow play/pause with spacebar while placing hitobjects
2024-08-30 12:58:41 +09:00
Dan Balasescu
4e8fb0dcab
Merge branch 'master' into scroll-speed-std
2024-08-30 00:41:05 +09:00
clayton
70d08b9e97
Increase mod icon acronym font weight
2024-08-25 20:42:57 -07:00
clayton
2bb72762ad
Use more contrasting color for mod icon foreground
2024-08-25 20:42:34 -07:00
OliBomby
998b5fdc12
Add property EditorShowScrollSpeed to Ruleset
2024-08-22 19:53:34 +02:00
Dean Herbert
36b4013fa6
Rename GameplaySkinComponentLookup -> SkinComponentLookup
2024-08-22 18:46:03 +09:00
OliBomby
eefd7cf083
add back protection against perfect curve segments with > 3 points
2024-08-21 12:03:15 +02:00
Bartłomiej Dach
588a36cba3
Remove unused variable
2024-08-19 14:58:12 +02:00
Bartłomiej Dach
42675be6cf
Merge branch 'master' into additions
2024-08-19 11:13:43 +02:00
Bartłomiej Dach
32821be046
Make "double ternary button" specific to samples
...
We can generalise *when* there is the need to generalise. So far the
generalisation only looked like *obfuscation*.
2024-08-19 11:13:29 +02:00
OliBomby
a2e26ba9ff
Fix perfect curve anchors losing type between reloads
2024-08-16 14:24:55 +02:00
OliBomby
e5fab9cfbe
Remove select action to end placement
2024-08-16 11:55:07 +02:00
OliBomby
2abcdd0064
Redesign sample bank toggles
2024-08-13 22:05:01 +02:00
Dean Herbert
2221c4891f
Remove legacy non-pooled pathway to DrawableJudgement
2024-08-13 21:03:00 +09:00
Dean Herbert
bb0c9e2497
Add log output when judgements aren't being pooled
2024-08-13 20:57:23 +09:00
Dean Herbert
d74ac57092
Never call prepareDrawables from unsafe context
...
I can't mentally figure out *what* is causing the issue here, but in the
case where `prepareDrawables` is called from
`JudgementBody.OnSkinChanged` (only happens in a non-pooled scenario),
things go very wrong.
I think a smell test is enough for anyone to agree that the flow was
very bad. Removing this call doesn't seem to cause any issues.
`runAnimation` should always be called in `PrepareForUse` (both pooled
and non-pooled scenarios) so things should still always be in a correct
state.
Closes #29398 .
2024-08-13 20:57:20 +09:00
Dean Herbert
d072c6a743
Fix hit object coordinates being truncated to int values
...
Closes https://github.com/ppy/osu/issues/29340 .
2024-08-09 16:34:39 +09:00
Dean Herbert
b5a19707d0
Merge branch 'master' into additions
2024-08-08 03:31:11 +09:00
Dean Herbert
0557b9ab79
Allow placement deletion with middle mouse
...
This is in addition to Shift + Right-click.
I thik middle mouse feels more natural and is a good permanent solution
to this issue.
Note that this also *allows triggering the context menu from placement
mode*. Until now it's done nothing. This may be annoying to users with
muscle memory but I want to make the change and harvest feedback. I
think showing the context menu is more correct behaviour (although
arguably it should return to placement mode on dismiss?).
2024-08-05 14:25:09 +09:00
Bartłomiej Dach
6813f5ee0a
Fix incorrect DifficultyBindable logic
2024-07-30 08:39:20 +02:00
Shreyas Kadambi
dec6b190f2
Add optional 'suffix' to timestamp
2024-07-28 11:31:36 -04:00
Bartłomiej Dach
088e8ad0a2
Respect pre-empt time when auto-generating breaks
...
Closes https://github.com/ppy/osu/issues/28703 .
2024-07-23 13:30:13 +02:00
Dean Herbert
d707e29ff7
Merge branch 'master' into beatmap-info-purge
2024-07-23 12:09:32 +09:00
Bartłomiej Dach
57fa502786
Fix editor UI dimming when hovering over expanded part of toolboxes
...
Closes https://github.com/ppy/osu/issues/28969 .
2024-07-22 11:57:46 +02:00
