114 Commits

• Automated #nullable processing
  Dan Balasescu · 2022-06-17 16:37:17 +09:00
  f8830c6850
• Handle all skin component types explicitly
  Salman Ahmed · 2022-04-23 03:34:05 +03:00
  61078910a6
• Remove skin ctor param from LegacyCatchComboCounter

  No longer used since 004798d61d.

  Bartłomiej Dach · 2022-02-01 21:49:52 +01:00
  e042f29ee3
• Fix incorrect naming / apply review
  Joseph Madamba · 2021-12-27 21:44:19 -08:00
  0bd928b5cd
• Fix clear identifier typos
  Joseph Madamba · 2021-12-27 20:26:28 -08:00
  98524d60a4
• Merge branch 'master' into fix-skin-layout-editor-crash
  Dean Herbert · 2021-10-28 06:24:24 +09:00
  add39fbd4f
• Apply batch fixing of built-in types using var
  Dean Herbert · 2021-10-27 13:04:41 +09:00
  6944151486
• Remove SkinConfiguration subclasses and allow configuration parsing for all skin types
  Dean Herbert · 2021-10-22 14:42:23 +09:00
  93482414d6
• Adjust scaling numbers to be closer to stable
  Bartłomiej Dach · 2021-08-12 22:33:12 +02:00
  b84f238106
• Add comment about swapped sprite names
  Bartłomiej Dach · 2021-08-12 21:48:07 +02:00
  f3045b3152
• Enable NRT in explosion-related classes and streamline null handling
  Bartłomiej Dach · 2021-08-12 21:48:07 +02:00
  68f454b51a
• Remove duplicated ClearTransforms() call
  Bartłomiej Dach · 2021-08-11 23:18:42 +02:00
  427a88940c
• Fix legacy explosion sprites incorrectly showing after skin change
  Bartłomiej Dach · 2021-08-11 22:36:27 +02:00
  2fb19210af
• Restructure explosion to ensure proper lifetime bounds
  Bartłomiej Dach · 2021-08-11 21:23:34 +02:00
  4bcbe6ac90
• Add legacy hit lighting implementation
  Bartłomiej Dach · 2021-08-11 21:23:33 +02:00
  8c8a64fe6e
• Store judgement directly in hit explosion entry
  Bartłomiej Dach · 2021-08-11 21:23:33 +02:00
  95a58ca366
• Add basic structure for skinning catch explosions
  Bartłomiej Dach · 2021-08-11 21:23:32 +02:00
  a1f50e39aa
• Fix default skin catcher not flipping catcher plate

  When legacy beatmap skin is present but catcher is not provided, it was using the legacy setting (always false).

  ekrctb · 2021-07-05 20:05:08 +09:00
  d247b8042e
• Don't flip catcher plate contents in legacy skin
  ekrctb · 2021-07-02 23:23:21 +09:00
  83c80291d4
• Merge branch 'master' into transformers-per-skin
  Dean Herbert · 2021-06-22 16:03:15 +09:00
  1b0aadcc6f
• Remove CurrentTexture from catcher
  ekrctb · 2021-06-14 20:26:33 +09:00
  df16d4bacc
• Call base when overriding lookup methods

  Rather than arbitrarily accessing `Skin` here and there.

  Salman Ahmed · 2021-06-11 12:44:44 +03:00
  fbb856d84b
• Remove stale access to Source from master merge
  Salman Ahmed · 2021-06-10 13:07:32 +03:00
  26cdcc8d78
• Merge branch 'master' into transformers-per-skin
  Salman Ahmed · 2021-06-10 11:58:52 +03:00
  dde84e5cbd
• Use [Resolved] to simplify bindable resolution
  Dean Herbert · 2021-06-10 15:47:03 +09:00
  865c5c0676
• Use With to simplify drawable construction
  Dean Herbert · 2021-06-10 15:45:49 +09:00
  6995945360
• Convert LegacySkinTransformers to accept raw ISkins rather than a full ISkinSource
  Salman Ahmed · 2021-06-09 22:49:31 +03:00
  cf40282f1f
• Check skin version for legacy catcher sprite
  ekrctb · 2021-06-09 15:47:23 +09:00
  e5deecf459
• ICatcherPiece -> ICatcherSprite
  ekrctb · 2021-06-08 22:10:13 +09:00
  7df971a970
• Use separate classes for old and new catcher legacy skin element

  - Fix catcher texture animation is reset for legacy old catcher skin

  ekrctb · 2021-06-08 21:59:09 +09:00
  109a366722
• Refactor catcher sprite to use skinned piece pattern
  ekrctb · 2021-06-08 21:29:41 +09:00
  0192549d6c
• Move default catcher sprite to its own file
  ekrctb · 2021-06-08 17:54:57 +09:00
  6e28c1b29a
• Merge branch 'master' into fruit-representation
  Dean Herbert · 2021-06-07 16:05:00 +09:00
  1b93234c76
• Move all osu!catch legacy skin piece files to the correct location
  ekrctb · 2021-06-07 15:10:47 +09:00
  bb02c35f2d
• Remove "fruit visual representation" state from DrawableFruit

  Instead, skin pieces compute visual representation from `IndexInBeatmap`.

  ekrctb · 2021-06-07 14:49:37 +09:00
  ac5c55bd2c
• Move FruitVisualRepresentation namespace
  ekrctb · 2021-06-07 13:59:17 +09:00
  166e4565be
• ContentVisible -> HiddenByRulesetImplementation
  Salman Ahmed · 2021-05-31 09:24:26 +03:00
  4e186b0cf5
• Rewrite catch combo counter hide logic
  Salman Ahmed · 2021-05-30 14:22:11 +03:00
  60b781701f
• Merge branch 'master' into catch-hide-combo-workaround
  Salman Ahmed · 2021-05-30 14:16:46 +03:00
  fb81e5133f
• Restructure lookup code to avoid repeating the base call
  Dean Herbert · 2021-05-30 17:55:10 +09:00
  50d71faf56
• Fix legacy skin transformers potentially ignoring source implementations
  Salman Ahmed · 2021-05-29 21:23:22 +03:00
  fbc316ea1d
• Use switch—case instead
  Salman Ahmed · 2021-05-19 23:37:22 +03:00
  a4d52a7f52
• Hide the combo counter content rather than full death
  Salman Ahmed · 2021-05-18 09:10:15 +03:00
  ff419af512
• Improve code readability
  Salman Ahmed · 2021-05-17 11:41:53 +03:00
  df248ea41b
• Expire legacy combo counters on catch ruleset
  Salman Ahmed · 2021-05-15 16:55:15 +03:00
  102842bcf1
• Update Legacy components to not require skin in ctor
  Dean Herbert · 2021-05-11 18:39:14 +09:00
  004798d61d
• Update existing usages

  Resolve post-conflict issues

  Salman Ahmed · 2021-03-13 06:09:07 +03:00
  43c1e1d217
• Fix codefactor style issues
  Joehu · 2021-02-04 13:28:35 -08:00
  9ef130cdcc
• Remove null check that is not required anymore
  ekrctb · 2020-12-09 10:28:42 +09:00
  df9de7a8dd
• Introduce IHasCatchObjectState implemented by DHO and CaughtObject
  ekrctb · 2020-12-08 21:29:26 +09:00
  a32dac00dd