1
0
mirror of https://github.com/ppy/osu.git synced 2024-11-11 10:33:30 +08:00

Fix default skin catcher not flipping catcher plate

When legacy beatmap skin is present but catcher is not provided, it was using the legacy setting (always false).
This commit is contained in:
ekrctb 2021-07-05 20:05:08 +09:00
parent 333caca386
commit d247b8042e

View File

@ -108,8 +108,11 @@ namespace osu.Game.Rulesets.Catch.Skinning.Legacy
switch (config)
{
case CatchSkinConfiguration.FlipCatcherPlate:
// Always return `false` (don't flip catcher plate contents) for a legacy skin.
return (IBindable<TValue>)new Bindable<bool>();
// Don't flip catcher plate contents if the catcher is provided by this legacy skin.
if (GetDrawableComponent(new CatchSkinComponent(CatchSkinComponents.Catcher)) != null)
return (IBindable<TValue>)new Bindable<bool>();
break;
}
break;